I am concerned that many of these tests are now "passing", and don't
have any of the annotation for getting back to that were found. Given
how some of these failures are going to be fairly subtle, and that we
don't really do an exhaustive job of input testing, I worry that they
will end up missed.
These set of changes are intended to get the tests working and the
implementation in a stable state, though not strictly correct for the
reasons you mention and also UNC paths, etc. Rather than make those changes
in this patch series, I will be making a second pass, refactoring path
validation into
On Tue, Jul 19, 2011 at 14:59, Josh Cooper wrote:
> When testing whether a file path is absolute, the regexp was only
> handling POSIX style file paths. This commit requires Windows
> style file paths to start with a drive letter. A future commit
> will refacter the various places we do path valid
When testing whether a file path is absolute, the regexp was only
handling POSIX style file paths. This commit requires Windows
style file paths to start with a drive letter. A future commit
will refacter the various places we do path validation to
support both Windows drive letters and UNC paths.
