Re: [Puppet-dev] [PATCH] (#5318) Always notice changes to manifests when compiling.

2011-05-27 Thread markus
> Thanks for the really nice investigation and explanation, I definitely > +1 this patch (even though I'm unaffected). Ditto on the +1; it has the side benefit on making the comment describing how things work in node/environment.rb correct again. -- M -- You received this message because yo

Re: [Puppet-dev] [PATCH] (#5318) Always notice changes to manifests when compiling.

2011-05-27 Thread Daniel Pittman
Oh. I sent the patch from my 2.7rc commit, but the head of 2.6.x contains *exactly* the same change, fixing it in the same way. So, yes, absolutely. You can just patch this direct in and things will work just fine. :) Daniel On Fri, May 27, 2011 at 12:06, Eric Sorenson wrote: > +1 > > This is

Re: [Puppet-dev] [PATCH] (#5318) Always notice changes to manifests when compiling.

2011-05-27 Thread Eric Sorenson
+1 This is a big pain for my users who test changed manifests. Seems like this change would work against 2.6.x, right? On May 27, 2011, at 11:58 AM, Brice Figureau wrote: > Thanks for the really nice investigation and explanation, I definitely > +1 this patch (even though I'm unaffected). > >

Re: [Puppet-dev] [PATCH] (#5318) Always notice changes to manifests when compiling.

2011-05-27 Thread Daniel Pittman
Ah. If you had any comments about why, and what to watch out for if we work to clean this up, https://projects.puppetlabs.com/issues/7703 would be a wonderful place to add them. When I chased down the tickets around the code being introduced I got some idea why it was there, but concrete things t

Re: [Puppet-dev] [PATCH] (#5318) Always notice changes to manifests when compiling.

2011-05-27 Thread Brice Figureau
Thanks for the really nice investigation and explanation, I definitely +1 this patch (even though I'm unaffected). For the history, we (I believe Markus and I) introduced this thread caching stuff around 2.6.1 to fix an important performance regression and some thread safety issues. On 27/05/11 1

Re: [Puppet-dev] [PATCH] (#5318) Always notice changes to manifests when compiling.

2011-05-27 Thread Daniel Pittman
I wanted to call this out a little more: this will fix a problem that was mostly visible to folks using Passenger to scale their puppet master pool. This will be visible as changes to manifest files taking longer than expected to apply, but coming good after a few runs. If you are in that situati

[Puppet-dev] [PATCH] (#5318) Always notice changes to manifests when compiling.

2011-05-27 Thread Daniel Pittman
When we are asked to compile a catalog we need to update the set of known resource types, along with the node declaration, from the pool of manifests on disk. This is, obviously, a per-environment pool of resource types. To reduce the scope of the race where an update to those manifest files on d