Hi, Here is the second version of the Application Controller patch for review. It follows Luke's comment. I'll wait approval before continuing the work on this patch series, to be sure I'm doing the Right Things(tm).
Since I'm still a ruby newbie on metaprogramming, I suspect that there will be lots of comments :-) The next step will be to find duplicated code in all the application setups and find a way to merge all this in the Application controller. I also will cover the applications with unit tests. I'm just not really sure how I can do this in this model. I know that the various newcommand/newoption things creates some methods in the instance, so they can be the things under test, but it means the test then knows some inner-workings of the Application Controller. Any advice on this topic? Thanks for the review! Brice Figureau (2): Introducing the Application Controller Move filebucket and PuppetCA to the Application Controller paradigm bin/filebucket | 119 +------------ bin/puppetca | 103 +----------- lib/puppet/application.rb | 203 +++++++++++++++++++++ lib/puppet/application/filebucket.rb | 95 ++++++++++ lib/puppet/application/puppetca.rb | 83 +++++++++ spec/unit/application.rb | 327 ++++++++++++++++++++++++++++++++++ 6 files changed, 714 insertions(+), 216 deletions(-) create mode 100644 lib/puppet/application.rb create mode 100644 lib/puppet/application/filebucket.rb create mode 100644 lib/puppet/application/puppetca.rb create mode 100755 spec/unit/application.rb --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
