Re: [Puppet-dev] Duplicate features

2014-08-19 Thread Rob Reynolds
On Mon, Aug 18, 2014 at 6:29 PM, badgerious wrote: > Thanks Rob. I guess I'd vote B as well, because, while A may work even > with some name collisions, it would be I think very confusing to debug if > there were ever a real conflict. As far as how back I want to support, > dunno really, I just t

Re: [Puppet-dev] Duplicate features

2014-08-18 Thread badgerious
Thanks Rob. I guess I'd vote B as well, because, while A may work even with some name collisions, it would be I think very confusing to debug if there were ever a real conflict. As far as how back I want to support, dunno really, I just thought it would be polite to throw a guard in there since

Re: [Puppet-dev] Duplicate features

2014-08-18 Thread Rob Reynolds
On Sun, Aug 17, 2014 at 8:16 PM, badgerious wrote: > I'd like to define an FFI feature in a module so it can die gracefully on > older puppets > This seems reasonable, but how far back are you wanting to support? We've had FFI included since 3.3.2[1]. [1] https://github.com/puppetlabs/puppet/b

[Puppet-dev] Duplicate features

2014-08-17 Thread badgerious
I'd like to define an FFI feature in a module so it can die gracefully on older puppets, but the question I have is this: Is it better to A) create a feature at 'puppet/feature/ffi.rb' and do something like: Puppet.features.add(:ffi, :libs => ['ffi']) B) create a feature at 'puppet/feature/my_