[Puppet-dev] Re: [PATCH 1/1] Add insync? checks to Onyx Point Concat module

2011-06-14 Thread Markus Falb
On 3.6.2011 17:07, Greg Sutcliffe wrote: > Hi all, > > As my first foray into types and providers (and as suggested on the > -users list), here is a patch for Onyx Point's Concat type which > implements insync? for both concat_build and concat_fragment. It's > probably ugly, and I need to learn, s

Re: [Puppet-dev] Re: [PATCH 1/1] Add insync? checks to Onyx Point Concat module

2011-06-13 Thread Greg Sutcliffe
On 13 June 2011 10:24, Peter Meier wrote: > > > If you deleted the target, it wont recreated. What is diff(filea,fileb) > > returning when one of its arguments does not exist ? > > it looks like it returns an empty string. I fixed this in my work on the > module[1]. > > ~pete Eeek, how did I mi

Re: [Puppet-dev] Re: [PATCH 1/1] Add insync? checks to Onyx Point Concat module

2011-06-13 Thread Peter Meier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > If you deleted the target, it wont recreated. What is diff(filea,fileb) > returning when one of its arguments does not exist ? it looks like it returns an empty string. I fixed this in my work on the module[1]. ~pete [1] https://github.com/duriton

[Puppet-dev] Re: [PATCH 1/1] Add insync? checks to Onyx Point Concat module

2011-06-12 Thread Markus Falb
On 3.6.2011 17:07, Greg Sutcliffe wrote: > Hi all, > > As my first foray into types and providers (and as suggested on the > -users list), here is a patch for Onyx Point's Concat type which > implements insync? for both concat_build and concat_fragment. It's > probably ugly, and I need to learn, s