applied (and built a new proxmox-backup-qemu package)
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Saw the forum thread's subject [0] and was reminded of the issue with the LIO
target provider recently [1].
Depending on feedback I might slowly be inclined to blindly untaint in
run_command again?
[0]
https://forum.proxmox.com/threads/insecure-dependency-in-exec-during-osd-destroy.79574/
[1]
We get the device list from ceph-volume lvm list, and decode the json
output, which at that point is tainted (perlsec (1)).
Untaint it here before calling, because it is currently the only
call-site using the information in a problematic way (run_command).
(the only other call-site being in pve5to6
Signed-off-by: Stoiko Ivanov
---
PVE/API2/Ceph/OSD.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm
index f1f39bf9..685b68bc 100644
--- a/PVE/API2/Ceph/OSD.pm
+++ b/PVE/API2/Ceph/OSD.pm
@@ -575,7 +575,7 @@ __PACKAGE__->register_met
> proxmox-backup-qemu is missing a not-pushed version bump commit, otherwise
> I'd have applied this.
sorry, just pushed the missing commit.
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-
Signed-off-by: Stefan Reiter
---
images/screenshot/gui-qemu-edit-bootorder.png | Bin 0 -> 24530 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
create mode 100644 images/screenshot/gui-qemu-edit-bootorder.png
diff --git a/images/screenshot/gui-qemu-edit-bootorder.png
b/images/screenshot
Signed-off-by: Stefan Reiter
---
www/manager6/qemu/BootOrderEdit.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/manager6/qemu/BootOrderEdit.js
b/www/manager6/qemu/BootOrderEdit.js
index 1e924dea..de80c7e1 100644
--- a/www/manager6/qemu/BootOrderEdit.js
+++ b/www/manager6/qemu/BootO
...and fix outdated example config
Signed-off-by: Stefan Reiter
---
qm.adoc | 35 ++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/qm.adoc b/qm.adoc
index d30672e..809154a 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -840,6 +840,39 @@ recommended to alwa
Tested-by: Fabian Grünbichler
requires now updated patch from <20201124154122.22202-2-s.rei...@proxmox.com>:
"[PATCH v3 pve-qemu 1/3] update patches with squashed in 'include library
version'"
On November 10, 2020 5:16 pm, Stefan Reiter wrote:
> ...and literal cleanup, as in, call save_cleanup
Reviewed-by: Fabian Grünbichler
Tested-by: Fabian Grünbichler
proxmox-backup-qemu is missing a not-pushed version bump commit, otherwise I'd
have applied this.
On November 24, 2020 4:41 pm, Stefan Reiter wrote:
> v3:
> * use function, as header macro was compiled into QEMU, not the library
>
might be worthy of a prominent changelog entry to avoid surprises.
On November 20, 2020 3:50 pm, Fabian Ebner wrote:
> across different modes and also with a pbs storage. For suspend mode relative
> patterns are already working. To not break that behavior, and because pxar
> and proxmox-backup-cli
Extends print_recursive_hash for the CLI to handle JSON booleans so the
result will actually show up in 'qm status --verbose'.
Signed-off-by: Stefan Reiter
---
v3: unchanged
PVE/CLI/qm.pm | 2 +-
PVE/QemuServer.pm | 8
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/
Signed-off-by: Stefan Reiter
---
v3: use function instead of macro from lib
Requires a depends on bumped library to find function.
...dd-query_proxmox_support-QMP-command.patch | 22 ++--
...issing-crypt-and-compress-parameters.patch | 2 +-
...rite-callback-with-big-blocks-correc
v3:
* use function, as header macro was compiled into QEMU, not the library
pve-qemu: Stefan Reiter (1):
update patches with squashed in 'include library version'
...dd-query_proxmox_support-QMP-command.patch | 22 ++--
...issing-crypt-and-compress-parameters.patch | 2 +-
...rit
Otherwise the string gets included in the QEMU binary, not the library.
Suggested-by: Fabian Grünbichler
Signed-off-by: Stefan Reiter
---
v3: added, applies as followup on top of already applied one
Makefile | 2 +-
build.rs | 6 +++---
current-api.h | 7 +--
src/lib.rs|
On November 6, 2020 3:30 pm, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
>
> same comment as for the corresponding LXC patch
>
> PVE/QemuMigrate.pm | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
> index f2c2b07..10cf31a 100644
On November 6, 2020 3:30 pm, Fabian Ebner wrote:
> Offline migrated volumes are now activated within storage_migrate.
> Online migrated volumes can be assumed to be already active.
>
> Signed-off-by: Fabian Ebner
> ---
>
> dependency bump needed
>
> Sent as RFC, because I'm not completly sure i
it can't hurt either, and makes it more uniform with qemu migration
On November 6, 2020 3:30 pm, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
>
> This is probably not worth it, for two reasons:
> 1. only local unused volumes are not already deactivated by the existing code
> 2. if not
On 24.11.20 15:32, Dominik Csapak wrote:
> by deleteing it from $ceph_param we deleted it also from
> $param since it was only a reference
>
> fix it by extracting it beforehand
>
> Signed-off-by: Dominik Csapak
> ---
> changes from v1:
> * also use $add_storages in permission check/pool name ch
On 24.11.20 15:31, Fabian Ebner wrote:
> extracting the logic from the previous checkbox listener into a function,
> which
> is also called on field changes and once in afterrender. Calling it initially
> makes sure the hint is also displayed at the beginning when editing a storage
> with no reten
by deleteing it from $ceph_param we deleted it also from
$param since it was only a reference
fix it by extracting it beforehand
Signed-off-by: Dominik Csapak
---
changes from v1:
* also use $add_storages in permission check/pool name check
PVE/API2/Ceph.pm | 29 +
extracting the logic from the previous checkbox listener into a function, which
is also called on field changes and once in afterrender. Calling it initially
makes sure the hint is also displayed at the beginning when editing a storage
with no retention options configured, and the initial disabling
by deleteing it from $ceph_param we deleted it also from
$param since it was only a reference
fix it by extracting it beforehand
Signed-off-by: Dominik Csapak
---
PVE/API2/Ceph.pm | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/PVE/API2/Ceph.pm
if one would try to use -v in a systemd service, systemd would disable
line buffering for stdout and no output would happen (until the buffer
is full)
Signed-off-by: Dominik Csapak
---
qmeventd/qmeventd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qmeventd/qmeventd.h b/q
comments inline
On 11/24/20 11:58 AM, Alwin Antreich wrote:
Letting the columns flex needs a flat column head structure.
Signed-off-by: Alwin Antreich
---
www/manager6/ceph/Pool.js | 131 ++
1 file changed, 75 insertions(+), 56 deletions(-)
diff --git a/
mhmm.. you did not simply move the code, you added at least the 'titles'
it would be better to have a commit which really only moves the
code to a new file
or at least mention it in the commit message
one comment inline
On 11/24/20 11:58 AM, Alwin Antreich wrote:
for better handling and since
seems not to work to set the target_size(_bytes) via gui (cli works)
comments inline
On 11/24/20 11:58 AM, Alwin Antreich wrote:
* add the ability to edit an existing pool
* allow adjustment of autoscale settings
* warn if user specifies min_size 1
* disallow min_size 1 on pool create
* calcula
comments inline
On 11/24/20 11:58 AM, Alwin Antreich wrote:
the properties target_size_ratio and target_size_bytes are the only two
options by ceph to set on a pool. The updated pool list shows now
autoscale settings & status. Including the new target PGs. To make it
easier for new users to get/
comments inline
On 11/24/20 11:58 AM, Alwin Antreich wrote:
Information of a single pool can be queried.
Signed-off-by: Alwin Antreich
---
PVE/API2/Ceph/POOLS.pm | 113 +++--
1 file changed, 108 insertions(+), 5 deletions(-)
diff --git a/PVE/API2/Ceph/PO
high level comment
it seems the series depends on pg autoscaling to be enabled, but on my
nautilus installation it was not
so i'd say we have to handle that by not querying autoscaling settings
if it is disabled or wrapping the mon call in an eval, else the whole
pool view does not work
(i get
Signed-off-by: Alexandre Derumier
---
www/manager6/Utils.js| 4 +--
www/manager6/sdn/SubnetEdit.js | 39 +-
www/manager6/sdn/SubnetView.js | 23 ++-
www/manager6/sdn/VnetEdit.js | 10 ++-
www/manager6/sdn/ZoneView.js
Signed-off-by: Alexandre Derumier
---
www/manager6/Utils.js | 29 ++
www/manager6/sdn/ControllerView.js | 39 +---
www/manager6/sdn/SubnetView.js | 49 +++---
www/manager6/sdn/VnetView.js | 31 +--
Signed-off-by: Alexandre Derumier
---
www/manager6/Makefile| 4 +
www/manager6/Utils.js| 20
www/manager6/dc/Config.js| 8 ++
www/manager6/form/SDNDnsSelector.js | 52 +++
www/manager6/sdn/DnsView.js | 131 ++
Signed-off-by: Alexandre Derumier
---
www/manager6/Utils.js | 3 ++-
www/manager6/sdn/SubnetEdit.js | 6 --
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 8c939536..5440b972 100644
--- a/www/manager6/Utils.js
+++ b/w
Signed-off-by: Alexandre Derumier
---
www/manager6/Makefile | 1 +
www/manager6/dc/Config.js | 24 +++--
www/manager6/sdn/ControllerView.js | 1 +
www/manager6/sdn/DnsView.js| 1 +
www/manager6/sdn/IpamView.js | 2 ++
www/manager6/sdn/OptionsPan
Signed-off-by: Alexandre Derumier
---
www/manager6/sdn/SubnetEdit.js | 35 ++
1 file changed, 35 insertions(+)
diff --git a/www/manager6/sdn/SubnetEdit.js b/www/manager6/sdn/SubnetEdit.js
index 2afa1a27..ac9a40ea 100644
--- a/www/manager6/sdn/SubnetEdit.js
+++ b/w
Signed-off-by: Alexandre Derumier
---
www/manager6/sdn/SubnetEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/sdn/SubnetEdit.js b/www/manager6/sdn/SubnetEdit.js
index c9c6475b..2afa1a27 100644
--- a/www/manager6/sdn/SubnetEdit.js
+++ b/www/manager6/sdn/Subn
Signed-off-by: Alexandre Derumier
---
www/manager6/Makefile | 5 +
www/manager6/Utils.js | 25 +
www/manager6/dc/Config.js | 8 ++
www/manager6/form/SDNIpamSelector.js | 52 ++
www/manager6/sdn/IpamView.js | 131 +
Signed-off-by: Alexandre Derumier
---
www/manager6/Makefile | 5 +--
www/manager6/dc/Config.js | 10 +-
www/manager6/sdn/SubnetEdit.js | 13 +++
www/manager6/sdn/SubnetView.js | 62 ++
www/manager6/sdn/VnetPanel.js | 39 +
Signed-off-by: Alexandre Derumier
---
www/manager6/Makefile| 1 +
www/manager6/Utils.js| 5 ++
www/manager6/sdn/ControllerView.js | 9
www/manager6/sdn/controllers/BgpEdit.js | 62
www/manager6/sdn/controllers/EvpnEdi
(needed, or the panel don't load)
Signed-off-by: Alexandre Derumier
---
www/manager6/sdn/Browser.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/manager6/sdn/Browser.js b/www/manager6/sdn/Browser.js
index 1415f966..e5ffc0e8 100644
--- a/www/manager6/sdn/Browser.js
+++ b/www/manager6
Signed-off-by: Alexandre Derumier
---
www/manager6/Makefile| 1 +
www/manager6/form/SDNVnetSelector.js | 68
www/manager6/sdn/SubnetEdit.js | 7 +++
www/manager6/sdn/SubnetView.js | 5 ++
www/manager6/sdn/VnetEdit.js | 8 +---
w
Signed-off-by: Alexandre Derumier
---
www/manager6/Makefile | 2 +
www/manager6/dc/Config.js | 8 +++
www/manager6/sdn/SubnetEdit.js | 95 +
www/manager6/sdn/SubnetView.js | 107 +
4 files changed, 212 insertions(+)
c
Changelogv2:
- add ipams gui
Changelogv3:
- add internal pve ipam form
- ipam is optional for subnets
Changelogv4:
- add dns
changelogv5:
- move subnets to vnet split panel (like ipsets)
- move controllers, ipams, dns to a new options panel
changelogv6:
- display pending grid
- move dns/i
Signed-off-by: Alexandre Derumier
---
www/manager6/sdn/VnetEdit.js | 29 +++--
www/manager6/sdn/VnetView.js | 18 +++---
2 files changed, 6 insertions(+), 41 deletions(-)
diff --git a/www/manager6/sdn/VnetEdit.js b/www/manager6/sdn/VnetEdit.js
index aa40b41f..
Signed-off-by: Alexandre Derumier
---
www/manager6/Makefile | 1 +
www/manager6/Utils.js | 5
www/manager6/sdn/ipams/PVEIpamEdit.js | 34 +++
3 files changed, 40 insertions(+)
create mode 100644 www/manager6/sdn/ipams/PVEIpamEdit.js
On 23.11.20 16:41, Dominik Csapak wrote:
> this includes migration detection
>
> basically we should only enable this when we are fully connected
>
> Signed-off-by: Dominik Csapak
> ---
> src/www/main.js | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks!
- add new bgp plugin
- add ebgp support
- add loopback support
- move gateway-nodes option to zone as 'exitnodes'
- move external-peers to bgp plugin
Signed-off-by: Alexandre Derumier
---
PVE/API2/Network/SDN/Controllers.pm | 1 +
PVE/Network/SDN/Controllers.pm | 12 +-
P
Signed-off-by: Alexandre Derumier
---
PVE/API2/Network/SDN/Zones.pm | 12 +++--
PVE/Network/SDN.pm | 45 ++---
PVE/Network/SDN/Zones/Plugin.pm | 28
3 files changed, 52 insertions(+), 33 deletions(-)
diff --git a/PVE/API2/Networ
Signed-off-by: Alexandre Derumier
---
test/documentation.txt | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/test/documentation.txt b/test/documentation.txt
index 7886966..6ee8ee6 100644
--- a/test/documentation.txt
+++ b/test/documentation.txt
@@ -12,14 +12,18
Signed-off-by: Alexandre Derumier
---
PVE/Network/SDN/Zones.pm | 2 +-
PVE/Network/SDN/Zones/EvpnPlugin.pm | 7 +++
PVE/Network/SDN/Zones/Plugin.pm | 2 +-
PVE/Network/SDN/Zones/QinQPlugin.pm | 2 +-
PVE/Network/SDN/Zones/SimplePlugin.pm | 2 +-
PVE/Network/SDN/Zones/Vl
This add support for a new controller plugin "bgp",
to manage specific bgp section by host.
This is allowing ebgp
(I'll send doc soon)
Also some fixes on pending parser
Alexandre Derumier (4):
controllers: improve bgp-evpn
zones: evpn : add support for loopback
update test documentation
On 24.11.20 14:00, Fabian Ebner wrote:
> adapted from PBS. Main differences are:
> * API has GET/DELETE distinction instead of 'dry-run'
> * API expects a single property string for the prune options
>
> Signed-off-by: Fabian Ebner
> ---
>
> Needs a dependency bump for proxmox-widget-too
On 24.11.20 10:09, Dominik Csapak wrote:
> implement editing/showing notes from pve side
> for directory and pbs storages
>
> this series technically consists of a breaking api change
> (comments -> notes) in content listing, but since we only just built
> packages with the relevant commits, this
adapted from PBS. Main differences are:
* API has GET/DELETE distinction instead of 'dry-run'
* API expects a single property string for the prune options
Signed-off-by: Fabian Ebner
---
Needs a dependency bump for proxmox-widget-toolkit.
Changes from v4:
* Switch to widget toolkit'
On 24.11.20 13:19, Wolfgang Bumiller wrote:
> Allows nameserver entries of the form `fe80::1%eth2`
>
> Note that previously the schema allowed domain names here as
> well, while only allowing IPs in the hotplug's verification
> code.
>
> Signed-off-by: Wolfgang Bumiller
> ---
> NOTE: GUI still n
On 24.11.20 13:15, Dominic Jäger wrote:
> ... as this is now allowed by the API (createSchema() in PVE::SectionConfig).
> It is only allowed by the update API call (updateSchema()).
>
> Signed-off-by: Dominic Jäger
> ---
>
> www/manager6/storage/Base.js | 23 ++-
> 1 file ch
applied
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Allows nameserver entries of the form `fe80::1%eth2`
Note that previously the schema allowed domain names here as
well, while only allowing IPs in the hotplug's verification
code.
Signed-off-by: Wolfgang Bumiller
---
NOTE: GUI still needs to be adapted for this.
src/PVE/LXC.pm| 2 +-
... as this is now allowed by the API (createSchema() in PVE::SectionConfig).
It is only allowed by the update API call (updateSchema()).
Signed-off-by: Dominic Jäger
---
www/manager6/storage/Base.js | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/ww
Previously only the hash reference was printed instead of the property string.
It's also necessary to parse the property string when reading the cron config.
Signed-off-by: Fabian Ebner
---
PVE/VZDump/Common.pm | 17 +
1 file changed, 17 insertions(+)
diff --git a/PVE/VZDump/Com
On 24.11.20 11:14, Dylan Whyte wrote:
> Improve the language found in the ceph install Wizard.
>
> Signed-off-by: Dylan Whyte
> ---
> www/manager6/ceph/CephInstallWizard.js | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
>
applied, thanks!
___
applied patch 2 & 3, replaced 1
On Fri, Oct 30, 2020 at 10:42:33AM +0100, Alexandre Derumier wrote:
> following pve-common patch series
>
> Alexandre Derumier (3):
> add PVE::QemuServer::Cgroup
> replace cgroups_write by cgroup change_cpu_shares && change_cpu_quota
> systemd scope: add CPUW
qemu doesn't actually have a limiting namespace subdirectory, so I'll
just replace this with:
sub get_subdir {
my ($self, $controller, $limiting) = @_;
my $vmid = $self->{vmid};
return "qemu.slice/$vmid.scope/";
}
On Fri, Oct 30, 2020 at 10:42:34AM +0100, Alexandre
On 24.11.20 11:02, Fabian Ebner wrote:
> adapted from the PBS docs, and mention that maxfiles is deprecated.
>
> Signed-off-by: Fabian Ebner
> ---
> pvesm.adoc | 8 -
> vzdump.adoc | 94 +++--
> 2 files changed, 98 insertions(+), 4 deletions(
On 24.11.20 11:34, Oguz Bektas wrote:
> (for #2829)
>
> add a section describing how SSH tunnels are used in conjunction
> with PVE.
>
> Signed-off-by: Oguz Bektas
> ---
> v1->v2:
> * fix heading
> * fix list
>
> thank you thomas for noticing
>
>
> pvecm.adoc | 38 +++
* add the ability to edit an existing pool
* allow adjustment of autoscale settings
* warn if user specifies min_size 1
* disallow min_size 1 on pool create
* calculate min_size replica by size
Signed-off-by: Alwin Antreich
---
www/manager6/ceph/Pool.js | 276 ++--
the properties target_size_ratio and target_size_bytes are the only two
options by ceph to set on a pool. The updated pool list shows now
autoscale settings & status. Including the new target PGs. To make it
easier for new users to get/set the correct amount of PGs.
And use parameter extraction in
Since Ceph Nautilus 14.2.10 and Octopus 15.2.2 the min_size of a pool is
calculated by the size (round(size / 2)). When size is applied after
min_size to the pool, the manual specified min_size will be overwritten.
With that a race condition can occur if the setting was set but is not
active yet.
to 1, since Ceph creates a pool with 1 PG for device health metrics. And
the autoscaler may adjust the PGs of a pool anyway.
Signed-off-by: Alwin Antreich
---
PVE/API2/Ceph/POOLS.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Ceph/POOLS.pm b/PVE/API2/Ceph/POOLS.p
for better handling and since the pool endpoints got more entries.
Signed-off-by: Alwin Antreich
---
PVE/API2/Ceph/Makefile | 1 +
PVE/API2/Ceph.pm | 380 +-
PVE/API2/Ceph/POOLS.pm | 404 +
PVE/CLI/pveceph.pm
Information of a single pool can be queried.
Signed-off-by: Alwin Antreich
---
PVE/API2/Ceph/POOLS.pm | 113 +++--
1 file changed, 108 insertions(+), 5 deletions(-)
diff --git a/PVE/API2/Ceph/POOLS.pm b/PVE/API2/Ceph/POOLS.pm
index 744f2bce..19fc1b7e 100644
-
Letting the columns flex needs a flat column head structure.
Signed-off-by: Alwin Antreich
---
www/manager6/ceph/Pool.js | 131 ++
1 file changed, 75 insertions(+), 56 deletions(-)
diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
index 271dc
The default pg_autoscale_mode can be configured at Ceph directly. With
Nautilus the default mode is warn and with Octopus it has changed to on.
Signed-off-by: Alwin Antreich
---
PVE/API2/Ceph/POOLS.pm | 2 --
1 file changed, 2 deletions(-)
diff --git a/PVE/API2/Ceph/POOLS.pm b/PVE/API2/Ceph/POO
This set allows to edit pools via GUI & CLI. This should make it easier
for users to adjust pool settings, since they don't have to go the ceph
tool route.
v1 -> v2:
- move pools endpoint to a subclass
- add pg autsocale status and settings
- rework and flatten the grid view of ceph po
applied the first 2 patches
On Fri, Oct 30, 2020 at 10:42:25AM +0100, Alexandre Derumier wrote:
> following pve-common patch series
>
> Alexandre Derumier (3):
> Cgroups: use base PVE::CGroup and keep specific lxc code
> use PVE::CGroup
> cgroup: get_subdir: return cgroupv2 path for undef c
On Fri, Oct 30, 2020 at 10:42:28AM +0100, Alexandre Derumier wrote:
> ---
> src/PVE/LXC/CGroup.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/PVE/LXC/CGroup.pm b/src/PVE/LXC/CGroup.pm
> index 19562c2..74d84c4 100644
> --- a/src/PVE/LXC/CGroup.pm
> +++ b/src/PVE/LXC/CGroup.pm
> @@
(for #2829)
add a section describing how SSH tunnels are used in conjunction
with PVE.
Signed-off-by: Oguz Bektas
---
v1->v2:
* fix heading
* fix list
thank you thomas for noticing
pvecm.adoc | 38 ++
1 file changed, 38 insertions(+)
diff --git a/pvecm.ad
Am 24.11.20 um 11:14 schrieb Fabian Ebner:
Otherwise it prints the hash reference instead of the prune options.
Signed-off-by: Fabian Ebner
---
AFAICT the result of the function was only used for printing, so this
should've been a cosmetic problem only.
It is also used for printing the cron
Improve the language found in the ceph install Wizard.
Signed-off-by: Dylan Whyte
---
www/manager6/ceph/CephInstallWizard.js | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/www/manager6/ceph/CephInstallWizard.js
b/www/manager6/ceph/CephInstallWizard.js
Otherwise it prints the hash reference instead of the prune options.
Signed-off-by: Fabian Ebner
---
AFAICT the result of the function was only used for printing, so this
should've been a cosmetic problem only.
PVE/VZDump/Common.pm | 4
1 file changed, 4 insertions(+)
diff --git a/PVE/VZ
adapted from the PBS docs, and mention that maxfiles is deprecated.
Signed-off-by: Fabian Ebner
---
pvesm.adoc | 8 -
vzdump.adoc | 94 +++--
2 files changed, 98 insertions(+), 4 deletions(-)
diff --git a/pvesm.adoc b/pvesm.adoc
index ee7f59
On Tue, Nov 24, 2020 at 10:09:29AM +0100, Dominik Csapak wrote:
> to show and update snapshot notes from the cli
>
> Signed-off-by: Dominik Csapak
> ---
> src/bin/proxmox-backup-client.rs | 1 +
> src/bin/proxmox_backup_client/mod.rs | 2 +
> src/bin/proxmox_backup_client/snaps
implement editing/showing notes from pve side
for directory and pbs storages
this series technically consists of a breaking api change
(comments -> notes) in content listing, but since we only just built
packages with the relevant commits, this should be ok...
i also omitted the suggested 'snapsh
so that we are more consistent with pbs
Signed-off-by: Dominik Csapak
---
PVE/API2/Storage/Content.pm | 4 ++--
PVE/Storage/PBSPlugin.pm| 2 +-
PVE/Storage/Plugin.pm | 10 +-
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2
Signed-off-by: Dominik Csapak
---
www/manager6/grid/BackupView.js | 4 ++--
www/manager6/storage/Browser.js | 2 +-
www/manager6/storage/ContentView.js | 12 ++--
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/B
for now we filter out pbs storages
Signed-off-by: Dominik Csapak
---
www/manager6/grid/BackupView.js | 51 -
1 file changed, 50 insertions(+), 1 deletion(-)
diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js
index 191b2e3f..d43f5a3f 10
Signed-off-by: Dominik Csapak
---
www/manager6/grid/BackupView.js | 8
1 file changed, 8 deletions(-)
diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js
index d43f5a3f..28326a79 100644
--- a/www/manager6/grid/BackupView.js
+++ b/www/manager6/grid/BackupView.j
Signed-off-by: Dominik Csapak
---
PVE/Storage/PBSPlugin.pm | 20
1 file changed, 20 insertions(+)
diff --git a/PVE/Storage/PBSPlugin.pm b/PVE/Storage/PBSPlugin.pm
index fbffbdf..7d3db34 100644
--- a/PVE/Storage/PBSPlugin.pm
+++ b/PVE/Storage/PBSPlugin.pm
@@ -608,6 +608,26 @@
and add the appropriate api call to set and get the comment
we need to bump APIVER for this and can bump APIAGE, since
we only use it at this new call that can work with the default
implementation
Signed-off-by: Dominik Csapak
---
PVE/API2/Storage/Content.pm | 63
'file_size_info' only works for directory based storages, while
'volume_size_info' should work for all
Signed-off-by: Dominik Csapak
---
PVE/API2/Storage/Content.pm | 29 ++---
1 file changed, 26 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Storage/Content.pm b/PV
to show and update snapshot notes from the cli
Signed-off-by: Dominik Csapak
---
src/bin/proxmox-backup-client.rs | 1 +
src/bin/proxmox_backup_client/mod.rs | 2 +
src/bin/proxmox_backup_client/snapshot.rs | 126 ++
3 files changed, 129 insertions(+)
creat
92 matches
Mail list logo
