Re: [pve-devel] [PATCH manager] ui: improve description of guest-fstrim checkbox

2020-12-15 Thread Thomas Lamprecht
On 15.12.20 16:22, Aaron Lauterer wrote: > The phrasing left some room to speculation when this would actually be > run, e.g. after cloning a full VM? Adding/Expanding a QGA pve-docs section with that info in detail and adding a onlineHelp button here would be also great, allows to explain it in

[pve-devel] [PATCH manager] ui: improve description of guest-fstrim checkbox

2020-12-15 Thread Aaron Lauterer
The phrasing left some room to speculation when this would actually be run, e.g. after cloning a full VM? Currently the only instances where it is used is after moving a disk or migrating a VM. Signed-off-by: Aaron Lauterer --- www/manager6/form/AgentFeatureSelector.js | 2 +- 1 file changed,

[pve-devel] [PATCH qemu-server] improve description of fstrim_cloned_disks

2020-12-15 Thread Aaron Lauterer
The phrasing left some room for speculation when this would be triggered. E.g. after cloning a full VM? Currently the only instances where it is used is when a disk is moved or a VM migrated. Signed-off-by: Aaron Lauterer --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1

[pve-devel] applied-series: [PATCH-SERIES v3] migration tests

2020-12-15 Thread Thomas Lamprecht
On 01.12.20 13:06, Fabian Ebner wrote: > Refactor some code and create a test enviroment for migration. See the last > patch for a description of the latter. > > The first two patches depend on libpve-guest-common-perl >=3.1-3 > > Changes from v2: > * drop already applied patch introducing

[pve-devel] applied: [PATCH v2 qemu-server] fix cloning/restoring of cloudinit disks in raw format

2020-12-15 Thread Thomas Lamprecht
On 02.12.20 13:50, Mira Limbeck wrote: > We only added the format extension when it was not 'raw'. But on file level > storages we always require it. To fix this, always add the format > extension if the storage provides the 'path' property. > This is the same logic we use in create_disks for

Re: [pve-devel] [PATCH v2 qemu-server] fix cloning/restoring of cloudinit disks in raw format

2020-12-15 Thread Mira Limbeck
On 12/15/20 2:57 PM, Thomas Lamprecht wrote: On 02.12.20 13:50, Mira Limbeck wrote: We only added the format extension when it was not 'raw'. But on file level storages we always require it. To fix this, always add the format extension if the storage provides the 'path' property. This is the

[pve-devel] applied: [PATCH docs] remove duplicate line on the ZFS advantage list

2020-12-15 Thread Thomas Lamprecht
On 27.11.20 15:50, Alwin Antreich wrote: > Signed-off-by: Alwin Antreich > --- > local-zfs.adoc | 2 -- > 1 file changed, 2 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

Re: [pve-devel] [PATCH v2 qemu-server] fix cloning/restoring of cloudinit disks in raw format

2020-12-15 Thread Thomas Lamprecht
On 02.12.20 13:50, Mira Limbeck wrote: > We only added the format extension when it was not 'raw'. But on file level > storages we always require it. To fix this, always add the format > extension if the storage provides the 'path' property. > This is the same logic we use in create_disks for

[pve-devel] applied: [PATCH qemu-server] clone_disk: fix offline clone of efidisk

2020-12-15 Thread Thomas Lamprecht
On 07.12.20 13:15, Fabian Ebner wrote: > by partially reverting 4df98f2f14348d0ed57529c4c04a1b5ffb840055 and fixing the > line-length issue differently. The commit didn't update two later usages of > $size, breaking copying the efidisk. The other usage as a parameter to > qemu_img_convert() is

[pve-devel] applied: [PATCH qemu-server] qm destroy: Extend --purge description

2020-12-15 Thread Thomas Lamprecht
On 10.12.20 10:17, Dominic Jäger wrote: > Add replication jobs & HA. This makes the enumeration complete. > > Signed-off-by: Dominic Jäger > --- > PVE/API2/Qemu.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___

[pve-devel] applied: [PATCH v2 pve-installer] installer: minor language fixup

2020-12-15 Thread Thomas Lamprecht
On 11.12.20 08:55, Dylan Whyte wrote: > just some nitpicky changes. > > v2: > - remove tag files > @Thomas: Like you thought, they are autogenerated by some vim plugin. > They usually sit quitely in the untracked files, but this time, I guess > I somehow I managed to add them in without

[pve-devel] applied: [RFC pve-qemu] disable jemalloc

2020-12-15 Thread Thomas Lamprecht
On 10.12.20 16:23, Stefan Reiter wrote: > jemalloc does not play nice with our Rust library (proxmox-backup-qemu), > specifically it never releases memory allocated from Rust to the OS. > This leads to a problem with larger caches (e.g. for the PBS block driver). > > It appears to be related to

[pve-devel] applied: [PATCH storage 2/2] Diskmanage: extend wearout detection for SAS disk

2020-12-15 Thread Thomas Lamprecht
On 11.12.20 14:52, Dominik Csapak wrote: > for some controllers/disks there the line is > Percentage used endurance indicator: x% > > so extend the regex for that possibilty. > We even had a test-case for SAS but did not notice we could extract > that info from there... > > Signed-off-by:

[pve-devel] applied: [PATCH storage 1/2] tests: add ssd sas disk

2020-12-15 Thread Thomas Lamprecht
On 11.12.20 14:52, Dominik Csapak wrote: > copied from test 'sas' with rotational set to 0 > this has then the type 'ssd', rpm: 0, and health: 'OK' > > Signed-off-by: Dominik Csapak > --- > test/disk_tests/sas_ssd/disklist | 1 + > .../disk_tests/sas_ssd/disklist_expected.json |

[pve-devel] applied: [PATCH storage] fix #3199: by fixing usage of strftime

2020-12-15 Thread Thomas Lamprecht
On 15.12.20 11:59, Fabian Ebner wrote: > In a very early version I wanted to parse the date from the backup name, and > when switching to using the ctime and localtime() instead, I forgot to update > the usage of strftime. applied, thanks! ___

[pve-devel] [PATCH v4 manager 4/4] ui: qemu: Add disk reassign dialog

2020-12-15 Thread Aaron Lauterer
Adds a new button to the hardware panel labeled 'Reassign disk' and enables a user to reassign a disk to another VM. Signed-off-by: Aaron Lauterer --- v3 -> v4: * added check to not show template VMs in dropdown * renamed disk parameter to `drive_name` v2 -> v3: * fixed check to omit the

[pve-devel] [PATCH v4 manager 2/4] ui: qemu/HardwareView: white space fixes

2020-12-15 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- v1 -> v2 -> v3 -> v4: nothing changed www/manager6/qemu/HardwareView.js | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 40b3fe86..b641317d 100644 ---

[pve-devel] [PATCH v4 manager 3/4] ui: utils: add method to get VM data from resource store

2020-12-15 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- v3 -> v4: rebased v2 -> v3: nothing changed v1 -> v2: fixed linter errors www/manager6/Utils.js | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 366385da..f70e901f 100644 ---

[pve-devel] [PATCH v4 widget-toolkit 1/4] window/edit: add option to disable reset button

2020-12-15 Thread Aaron Lauterer
Sometimes the reset button does not make sense and the isCreate option does not fit as well because with it, the submit button will be enabled right away instead of waiting for the form to be valid. Signed-off-by: Aaron Lauterer --- v1 -> v2 -> v3 -> v4: nothing changed This helps to reuse the

[pve-devel] [PATCH v4 series 0/4] Add GUI for disk reassignment

2020-12-15 Thread Aaron Lauterer
This patch series adds the GUI to the recent patch series [0] which enables the reassignment of disks between VMs. For this to work, the backend patch series [0] needs to be applied and installed. v3 -> v4: * rebased * added check to not add template VMs to dropdown * renamed disk parameter to

[pve-devel] [PATCH v5 qemu-server 2/5] disk reassign: add API endpoint

2020-12-15 Thread Aaron Lauterer
The goal of this new API endpoint is to provide an easy way to move a disk between VMs as this was only possible with manual intervention until now. Either by renaming the VM disk or by manually adding the disks volid to the config of the other VM. The latter can easily cause unexpected behavior

[pve-devel] [PATCH v5 manager 5/5] ui: tasks: add qmreassign task description

2020-12-15 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- v4->v5: rebased www/manager6/Utils.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 5b6a0221..f70e901f 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -1707,6 +1707,7 @@

[pve-devel] [PATCH v5 guest-common 4/5] Replication: mention disk reassign in comment of possible reasons

2020-12-15 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- v5: newly added PVE/Replication.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index ae0f145..47f5434 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@ -169,7 +169,7 @@ sub prepare {

[pve-devel] [PATCH v5 qemu-server 3/5] cli: disk reassign: add reassign_disk to qm command

2020-12-15 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- v4 -> v5: renamed `drive_key` to `drive_name` v3 ->v4: nothing v2 -> v3: renamed parameter `disk` to `drive_key` rfc -> v1 -> v2: nothing changed PVE/CLI/qm.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index

[pve-devel] [PATCH v5 storage 1/5] add disk reassign feature

2020-12-15 Thread Aaron Lauterer
Functionality has been added for the following storage types: * dir based ones * directory * NFS * CIFS * gluster * ZFS * (thin) LVM * Ceph A new feature `reassign` has been introduced to mark which storage plugin supports the feature. Version API and AGE have been bumped.

[pve-devel] [PATCH v5 series 0/5] disk reassign: add new feature

2020-12-15 Thread Aaron Lauterer
This series implements a new feature which allows users to easily reassign disks between VMs. Currently this is only possible with one of the following manual steps: * rename the disk image/file and do a `qm rescan` * configure the disk manually and use the old image name, having an image for

[pve-devel] [PATCH storage] fix #3199: by fixing usage of strftime

2020-12-15 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- This is embarassing... In a very early version I wanted to parse the date from the backup name, and when switching to using the ctime and localtime() instead, I forgot to update the usage of strftime. PVE/Storage.pm | 4 ++--

Re: [pve-devel] [PATCH pve-common] JSONSchema: Increase vmid option minimum to 100

2020-12-15 Thread Thomas Lamprecht
On 15.12.20 09:11, Dominic Jäger wrote: > On Mon, Dec 14, 2020 at 01:33:25PM +0100, Fabian Grünbichler wrote: >> I think the argument is that the associated format already enforces that >> the ID is >= 100, so that the API allows less has no practical effect >> except confusing users that read

Re: [pve-devel] [PATCH pve-common] JSONSchema: Increase vmid option minimum to 100

2020-12-15 Thread Dominic Jäger
On Mon, Dec 14, 2020 at 01:33:25PM +0100, Fabian Grünbichler wrote: > I think the argument is that the associated format already enforces that > the ID is >= 100, so that the API allows less has no practical effect > except confusing users that read the man page/help output/api dump. This is