Re: [pve-devel] Adding new data storage

2020-12-17 Thread Thomas Lamprecht
Hi again, On 17/12/2020 17:16, Andrei Perapiolkin wrote: > Hi Thomas, Dietmar, > > Thanks for the quick reply. > > > Sorry for ambiguity with "API". By API I meant usage of SSH to send commands > to Open-E JovianDSS. > > The problem here is that this commands are different from the one used i

Re: [pve-devel] Adding new data storage

2020-12-17 Thread Andrei Perapiolkin
Hi Thomas, Dietmar, Thanks for the quick reply. Sorry for ambiguity with "API". By API I meant usage of SSH to send commands to Open-E JovianDSS. The problem here is that this commands are different from the one used in "ZFS over iSCSI" plugin. That is why Im thinking about adding separat

Re: [pve-devel] Adding new data storage

2020-12-17 Thread Dietmar Maurer
> I would like to add new data storage. This storage would resemble ZFS > over iSCSI but will use different API to access storage. I am curios, what API exactly? ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/

Re: [pve-devel] Adding new data storage

2020-12-17 Thread Thomas Lamprecht
Hi, On 17/12/2020 16:06, Andrei Perapiolkin wrote: > I would like to add new data storage. This storage would resemble ZFS over > iSCSI but will use different API to access storage. > What do you mean here, what API will it use? If you want to include this in our repository some more details wo

[pve-devel] Adding new data storage

2020-12-17 Thread Andrei Perapiolkin
Hi, I would like to add new data storage. This storage would resemble ZFS over iSCSI but will use different API to access storage. Should I create/provide anything besides pve-storage/PVE/Storage/.pm ? Is there any documentation I should familiarize myself with beside coding style? Be

Re: [pve-devel] [PATCH v2 docs] qm: add guest agent section

2020-12-17 Thread Thomas Lamprecht
just a small comment on top of the other reviewers stuff. On 17/12/2020 13:13, Aaron Lauterer wrote: > +Proxmox VE will issue a trim command to the guest after the following use {pve} for Proxmox VE > +operations that have the potential to write out zeros to the storage: > + > +* moving a disk t

[pve-devel] [PATCH v2 zsync 3/3] fix #2821: only abort if there really is a waiting/syncing job

2020-12-17 Thread Fabian Ebner
by remembering the process via PID+start time+boot ID and checking for that information in the new instance. If the old instance can't be found, the new one will continue and register itself in the state. After updating the pve-zsync package, if there is a waiting instance running the old version,

[pve-devel] [PATCH v2 zsync 1/3] remove unused function write_cron

2020-12-17 Thread Fabian Ebner
Commit 76b2c677f7a2fd81a990533b317374d168d1d918 replaced it with update_cron. Signed-off-by: Fabian Ebner --- New in v2 and not related to the rest of the series. pve-zsync | 36 1 file changed, 36 deletions(-) diff --git a/pve-zsync b/pve-zsync index f3b9

[pve-devel] [PATCH v2 zsync 2/3] introduce and use read_file helper

2020-12-17 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- New in v2 Is there a special reason why the input file handle was kept open until after renaming (in update_cron and update_state)? pve-zsync | 53 - 1 file changed, 20 insertions(+), 33 deletions(-) diff --gi

Re: [pve-devel] [PATCH v2 docs] qm: add guest agent section

2020-12-17 Thread Stoiko Ivanov
Thanks for getting this documented! LGTM as it currently is! (All comments are purely suggestions - feel free to ignore them) One thing I would emphasize a bit more (e.g. by adding it as list items in the initial paragraph) is that getting all the guest agent goodness needs 2 prerequisites: * ins

Re: [pve-devel] [PATCH v2 docs] qm: add guest agent section

2020-12-17 Thread Oguz Bektas
hi, lgtm, except maybe you should also mention that one needs to start/enable the qemu-ga service in the VM for it to work. (not all distributions do this automatically) On Thu, Dec 17, 2020 at 01:13:35PM +0100, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > v1 -> v2: implemented

[pve-devel] [PATCH v2 manager] gui: add help button to qm guest agent window

2020-12-17 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- v1 -> v2: nothing www/manager6/qemu/Options.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js index 1f07d81a..3467a952 100644 --- a/www/manager6/qemu/Options.js +++ b/www/manager6/qemu/Options.js

[pve-devel] [PATCH v2 docs] qm: add guest agent section

2020-12-17 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- v1 -> v2: implemented suggested changes from Dylan. Thx for that. Additionally to the previous series [0] which changes the phrasing, it would be nice to have a dedicated Qemu Guest Agent section in the docs. [0] https://lists.proxmox.com/pipermail/pve-devel/202

Re: [pve-devel] [PATCH docs] qm: add guest agent section

2020-12-17 Thread Dylan Whyte
Hi, Just a few language corrections. I have no problem with the content :) Dylan On 12/16/20 3:38 PM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer --- Additionally to the previous series [0] which changes the phrasing, it would be nice to have a dedicated Qemu Guest Agent section in t

[pve-devel] [PATCH v2 qemu-server] tests: allow running migration tests in parallel

2020-12-17 Thread Fabian Ebner
It's not easily possible to use separate JSON files for the test configuration, because part of it is generated with perl code. While this could be encoded too, it seems cleaner to use the "run a single test by specifing the name" functionality while adding a way for make to obtain a list of the te

Re: [pve-devel] [PATCH zsync] fix #2821: only abort if there really is a waiting/syncing job instance already

2020-12-17 Thread Thomas Lamprecht
On 17/12/2020 09:40, Fabian Ebner wrote: > Am 14.12.20 um 14:47 schrieb Thomas Lamprecht: >> On 14.12.20 14:00, Fabian Ebner wrote: >>> @@ -584,6 +586,33 @@ sub destroy_job { >>>   }); >>>   } >>>   +sub get_process_start_time { >>> +    my ($pid) = @_; >>> + >>> +    return eval { run_cmd(['ps

Re: [pve-devel] [PATCH zsync] fix #2821: only abort if there really is a waiting/syncing job instance already

2020-12-17 Thread Fabian Ebner
Am 14.12.20 um 14:47 schrieb Thomas Lamprecht: On 14.12.20 14:00, Fabian Ebner wrote: By remembering the instance via PID and start time and checking for that information in later instances. If the old instance can't be found, the new one will continue and register itself in the state. After up