[pve-devel] applied: Re: [PATCH pve-network 0/3] add zones/controllers tests

2020-12-18 Thread Thomas Lamprecht
On 09/12/2020 16:11, Alexandre Derumier wrote: > This patch serie add unit tests for zones && controllers > config generation. > > (This need to be apply on top of my last patches series) > applied, thanks. It seems that some build-dependencies are missing in debian control, at least I cannot b

Re: [pve-devel] [PATCH V2 pve-network 3/7] use canonical ipv6 address (RFC 5952) everywhere

2020-12-18 Thread Thomas Lamprecht
On 03/12/2020 10:19, Alexandre Derumier wrote: > we want only 1 format for ipam database > > Signed-off-by: Alexandre Derumier > --- > PVE/Network/SDN/Dns/PowerdnsPlugin.pm | 3 +-- > PVE/Network/SDN/Ipams/PVEPlugin.pm| 5 +++-- > PVE/Network/SDN/Subnets.pm| 9 - > 3 file

[pve-devel] applied-series: Re: [PATCH V2 pve-network 0/7] various cleanups

2020-12-18 Thread Thomas Lamprecht
On 03/12/2020 10:19, Alexandre Derumier wrote: > changelog v2: > > - add more bugfix > > Alexandre Derumier (7): > evpn: frr: use datacenter default profile (lower timeouts) > get_local_vnets: display vnet alias in comments > use canonical ipv6 address (RFC 5952) everywhere > ipam : pve:

[pve-devel] applied-series: Re: [PATCH docs] qm/pct: Add explanation for --purge

2020-12-18 Thread Thomas Lamprecht
On 10/12/2020 09:15, Dominic Jäger wrote: > This was apparently not clear enough. > For example, see #3184. > > A bit long, but I think this is a better place for additional > information about ACL and firewall than the GUI tooltip or the > API parameter description. > > Signed-off-by: Dominic Jä

[pve-devel] applied: Re: [PATCH qemu-server] improve description of fstrim_cloned_disks

2020-12-18 Thread Thomas Lamprecht
On 15/12/2020 16:22, Aaron Lauterer wrote: > The phrasing left some room for speculation when this would be triggered. > E.g. after cloning a full VM? > > Currently the only instances where it is used is when a disk is moved or > a VM migrated. > > Signed-off-by: Aaron Lauterer > --- > > PVE/Q

[pve-devel] applied: Re: [PATCH manager] ui: improve description of guest-fstrim checkbox

2020-12-18 Thread Thomas Lamprecht
On 15/12/2020 16:22, Aaron Lauterer wrote: > The phrasing left some room to speculation when this would actually be > run, e.g. after cloning a full VM? > > Currently the only instances where it is used is after moving a disk or > migrating a VM. > > Signed-off-by: Aaron Lauterer > --- > www/ma

[pve-devel] applied: Re: [PATCH manager] ceph: extend error for wrong config-file link

2020-12-18 Thread Thomas Lamprecht
On 16/12/2020 12:46, Stoiko Ivanov wrote: > Since I had to look up the cause of the error-message in our source > explaining why exactly ceph-operations fail, because > /etc/ceph/ceph.conf exists. > > reported via our community forum: > https://forum.proxmox.com/threads/osd-ersetzen-neu-erstellen.

[pve-devel] applied: Re: [PATCH v2 qemu-server] tests: allow running migration tests in parallel

2020-12-18 Thread Thomas Lamprecht
On 17/12/2020 10:37, Fabian Ebner wrote: > It's not easily possible to use separate JSON files for the test > configuration, > because part of it is generated with perl code. While this could be encoded > too, > it seems cleaner to use the "run a single test by specifing the name" > functionality

Re: [pve-devel] [PATCH v2 zsync 2/3] introduce and use read_file helper

2020-12-18 Thread Thomas Lamprecht
On 17/12/2020 15:17, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > > New in v2 > > Is there a special reason why the input file handle was kept open until > after renaming (in update_cron and update_state)? Did not see any. ___ pve-devel

[pve-devel] applied-series: Re: [PATCH v2 zsync 1/3] remove unused function write_cron

2020-12-18 Thread Thomas Lamprecht
On 17/12/2020 15:17, Fabian Ebner wrote: > Commit 76b2c677f7a2fd81a990533b317374d168d1d918 replaced it with > update_cron. > > Signed-off-by: Fabian Ebner > --- > > New in v2 and not related to the rest of the series. > > pve-zsync | 36 > 1 file changed, 3

Re: [pve-devel] [PATCH manager] pveceph: change status from long JSON to ceph -s

2020-12-18 Thread Thomas Lamprecht
On 18/12/2020 17:00, Aaron Lauterer wrote: > Printing a lot of very detailed JSON output on the CLI is not very > useful. > > Printing the `ceph -s` overview is much more suited to give an overview > of the ceph cluster status. > > Signed-off-by: Aaron Lauterer > --- > > @Thomas: I hope this is

[pve-devel] [PATCH manager] pveceph: change status from long JSON to ceph -s

2020-12-18 Thread Aaron Lauterer
Printing a lot of very detailed JSON output on the CLI is not very useful. Printing the `ceph -s` overview is much more suited to give an overview of the ceph cluster status. Signed-off-by: Aaron Lauterer --- @Thomas: I hope this is what you hand in mind when we did discuss this off list. PVE

[pve-devel] [PATCH zfsonlinux] update submodule and patches for zfs-0.8.6

2020-12-18 Thread Stoiko Ivanov
zfs-0.8.6 got released recently [0]. The changes are rather small: * compat for kernels up to 5.10 * a fix for ARC performance (certain hits were not accounted, resulting in earlier eviction) * build fixes for in kernel (not module) compilation None of them seem to have a large potential for reg

Re: [pve-devel] OpenAPI converter (similar to JSONSchema generator)

2020-12-18 Thread Thomas Lamprecht
On 18/12/2020 12:27, Erik Hollensbe wrote: > Thanks for your assistance! I will look into these things over the weekend. > > As for the swagger endpoint, yes, more or less, I was going to assume there > could be a /api2/swagger.json or similar route that could resolve to the API > definition. >

[pve-devel] [PATCH qemu-server v3] Prepare API for import GUI

2020-12-18 Thread Dominic Jäger
Move existing import functionality to the API so that it is available for the GUI. Signed-off-by: Dominic Jäger --- I haven't checked everything (e.g. permissions, code style) yet, but 1. a large part of intermediate bloat is away (some may be left) 2. it's rebased 3. so clicking through the GUI

[pve-devel] [PATCH manager v3] gui: Add import for disk & VM

2020-12-18 Thread Dominic Jäger
Add GUI wizard to import whole VMs and a window for only single disks in hardware view. Signed-off-by: Dominic Jäger --- PVE/API2/Nodes.pm | 49 www/manager6/Makefile | 2 + www/manager6/Workspace.js | 15 ++ www/manager6/form/Contr

Re: [pve-devel] OpenAPI converter (similar to JSONSchema generator)

2020-12-18 Thread Erik Hollensbe
Thanks for your assistance! I will look into these things over the weekend. As for the swagger endpoint, yes, more or less, I was going to assume there could be a /api2/swagger.json or similar route that could resolve to the API definition. On Fri, Dec 18, 2020 at 2:02 AM Thomas Lamprecht wrote:

Re: [pve-devel] OpenAPI converter (similar to JSONSchema generator)

2020-12-18 Thread Thomas Lamprecht
Hi, first, thanks for your interest in working on and improving Proxmox VE! On 17/12/2020 05:45, Erik Hollensbe wrote: > The specification is here and has similar semantics and goals to > jsonschema, just really good codegen support: > https://swagger.io/specification/ > > What I am proposing i