Re: [pve-devel] Audio support, dummy/none

2021-01-05 Thread Gilles Pietri
Le 05/01/2021 à 12:43, Aaron Lauterer a écrit : > Adding support for the 'none' backend should not be too hard to > implement. Besides changes in QemuServer.pm, the GUI (pve-manager) needs > to be adapted as well because right now the backend is hard coded. I'll start with that, it's a good "non i

Re: [pve-devel] [PATCH i18n] Update German translations

2021-01-05 Thread Stoiko Ivanov
Thanks for the patch! (not a user of non-english locales myself, so probably not the best source for feedback) noticed one typo (and a few places where the use of gettext seems wrong) feel free to ignore any and all of the suggestions :) On Tue, 5 Jan 2021 13:12:29 +0100 Dominic Jäger wrote:

[pve-devel] [PATCH i18n] Update German translations

2021-01-05 Thread Dominic Jäger
Signed-off-by: Dominic Jäger --- de.po | 451 -- 1 file changed, 186 insertions(+), 265 deletions(-) diff --git a/de.po b/de.po index ffdc6ff..06dc295 100644 --- a/de.po +++ b/de.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: proxmox tr

Re: [pve-devel] Audio support, dummy/none

2021-01-05 Thread Aaron Lauterer
On 1/4/21 6:55 PM, Gilles Pietri wrote: Le 03/01/2021 à 01:55, Gilles Pietri a écrit : Hi! Happy new year to everyone, especially the devs working on Proxmox, it's still awesome in 2021 ;) I'm interested in replicating a qemu audio setup that uses the dummy driver (called "none") on Proxmox,

[pve-devel] [PATCH manager 1/2] ui: firewall: Clarify group rule subjects

2021-01-05 Thread Dominic Jäger
First, both buttons add a row to the grid, so they should be both "Add" (or both "Insert"). Secondly, we add a (security group) rule to the grid, not the group itself. Thirdly, the window title should be different to the regular rule. Signed-off-by: Dominic Jäger --- www/manager6/grid/FirewallRu

[pve-devel] [PATCH manager 2/2] ui: firewall: Clarify text for "Add" button

2021-01-05 Thread Dominic Jäger
The regular button is titled "Add". If groups are allowed, then the group button is titled "Add: Group rule". In this case, changing the regular button title to "Add: Rule" makes the difference a little more clear and also both buttons then look the same. Signed-off-by: Dominic Jäger --- www/m

Re: [pve-devel] [PATCH qemu] PVE: fix aborting multiple 'CREATED' jobs in sequential transaction

2021-01-05 Thread Mira Limbeck
Tested Stefan's prebuilt qemu package with this patch applied and my VM that has the issue. Additionally tested the case of a full backup target (https://forum.proxmox.com/threads/vm-hard-freezes-on-backup.81752/) and it no longer hangs. Looks good in my tests, so: Tested-by: Mira Limbeck

[pve-devel] [PATCH pve-network 09/15] tests: add ipams tests

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- test/Makefile | 5 +- test/ipams/netbox/expected.add_ip | 9 + test/ipams/netbox/expected.add_next_freeip | 9 + test/ipams/netbox/expected.add_subnet | 9 + test/ipams/netbox/expected.del_ip |

[pve-devel] [PATCH pve-network 10/15] dns: add noerr param

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Dns/Plugin.pm | 10 +- PVE/Network/SDN/Dns/PowerdnsPlugin.pm | 22 +++--- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/PVE/Network/SDN/Dns/Plugin.pm b/PVE/Network/SDN/Dns/Plugin.pm index 199c

[pve-devel] [PATCH pve-network 13/15] subnets: add add_subnet/del_subnet

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Subnets.pm | 19 --- PVE/Network/SDN/SubnetPlugin.pm | 5 + PVE/Network/SDN/Subnets.pm | 20 3 files changed, 29 insertions(+), 15 deletions(-) diff --git a/PVE/API2/Network/SDN/Subnets.pm b

[pve-devel] [PATCH pve-network 04/15] dns/ipam : move api_request helper to sdn module

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 47 +- PVE/Network/SDN/Dns/Plugin.pm | 37 PVE/Network/SDN/Dns/PowerdnsPlugin.pm | 12 +++ PVE/Network/SDN/Ipams/NetboxPlugin.pm | 18 +- PVE/Network/

[pve-devel] [PATCH pve-network 02/15] ipams: add mac address

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Ipams/NetboxPlugin.pm | 6 -- PVE/Network/SDN/Ipams/PVEPlugin.pm | 4 ++-- PVE/Network/SDN/Ipams/PhpIpamPlugin.pm | 7 +-- PVE/Network/SDN/Ipams/Plugin.pm| 4 ++-- PVE/Network/SDN/SubnetPlugin.pm| 4 +++- PVE/Netwo

[pve-devel] [PATCH pve-network 01/15] sdn: pending_config: initialize empty pending key

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/Network/SDN.pm b/PVE/Network/SDN.pm index 256a7c8..a20233a 100644 --- a/PVE/Network/SDN.pm +++ b/PVE/Network/SDN.pm @@ -104,6 +104,7 @@ sub pending_config { $pending-

[pve-devel] [PATCH pve-network 11/15] tests: add dns tests

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- test/Makefile | 5 +- test/dns/powerdns/dns_config | 10 + .../expected.add_a_multiple_record.ipv4 | 13 + .../expected.add_a_multiple_record.ipv6 | 13 + test/dns/powerdns/expected.add_a_recor

[pve-devel] [PATCH pve-network 14/15] tests: add subnets tests

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- test/Makefile | 5 +- test/run_test_subnets.pl | 273 ++ test/subnets/ipv4/ipam_config | 18 +++ test/subnets/ipv4/sdn_config | 20 +++ test/subnets/ipv6/ipam_config | 18 +++ test/subnets/ipv6/sdn_co

[pve-devel] [PATCH pve-network 12/15] subnets: convert dns private function to public sub

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Subnets.pm | 66 +++--- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/PVE/Network/SDN/Subnets.pm b/PVE/Network/SDN/Subnets.pm index 25261ac..ec0fb66 100644 --- a/PVE/Network/SDN/Subnets.pm +++

[pve-devel] [PATCH pve-network 08/15] ipams: add noerr param

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Ipams/NetboxPlugin.pm | 24 +++ PVE/Network/SDN/Ipams/PhpIpamPlugin.pm | 27 +- PVE/Network/SDN/Ipams/Plugin.pm| 12 ++-- 3 files changed, 31 insertions(+), 32 deletions(-) diff --g

[pve-devel] [PATCH pve-network 15/15] fix coding style NetAddr::IP->new

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Dns/PowerdnsPlugin.pm | 2 +- PVE/Network/SDN/Ipams/PVEPlugin.pm| 2 +- PVE/Network/SDN/Subnets.pm| 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/PVE/Network/SDN/Dns/PowerdnsPlugin.pm b/PVE/Network/S

[pve-devel] [PATCH pve-network 07/15] ipam: phpipam: rename get_internal to get_prefix_id (like netbox)

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Ipams/PhpIpamPlugin.pm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm b/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm index 7147916..235d553 100644 --- a/PVE/Network/SDN/Ipams/Ph

[pve-devel] [PATCH pve-network 06/15] dns: add update record && fix powerdns

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Dns/Plugin.pm | 32 +- PVE/Network/SDN/Dns/PowerdnsPlugin.pm | 87 +-- PVE/Network/SDN/Subnets.pm| 7 ++- PVE/Network/SDN/Vnets.pm | 4 +- 4 files changed, 119 insertions(+), 1

[pve-devel] [PATCH pve-network 00/15] bugfix && unit tests

2021-01-05 Thread Alexandre Derumier
Hello everybody and Happy new year ! This add unit tests for ipams, dns, subnets and some bugfixes detected with them. for external ipam/dns api, I'm testing only the expected http query with param. I think it should be enough. I have retested all plugins, all methods, I don't have detected bug

[pve-devel] [PATCH pve-network 03/15] ipam: add update_ip

2021-01-05 Thread Alexandre Derumier
used to update ip address options like hostname, mac,... don't allow to change ip address, as some ipam don't support it. Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Ipams/NetboxPlugin.pm | 23 ++ PVE/Network/SDN/Ipams/PVEPlugin.pm | 5 +++ PVE/Network/SDN/Ipams/PhpI

[pve-devel] [PATCH pve-network 05/15] subnets: fix del_ip rollback

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Subnets.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/Network/SDN/Subnets.pm b/PVE/Network/SDN/Subnets.pm index 808c1bf..5446044 100644 --- a/PVE/Network/SDN/Subnets.pm +++ b/PVE/Network/SDN/Subnets.pm @@ -202,

[pve-devel] [PATCH pve-container] add ipam support

2021-01-05 Thread Alexandre Derumier
This add ipam support for nic using sdn vnets. - if ips are specified manally, we verify that subnet exist on vnet, and we register ip in ipam - if nic is on a vnet, but no ip is specified, we auto find the next available ips in this vnet subnet - if a gateway is defined on the subnet, we overri

[pve-devel] [PATCH v10 pve-manager 12/19] sdn: display pending values

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Utils.js | 29 ++ www/manager6/sdn/ControllerView.js | 39 +--- www/manager6/sdn/SubnetView.js | 49 +++--- www/manager6/sdn/VnetView.js | 31 +--

[pve-devel] [PATCH v10 pve-manager 18/19] sdn: add pending state column with hover tip

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Utils.js | 71 +++--- www/manager6/sdn/ControllerView.js | 17 +++ www/manager6/sdn/SubnetView.js | 12 - www/manager6/sdn/VnetView.js | 8 www/manager6/sdn/ZoneView.js | 27 +++--

[pve-devel] [PATCH v10 pve-manager 16/19] sdn: update onlinehelp links

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/ControllerView.js | 2 +- www/manager6/sdn/OptionsPanel.js | 2 +- www/manager6/sdn/ZoneView.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/sdn/ControllerView.js b/www/manager6/sdn/ControllerVi

[pve-devel] [PATCH v10 pve-manager 03/19] add sdn ipams

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile | 5 + www/manager6/Utils.js | 25 + www/manager6/dc/Config.js | 8 ++ www/manager6/form/SDNIpamSelector.js | 52 ++ www/manager6/sdn/IpamView.js | 131 +

[pve-devel] [PATCH v10 pve-manager 19/19] vnets: readd missing mac address advanced field

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/VnetEdit.js | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/www/manager6/sdn/VnetEdit.js b/www/manager6/sdn/VnetEdit.js index af5d6cde..b145a95c 100644 --- a/www/manager6/sdn/VnetEdit.js +++ b/www/manager6

[pve-devel] [PATCH v10 pve-manager 05/19] sdn: subnets: ipam is optional

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/SubnetEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/sdn/SubnetEdit.js b/www/manager6/sdn/SubnetEdit.js index c9c6475b..2afa1a27 100644 --- a/www/manager6/sdn/SubnetEdit.js +++ b/www/manager6/sdn/Subn

[pve-devel] [PATCH v10 pve-manager 02/19] add sdn subnets

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile | 2 + www/manager6/dc/Config.js | 8 +++ www/manager6/sdn/SubnetEdit.js | 95 + www/manager6/sdn/SubnetView.js | 107 + 4 files changed, 212 insertions(+) c

[pve-devel] [PATCH v10 pve-manager 01/19] sdn: vnetedit: add subnets && remove ip/mac

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/VnetEdit.js | 29 +++-- www/manager6/sdn/VnetView.js | 18 +++--- 2 files changed, 6 insertions(+), 41 deletions(-) diff --git a/www/manager6/sdn/VnetEdit.js b/www/manager6/sdn/VnetEdit.js index aa40b41f..

[pve-devel] [PATCH v10 pve-manager 04/19] sdn: add PVEIpam

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 5 www/manager6/sdn/ipams/PVEIpamEdit.js | 34 +++ 3 files changed, 40 insertions(+) create mode 100644 www/manager6/sdn/ipams/PVEIpamEdit.js

[pve-devel] [PATCH v10 pve-manager 13/19] move ipams && dns options to zone

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Utils.js| 4 +-- www/manager6/sdn/SubnetEdit.js | 39 +- www/manager6/sdn/SubnetView.js | 23 ++- www/manager6/sdn/VnetEdit.js | 10 ++- www/manager6/sdn/ZoneView.js

[pve-devel] [PATCH v10 pve-manager 09/19] add vnet panel with vnet + subnets split view

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile | 5 +-- www/manager6/dc/Config.js | 10 +- www/manager6/sdn/SubnetEdit.js | 13 +++ www/manager6/sdn/SubnetView.js | 62 ++ www/manager6/sdn/VnetPanel.js | 39 +

[pve-devel] [PATCH v10 pve-manager 06/19] add sdn dns

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile| 4 + www/manager6/Utils.js| 20 www/manager6/dc/Config.js| 8 ++ www/manager6/form/SDNDnsSelector.js | 52 +++ www/manager6/sdn/DnsView.js | 131 ++

[pve-devel] [PATCH v10 pve-manager 15/19] sdn: evpn improvments

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile| 1 + www/manager6/Utils.js| 5 ++ www/manager6/sdn/ControllerView.js | 9 www/manager6/sdn/controllers/BgpEdit.js | 62 www/manager6/sdn/controllers/EvpnEdi

[pve-devel] [PATCH v10 pve-manager 08/19] add vnet option to subnets and remove subnets list from vnet

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile| 1 + www/manager6/form/SDNVnetSelector.js | 68 www/manager6/sdn/SubnetEdit.js | 7 +++ www/manager6/sdn/SubnetView.js | 5 ++ www/manager6/sdn/VnetEdit.js | 8 +--- w

[pve-devel] [PATCH v10 pve-manager 11/19] sdn: add options panel + move controller/ipam/dns view

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile | 1 + www/manager6/dc/Config.js | 24 +++-- www/manager6/sdn/ControllerView.js | 1 + www/manager6/sdn/DnsView.js| 1 + www/manager6/sdn/IpamView.js | 2 ++ www/manager6/sdn/OptionsPan

[pve-devel] [PATCH v10 pve-manager 17/19] sdn : zone content view: add alias && resize column

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/ZoneContentView.js | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/www/manager6/sdn/ZoneContentView.js b/www/manager6/sdn/ZoneContentView.js index 20a5fe1e..7069e52a 100644 --- a/www/manager6/sdn/ZoneConten

[pve-devel] [PATCH v10 pve-manager 14/19] sdn: browser: add onlinehelp

2021-01-05 Thread Alexandre Derumier
(needed, or the panel don't load) Signed-off-by: Alexandre Derumier --- www/manager6/sdn/Browser.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/sdn/Browser.js b/www/manager6/sdn/Browser.js index 1415f966..e5ffc0e8 100644 --- a/www/manager6/sdn/Browser.js +++ b/www/manager6

[pve-devel] [PATCH v10 pve-manager 10/19] subnets: move ipam/dns in advanced section, and use "pve" as default ipam

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Utils.js | 3 ++- www/manager6/sdn/SubnetEdit.js | 6 -- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 8c939536..5440b972 100644 --- a/www/manager6/Utils.js +++ b/w

[pve-devel] [PATCH v10 pve-manager 07/19] subnets: add dns fields

2021-01-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/SubnetEdit.js | 35 ++ 1 file changed, 35 insertions(+) diff --git a/www/manager6/sdn/SubnetEdit.js b/www/manager6/sdn/SubnetEdit.js index 2afa1a27..ac9a40ea 100644 --- a/www/manager6/sdn/SubnetEdit.js +++ b/w

[pve-devel] [PATCH v10 pve-manager 00/19] sdn: add subnets management

2021-01-05 Thread Alexandre Derumier
Changelogv2: - add ipams gui Changelogv3: - add internal pve ipam form - ipam is optional for subnets Changelogv4: - add dns changelogv5: - move subnets to vnet split panel (like ipsets) - move controllers, ipams, dns to a new options panel changelogv6: - display pending grid - move dns/i