Re: [pve-devel] [PATCH conntrack-tool v2 2/5] add packaging support

2021-02-03 Thread Thomas Lamprecht
On 03.02.21 15:25, Mira Limbeck wrote: > Signed-off-by: Mira Limbeck > --- > v2: > - unchanged Some nits/comments inline. You probably adapted this from proxmox-backup so my comments may hold true there too. > > .cargo/config| 5 > Makefile | 63

[pve-devel] [PATCH conntrack-tool v2 1/5] initial commit

2021-02-03 Thread Mira Limbeck
Dumping conntrack information and importing conntrack information works for IPv4 and IPv6. No filtering is supported for now. pve-conntrack-tool will always return both IPv4 and IPv6 conntracks together. Conntracks are serialized as JSON and printed on STDOUT line by line with one line containing

[pve-devel] [PATCH conntrack-tool v2 3/5] add expectation support

2021-02-03 Thread Mira Limbeck
Expectation support requires net.netfilter.nf_conntrack_helper to be set to 1. In addition the helper modules have to be loaded as well. In the tests nf_conntrack_ftp was used as helper. Together with expectation support, string attribute support is also added. Some functions which are conntrack

[pve-devel] [PATCH conntrack-tool v2 5/5] replace C callback with closures

2021-02-03 Thread Mira Limbeck
Internally we still have to use a C callback, but all it does is forward to the closure we pass to it. Signed-off-by: Mira Limbeck --- v2: - new addition src/main.rs | 208 +++- 1 file changed, 109 insertions(+), 99 deletions(-) diff --git

[pve-devel] [PATCH conntrack-tool v2 2/5] add packaging support

2021-02-03 Thread Mira Limbeck
Signed-off-by: Mira Limbeck --- v2: - unchanged .cargo/config| 5 Makefile | 63 debian/changelog | 5 debian/copyright | 16 +++ debian/debcargo.toml | 17 debian/docs | 1 + 6

[pve-devel] [PATCH qemu-server v2] copy conntrack information on migration

2021-02-03 Thread Mira Limbeck
Requires the pve-conntrack-tool. On migration the conntrack information from the source node is dumped and sent to the target node where it is then inserted. This helps with open connections during migration when the firewall is active. A new 'migrate-conntracks' option is added to the migrate_vm

[pve-devel] [PATCH conntrack-tool v2 4/5] add additional bindings

2021-02-03 Thread Mira Limbeck
Signed-off-by: Mira Limbeck --- v2: - new addition, can be ignored as it only adds batch and print function bindings which are not used in the code currently src/mnl.rs | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/src/mnl.rs

[pve-devel] [PATCH manager] ui: storage: pbs: allow to set port

2021-02-03 Thread Stoiko Ivanov
This patch allows to set a custom port to a PBS storage, by appending it to the Server field (e.g. pbs.proxmox.com:443). The code was taken from the RemoteEdit widget in the proxmox-backup repository. While the storage config stores the port as separate line, the current approach seems a bit more

Re: [pve-devel] [PATCH manager 2/7] ui: qemu/HardwareView: eslint: enforce "max-len" rule

2021-02-03 Thread Aaron Lauterer
On 2/3/21 10:50 AM, Aaron Lauterer wrote: On 2/3/21 8:40 AM, Thomas Lamprecht wrote: On 01.02.21 15:21, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer ---   www/manager6/qemu/HardwareView.js | 4 +++-   1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [pve-devel] [PATCH manager 2/7] ui: qemu/HardwareView: eslint: enforce "max-len" rule

2021-02-03 Thread Aaron Lauterer
On 2/3/21 8:40 AM, Thomas Lamprecht wrote: On 01.02.21 15:21, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer --- www/manager6/qemu/HardwareView.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/HardwareView.js

Re: [pve-devel] [PATCH qemu-server] cloudinit: add sshdeletehostkeys option

2021-02-03 Thread aderumier
Le lundi 01 février 2021 à 17:12 +0100, aderum...@odiso.com a écrit : > > > > [0] https://cloudinit.readthedocs.io/en/latest/topics/cli.html#clea > > n > > > The main problem currently is indeed that we change instance-id at > each rebuild of the cloud-init disk. > But I'm not sure that's it's