[pve-devel] [PATCH common] fix #3259: always free certificate file after reading it

2021-02-11 Thread Stoiko Ivanov
This commit mirrors e3c4007bc94956962c03da8c6853415d2fdf057c in pve-cluster. The fix there got lost with a refactoring for reusing the code here in pve-common in c92b771669e68a8b49906b8a0a68b533750567b0 Tested by repeadetly reading https://$pve-node:8006/nodes on a virtual testcluster. Signed-off

[pve-devel] applied: [PATCH zfsonlinux] cherry-pick file-mode fix from 2.0.3-staging

2021-02-11 Thread Thomas Lamprecht
On 10.02.21 15:55, Stoiko Ivanov wrote: > the patch fixes a potential panic on systems running ZFS > 2.0.0 and > is already queued for inclusion in 2.0.3 - see [0] for a related > github issue. > > [0] https://github.com/openzfs/zfs/issues/11474 > > Signed-off-by: Stoiko Ivanov > --- > tested by

[pve-devel] applied-series: [PATCH zfsonlinux 0/2] split out libpam-zfs and update copyright

2021-02-11 Thread Thomas Lamprecht
On 09.02.21 19:41, Stoiko Ivanov wrote: > With ZFS 2.0.0 upstream ships a pam module, which uses an users login password > to optionally decrypt their home dataset. > > Debian upstream ships the config in a separate package, which seems cleaner > than adding it to zfsutil-linux. > > This patchset

[pve-devel] applied: [PATCH v2 manager 6/6] ui: snapshot: show task viewer for progress log

2021-02-11 Thread Thomas Lamprecht
On 08.02.21 12:15, Stefan Reiter wrote: > Signed-off-by: Stefan Reiter > --- > > v2: > * always show task viewer, since with patch 5 we always print something to the > task log - I'm honestly fine with whatever here, might as well apply v1 of > this or go with Fabians idea and use 'vmstate' a

[pve-devel] applied: [PATCH v2 qemu-server 5/6] savevm: show information about drives during snapshot

2021-02-11 Thread Thomas Lamprecht
On 08.02.21 12:15, Stefan Reiter wrote: > Signed-off-by: Stefan Reiter > --- > > v2: > * use $device > > PVE/QemuConfig.pm | 2 ++ > 1 file changed, 2 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https:

[pve-devel] applied: [PATCH v2 qemu-server 4/6] savevm: periodically print progress

2021-02-11 Thread Thomas Lamprecht
On 08.02.21 12:15, Stefan Reiter wrote: > Signed-off-by: Stefan Reiter > --- > > v2: > * rename helper > * return tuple > * use 'total-time' > * improve messages > > PVE/QemuConfig.pm | 12 > 1 file changed, 12 insertions(+) > > applied, thanks! made some adaptions though: * swi

[pve-devel] applied: [PATCH v2 qemu-server 3/6] vzdump: use renderers from Tools instead of duplicating code

2021-02-11 Thread Thomas Lamprecht
On 08.02.21 12:15, Stefan Reiter wrote: > ...taking card not to lose the custom precision for byte conversion. > > Signed-off-by: Stefan Reiter > --- > > v2: > * add precision parameter to render_bytes > > now needs a dependency bump on common > > PVE/VZDump/QemuServer.pm | 64 ---

[pve-devel] applied: [PATCH qemu-server] qmeventd: explicitly close() pidfds

2021-02-11 Thread Thomas Lamprecht
On 09.02.21 16:24, Stefan Reiter wrote: > In most circumstances a pidfd gets closed automatically once the child > dies, and that *should* be guaranteed by us calling SIGKILL - however, > it seems that sometimes that doesn't happen, leading to leaked file > descriptors[0]. > > Also add a small not

[pve-devel] [PATCH INFO v2 qemu 3/5] PVE: Use coroutine QMP for backup/cancel_backup

2021-02-11 Thread Stefan Reiter
Finally turn backup QMP calls into coroutines, now that it's possible. This has the benefit that calls are asynchronous to the main loop, i.e. long running operations like connecting to a PBS server will no longer hang the VM. Additionally, it allows us to get rid of block_on_coroutine_fn, which w

[pve-devel] [PATCH INFO v2 qemu 4/5] PVE: increase max IOV count in QEMUFile

2021-02-11 Thread Stefan Reiter
might help with RBD performance for snapshots, since it writes larger data buffers at once Signed-off-by: Stefan Reiter --- Included in first patch, squashed into existing patches. New in v2. migration/qemu-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/qe

[pve-devel] [PATCH INFO v2 qemu 5/5] PVE: savevm-async: improve snapshot abort

2021-02-11 Thread Stefan Reiter
Do not block the VM and save the state on aborting a snapshot, as the snapshot will be invalid anyway. Also, when aborting, wait for the target file to be closed, otherwise a client might run into race-conditions when trying to remove the file still opened by QEMU. Signed-off-by: Stefan Reiter -

[pve-devel] [PATCH v2 pve-qemu 2/5] add PBS master key support

2021-02-11 Thread Stefan Reiter
Signed-off-by: Stefan Reiter --- Rebased from Fabian's series. Thus of course also needs the updated version of libproxmox-backup-qemu to build and run. See: https://lists.proxmox.com/pipermail/pve-devel/2021-February/046945.html .../pve/0059-PBS-add-master-key-support.patch | 97 +

Re: [pve-devel] [PATCH v4 qemu-server] Add API for disk & VM import

2021-02-11 Thread Dominic Jäger
Thank you for looking so carefully! On Wed, Feb 10, 2021 at 10:40:56AM +0100, Fabian Grünbichler wrote: > > On February 5, 2021 11:04 am, Dominic Jäger wrote: > > Extend qm importdisk/importovf functionality to the API. > > > > @@ -4325,4 +4324,378 @@ __PACKAGE__->register_method({ > > retu

[pve-devel] [PATCH v2 storage] storage migration: insecure: improve logging

2021-02-11 Thread Fabian Ebner
by including the message/error from the remote side. Some people on the forum[0] ran into 'no tunnel IP received', but without information from the remote side it's hard to tell why. [0]: https://forum.proxmox.com/threads/failed-no-tunnel-ip-received.80172 Signed-off-by: Fabian Ebner --- Change

Re: [pve-devel] [PATCH storage] storage migration: insecure: improve logging

2021-02-11 Thread Fabian Ebner
This breaks pvesr replication, because the -T switch is active there. I'll send a v2 and preserve the regex captures. Am 11.02.21 um 10:42 schrieb Fabian Ebner: by including the message/error from the remote side. Some people on the forum [0] ran into 'no tunnel IP received', but without infor

[pve-devel] [PATCH storage] storage migration: insecure: improve logging

2021-02-11 Thread Fabian Ebner
by including the message/error from the remote side. Some people on the forum [0] ran into 'no tunnel IP received', but without information from the remote side it's hard to tell why. [0]: https://forum.proxmox.com/threads/failed-no-tunnel-ip-received.80172 Signed-off-by: Fabian Ebner --- PVE/