[pve-devel] [PATCH storage] zfspoolplugin: check if mounted instead of imported

2021-02-18 Thread Stoiko Ivanov
This patch addresses an issue we recently saw on a production machine: * after booting a ZFS pool failed to get imported (due to an empty /etc/zfs/zpool.cache) * pvestatd/guest-startall eventually tried to import the pool * the pool was imported, yet the datasets of the pool remained not mounte

[pve-devel] [PATCH v2 http-server 1/2] utils: add LISTEN_IP option in /etc/default/pveproxy

2021-02-18 Thread Oguz Bektas
to allow setting arbitrary IP address to listen on Signed-off-by: Oguz Bektas --- v1->v2: * changed parameter name from BIND_IP to LISTEN_IP PVE/APIServer/Utils.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/APIServer/Utils.pm b/PVE/APIServer/Utils.pm index e843e5f..36e3ae6 1006

[pve-devel] [PATCH v2 http-server manager 0/2] fix #2997: allow setting LISTEN_IP for pveproxy

2021-02-18 Thread Oguz Bektas
pve-http-server: Oguz Bektas (1): utils: add LISTEN_IP option in /etc/default/pveproxy PVE/APIServer/Utils.pm | 3 +++ 1 file changed, 3 insertions(+) pve-manager: Oguz Bektas (1): proxy: allow setting LISTEN_IP for pveproxy PVE/Service/pveproxy.pm | 3 ++- 1 file changed, 2 insertions(+)

[pve-devel] [PATCH v2 manager 2/2] proxy: allow setting LISTEN_IP for pveproxy

2021-02-18 Thread Oguz Bektas
to preserve backwards behavior we leave this as 'undef' if it's not configured in /etc/default/pveproxy Signed-off-by: Oguz Bektas --- v1->v2: * use 'undef' as default instead of 0.0.0.0 * s/BIND_IP/LISTEN_IP/g PVE/Service/pveproxy.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) dif

[pve-devel] [PATCH qemu-server] snapshot-test: mock query-savevm better

2021-02-18 Thread Stefan Reiter
Otherwise the new printing functions produce warnings about undefined numbers. These stats are guaranteed to be returned by real QEMU, so mock them with some sensible values. Signed-off-by: Stefan Reiter --- test/snapshot-test.pm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff -

Re: [pve-devel] [RFC storage] zfspoolplugin: check if mounted instead of imported

2021-02-18 Thread Thomas Lamprecht
On 18.02.21 14:34, Thomas Lamprecht wrote: +if (!defined($dataset_mounted->())) { >>> don't complicated boolean, drop the defined. >> in that case the return value of $dataset_mounted->() is ternary: > Then the more NAK'd for my taste, that method being ternary is IMO > not nice and sens

Re: [pve-devel] [RFC storage] zfspoolplugin: check if mounted instead of imported

2021-02-18 Thread Thomas Lamprecht
On 18.02.21 14:15, Stoiko Ivanov wrote: > Thanks for looking at the patch! > > On Thu, 18 Feb 2021 13:20:55 +0100 > Thomas Lamprecht wrote: > >> On 18.02.21 12:33, Stoiko Ivanov wrote: >>> This patch addresses an issue we recently saw on a production machine: >>> * after booting a ZFS pool faile

Re: [pve-devel] [RFC storage] zfspoolplugin: check if mounted instead of imported

2021-02-18 Thread Stoiko Ivanov
Thanks for looking at the patch! On Thu, 18 Feb 2021 13:20:55 +0100 Thomas Lamprecht wrote: > On 18.02.21 12:33, Stoiko Ivanov wrote: > > This patch addresses an issue we recently saw on a production machine: > > * after booting a ZFS pool failed to get imported (due to an empty > > /etc/zfs/z

Re: [pve-devel] [RFC storage] zfspoolplugin: check if mounted instead of imported

2021-02-18 Thread Thomas Lamprecht
On 18.02.21 12:33, Stoiko Ivanov wrote: > This patch addresses an issue we recently saw on a production machine: > * after booting a ZFS pool failed to get imported (due to an empty > /etc/zfs/zpool.cache) > * pvestatd/guest-startall eventually tried to import the pool > * the pool was imported,

[pve-devel] applied: [PATCH v2 common 2/8] register email-or-username format

2021-02-18 Thread Thomas Lamprecht
On 15.02.21 13:24, Fabian Ebner wrote: > To be used for the mailto vzdump parameter. > > Signed-off-by: Fabian Ebner > --- > > New in v2. > > src/PVE/JSONSchema.pm | 12 > 1 file changed, 12 insertions(+) > > applied, thanks! ___ pve

[pve-devel] applied: [PATCH v2 common 1/8] sendmail: use more complete email regex and shellquote

2021-02-18 Thread Thomas Lamprecht
On 15.02.21 13:24, Fabian Ebner wrote: > Shellquote is needed for '~', and while it doesn't help with '-', there should > be no problem, because options are separated from mailto since commit > 216a3f4f131693dc4bbad5e06e96a61baef5f5e9. > > Signed-off-by: Fabian Ebner > --- > > New in v2. > > Si

[pve-devel] [RFC storage] zfspoolplugin: check if mounted instead of imported

2021-02-18 Thread Stoiko Ivanov
This patch addresses an issue we recently saw on a production machine: * after booting a ZFS pool failed to get imported (due to an empty /etc/zfs/zpool.cache) * pvestatd/guest-startall eventually tried to import the pool * the pool was imported, yet the datasets of the pool remained not mounte

[pve-devel] [PATCH v2 pve-docs 1/2] docs: ceph: explain pool options

2021-02-18 Thread Dylan Whyte
Signed-off-by: Alwin Antreich edited-by: Dylan Whyte --- v1->v2: * Minor language fixup pveceph.adoc | 47 +++ 1 file changed, 39 insertions(+), 8 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index fd3fded..9253613 100644 --- a/pveceph.adoc

[pve-devel] [PATCH v2 pve-docs 2/2] ceph: add explanation on the pg autoscaler

2021-02-18 Thread Dylan Whyte
Signed-off-by: Alwin Antreich edited-by: Dylan Whyte --- v1->v2: * minor language fixup pveceph.adoc | 36 1 file changed, 36 insertions(+) diff --git a/pveceph.adoc b/pveceph.adoc index 9253613..9ef268b 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -540,6