Re: [pve-devel] [PATCH container] fix #3313: recover unprivileged bit from old config during pct restore

Am 22.02.21 um 16:03 schrieb Oguz Bektas: since pct defaults to privileged containers, it restores the container as privileged when `--unprivileged 1` is not passed. instead we should check the old configuration and retrieve it from there. this way, when one creates an unprivileged container on

[pve-devel] applied: [PATCH v2 qemu-server] API: update_vm_api: check for CDROM on disk delete

On 12.02.21 16:57, Aaron Lauterer wrote: > Since CDRoms and disks share the same config keys, we need to check if > it actually is a CDRom and then check the permissions accordingly. > > Otherwise it is possible for someone without VM.Config.CDROM > permissions, but with VM.Config.Disk permissions

[pve-devel] [PATCH container] fix #3313: recover unprivileged bit from old config during pct restore

since pct defaults to privileged containers, it restores the container as privileged when `--unprivileged 1` is not passed. instead we should check the old configuration and retrieve it from there. this way, when one creates an unprivileged container on GUI, it will be still restored as unprivile

[pve-devel] applied: [PATCH firewall] fix #2358: allow -- in firewall rule config files

On 22.02.21 13:00, Mira Limbeck wrote: > The docs mention -- as valid syntax for firewall rules, but the > code that parses the .fw files only accepts -. To make it > consistent with the docs and the API, also accept --. > > In addition allow 'proto' as option, not only '-p'. > > Signed-off-by: M

[pve-devel] applied: [PATCH manager 2/2] ui: FirewallRules: Add tooltip to comments

On 22.02.21 11:16, Aaron Lauterer wrote: > The comment columns might not be wide enough for longer comments. Since > it is the most right columns, it can be tricky to grab the right pixel > to drag it wider. > > A tooltip that shows up on hover should be okay. > > Signed-off-by: Aaron Lauterer >

[pve-devel] applied: [PATCH manager 1/2] ui: FirewallRules: make columns flexible

On 22.02.21 11:16, Aaron Lauterer wrote: > Changing the width definitions to use flex will make better use on > larger monitors. Changing the `width` parameter to `minWidth` ensures > that on smaller screens it is still usable, though some horizontal > scrolling might be necessary. > > Signed-off-

[pve-devel] [PATCH common] network: get_local_ip_from_cidr: return unique IPs

to avoid erroring out when "multiple" addresses are configured on live migration, when in fact it's the same IP multiple times. Seems like the same problem for a caller in pve-cluster was fixed by checking the uniqueness afterwards, see commit 266041169beb36c8892ca54265e2d91335307ffb in pve-cluste

[pve-devel] [PATCH firewall] fix #2358: allow -- in firewall rule config files

The docs mention -- as valid syntax for firewall rules, but the code that parses the .fw files only accepts -. To make it consistent with the docs and the API, also accept --. In addition allow 'proto' as option, not only '-p'. Signed-off-by: Mira Limbeck --- src/PVE/Firewall.pm | 14 +++---

[pve-devel] [PATCH manager 2/2] ui: FirewallRules: Add tooltip to comments

The comment columns might not be wide enough for longer comments. Since it is the most right columns, it can be tricky to grab the right pixel to drag it wider. A tooltip that shows up on hover should be okay. Signed-off-by: Aaron Lauterer --- As an additional patch as I realized that the comme

[pve-devel] [PATCH manager 1/2] ui: FirewallRules: make columns flexible

Changing the width definitions to use flex will make better use on larger monitors. Changing the `width` parameter to `minWidth` ensures that on smaller screens it is still usable, though some horizontal scrolling might be necessary. Signed-off-by: Aaron Lauterer --- www/manager6/grid/FirewallRu