Re: [pve-devel] [PATCH v2 proxmox-backup-qemu 05/11] access: use bigger cache and LRU chunk reader

2021-03-16 Thread Thomas Lamprecht
On 03.03.21 10:56, Stefan Reiter wrote: > Values chosen by fair dice roll, seems to be a good sweet spot on my > machine where any less causes performance degradation but any more > doesn't really make it go any faster. > > Keep in mind that those values are per drive in an actual restore. > > Si

[pve-devel] applied: [PATCH pve-qemu v3] add alloc-track block driver patch

2021-03-16 Thread Thomas Lamprecht
On 15.03.21 16:41, Stefan Reiter wrote: > See added patches for more info, overview: > 0044: slightly increase PBS performance by reducing allocations > 0045: slightly increase block-stream performance for Ceph > 0046: don't crash with block-stream on RBD > 0047: add alloc-track driver for live res

[pve-devel] applied: [PATCH qemu-server 2/2] snapshot: set migration caps before savevm-start

2021-03-16 Thread Thomas Lamprecht
On 16.03.21 17:30, Stefan Reiter wrote: > A "savevm" call (both our async variant and the upstream sync one) use > migration code internally. As such, they both expect migration > capabilities to be set. > > This is usually not a problem, as the default set of capabilities is ok, > however, it lea

[pve-devel] applied: [PATCH pve-qemu 1/2] fix saving and loading dirty bitmaps in snapshots

2021-03-16 Thread Thomas Lamprecht
On 16.03.21 17:30, Stefan Reiter wrote: > Saving dirty bitmaps from our savevm-async code didn't work, since we > use a coroutine which holds the iothread mutex already (upstream savevm > is sync, migration uses a thread). Release the mutex before calling the > one function that (according to it's

[pve-devel] applied: [PATCH pve-docs] change 'Gmbh' to 'GmbH'

2021-03-16 Thread Thomas Lamprecht
On 16.03.21 14:59, Dylan Whyte wrote: > Signed-off-by: Dylan Whyte > --- > README.adoc| 2 +- > asciidoc/asciidoc-pve.conf | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > applied, thanks! Proxmox Mail Gateway seems to have the wrong casing too..

[pve-devel] [PATCH pve-qemu 1/2] fix saving and loading dirty bitmaps in snapshots

2021-03-16 Thread Stefan Reiter
Saving dirty bitmaps from our savevm-async code didn't work, since we use a coroutine which holds the iothread mutex already (upstream savevm is sync, migration uses a thread). Release the mutex before calling the one function that (according to it's documentation) requires the lock to *not* be hel

[pve-devel] [PATCH qemu-server 2/2] snapshot: set migration caps before savevm-start

2021-03-16 Thread Stefan Reiter
A "savevm" call (both our async variant and the upstream sync one) use migration code internally. As such, they both expect migration capabilities to be set. This is usually not a problem, as the default set of capabilities is ok, however, it leads to differing snapshot settings if one does a snap

Re: [pve-devel] [pbs-devel] [PATCH-SERIES] improve warnings handling in UI and add to PVE

2021-03-16 Thread Dominik Csapak
series looks good to me, the only thing that might be not ideal is the value.replace('WARNINGS', '') call. it seems very brittle though in reality it will probably not be a problem Reviewed-By: Dominik Csapak ___ pve-devel mailing list pve-devel@list

[pve-devel] [PATCH pve-docs] change 'Gmbh' to 'GmbH'

2021-03-16 Thread Dylan Whyte
Signed-off-by: Dylan Whyte --- README.adoc| 2 +- asciidoc/asciidoc-pve.conf | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.adoc b/README.adoc index 2f84ddf..06aa709 100644 --- a/README.adoc +++ b/README.adoc @@ -351,7 +351,7 @@ screenshots creat

[pve-devel] applied: [PATCH manager 3/6] ui: cluster task log: eslint fixes

2021-03-16 Thread Dominik Csapak
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-docs] pvesm: mark pbs storage as stable

2021-03-16 Thread Dylan Whyte
Signed-off-by: Dylan Whyte --- pvesm.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvesm.adoc b/pvesm.adoc index 67745a0..2e8ee89 100644 --- a/pvesm.adoc +++ b/pvesm.adoc @@ -72,7 +72,7 @@ data to different nodes. |Directory |dir |file |no|no^1^|

Re: [pve-devel] [PATCH v2 container 3/5] vmstatus: make template property optional

2021-03-16 Thread Fabian Ebner
Am 15.03.21 um 14:01 schrieb Thomas Lamprecht: On 11.03.21 11:26, Fabian Ebner wrote: to avoid printing 'template: ' with 'pct status --verbose' if it's false. Signed-off-by: Fabian Ebner --- Breaks pve-manager without the first patch! (e.g. guest's Start/Shutdown buttons won't be updated an