Re: [pve-devel] [PATCH qemu-server 2/3] migrate: always check if content type images is available for target storage

On March 19, 2021 2:49 pm, Fabian Ebner wrote: > it's cheap and saves code. but also changes behaviour in a non-backwards-compatible fashion. previously, if a disk was already on a storage that does not have images configured, and the migration leaves it on that storage, this config mismatch wa

[pve-devel] [PATCH pve-storage] fix #3354: support notes on ceph backups

use DirPlugin's get/update_volume_notes implementation (which all the other supported file systems use) Signed-off-by: Dylan Whyte --- PVE/Storage/CephFSPlugin.pm | 10 ++ 1 file changed, 10 insertions(+) diff --git a/PVE/Storage/CephFSPlugin.pm b/PVE/Storage/CephFSPlugin.pm index 8eb7c

[pve-devel] [PATCH qemu-server 1/3] migrate: improve early error messages

by re-using the log_error-closure and not dying too early. In the case of unreferenced volumes, it was not clear why a certain storage would be required for migration. Now, the list of all volumes is always printed, and in the error case, all problems will be printed before we abort. Reported-by:

[pve-devel] [PATCH qemu-server 3/3] code cleanup: migrate: avoid post-ifs

Signed-off-by: Fabian Ebner --- PVE/QemuMigrate.pm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 44cecce..64794a7 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -407,11 +407,11 @@ sub sync_disks {

[pve-devel] [PATCH qemu-server 2/3] migrate: always check if content type images is available for target storage

it's cheap and saves code. Signed-off-by: Fabian Ebner --- PVE/QemuMigrate.pm | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 3597cc9..44cecce 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -410,11 +410,8 @@ su

[pve-devel] [PATCH pve-manager 1/1] ui: cloudinit : use new cloudinit config api

--- www/manager6/qemu/CloudInit.js | 44 ++ 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/www/manager6/qemu/CloudInit.js b/www/manager6/qemu/CloudInit.js index ccd1840b..423f09ef 100644 --- a/www/manager6/qemu/CloudInit.js +++ b/www/manager6/qemu/C

[pve-devel] [PATCH pve-manager 0/1] RFC: cloud-init change

Following the qemu-server patch series Alexandre Derumier (1): ui: cloudinit : use new cloudinit config api www/manager6/qemu/CloudInit.js | 44 ++ 1 file changed, 24 insertions(+), 20 deletions(-) -- 2.20.1 ___ pv

[pve-devel] [PATCH qemu-server 2/4] generate cloudinit when vm is offline too

Currently, the regenerate button in ui don't do nothing when vm is offline, and the config is only regenerated at vm start --- PVE/QemuServer.pm | 10 ++ 1 file changed, 10 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index f47ae87..e831667 100644 --- a/PVE/QemuServer.

[pve-devel] [PATCH qemu-server 4/4] api2: add cloudinit config api

--- PVE/API2/Qemu.pm | 132 +++ 1 file changed, 132 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index ea74c69..9f3a55e 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1039,6 +1039,138 @@ __PACKAGE__->register_method({

[pve-devel] [PATCH qemu-server 1/4] cloudinit: add cloudinit section for current generated config.

Instead using vm pending options for pending cloudinit generated config, write current generated cloudinit config in a new [CLOUDINIT] SECTION. Currently, some options like vm name, nic mac address can be hotplugged, so they are not way to know if the cloud-init disk is already updated. --- PVE/

[pve-devel] [PATCH qemu-server 3/4] cloudinit: make cloudnit options fastplug

--- PVE/QemuServer.pm | 30 +++--- 1 file changed, 3 insertions(+), 27 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index e831667..fe05de8 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -4455,9 +4455,10 @@ sub vmconfig_hotplug_pending {

[pve-devel] [PATCH qemu-server 0/4] RFC: cloudinit pending behaviour change

Hi, This is an attempt to cleanup current behaviour of cloudinit online changes. Currently, we setup cloudinit options as pending, until we generate the config drive. This is not 100% true, because some option like vm name, nic mac address can be changed, without going to pending, so user can'