[pve-devel] [PATCH qemu-server] vm status: force int where appropriate

2021-05-31 Thread Fabian Ebner
to avoid potential problems with stringified numbers in Javascript and elsewehere. The 'vmid' is still a string, because the property is injected via the 'links' property in the return type schema. Signed-off-by: Fabian Ebner --- PVE/QemuServer.pm | 6 +++--- 1 file changed, 3 insertions(+), 3

[pve-devel] [PATCH container] vm status: force int where appropriate

2021-05-31 Thread Fabian Ebner
In the case of a running container with cgroupv2, swap would be a string, causing a size.toFixed is not a function error for the format_size call in the containers's "Summary" page in the UI. The 'vmid' is still a string, because the property is injected via the 'links' property in the return

[pve-devel] [PATCH qemu-server] test: fix restore config test as unprivileged user

2021-05-31 Thread Fabian Ebner
after upgrading to bullseye, the cfs_read_file call within restore_update_config_line() results in an error: Is a directory! when done as an unprivileged user. Signed-off-by: Fabian Ebner --- Is that the intended behavior? test/run_qemu_restore_config_tests.pl | 8 1 file

Re: [pve-devel] [pbs-devel] [RFC v5 pve-rs 16/23] add perlmod crate with initial APT module

2021-05-31 Thread Fabian Ebner
Am 31.05.21 um 14:55 schrieb Wolfgang Bumiller: Please don't use 'perlmod' as the name of a crate which also depends on a different 'perlmod' crate, that won't be fun for long. Call it pve-rs ;-) I called it perlmod, because that's what was suggested in the (outdated) README. Should it even

Re: [pve-devel] [pbs-devel] [PATCH v5 proxmox-apt 06/23] add replace_suite function and constants for the current/next stable suites

2021-05-31 Thread Fabian Ebner
For the security repository, "buster/updates" needs to be replaced with "bullseye-security", so this is not enough. I'll add a special case for that in the next version. Am 28.05.21 um 16:29 schrieb Fabian Ebner: useful for major upgrades. Signed-off-by: Fabian Ebner --- New in v5.

Re: [pve-devel] [pbs-devel] [RFC v5 pve-rs 15/23] add cargo config

2021-05-31 Thread Fabian Ebner
Am 31.05.21 um 14:53 schrieb Wolfgang Bumiller: Please don't put this on top of this repo, better start over since the diskmanage stuff in here hasn't been touched in a while and therefore isn't used anywhere, yet. Okay, should've paid more attention to the actual status of the repository in

Re: [pve-devel] [pbs-devel] [RFC v5 pve-rs 16/23] add perlmod crate with initial APT module

2021-05-31 Thread Wolfgang Bumiller
On Fri, May 28, 2021 at 04:29:55PM +0200, Fabian Ebner wrote: > and disable diskmanage for now, whose Cargo.toml references local paths. > > Signed-off-by: Fabian Ebner > --- > > New in v5. > > Cargo.toml | 3 +- > perlmod/Cargo.toml | 17 ++ >

Re: [pve-devel] [pbs-devel] [RFC v5 pve-rs 16/23] add perlmod crate with initial APT module

2021-05-31 Thread Wolfgang Bumiller
Please don't use 'perlmod' as the name of a crate which also depends on a different 'perlmod' crate, that won't be fun for long. Call it pve-rs ;-) On Fri, May 28, 2021 at 04:29:55PM +0200, Fabian Ebner wrote: > and disable diskmanage for now, whose Cargo.toml references local paths. > >

Re: [pve-devel] [pbs-devel] [RFC v5 pve-rs 15/23] add cargo config

2021-05-31 Thread Wolfgang Bumiller
Please don't put this on top of this repo, better start over since the diskmanage stuff in here hasn't been touched in a while and therefore isn't used anywhere, yet. Also, I'm confused by the patch numbering. I'd rather have individual repositories have their own individual numbers. On Fri, May

[pve-devel] RE : [PATCH] [PATCH pve-http-server] SSO feature: loginwith SAMLv2

2021-05-31 Thread wb
Hi, You can find the instructions on your forum at this address with keycloak as IdP. ⇨ https://forum.proxmox.com/threads/auth-module-openid-connect.79987/#post-390606 Keycloak is very easy to set up. You can even start from a docker container. I will test later with lemonldap-ng to see if my

Re: [pve-devel] [PATCH] [PATCH pve-http-server] SSO feature: login with SAMLv2

2021-05-31 Thread Dietmar Maurer
I am trying to test your code, so I need a SAML Identity provider. What is the best OSS implementation for that? I tried lemonldap-ng, but there example configuration is a nightmare and I was unable to get that running. Is there anything else I can use to test?. - Dietmar