On 19.10.21 20:50, Jasper Yu wrote:
> From: Li-Heng Yu <007sea...@gmail.com>
>
> Signed-off-by: Li-Heng Yu <007sea...@gmail.com>
> ---
> src/PVE/AccessControl.pm | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm
> ind
On 31.08.21 12:16, Lorenz Stechauner wrote:
> $tmpfilename already gets unlinked after executing the cmd.
>
> furthermore, because this is a local file, it is wrong to delete
> it via the ssh command on a remote node.
>
> small change: added \n to the error message.
>
> Signed-off-by: Lorenz Ste
On 04.11.21 13:05, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas
> ---
> v2->v3:
> * use asciidoc quote syntax
> * using single quotes makes the link clickable inside quote
>
>
> pct.adoc | 144 ---
> 1 file changed, 138 insertions(+), 6 del
Series LGTM, looked closely at the regexes,
and they match (semantically), tested around a bit
and all seemed to work.
one super small nit (not a blocker IMHO)
the format/extension/compression handling in 2/2
could maybe use a comment what we do there
(though maybe it's just me who's confused ^^
On 03.11.21 16:58, Thomas Lamprecht wrote:
> config: add new meta property withe creation time
> config: meta: also save the QEMU version installed during creation
> tests: cfg2cmd: add a few q35 related tests
> cfg2cmd: switch off ACPI hotplug on bridges for q35 VMs
applied with Dominik'
I guess that's okay...
for all those weirdos who don't create `.link` files to pin their
network interface names in place :-P
Acked-by: Wolfgang Bumiller
On Wed, Nov 03, 2021 at 04:58:08PM +0100, Thomas Lamprecht wrote:
> changes v1 -> v2:
> * move checks into own method
> * ensure forced machi
On Thu, Nov 04, 2021 at 02:58:25PM +0100, Thomas Lamprecht wrote:
> On 04.11.21 14:19, Oguz Bektas wrote:
> > to allow creating containers with 'unmanaged' ostype easily in GUI.
> > that way we can use other unsupported templates in the GUI as well.
>
> it's rather an advanced option, but I'm not
On 04.11.21 14:19, Oguz Bektas wrote:
> to allow creating containers with 'unmanaged' ostype easily in GUI.
> that way we can use other unsupported templates in the GUI as well.
it's rather an advanced option, but I'm not even sure I want it there,
unmanaged CTs are def. not the norm. Is there any
to allow creating containers with 'unmanaged' ostype easily in GUI.
that way we can use other unsupported templates in the GUI as well.
Signed-off-by: Oguz Bektas
---
www/manager6/lxc/CreateWizard.js | 7 +++
1 file changed, 7 insertions(+)
diff --git a/www/manager6/lxc/CreateWizard.js b/ww
On 04.11.21 12:28, Mira Limbeck wrote:
> Looks good.
>
> Reviewed-by: Mira Limbeck
With that: applied, thanks to both.
I added Mira's suggested comment regarding the size limitation as a followup:
https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=115cb432bcd90e00a487d1ed5ad28c4158dd0e47
Signed-off-by: Oguz Bektas
---
v2->v3:
* use asciidoc quote syntax
* using single quotes makes the link clickable inside quote
pct.adoc | 144 ---
1 file changed, 138 insertions(+), 6 deletions(-)
diff --git a/pct.adoc b/pct.adoc
index d01e6d
On 04.11.21 12:12, Oguz Bektas wrote:
> On Thu, Nov 04, 2021 at 12:00:03PM +0100, Thomas Lamprecht wrote:
>> On 02.11.21 15:18, Oguz Bektas wrote:
>>> any news for this?
>>>
>> not really, but not using asciidoc syntax for quotes was a reason that
>> prevented me from applying it.
>
> which synta
Looks good.
Reviewed-by: Mira Limbeck
On 10/30/21 4:49 PM, Constantin Herold wrote:
Signed-off-by: Constantin Herold
---
PVE/QemuServer.pm | 8
PVE/QemuServer/Cloudinit.pm | 25 -
2 files changed, 28 insertions(+), 5 deletions(-)
diff --git a/P
On Thu, Nov 04, 2021 at 12:00:03PM +0100, Thomas Lamprecht wrote:
> On 02.11.21 15:18, Oguz Bektas wrote:
> > any news for this?
> >
> not really, but not using asciidoc syntax for quotes was a reason that
> prevented me from applying it.
which syntax exactly?
if i do it like this:
"a lightweig
On 06.10.21 23:58, Alexandre Derumier wrote:
> This option don't have any impact on device itself.
>
> Signed-off-by: Alexandre Derumier
> ---
> PVE/QemuServer.pm | 25 +
> 1 file changed, 25 insertions(+)
>
>
applied, thanks!
_
On 02.11.21 15:18, Oguz Bektas wrote:
> any news for this?
>
not really, but not using asciidoc syntax for quotes was a reason that
prevented me from applying it.
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/
hi,
was this patch missed?
or is there a problem with it?
the fix for containers was applied but without this one.
thanks
On Thu, Oct 14, 2021 at 11:29:57AM +0200, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas
> ---
> v2->v3:
> * automatically delete the 'parent' property for an existing snap
LGTM, tested fine and worked as advertised
if we want to go forward this way:
Reviewed-by: Dominik Csapak
Tested-by: Dominik Csapak
On 11/3/21 16:58, Thomas Lamprecht wrote:
changes v1 -> v2:
* move checks into own method
* ensure forced machine is parsed so that min_version can work
* only
18 matches
Mail list logo
