[pve-devel] applied: [PATCH manager 1/4] ui: qm: disk selection: add optional selection of unused

2021-11-12 Thread Thomas Lamprecht
On 12.11.21 10:53, Aaron Lauterer wrote: > With this optional setting, it is possible to allow the user to also > select 'unused' as a disk bus type. > > Signed-off-by: Aaron Lauterer > --- > www/manager6/Utils.js | 1 + > www/manager6/form/BusTypeSelector.js| 5 + > ww

Re: [pve-devel] [PATCH manager] ui: ceph: add more compatibilty code for versions

2021-11-12 Thread Dominik Csapak
disregard... i sent too soon... ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] ui: ceph: add more compatibilty code for versions

2021-11-12 Thread Thomas Lamprecht
On 12.11.21 17:01, Dominik Csapak wrote: > we now have to handle the version of 'old' nodes, as well as the > new nodes, which are missing the 'version' field in the metadata/osd call > > so set the 'versions' object to a default empty object for osds > and get the host version directly from the t

[pve-devel] applied: [PATCH manager] ui: ceph: add more compatibilty code for versions

2021-11-12 Thread Thomas Lamprecht
On 12.11.21 17:01, Dominik Csapak wrote: > we now have to handle the version of 'old' nodes, as well as the > new nodes, which are missing the 'version' field in the metadata/osd call > > so set the 'versions' object to a default empty object for osds > and get the host version directly from the t

[pve-devel] [PATCH manager] ui: ceph: add more compatibilty code for versions

2021-11-12 Thread Dominik Csapak
we now have to handle the version of 'old' nodes, as well as the new nodes, which are missing the 'version' field in the metadata/osd call so set the 'versions' object to a default empty object for osds and get the host version directly from the treenode (the parent node of the osd node) also com

[pve-devel] applied: [PATCH storage] pbs: update attribute: cleaner error message if not supported

2021-11-12 Thread Thomas Lamprecht
On 12.11.21 15:29, Fabian Ebner wrote: > Reported-by: Fabian Grünbichler > Signed-off-by: Fabian Ebner > --- > PVE/Storage/PBSPlugin.pm | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pv

[pve-devel] applied-series: [PATCH manager 1/3] api/services: sort service list

2021-11-12 Thread Thomas Lamprecht
On 12.11.21 13:37, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > PVE/API2/Services.pm | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > applied series, thanks! ___ pve-devel mailing list pve-devel@lis

[pve-devel] applied: [PATCH widget-toolkit] window/TfaWindow: fix text format

2021-11-12 Thread Thomas Lamprecht
On 12.11.21 15:40, Dominik Csapak wrote: > Ext.String.format was missing to show the number correctly > > Signed-off-by: Dominik Csapak > --- > alternatively, we could simply change the gettext, but > this way we are more flexible if we want to change the number in the > future > src/window/TfaW

[pve-devel] applied: [PATCH proxmox-i18n] DE: Replace 'Subscription' with 'Subskription'

2021-11-12 Thread Thomas Lamprecht
On 08.11.21 17:15, Dylan Whyte wrote: > This is consistent with the website's usage > > Signed-off-by: Dylan Whyte > --- > de.po | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) > > applied, thanks! ___ pve

[pve-devel] applied: [PATCH manager] ui: dc/Backup: fix 'run now' button for jobs with comments

2021-11-12 Thread Thomas Lamprecht
On 11.11.21 13:04, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > www/manager6/dc/Backup.js | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/

[pve-devel] applied-series: [PATCH-SERIES v2 storage/widget-toolkit/manager] disk creation and wiping improvements

2021-11-12 Thread Thomas Lamprecht
On 06.10.21 11:18, Fabian Ebner wrote: > pve-manager: > > Fabian Ebner (6): > api: ceph: create osd: set correct parttype for DB/WAL > partially fix #2285: api: ceph: create osd: allow using partitions > api: ceph: create osd: set correct partition type > partially fix #2285: ui: ceph: all

[pve-devel] [PATCH widget-toolkit] window/TfaWindow: fix text format

2021-11-12 Thread Dominik Csapak
Ext.String.format was missing to show the number correctly Signed-off-by: Dominik Csapak --- alternatively, we could simply change the gettext, but this way we are more flexible if we want to change the number in the future src/window/TfaWindow.js | 5 - 1 file changed, 4 insertions(+), 1 de

[pve-devel] [PATCH storage] pbs: update attribute: cleaner error message if not supported

2021-11-12 Thread Fabian Ebner
Reported-by: Fabian Grünbichler Signed-off-by: Fabian Ebner --- PVE/Storage/PBSPlugin.pm | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/PVE/Storage/PBSPlugin.pm b/PVE/Storage/PBSPlugin.pm index 06ebfa7..e186663 100644 --- a/PVE/Storage/PBSPlugin.pm +++ b/PVE/Storage/PB

Re: [pve-devel] [PATCH cluster] fix #3596: handle delnode of offline node

2021-11-12 Thread Thomas Lamprecht
On 12.11.21 13:46, Fabian Ebner wrote: > Am 12.11.21 um 13:14 schrieb Thomas Lamprecht: >> On 12.11.21 12:50, Fabian Ebner wrote: >>> Am 12.11.21 um 09:45 schrieb Fabian Grünbichler: the recommended way is to first shutdown, then delnode, and never let it come back online, in which case c

Re: [pve-devel] [PATCH cluster] fix #3596: handle delnode of offline node

2021-11-12 Thread Fabian Grünbichler
On November 12, 2021 1:14 pm, Thomas Lamprecht wrote: > On 12.11.21 12:50, Fabian Ebner wrote: >> Am 12.11.21 um 09:45 schrieb Fabian Grünbichler: >>> the recommended way is to first shutdown, then delnode, and never let it >>> come back online, in which case corosync-cfgtool won't be able to kill

Re: [pve-devel] [PATCH cluster] fix #3596: handle delnode of offline node

2021-11-12 Thread Fabian Ebner
Am 12.11.21 um 13:14 schrieb Thomas Lamprecht: On 12.11.21 12:50, Fabian Ebner wrote: Am 12.11.21 um 09:45 schrieb Fabian Grünbichler: the recommended way is to first shutdown, then delnode, and never let it come back online, in which case corosync-cfgtool won't be able to kill the removed (off

[pve-devel] [PATCH manager 1/3] api/services: sort service list

2021-11-12 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- PVE/API2/Services.pm | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/PVE/API2/Services.pm b/PVE/API2/Services.pm index f0159b65..60502ce2 100644 --- a/PVE/API2/Services.pm +++ b/PVE/API2/Services.pm @@ -17,24 +17,24 @@ u

[pve-devel] [PATCH manager 2/3] api/services: add pvescheduler to the service list

2021-11-12 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- PVE/API2/Services.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Services.pm b/PVE/API2/Services.pm index 60502ce2..40f7504a 100644 --- a/PVE/API2/Services.pm +++ b/PVE/API2/Services.pm @@ -29,6 +29,7 @@ my $service_name_list = [ 'pvedaemon'

[pve-devel] [PATCH manager 3/3] jobs: vzdump: fixup prune-schedule conf

2021-11-12 Thread Dominik Csapak
when we parse the config, we get the 'prune-backup' decoded, but the api call we use wants it as a property string, so encode it here again this fixes having jobs with prune options Signed-off-by: Dominik Csapak --- PVE/Jobs/VZDump.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PV

[pve-devel] [PATCH manager] pvestatd: rebroadcast version info as needed

2021-11-12 Thread Wolfgang Bumiller
since this is just in-memory data and can get lost with pmxcfs restarts Signed-off-by: Wolfgang Bumiller Fixes: 34a1305e9c21 ("pvestatd: broadcast version info") --- PVE/Service/pvestatd.pm | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/PVE/Service/pvestatd.p

Re: [pve-devel] [PATCH cluster] fix #3596: handle delnode of offline node

2021-11-12 Thread Thomas Lamprecht
On 12.11.21 12:50, Fabian Ebner wrote: > Am 12.11.21 um 09:45 schrieb Fabian Grünbichler: >> the recommended way is to first shutdown, then delnode, and never let it >> come back online, in which case corosync-cfgtool won't be able to kill >> the removed (offline) node. >> >> also, the order was wr

Re: [pve-devel] [PATCH cluster] fix #3596: handle delnode of offline node

2021-11-12 Thread Fabian Ebner
Am 12.11.21 um 09:45 schrieb Fabian Grünbichler: the recommended way is to first shutdown, then delnode, and never let it come back online, in which case corosync-cfgtool won't be able to kill the removed (offline) node. also, the order was wrong - if we first update corosync.conf to remove the

[pve-devel] [PATCH manager 2/2] ui: backup: protect button: use dynamic protect/unprotect text

2021-11-12 Thread Fabian Ebner
Suggested-by: Thomas Lamprecht Signed-off-by: Fabian Ebner --- www/manager6/grid/BackupView.js| 22 +- www/manager6/storage/BackupView.js | 24 +++- 2 files changed, 44 insertions(+), 2 deletions(-) diff --git a/www/manager6/grid/BackupView.js b/www/m

[pve-devel] [PATCH manager 1/2] ui: backup: disable remove button when backup is protected

2021-11-12 Thread Fabian Ebner
Suggested-by: Thomas Lamprecht Signed-off-by: Fabian Ebner --- www/manager6/grid/BackupView.js| 18 +- www/manager6/storage/BackupView.js | 22 ++ 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/www/manager6/grid/BackupView.js b/www/manager6

[pve-devel] applied: [PATCH cluster] fix #3596: handle delnode of offline node

2021-11-12 Thread Thomas Lamprecht
On 12.11.21 09:45, Fabian Grünbichler wrote: > the recommended way is to first shutdown, then delnode, and never let it > come back online, in which case corosync-cfgtool won't be able to kill > the removed (offline) node. > > also, the order was wrong - if we first update corosync.conf to remove

[pve-devel] applied: [PATCH access-control] tfa: fix http 404 in get_tfa_entry

2021-11-12 Thread Thomas Lamprecht
On 12.11.21 10:37, Wolfgang Bumiller wrote: > this produced warnings in the journal and returned code 500 > instead > > Signed-off-by: Wolfgang Bumiller > --- > src/PVE/API2/TFA.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > applied, thanks! ___

[pve-devel] [PATCH manager 2/4] ui: lxc/qemu: add disk reassign

2021-11-12 Thread Aaron Lauterer
For the new HDReassign component, we follow the approach of HDMove to have one componend for qemu and lxc as they are the same for most parts. The 'Move disk/volume' button is now a SplitButton which has the 'Reassign' button as menu item. In the lxc resource panel the menu item is defined extra

[pve-devel] [PATCH manager 4/4] ui: hdmove: modernize/refactor

2021-11-12 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/qemu/HDMove.js | 239 +- www/manager6/qemu/HardwareView.js | 1 + 2 files changed, 134 insertions(+), 106 deletions(-) diff --git a/www/manager6/qemu/HDMove.js b/www/manager6/qemu/HDMove.js index 181b7bdc..6e9b748

[pve-devel] [PATCH manager 3/4] ui: BusTypeSelector: change noVirtIO to withVirtIO

2021-11-12 Thread Aaron Lauterer
Double negated properties make it harder than necessary to parse conditions. Signed-off-by: Aaron Lauterer --- www/manager6/form/BusTypeSelector.js| 4 ++-- www/manager6/form/ControllerSelector.js | 4 ++-- www/manager6/qemu/CDEdit.js | 2 +- www/manager6/qemu/CIDriveEdit.js

[pve-devel] [PATCH manager 1/4] ui: qm: disk selection: add optional selection of unused

2021-11-12 Thread Aaron Lauterer
With this optional setting, it is possible to allow the user to also select 'unused' as a disk bus type. Signed-off-by: Aaron Lauterer --- www/manager6/Utils.js | 1 + www/manager6/form/BusTypeSelector.js| 5 + www/manager6/form/ControllerSelector.js | 2 ++ 3 files cha

[pve-devel] [PATCH manager 0/4] ui: lxc/qemu: add reassign for disks and

2021-11-12 Thread Aaron Lauterer
This series adds the UI for the recently applied backend series that allows to reassign a disk / volume from one guest to another. The first patch is needed to reassing a disk as an unused disk on the target VM side. Patch 3 and 4 are optional. Patch 3 only changes a double negated option and pa

[pve-devel] [PATCH access-control] tfa: fix http 404 in get_tfa_entry

2021-11-12 Thread Wolfgang Bumiller
this produced warnings in the journal and returned code 500 instead Signed-off-by: Wolfgang Bumiller --- src/PVE/API2/TFA.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/TFA.pm b/src/PVE/API2/TFA.pm index 87d7255..657a74c 100644 --- a/src/PVE/API2/TFA.pm ++

[pve-devel] applied-series: [PATCH proxmox-perl-rs 1/2] pve-rs/tfa: fix off by one trimming

2021-11-12 Thread Wolfgang Bumiller
applied both patches, thanks On Fri, Nov 12, 2021 at 09:58:13AM +0100, Dominik Csapak wrote: > to is the last *valid* character, and ranges end by default with one > less, so extend the range to the actual last character > > this fixes an issue that we could not parse old configs with > non-padde

[pve-devel] [PATCH proxmox-perl-rs 2/2] pve-rs/tfa: ignore and discard incomplete u2f entries

2021-11-12 Thread Dominik Csapak
it can happen that we have leftover entries with non-completed challenges. since a user cannot continue here in a sensible way, ignore and discard them Signed-off-by: Dominik Csapak --- pve-rs/src/tfa/mod.rs | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git

[pve-devel] [PATCH proxmox-perl-rs 1/2] pve-rs/tfa: fix off by one trimming

2021-11-12 Thread Dominik Csapak
to is the last *valid* character, and ranges end by default with one less, so extend the range to the actual last character this fixes an issue that we could not parse old configs with non-padded base64 values Signed-off-by: Dominik Csapak --- pve-rs/src/tfa/mod.rs | 2 +- 1 file changed, 1 ins

[pve-devel] [PATCH cluster] fix #3596: handle delnode of offline node

2021-11-12 Thread Fabian Grünbichler
the recommended way is to first shutdown, then delnode, and never let it come back online, in which case corosync-cfgtool won't be able to kill the removed (offline) node. also, the order was wrong - if we first update corosync.conf to remove the node entry from the nodelist, corosync doesn't know

Re: [pve-devel] [PATCH pve-common] Fix 3560: gui/notes: escape % symbol when encoding

2021-11-12 Thread Dylan Whyte
bump. Noticed while doing some testing that this was never reviewed/applied. On 8/6/21 3:22 PM, Dylan Whyte wrote: This prevents cases in which a string containing a percent character is inadvertently utf-8 decoded before being displayed in notes. Signed-off-by: Dylan Whyte --- src/PVE/Tool

[pve-devel] [PATCH guest-common] migrate: handle migration_network with remote migration

2021-11-12 Thread Fabian Grünbichler
we only want to use an explicitly provided migration network, not one for the local cluster. Signed-off-by: Fabian Grünbichler --- forgot to send, sorry v2: dropped remote + migration network handling, not needed anymore src/PVE/AbstractMigrate.pm | 37 + 1