Re: [pve-devel] [PATCH container 0/2] Improve volume deactivation

2021-12-01 Thread Aaron Lauterer
On 12/2/21 08:40, Fabian Ebner wrote: Am 01.12.21 um 17:27 schrieb Aaron Lauterer: On 12/1/21 11:12, Fabian Ebner wrote: Am 26.11.21 um 11:19 schrieb Aaron Lauterer: While working on the reassign feature we (F.Ebner & I) discovered that it is possible, mainly with RBD volumes, to get into

Re: [pve-devel] [PATCH container 0/2] Improve volume deactivation

2021-12-01 Thread Fabian Ebner
Am 01.12.21 um 17:27 schrieb Aaron Lauterer: On 12/1/21 11:12, Fabian Ebner wrote: Am 26.11.21 um 11:19 schrieb Aaron Lauterer: While working on the reassign feature we (F.Ebner & I) discovered that it is possible, mainly with RBD volumes, to get into situations where it is not possible to re

Re: [pve-devel] [PATCH container 0/2] Improve volume deactivation

2021-12-01 Thread Aaron Lauterer
On 12/1/21 11:12, Fabian Ebner wrote: Am 26.11.21 um 11:19 schrieb Aaron Lauterer: While working on the reassign feature we (F.Ebner & I) discovered that it is possible, mainly with RBD volumes, to get into situations where it is not possible to remove that volume as an old orphaned RBD mappin

[pve-devel] applied-series: [PATCH v2 manager container 0/2] lazytime mount option

2021-12-01 Thread Thomas Lamprecht
On 01.12.21 16:17, Oguz Bektas wrote: > > pve-container: > > Oguz Bektas (1): > config: allow 'lazytime' mount option for containers > > src/PVE/LXC/Config.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > pve-manager: > > Oguz Bektas (1): > lxc: add lazytime mount option

[pve-devel] [PATCH v2 manager 2/2] lxc: add lazytime mount option

2021-12-01 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- v2: * added patch, thanks to dylan for pointing this out! www/manager6/lxc/MPEdit.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/lxc/MPEdit.js b/www/manager6/lxc/MPEdit.js index dba69cb4..b8c6b6cb 100644 --- a/www/manager6/lxc/MPEdit.js +++ b/w

[pve-devel] [PATCH v2 manager container 0/2] lazytime mount option

2021-12-01 Thread Oguz Bektas
pve-container: Oguz Bektas (1): config: allow 'lazytime' mount option for containers src/PVE/LXC/Config.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) pve-manager: Oguz Bektas (1): lxc: add lazytime mount option www/manager6/lxc/MPEdit.js | 1 + 1 file changed, 1 insertio

[pve-devel] [PATCH v2 container 1/2] config: allow 'lazytime' mount option for containers

2021-12-01 Thread Oguz Bektas
worked fine here in ubuntu container. root@CT1022:/# mount | grep lazy /var/lib/pve/local-btrfs/images/1022/vm-1022-disk-0/disk.raw on / type ext4 (rw,relatime,lazytime) /var/lib/pve/local-btrfs/images/1022/vm-1022-disk-0/disk.raw on /snap type ext4 (rw,relatime,lazytime) requested in commu

Re: [pve-devel] [PATCH] config: allow 'lazytime' mount option for containers

2021-12-01 Thread Oguz Bektas
On Wed, Dec 01, 2021 at 03:54:12PM +0100, Dylan Whyte wrote: > Hi, > > I just tested/played with this a bit and couldn't find any issues within the > container, with the option enabled. > > However, you need to add a corresponding mount option in the GUI, as > otherwise, the "Edit: Mount Point" w

Re: [pve-devel] [PATCH qemu-server] apply pending changes at vm stop only if the section is not empty

2021-12-01 Thread Oguz Bektas
On Wed, Dec 01, 2021 at 03:10:28PM +0100, Fabian Ebner wrote: > Am 01.12.21 um 13:00 schrieb Oguz Bektas: > > we also have the same skipping logic when starting vms. this way we > > avoid calling 'write_config' when there are no present changes to > > commit. > > > > Signed-off-by: Oguz Bektas >

[pve-devel] applied: [PATCH qemu] fix #3738: cherry-pick "block: introduce max_hw_iov for use in scsi-generic"

2021-12-01 Thread Thomas Lamprecht
On 01.12.21 14:10, Fabian Ebner wrote: > which fixes the bad commit 18473467d55a20d643b6c9b3a52de42f705b4d35 > that was tracked down via bisecting, and has a Cc for qemu-stable as > well. > > Issue was easy enough to reproduce with a single virtio-block disk > using a few runs of dd if=/dev/urando

Re: [pve-devel] [PATCH] config: allow 'lazytime' mount option for containers

2021-12-01 Thread Dylan Whyte
Hi, I just tested/played with this a bit and couldn't find any issues within the container, with the option enabled. However, you need to add a corresponding mount option in the GUI, as otherwise, the "Edit: Mount Point" window breaks due to it not recognizing the option, and no changes can

Re: [pve-devel] [PATCH qemu-server] apply pending changes at vm stop only if the section is not empty

2021-12-01 Thread Fabian Ebner
Am 01.12.21 um 13:00 schrieb Oguz Bektas: we also have the same skipping logic when starting vms. this way we avoid calling 'write_config' when there are no present changes to commit. Signed-off-by: Oguz Bektas --- PVE/QemuServer.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[pve-devel] [PATCH qemu] fix #3738: cherry-pick "block: introduce max_hw_iov for use in scsi-generic"

2021-12-01 Thread Fabian Ebner
which fixes the bad commit 18473467d55a20d643b6c9b3a52de42f705b4d35 that was tracked down via bisecting, and has a Cc for qemu-stable as well. Issue was easy enough to reproduce with a single virtio-block disk using a few runs of dd if=/dev/urandom of=file bs=1M count=1000 Commit cc071629539dc1f3

[pve-devel] [PATCH qemu-server] apply pending changes at vm stop only if the section is not empty

2021-12-01 Thread Oguz Bektas
we also have the same skipping logic when starting vms. this way we avoid calling 'write_config' when there are no present changes to commit. Signed-off-by: Oguz Bektas --- PVE/QemuServer.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuSer

Re: [pve-devel] [PATCH container 0/2] Improve volume deactivation

2021-12-01 Thread Fabian Ebner
Am 26.11.21 um 11:19 schrieb Aaron Lauterer: While working on the reassign feature we (F.Ebner & I) discovered that it is possible, mainly with RBD volumes, to get into situations where it is not possible to remove that volume as an old orphaned RBD mapping still exists. Mainly when converting a

[pve-devel] [PATCH master/5.13 kernel 2/2] KConfig: disable module BTF debug info

2021-12-01 Thread Fabian Grünbichler
enabling this effectively makes the debug info of the kernel image part of the kernel <-> module ABI[0], potentially breaking module loading for otherwise compatible kernel/module combinations. there were several user reports[1,2,3,..], and although a workaround exists (re-installing the currently

[pve-devel] [PATCH master/5.13 kernel 1/2] d/control: add zstd to B-D

2021-12-01 Thread Fabian Grünbichler
used for compressing the kernel image, build fails if not installed. Signed-off-by: Fabian Grünbichler --- debian/control.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/debian/control.in b/debian/control.in index ee91978..f924ab2 100644 --- a/debian/control.in +++ b/deb

[pve-devel] [PATCH proxmox-perl-rs/common] use calendar-events from rust

2021-12-01 Thread Dominik Csapak
this series replaces the perl calendar event implementation with the one in rust, using proxmox-perl-rs the perl interface to 'PVE::CalendarEvent' is the same, but we could use PVE::RS::CalendarEvent directly downstream (guest-common/manager) but since we need the api type anyway i left that out f

[pve-devel] [PATCH 1/1] pve-rs: add PVE::RS::CalendarEvent

2021-12-01 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- pve-rs/Makefile | 1 + pve-rs/src/calendar_event.rs | 20 pve-rs/src/lib.rs| 1 + 3 files changed, 22 insertions(+) create mode 100644 pve-rs/src/calendar_event.rs diff --git a/pve-rs/Makefile b/pve-rs/Makefile in

[pve-devel] [PATCH common 1/1] CalendarEvent: use rust implementation

2021-12-01 Thread Dominik Csapak
by replacing the parsing code and 'compute_next_event' by their PVE::RS::CalendarEvent equivalent adapt the tests, since we do not have access to the internal structure (and even if we had, it would be different) and the error messages are different the 'compute_next_event' and parsing tests stil

[pve-devel] applied: [PATCH installer] proxmox-boot-preparation: add newline to /etc/kernel/cmdline

2021-12-01 Thread Thomas Lamprecht
On 30.11.21 18:52, Stoiko Ivanov wrote: > for better readability - and more robust handling in proxmox-boot-tool > > quickly tested with the latest PMG-ISO and the debug mode. > > Signed-off-by: Stoiko Ivanov > --- > proxinstall | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > appl