On 12/20/21 20:53, Thomas Lamprecht wrote:
On 20/12/2021 12:33, Dominik Csapak wrote:
patch 15 hides the fullscreen button,
patch 16 make the error message dismissable
this seems broken?
The d/patches/series file gets 16 and 17 added:
On 20/12/2021 14:57, Aaron Lauterer wrote:
> Tested-By: Aaron Lauterer
>
how did you test this if the noVNC patch from Dominik is broken?
___
pve-devel mailing list
pve-devel@lists.proxmox.com
On 20/12/2021 20:19, Thomas Lamprecht wrote:
> On 20/12/2021 12:37, Dominik Csapak wrote:
>> since the webview seemingly does not allow javascripts 'requestFullscreen',
>> workaround that by making the whole webview fullscreen and hiding novncs
>> fullscreen button
>>
>> Signed-off-by: Dominik
On 20/12/2021 12:33, Dominik Csapak wrote:
> patch 15 hides the fullscreen button,
> patch 16 make the error message dismissable
>
this seems broken?
The d/patches/series file gets 16 and 17 added:
0016-hide-fullscreen-button-on-isFullscreen-get-variable.patch
0017-make-error-hideable.patch
On 20/12/2021 12:35, Dominik Csapak wrote:
> with the recent changes, the input field was invisible, adapting
> like the login dialog
>
> Signed-off-by: Dominik Csapak
> ---
> lib/proxmox_tfa_form.dart | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>
applied with Aaron's
On 20/12/2021 11:31, Wolfgang Bumiller wrote:
> The userid-* permission check variants work on
> $param->{userid} directly which does not exist for this
> call. Also, they work on the realm of the user being
> checked, rather than the realm provided as parameter.
>
> The result was that as
On 20/12/2021 16:38, Aaron Lauterer wrote:
> The new splash screen that came with Android 12 has stricter rules
> regarding the size and form of the logo in the splash screen [0].
oh, do you have an actual reference to the strict rules you found, as [0]
As I read [0] quite closely and basically
On 20/12/2021 16:38, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer
> ---
> .../src/main/res/drawable/launch_background.xml | 11 ---
> .../drawable/proxmox_logo_white_orange_250.png | Bin 10537 -> 0 bytes
> .../drawable/proxmox_logo_white_orange_800.png | Bin 17037 -> 0 bytes
On 20/12/2021 16:38, Aaron Lauterer wrote:
> The new splash screen that came with Android 12 has stricter rules
> regarding the size and form of the logo in the splash screen [0].
>
> We do need to have a drawable that is a square with the logo / icon in
> the center. That means the current
On 20/12/2021 12:37, Dominik Csapak wrote:
> since the webview seemingly does not allow javascripts 'requestFullscreen',
> workaround that by making the whole webview fullscreen and hiding novncs
> fullscreen button
>
> Signed-off-by: Dominik Csapak
> ---
>
Thanks for the series!
tried each of the option (and verified with `sslscan localhost:8006`)
2 minor cosmetic nits (mentioned as replies to the individual patches)
with and without them LGTM:
Tested-by: Stoiko Ivanov
Reviewed-by: Stoiko Ivanov
On Fri, 17 Dec 2021 13:57:26 +0100
Fabian
tiny nit inline:
On Fri, 17 Dec 2021 13:57:33 +0100
Fabian Grünbichler wrote:
> Signed-off-by: Fabian Grünbichler
> ---
> pveproxy.adoc | 30 +-
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/pveproxy.adoc b/pveproxy.adoc
> index
Thanks for tackling this!
gave it a spin - works as advertised
one thing I think could be improved - is that currently nothing is logged
when CIPHERSUITES is set to an invalid setting.
(tested with "garbage TLS_CHACHA20_POLY1305_SHA256")
with TLS1.2 CIPHERS the log gets filled with:
'garbage'
Signed-off-by: Aaron Lauterer
---
.../src/main/res/drawable/launch_background.xml | 11 ---
.../drawable/proxmox_logo_white_orange_250.png | Bin 10537 -> 0 bytes
.../drawable/proxmox_logo_white_orange_800.png | Bin 17037 -> 0 bytes
3 files changed, 11 deletions(-)
delete mode
The new splash screen that came with Android 12 has stricter rules
regarding the size and form of the logo in the splash screen [0].
We do need to have a drawable that is a square with the logo / icon in
the center. That means the current approach with the png image resulted
in it being scaled to
With the patch adding vendor-data support to cloud-init, a use of
uninitialized value was introduced. This can be fixed by setting it to
an empty string if no vendor-data is defined.
vendor-data can only be set via --cicustom and is optional.
Signed-off-by: Mira Limbeck
---
Tested-By: Aaron Lauterer
On 12/20/21 12:37, Dominik Csapak wrote:
since the webview seemingly does not allow javascripts 'requestFullscreen',
workaround that by making the whole webview fullscreen and hiding novncs
fullscreen button
Signed-off-by: Dominik Csapak
---
Seems to work fine.
Tested-By: Aaron Lauterer
On 12/20/21 12:35, Dominik Csapak wrote:
with the recent changes, the input field was invisible, adapting
like the login dialog
Signed-off-by: Dominik Csapak
---
lib/proxmox_tfa_form.dart | 7 +--
1 file changed, 5 insertions(+), 2
in get_credentials, we try to read the token for the specified server,
and warn if we cannot do that (e.g. because the file does not exist)
since having no token is a valid configuration, suppress that warning on
connection.
reported by a forum-user:
since the webview seemingly does not allow javascripts 'requestFullscreen',
workaround that by making the whole webview fullscreen and hiding novncs
fullscreen button
Signed-off-by: Dominik Csapak
---
lib/widgets/pve_console_menu_widget.dart | 14 ++
1 file changed, 6 insertions(+),
with the recent changes, the input field was invisible, adapting
like the login dialog
Signed-off-by: Dominik Csapak
---
lib/proxmox_tfa_form.dart | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/proxmox_tfa_form.dart b/lib/proxmox_tfa_form.dart
index
patch 15 hides the fullscreen button,
patch 16 make the error message dismissable
Signed-off-by: Dominik Csapak
---
...-button-on-isFullscreen-get-variable.patch | 39 +++
debian/patches/0017-make-error-hideable.patch | 47 +++
debian/patches/series
one question:
either it's not explained, or i missed it:
what do we gain by having a limit on the number of protected backups?
storage 2/2 mentions that protection broke some assumption of vzdump
which is (somehow? not really explained imho) fixing it?
if it's not fixing it, what is the
The userid-* permission check variants work on
$param->{userid} directly which does not exist for this
call. Also, they work on the realm of the user being
checked, rather than the realm provided as parameter.
The result was that as non-root user this always failed
with the message "userid '' too
24 matches
Mail list logo
