Re: [pve-devel] [PATCH proxmox-acme 1/1] Add selfhost ACME DNS API

2022-02-17 Thread Thomas Lamprecht
On 15.02.22 06:38, Marvin Edeler wrote: > Signed-off-by: Marvin Edeler > --- > src/dns-challenge-schema.json | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/src/dns-challenge-schema.json b/src/dns-challenge-schema.json > index 39ac2ba..16fef64 100644 > --- a/src/d

[pve-devel] applied: [pbs-devel] [RFC proxmox] support quoted strings in property strings

2022-02-17 Thread Thomas Lamprecht
On 16.02.22 14:39, Wolfgang Bumiller wrote: > This allows free form text to exist within property strings, > quoted, like: > key="A value with \"quotes, also commas",key2=value2 > or also: > "the value for a default_key",key2=value2 > > And drop ';' as a key=value separator since those are

[pve-devel] [PATCH storage] fix #3894: file 'size' and 'used' are not integers

2022-02-17 Thread Mira Limbeck
'qemu-img info' with output format 'json' returns the size and used values as integers, but the regex match converts them to strings. As we know they only contain digits, we can simply cast them back to integers after the regex. The API requires them to be integers. Signed-off-by: Mira Limbeck -

Re: [pve-devel] [PATCH storage] fix #3894: file 'size' and 'used' are not integers

2022-02-17 Thread Fabian Ebner
Am 17.02.22 um 13:55 schrieb Mira Limbeck: > 'qemu-img info' with output format 'json' returns the size and used values as > integers, but the regex match converts them to strings. > As we know they only contain digits, we can simply cast them back to integers > after the regex. > > The API requir

Re: [pve-devel] [PATCH storage] fix #3894: file 'size' and 'used' are not integers

2022-02-17 Thread Mira Limbeck
On 2/17/22 14:24, Fabian Ebner wrote: Am 17.02.22 um 13:55 schrieb Mira Limbeck: 'qemu-img info' with output format 'json' returns the size and used values as integers, but the regex match converts them to strings. As we know they only contain digits, we can simply cast them back to integers aft

[pve-devel] applied: [PATCH qemu-server] clone disk: force raw format for TPM state

2022-02-17 Thread Thomas Lamprecht
On 16.02.22 11:47, Fabian Ebner wrote: > The format can't be qcow2 for TPM state, because swtpm reads the file > directly expecting raw data. > > Signed-off-by: Fabian Ebner > --- > > The DiskStorageSelector in the UI hides the format for TPM state, but > still sends along format=qcow2 triggerin

[pve-devel] applied: [PATCH v4 manager] api: apt: repos: fix interfacing with perlmod

2022-02-17 Thread Thomas Lamprecht
On 16.07.21 15:27, Fabian Ebner wrote: > Using > pvesh create /nodes/pve701/apt/repositories --path > "/etc/apt/sources.list" --index 0 --enabled 1 > reliably leads to > error: invalid type: string "0", expected usize > > Coerce to int to avoid this. I was not able to trigger the issue

Re: [pve-devel] applied: [PATCH qemu-server] clone disk: force raw format for TPM state

2022-02-17 Thread Fabian Ebner
Am 17.02.22 um 14:33 schrieb Thomas Lamprecht: > On 16.02.22 11:47, Fabian Ebner wrote: >> The format can't be qcow2 for TPM state, because swtpm reads the file >> directly expecting raw data. >> >> Signed-off-by: Fabian Ebner >> --- >> >> The DiskStorageSelector in the UI hides the format for TPM

Re: [pve-devel] [PATCH storage] fix #3894: file 'size' and 'used' are not integers

2022-02-17 Thread Fabian Ebner
Am 17.02.22 um 14:33 schrieb Mira Limbeck: > On 2/17/22 14:24, Fabian Ebner wrote: >> Am 17.02.22 um 13:55 schrieb Mira Limbeck: >>> 'qemu-img info' with output format 'json' returns the size and used >>> values as >>> integers, but the regex match converts them to strings. >>> As we know they only

[pve-devel] [PATCH qemu-server] fix 3674: QEMU restore: verify storage allows images before writing

2022-02-17 Thread Matthias Heiserer
When restoring a backup and the storage the disks would be created on doesn't allow 'images', the process errors without cleanup. This is the same behaviour we currently have when the storage is disabled. Signed-off-by: Matthias Heiserer --- PVE/QemuServer.pm | 4 1 file changed, 4 insertio

Re: [pve-devel] [PATCH storage] fix #3894: file 'size' and 'used' are not integers

2022-02-17 Thread Mira Limbeck
On 2/17/22 15:10, Fabian Ebner wrote: Am 17.02.22 um 14:33 schrieb Mira Limbeck: On 2/17/22 14:24, Fabian Ebner wrote: Am 17.02.22 um 13:55 schrieb Mira Limbeck: 'qemu-img info' with output format 'json' returns the size and used values as integers, but the regex match converts them to strings

[pve-devel] [PATCH v2 storage 2/2] file_size_info: cast 'size' and 'used' to integer

2022-02-17 Thread Mira Limbeck
`qemu-img info --output=json` returns the size and used values as integers in the JSON format, but the regex match converts them to strings. As we know they only contain digits, we can simply cast them back to integers after the regex. The API requires them to be integers. Signed-off-by: Mira Lim

[pve-devel] [PATCH v2 storage 1/2] fix #3894: cast 'size' and 'used' to integer

2022-02-17 Thread Mira Limbeck
Perl's automatic conversion can lead to integers being converted to strings, for example by matching it in a regex. To make sure we always return an integer in the API calls, add explicit casts to integer. Signed-off-by: Mira Limbeck --- v2: new PVE/API2/Storage/Content.pm | 6 -- 1 file c

Re: [pve-devel] [PATCH v2 storage 1/2] fix #3894: cast 'size' and 'used' to integer

2022-02-17 Thread Fabian Ebner
Am 17.02.22 um 15:54 schrieb Mira Limbeck: > Perl's automatic conversion can lead to integers being converted to > strings, for example by matching it in a regex. > > To make sure we always return an integer in the API calls, add > explicit casts to integer. > > Signed-off-by: Mira Limbeck > ---

Re: [pve-devel] [PATCH v2 storage 2/2] file_size_info: cast 'size' and 'used' to integer

2022-02-17 Thread Fabian Ebner
Am 17.02.22 um 15:54 schrieb Mira Limbeck: > `qemu-img info --output=json` returns the size and used values as integers in > the JSON format, but the regex match converts them to strings. > As we know they only contain digits, we can simply cast them back to integers > after the regex. > > The API