[pve-devel] [PATCH manager] fix #3976: api/backup: make schedule/starttime truly optional on update

2022-03-31 Thread Dominik Csapak
on create we require either starttime (+dow) or a schedule, but when updating an existing job, this is not necessary before we changed to schedules, the starttime was not optional either on update, but i think there is no reason to require the user to send the schedule/startime along every time.

Re: [pve-devel] [PATCH proxmox-openid-rs] fix Open ID with Azure as provider

2022-03-31 Thread Dietmar Maurer
> let response = if let Method::POST = request.method { > -req.send(&*request.body) > +let bytes = request.body.as_slice(); > +req.send_bytes(bytes) Does this have the side effect of changing the transfer encoding? If so, it is worth to add an inline comment.

[pve-devel] 3rd-party storage has "Unknown" type

2022-03-31 Thread Joshua Huber via pve-devel
--- Begin Message --- Hi everyone, I maintain a Proxmox storage plugin used at several service providers (with paying Proxmox subscriptions). We've had a few feature requests regarding the hard-coded mapping in StorageView between backend storage types and their user-friendly front-end names. Any

[pve-devel] [PATCH proxmox-openid-rs] fix Open ID with Azure as provider

2022-03-31 Thread Mira Limbeck
Azure doesn't accept `Transfer-Encoding: chunked` on their token endpoint, but with the switch to ureq we always send requests with this set. Fix by switching to `Content-Length` in the header instead. ureq only sets `Transfer-Encoding: chunked` when the body length is not known beforehand, which

Re: [pve-devel] [PATCH v3 qemu-server 0/7] cloudinit pending behaviour change

2022-03-31 Thread DERUMIER, Alexandre
Thanks for the review Fabian. I need to look it again between other approach. I don't remember exactly as I send it last year ;) I'm going on holiday for 2 weeks tomorrow, so I'll look it when I'll be back. thanks again Alexandre Le jeudi 31 mars 2022 à 15:01 +0200, Fabian Ebner a écrit : > Am

Re: [pve-devel] [PATCH v3 qemu-server 6/7] api2: add cloudinit_update

2022-03-31 Thread Fabian Ebner
Am 09.06.21 um 13:54 schrieb Alexandre Derumier: > This allow to regenerate the config drive with 1 api call. > > This also avoid to delete drive volume first, and recreate it again. > > we can simply: > - eject > - regenerated the volume > - replace it with qemu monitor > > Signed-off-by: Alexa

Re: [pve-devel] [PATCH v3 qemu-server 3/7] cloudinit: make cloudnit options fastplug

2022-03-31 Thread Fabian Ebner
Am 09.06.21 um 13:54 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer.pm | 30 +++--- > 1 file changed, 3 insertions(+), 27 deletions(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 6ddac72..0be4c45 100644 > --- a/PV

Re: [pve-devel] [PATCH v3 qemu-server 5/7] cloudinit : add extract_cloudinit_config

2022-03-31 Thread Fabian Ebner
Am 09.06.21 um 13:54 schrieb Alexandre Derumier: > --- a/PVE/QemuServer/Cloudinit.pm > +++ b/PVE/QemuServer/Cloudinit.pm > @@ -607,11 +607,56 @@ sub dump_cloudinit_config { > } > } > > +sub extract_cloudinit_config { > +my ($conf, $vmid) = @_; > + > +my $current_drive = undef; > +

Re: [pve-devel] [PATCH v3 qemu-server 4/7] api2: add cloudinit config api

2022-03-31 Thread Fabian Ebner
Am 09.06.21 um 13:54 schrieb Alexandre Derumier: > +code => sub { > + my ($param) = @_; > + > + my $vmid = $param->{vmid}; > + my $conf = PVE::QemuConfig->load_config($vmid); > + > + if( defined($conf->{cipassword}) && > + defined($conf->{cloudinit}->{cipassword}) && >

Re: [pve-devel] [PATCH v3 qemu-server 2/7] cloudinit: generate cloudinit drive on offline plug

2022-03-31 Thread Fabian Ebner
Am 09.06.21 um 13:54 schrieb Alexandre Derumier: > Currently when only generate it at vm start > > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer.pm | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 25ac052..6ddac72 1006

Re: [pve-devel] [PATCH v3 qemu-server 1/7] cloudinit: add vm config to cloudinit drive

2022-03-31 Thread Fabian Ebner
Am 09.06.21 um 13:54 schrieb Alexandre Derumier: > To have current running cloudinit config. > > An improvement could be to implement parsing of config drive format, > and also compare cicustom snippets content > > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer/Cloudinit.pm | 10 +

Re: [pve-devel] [PATCH v3 qemu-server 0/7] cloudinit pending behaviour change

2022-03-31 Thread Fabian Ebner
Am 09.06.21 um 13:54 schrieb Alexandre Derumier: > Hi, > > This is an attempt to cleanup current behaviour of cloudinit online changes. > > Currently, we setup cloudinit options as pending, until we generate the > config drive. > > This is not 100% true, because some option like vm name, nic ma

Re: [pve-devel] [PATCH 0/2] PoC for zfs native encryption in pve-installer

2022-03-31 Thread Fabian Grünbichler
On March 31, 2022 12:22 am, Gregor Michels via pve-devel wrote: > Hello everybody ! > > I wanted to have a fully encrypted PVE instance utilising the native > encryption of zfs. > > Unfortunately the PVE installer itself does not support this usecase. > There are various guides out there that do

[pve-devel] [PATCH v3 manager 0/4] BackupView as TreePanel

2022-03-31 Thread Matthias Heiserer
Depends on https://lists.proxmox.com/pipermail/pve-devel/2022-March/052322.html Matthias Heiserer (4): ui: Utils: Helpers for backup type and icon ui: storage: Rewrite backup content view as TreePanel. ui: delete BackupView and replace it with the new Tree BackupView ui: content view: remo

[pve-devel] [PATCH v3 manager 2/4] ui: storage: Rewrite backup content view as TreePanel.

2022-03-31 Thread Matthias Heiserer
Should be easier to read/use than the current flat list. Backups are grouped by ID and type, so in case there are backups with ID 100 for both CT and VM, this would create two separate groups in the UI. Date and size of group are taken from the latest backup. Notes, Protection, Encrypted, and Verif

[pve-devel] [PATCH v3 manager 3/4] ui: delete BackupView and replace it with the new Tree BackupView

2022-03-31 Thread Matthias Heiserer
Signed-off-by: Matthias Heiserer --- www/manager6/Makefile | 1 - www/manager6/grid/BackupView.js | 388 www/manager6/lxc/Config.js | 2 +- www/manager6/qemu/Config.js | 2 +- 4 files changed, 2 insertions(+), 391 deletions(-) delete mode

[pve-devel] [PATCH v3 manager 4/4] ui: content view: remove dead code

2022-03-31 Thread Matthias Heiserer
These lines were only used by grid/BackupView, which gets deleted in this series. Signed-off-by: Matthias Heiserer --- www/manager6/storage/ContentView.js | 43 ++--- 1 file changed, 8 insertions(+), 35 deletions(-) diff --git a/www/manager6/storage/ContentView.js b/www

[pve-devel] [PATCH v3 manager 1/4] ui: Utils: Helpers for backup type and icon

2022-03-31 Thread Matthias Heiserer
Signed-off-by: Matthias Heiserer --- changes from v2: return in else branch changes from v1: add "backup" to name www/manager6/Utils.js | 20 1 file changed, 20 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index aafe359a..1f067088 100644 --- a/w