[pve-devel] applied-series: [PATCH manager/docs 0/3] EC follow ups

2022-05-03 Thread Thomas Lamprecht
Am 5/3/22 um 13:58 schrieb Aaron Lauterer: > Some small follow ups. Mainly adapting the docs and API descriptions to > avoid misunderstandings. > > Also removign the 'crush_rule' parameter for the EC pool upon creation > as it gets its own crush rule anyway and we cannot change it. > > manager:

[pve-devel] applied: [PATCH docs 3/3] pveceph: ec pool: add note about parameter usage on creation

2022-05-03 Thread Thomas Lamprecht
Am 5/3/22 um 13:58 schrieb Aaron Lauterer: > Some optional parameters will only be used for the replicated metadata > pool. > > Signed-off-by: Aaron Lauterer > --- > pveceph.adoc | 6 ++ > 1 file changed, 6 insertions(+) > > applied, thanks! FYI: i did a s/'/`/ on the whole EC section,

[pve-devel] applied: [PATCH manager] schedule-analyze: fix schedules with limited runs

2022-05-03 Thread Thomas Lamprecht
Am 5/3/22 um 16:10 schrieb Dominik Csapak: > When a schedule only has a limited amount of runs it can happen > (e.g. 2022-10-01 8:00/30), $next will be undef after the last run. > Exit early in that case. > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Cluster/Jobs.pm | 1 + > 1 file

[pve-devel] [PATCH manager] schedule-analyze: fix schedules with limited runs

2022-05-03 Thread Dominik Csapak
When a schedule only has a limited amount of runs it can happen (e.g. 2022-10-01 8:00/30), $next will be undef after the last run. Exit early in that case. Signed-off-by: Dominik Csapak --- PVE/API2/Cluster/Jobs.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Cluster/Jobs.pm

[pve-devel] [PATCH docs 3/3] pveceph: ec pool: add note about parameter usage on creation

2022-05-03 Thread Aaron Lauterer
Some optional parameters will only be used for the replicated metadata pool. Signed-off-by: Aaron Lauterer --- pveceph.adoc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/pveceph.adoc b/pveceph.adoc index dff44e0..abc749b 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -595,6 +595,12

[pve-devel] [PATCH manager 2/3] ceph pools create: enhance erasure-code description

2022-05-03 Thread Aaron Lauterer
Mention which optional parameters will be used for the replicated metadata pool but won't have an effect on the erasure coded data pool. Signed-off-by: Aaron Lauterer --- PVE/API2/Ceph/Pools.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Ceph/Pools.pm

[pve-devel] [PATCH manager 1/3] ceph pools create: remove crush_rule for ec pool data

2022-05-03 Thread Aaron Lauterer
The crush rule is an optional paramter which can be used for the metadata pool, but the erasure coded data pool will always get its own crush rule. Therefore this parameter can not be adapted. Signed-off-by: Aaron Lauterer --- PVE/API2/Ceph/Pools.pm | 1 + 1 file changed, 1 insertion(+) diff

[pve-devel] [PATCH manager/docs 0/3] EC follow ups

2022-05-03 Thread Aaron Lauterer
Some small follow ups. Mainly adapting the docs and API descriptions to avoid misunderstandings. Also removign the 'crush_rule' parameter for the EC pool upon creation as it gets its own crush rule anyway and we cannot change it. manager: Aaron Lauterer (2): ceph pools create: remove

Re: [pve-devel] [PATCH storage] Diskmanage: check for extended partitions

2022-05-03 Thread Dominik Csapak
On 5/3/22 13:39, Stoiko Ivanov wrote: On Tue, 3 May 2022 13:08:47 +0200 Dominik Csapak wrote: those would not get assinged a usage and thus appear in the list when we want to select a partition (e.g. for creating a zpool) since we cannot do anything with such a partition, return the usage

Re: [pve-devel] [PATCH storage] Diskmanage: check for extended partitions

2022-05-03 Thread Stoiko Ivanov
On Tue, 3 May 2022 13:08:47 +0200 Dominik Csapak wrote: > those would not get assinged a usage and thus appear in the list > when we want to select a partition (e.g. for creating a zpool) > > since we cannot do anything with such a partition, return the usage > 'Extended Partition' for these.

[pve-devel] [PATCH storage 0/2] rbd: improve errormessages on missing/wrong poolname

2022-05-03 Thread Stoiko Ivanov
ran into the issues while configuring an external rbd-storage on my node (and not adding the correct poolname) Issue is cosmetic in nature - but the new messages should help in identifying where the problem is rooted Stoiko Ivanov (2): rbd: add fallback default poolname 'rbd' to status rbd:

[pve-devel] [PATCH storage 2/2] rbd: warn if no stats for a pool could be gathered

2022-05-03 Thread Stoiko Ivanov
happens in case of a mistyped poolname, and the new message should be more helpful than: `Use of uninitialized value $free in addition (+) at \ /usr/share/perl5/PVE/Storage/RBDPlugin.pm line 64` Signed-off-by: Stoiko Ivanov --- PVE/Storage/RBDPlugin.pm | 5 + 1 file changed, 5 insertions(+)

[pve-devel] [PATCH storage 1/2] rbd: add fallback default poolname 'rbd' to status

2022-05-03 Thread Stoiko Ivanov
the fallback to a default pool name of 'rbd' was introduced in: 1440604a4b072b88cc1e4f8bbae4511b50d1d68e and worked for the status command, because it used the `rados_cmd` sub. This fallback was lost with the changes in: 41aacc6cdeea9b0c8007cbfb280acf827932c3d6 leading to confusing errors: `Use

[pve-devel] [PATCH qemu-server] added test-cases for new machine-syntax & viommu

2022-05-03 Thread Markus Frank
added a few test-cases to test the new machine parameter with viommu Signed-off-by: Markus Frank --- test/restore-config-expected/401.conf | 14 + test/restore-config-expected/402.conf | 14 + test/restore-config-input/401.conf| 14 +

[pve-devel] [PATCH manager] ui: MachineEdit with viommu checkbox

2022-05-03 Thread Markus Frank
Added a Checkbox to enable viommu, if q35 is selected. Otherwise (i440fx) the checkbox is disabled. The GUI also needs to parse the new machine parameter as PropertyString. Signed-off-by: Markus Frank --- www/manager6/qemu/MachineEdit.js | 22 ++ 1 file changed, 22

[pve-devel] [PATCH qemu-server 1/3] tests: replaced somemachine with q35

2022-05-03 Thread Markus Frank
Needed for new machine parameter, because parse_property_string checks the parameter with the regex-pattern and therefore the test-cases with somemachine & someothermachine always fail. Since they do not have a special meaning, I changed somemachine & someothermachine to q35 & pc with sed sed

[pve-devel] [PATCH qemu-server] fix #3784: Parameter for guest vIOMMU & machine as property-string

2022-05-03 Thread Markus Frank
Changed the machine parameter to allow multiple machine-specific parameters via property_string, but also allow old configs (via default_key) possible-configurations-example: machine: q35 machine: pc machine: q35,viommu=1 machine: type=q35,viommu=1 Also added a Parameter for vIOMMU so nobody has

[pve-devel] [PATCH v2 manager 2/3] vzdump: notes-template: improve check for unknown variable

2022-05-03 Thread Fabian Ebner
so that '{{foo}}{{bar}}' is not detected as being an unknown variable named 'foo}}{{bar', but as 'foo' (and 'bar'). Signed-off-by: Fabian Ebner --- PVE/VZDump.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 9af2de3d..05cc1bec 100644 ---

[pve-devel] [PATCH v2 manager 1/3] vzdump: notes-template: avoid escaping meta-characters upon replace

2022-05-03 Thread Fabian Ebner
which is caused by the quoting operators \Q...\E. The actual intention was to avoid such surprises. Fixes: 413bb432 ("partially close #438: vzdump: support setting notes-template") Signed-off-by: Fabian Ebner --- Changes from v1: * Add follow-ups to further improve behavior. PVE/VZDump.pm

[pve-devel] [PATCH/RFC v2 manager 3/3] vzdump: notes-template: replace unknown variable with error string

2022-05-03 Thread Fabian Ebner
rather than not setting the notes at all. They still can contain useful information, and it likely is surprising to users to lose all of the note when an unkown variable (or simply mistyped) is provided. Signed-off-by: Fabian Ebner --- PVE/VZDump.pm | 14 +- 1 file changed, 9

[pve-devel] [PATCH storage] Diskmanage: check for extended partitions

2022-05-03 Thread Dominik Csapak
those would not get assinged a usage and thus appear in the list when we want to select a partition (e.g. for creating a zpool) since we cannot do anything with such a partition, return the usage 'Extended Partition' for these. Signed-off-by: Dominik Csapak --- PVE/Diskmanage.pm | 2 ++ 1

[pve-devel] [PATCH container] lxc-pve-{prestart, poststop}-hook: initialize RESTEnvironment

2022-05-03 Thread Dominik Csapak
else some operations will fail, e.g. using an guest disk on an external ceph-cluster Signed-off-by: Dominik Csapak --- src/lxc-pve-poststop-hook | 3 +++ src/lxc-pve-prestart-hook | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/lxc-pve-poststop-hook b/src/lxc-pve-poststop-hook index

[pve-devel] [PATCH manager] vzdump: notes-template: avoid escaping meta-characters upon replace

2022-05-03 Thread Fabian Ebner
which is caused by the quoting operators \Q...\E. The actual intention was to avoid such surprises. Fixes: 413bb432 ("partially close #438: vzdump: support setting notes-template") Signed-off-by: Fabian Ebner --- PVE/VZDump.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git