Re: [pve-devel] [PATCH v6 qemu-server 6/6] qm: add remote-migrate command

2022-10-17 Thread DERUMIER, Alexandre
Le mardi 18 octobre 2022 à 08:39 +0200, Thomas Lamprecht a écrit : > > We plan to have such functionality in the datacenter manager, as that > should provide > a better way to manage such remotes and interfacing, in PVE it'd be > bolted on and > would require the need to manage this on every host/

[pve-devel] applied: [PATCH zfsonlinux 0/2] add patches already on zfs-2.1.7-staging upstream

2022-10-17 Thread Thomas Lamprecht
Am 17/10/2022 um 20:09 schrieb Stoiko Ivanov: > While discussing whether to push the 2.1.6 packages further we noticed > that a small glitch happened on debian-upstream. > Our build should not be affected (we don't ship init-scripts), but syncing > the changes could help in a few corner cases (user

Re: [pve-devel] [PATCH v6 qemu-server 6/6] qm: add remote-migrate command

2022-10-17 Thread Thomas Lamprecht
Hi, Am 17/10/2022 um 16:40 schrieb DERUMIER, Alexandre: >> an example invocation: >> >> $ qm remote-migrate 1234 4321 > 'host=123.123.123.123,apitoken=pveapitoken=user@pve!incoming=----,fingerprint=aa:bb:cc:dd:ee:ff:aa:bb:cc:dd:ee:ff:aa:bb:cc:dd:ee:ff:aa:bb:cc:dd:e

Re: [pve-devel] [PATCH v6 qemu-server 2/6] mtunnel: add API endpoints

2022-10-17 Thread DERUMIER, Alexandre
I think it's missing cleaning of vm on remote storage, if migration is aborted on phase1 or phase2. It safe to delete vm conf && disk on remotehost until the end of the phase2, when disk are switched. If job is aborted, It trigger "mtunnel exited unexpectedly" on remotehost, without any cleani

[pve-devel] [PATCH zfsonlinux 1/2] cherry-pick a few patches from zfs-2.1.7-staging

2022-10-17 Thread Stoiko Ivanov
While checking the current state of 2.1.6 we noticed that there were some changes in debian-upstream [0] resulting from a bug-report in zfs-upstream [1]. Our packages should be unaffected (they do not ship the init-scripts in the first place). Since the issue was fixed by zfs-upstream already on t

[pve-devel] [PATCH zfsonlinux 2/2] install zfs-load-key.service

2022-10-17 Thread Stoiko Ivanov
following upstream shipping it as a symlnk to /dev/null (to mask it) follows commit b18419d7068b7ebcaa6dfbee85263177feffa711 from debian-upstream: https://salsa.debian.org/zfsonlinux-team/zfs/ Signed-off-by: Stoiko Ivanov --- debian/zfsutils-linux.install | 1 + 1 file changed, 1 insertion(+)

[pve-devel] [PATCH zfsonlinux 0/2] add patches already on zfs-2.1.7-staging upstream

2022-10-17 Thread Stoiko Ivanov
While discussing whether to push the 2.1.6 packages further we noticed that a small glitch happened on debian-upstream. Our build should not be affected (we don't ship init-scripts), but syncing the changes could help in a few corner cases (user installed 2.1.6-1 from debian-upstream and then chang

Re: [pve-devel] [PATCH v6 qemu-server 6/6] qm: add remote-migrate command

2022-10-17 Thread DERUMIER, Alexandre
Le 28/09/22 à 14:50, Fabian Grünbichler a écrit : > which wraps the remote_migrate_vm API endpoint, but does the > precondition checks that can be done up front itself. > > this now just leaves the FP retrieval and target node name lookup to the > sync part of the API endpoint, which should be do-

Re: [pve-devel] [PATCH v6 qemu-server 6/6] qm: add remote-migrate command

2022-10-17 Thread DERUMIER, Alexandre
Hi Fabian, > an example invocation: > > $ qm remote-migrate 1234 4321 'host=123.123.123.123,apitoken=pveapitoken=user@pve!incoming=----,fingerprint=aa:bb:cc:dd:ee:ff:aa:bb:cc:dd:ee:ff:aa:bb:cc:dd:ee:ff:aa:bb:cc:dd:ee:ff:aa:bb:cc:dd:ee:ff:aa:bb' --target-bridge v

Re: [pve-devel] [PATCH manager v2 2/4] api ceph osd: add OSD index, metadata and lv-info

2022-10-17 Thread Dominik Csapak
LGTM, some comments inline (mostly nitpicks/qestions) On 7/6/22 15:01, Aaron Lauterer wrote: To get more details for a single OSD, we add two new endpoints: * nodes/{node}/ceph/osd/{osdid}/metadata * nodes/{node}/ceph/osd/{osdid}/lv-info The {osdid} endpoint itself gets a new GET handler to ret

Re: [pve-devel] [PATCH widget-toolkit/manager v2 0/4] Ceph OSD: add detail infos

2022-10-17 Thread Dominik Csapak
high level looks mostly good, a small question: is there a special reason why we ignore pre-lvm osds here? AFAICS, we simply error out for osds that don't live on lvm (though we can add additional types later i guess) comments in the individual patches _

Re: [pve-devel] [PATCH manager v2 4/4] ui: osd: add details window

2022-10-17 Thread Dominik Csapak
comments inline: On 7/6/22 15:01, Aaron Lauterer wrote: This new windows provides more detailes about an OSD such as: * PID * Memory usage * various metadata that could be of interest * list of phyiscal disks used for the main disk, db and wal with additional infos about the volumes for each

Re: [pve-devel] [PATCH manager v2 3/4] ui utils: add renderer for ceph osd addresses

2022-10-17 Thread Dominik Csapak
overall, i'd like the renderer to be a bit more robust. a small change in output results in nothing showing at all. i'd try to parse it as good as possible, but fallback to the 'raw' value in case it fails. that way the user can at least see what ceph returned On 7/6/22 15:01, Aaron Lauterer wro

Re: [pve-devel] [PATCH widget-toolkit v2 1/4] ObjectGrid: optionally show loading mask on load

2022-10-17 Thread Dominik Csapak
as talked off-list, we can omit the whole patch by using the rstore.load()'s callback directly (we already have to go into the internals of the objectgrid there, so we can use 'rstore.load()' directly too instead of 'reload') On 7/6/22 15:01, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer

[pve-devel] [PATCH manager 1/2] fix #3719: gui: expose MTU option for containers in web UI

2022-10-17 Thread Daniel Tschlatscher
The option to set the mtu parameter for lxc containers already exists in the backend. It only had to be exposed in the web UI as well. Signed-off-by: Daniel Tschlatscher --- www/manager6/lxc/Network.js | 14 ++ 1 file changed, 14 insertions(+) diff --git a/www/manager6/lxc/Network.j

[pve-devel] [PATCH manager 2/2] gui: reorder with advanced section

2022-10-17 Thread Daniel Tschlatscher
The new MTU field and the rate limit field are now in the advanced section of the NetworkInputPanel to parallel the layout of the NetworkEdit for VMs. Signed-off-by: Daniel Tschlatscher --- While the layout now is the same as in the VM NetworkEdit, I just feel like the advanced column does not c

[pve-devel] [PATCH qemu-server] fix #4284: add read-only to non-hotpluggable disk options

2022-10-17 Thread Leo Nunner
Changing the read-only status of a disk is not possible through QMP, so it needs to be exempt from the hotpluggable values as to notify the user. Signed-off-by: Leo Nunner --- PVE/QemuServer.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServ

[pve-devel] [PATCH qemu] savevm async IO channel: channel writev: fix return value in error case

2022-10-17 Thread Fiona Ebner
The documentation in include/io/channel.h states that -1 or QIO_CHANNEL_ERR_BLOCK should be returned upon error. Simply passing along the return value from the blk-functions has the potential to confuse the call sides. Non-blocking mode is not implemented currently, so -1 it is. The "return ret" w