Re: [pve-devel] [PATCH access-control 1/1] add realmsync plugin for jobs and CRUD api for domainsync-jobs

2022-11-07 Thread Thomas Lamprecht
mid to high level review, but it may be that some things are slightly out of date since sending this ~7 months ago (sorry for the delay...) Am 04/04/2022 um 10:54 schrieb Dominik Csapak: > to be able to define automated jobs that sync ldap/ad > > The jobs plugin contains special handling when no

Re: [pve-devel] applied: [PATCH manager 3/4] Jobs: add RealmSync Plugin and register it

2022-11-07 Thread Thomas Lamprecht
Am 07/11/2022 um 17:14 schrieb Thomas Lamprecht: > Am 04/04/2022 um 10:54 schrieb Dominik Csapak: >> so that realmsync jobs get executed >> >> Signed-off-by: Dominik Csapak >> --- >> PVE/Jobs.pm | 2 ++ >> 1 file changed, 2 insertions(+) >> >> > > applied, thanks! replied to the wrong one, did

[pve-devel] applied: [PATCH manager 2/4] Jobs/Plugin: remove 'vzdump' from id description

2022-11-07 Thread Thomas Lamprecht
Am 04/04/2022 um 10:54 schrieb Dominik Csapak: > it's not necessarily a vzdump job > > Signed-off-by: Dominik Csapak > --- > PVE/Jobs/Plugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied: [PATCH manager 1/4] Jobs: provide id and schedule to the job

2022-11-07 Thread Thomas Lamprecht
Am 04/04/2022 um 10:54 schrieb Dominik Csapak: > we need that for realmsync jobs > > Signed-off-by: Dominik Csapak > --- > PVE/Jobs.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel

[pve-devel] applied: [PATCH manager 3/4] Jobs: add RealmSync Plugin and register it

2022-11-07 Thread Thomas Lamprecht
Am 04/04/2022 um 10:54 schrieb Dominik Csapak: > so that realmsync jobs get executed > > Signed-off-by: Dominik Csapak > --- > PVE/Jobs.pm | 2 ++ > 1 file changed, 2 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.pro

[pve-devel] applied: [PATCH v6 docs 1/1] pveum: mention Sys.Incoming privilege

2022-11-07 Thread Thomas Lamprecht
Am 28/09/2022 um 14:50 schrieb Fabian Grünbichler: > Signed-off-by: Fabian Grünbichler > --- > pveum.adoc | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/c

[pve-devel] applied: [PATCH http-server v2 2/2] remove dead code 'parse_content_disposition'

2022-11-07 Thread Thomas Lamprecht
Am 07/11/2022 um 16:07 schrieb Dominik Csapak: > our recent change to parsing the upload headers made that code > unnecessary, so remove it > > Signed-off-by: Dominik Csapak > --- > src/PVE/APIServer/AnyEvent.pm | 20 > 1 file changed, 20 deletions(-) > > applied, thanks!

[pve-devel] applied: [PATCH http-server v2 1/2] upload: allow whitespaces in filenames

2022-11-07 Thread Thomas Lamprecht
Am 07/11/2022 um 16:07 schrieb Dominik Csapak: > some fields (e.g. filename) can contain spaces, but our 'trim' function, > would only return the value until the first whitespace character instead > of removing leading/trailing white space. this lead to giving the wrong > filename to the api call (

[pve-devel] applied: [PATCH v6 access-control 1/1] privs: add Sys.Incoming

2022-11-07 Thread Thomas Lamprecht
Am 28/09/2022 um 14:50 schrieb Fabian Grünbichler: > for guarding cross-cluster data streams like guest migrations and > storage migrations. > > Signed-off-by: Fabian Grünbichler > --- > src/PVE/AccessControl.pm | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___

[pve-devel] applied: [PATCH v6 qemu-server 1/6] schema: move 'pve-targetstorage' to pve-common

2022-11-07 Thread Thomas Lamprecht
Am 28/09/2022 um 14:50 schrieb Fabian Grünbichler: > for proper re-use in pve-container. > > Signed-off-by: Fabian Grünbichler > Reviewed-by: Fiona Ebner > --- > > Notes: > requires versioned dependency on pve-common that has taken over the option > > new in v6 / follow-up to v5 >

[pve-devel] applied: [PATCH v6 common 1/1] schema: take over 'pve-targetstorage' option

2022-11-07 Thread Thomas Lamprecht
Am 28/09/2022 um 14:50 schrieb Fabian Grünbichler: > from qemu-server, for re-use in pve-container. > > Signed-off-by: Fabian Grünbichler > Reviewed-by: Fiona Ebner > --- > > Notes: > requires versioned breaks on old qemu-server containing the option, to > avoid > registering twice >

[pve-devel] applied: [RFC common 1/1] change cpu shares: drop unused $cgroupv1_default parameter

2022-11-07 Thread Thomas Lamprecht
Am 07/10/2022 um 14:41 schrieb Fiona Ebner: > The only expression it appears in short-circuits, because the line > before ensures that $shares is guaranteed to be set. > > Signed-off-by: Fiona Ebner > --- > > Before we can add a new parameter to the function again, it would need > a Breaks for q

[pve-devel] [PATCH http-server v2 1/2] upload: allow whitespaces in filenames

2022-11-07 Thread Dominik Csapak
some fields (e.g. filename) can contain spaces, but our 'trim' function, would only return the value until the first whitespace character instead of removing leading/trailing white space. this lead to giving the wrong filename to the api call (e.g. 'foo' instead of 'foo (1).iso') which would reject

[pve-devel] [PATCH http-server v2 2/2] remove dead code 'parse_content_disposition'

2022-11-07 Thread Dominik Csapak
our recent change to parsing the upload headers made that code unnecessary, so remove it Signed-off-by: Dominik Csapak --- src/PVE/APIServer/AnyEvent.pm | 20 1 file changed, 20 deletions(-) diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm index 39

[pve-devel] applied: [PATCH docs] updated copyright to current year

2022-11-07 Thread Thomas Lamprecht
Am 25/10/2022 um 15:28 schrieb Noel Ullreich: > Updated the copyright in `pve-copyright.adoc` which is used to generate the > man pages. > Pervious version was from 2019 > > Signed-off-by: Noel Ullreich > --- > pve-copyright.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > app

[pve-devel] applied: [PATCH] pbs: prune: avoid getting all snapshots for group assembly if fixed anyway

2022-11-07 Thread Thomas Lamprecht
If both type and vmid is defined we don't need to list the current snapshots, we simply can derive the single backup group from that and let the PBS client handle the rest. Should be a not so small speedup for most setups using PBS backup and pruning configured on PVE side, as vzdump calls this se

[pve-devel] [PATCH manager] ui: add missing tag classes

2022-11-07 Thread Dominik Csapak
for the tags ui to properly work, these css classes are necessary Signed-off-by: Dominik Csapak --- this patch was missing in my last tags gui series, somehow i messed up during rebase and these lines got lost if i need to resend the series, i fixup the correct patches with the css styles thank

Re: [pve-devel] [PATCH common v3 1/1] PBSClient: file_restore_list: add timeout parameter

2022-11-07 Thread Thomas Lamprecht
subject is not wrong but worded rather confusingly, as of now it rather implies that this adds a new parameter allowing callers to control the timeout, but actually it sets the timeout hard-coded to 25s. Am 27/05/2022 um 10:22 schrieb Dominik Csapak: > we always want the restore_list to use a time

[pve-devel] applied: [PATCH widget-toolkit] TaskProgress: show text instead of percentage

2022-11-07 Thread Thomas Lamprecht
Am 22/07/2022 um 14:15 schrieb Aaron Lauterer: > The text needs to be defined in the wait() call as otherwise the > Ext.Progressbar will show a percentage that is not correct anyway but > just reflects where the animated progress bar itself is. > > Signed-off-by: Aaron Lauterer > --- > This wasn'

Re: [pve-devel] [PATCH v2 librados2-perl storage manager 0/7] Add Ceph safety checks

2022-11-07 Thread Aaron Lauterer
ping? If we are okay with the way this would change RADOS.xs and RADOS.pm, I can send a follow up for patch 3 and 4 as a few other places started to issue mon commands in the meantime. There is also the currently pending "Ceph OSD: add detail infos" patch series which either could be include

Re: [pve-devel] [PATCH widget-toolkit] TaskProgress: show text instead of percentage

2022-11-07 Thread Aaron Lauterer
ping Recently ran into a situation where, on a slower system, the 100% were reached, and it started again at 0%. On 7/22/22 14:15, Aaron Lauterer wrote: The text needs to be defined in the wait() call as otherwise the Ext.Progressbar will show a percentage that is not correct anyway but just

Re: [pve-devel] [PATCH V3 qemu-server 3/3] migration : add del_nets_bridge_fdb

2022-11-07 Thread Mira Limbeck
On 8/24/22 18:26, Alexandre Derumier wrote: at the end of a live migration, we need to remove old mac entries on source host (vm is not yet stopped), before resume vm on target host Signed-off-by: Alexandre Derumier --- PVE/QemuMigrate.pm| 1 + PVE/QemuServer.pm

[pve-devel] [PATCH storage 2/2] zfs: list zvol: list single pool only for remote ZFS

2022-11-07 Thread Fiona Ebner
The remote ZFS plugin doesn't use a cache (would need a separate cache for each target host), so this can speed up the operation. Signed-off-by: Fiona Ebner --- PVE/Storage/ZFSPlugin.pm | 2 +- PVE/Storage/ZFSPoolPlugin.pm | 6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --

[pve-devel] [PATCH storage 1/2] zfs: only use cache when listing images locally

2022-11-07 Thread Fiona Ebner
The plugin for remote ZFS storages currently also uses the same list_images() as the plugin for local ZFS storages. The issue with this is that there is only one cache which does not remember the target host where the information originated. Simply restrict the cache to be used for the local ZFS p

Re: [pve-devel] pve-manager/www: API for external plugins?

2022-11-07 Thread Ilya Krel via pve-devel
--- Begin Message --- Hi Thomas and Roland, No problem about being added to the discussion! The GUI/Add operation has yet to be high on our list; adding storage via a one-time CLI command has not been a deployment challenge. However, our team would be happy to review and test the interface if one