[pve-devel] [PATCH manager v7] ui: vm network: allow to override MTU for virtio devices

2022-11-09 Thread Daniel Tschlatscher
From: Oguz Bektas we already have the 'mtu' option in the API, so we can just expose that option inside the 'Advanced' menu for virtio network interfaces. Signed-off-by: Oguz Bektas Moved the message tooltip below the advanced columns to avoid the line break and make it more visually pleasing.

[pve-devel] applied-series: [PATCH docs 00/10] docs (mostly) spelling update

2022-11-09 Thread Thomas Lamprecht
Am 09/11/2022 um 12:58 schrieb Matthias Heiserer: > These are mostly about the first chapters, I'll try to look through the later > ones aswell. > Many small patches, feel free to squash them, but I figured it's easier that > way when the inevitable > discussions about proper spelling arise :) >

Re: [pve-devel] [PATCH docs 05/10] move installation options to advanced folder

2022-11-09 Thread Thomas Lamprecht
Am 09/11/2022 um 12:58 schrieb Matthias Heiserer: > @Thomas The screenshot still shows the PVE6 menu. > Do you want to update that yourself, or should I send you the up-to-date > screeshot? please place such meta question/info not in the commit message itself but.. > Signed-off-by: Matthias Heis

Re: [pve-devel] [PATCH cluster v8 4/4] DataCenterConfig: add tag rights control to the datacenter config

2022-11-09 Thread Aaron Lauterer
On 10/18/22 16:02, Dominik Csapak wrote: by adding a 'user-tag-privileges' and 'admin-tags' option. The first sets the policy by which "normal" users (with 'VM.Config.Options' on the respective guest) can create/delete tags and the second is a list of tags only settable by 'admins' ('Sys.Modif

[pve-devel] applied: [PATCH docs] firewall: fix typo: ident -> identical

2022-11-09 Thread Thomas Lamprecht
Am 09/11/2022 um 12:41 schrieb Lukas Wagner: > "the following two are ident" --> "the following two are identical" > > Signed-off-by: Lukas Wagner > --- > pve-firewall.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! __

Re: [pve-devel] [PATCH V3 qemu-server 1/3] tap_plug: add support for bridge disable learning

2022-11-09 Thread Mira Limbeck
On 8/24/22 18:26, Alexandre Derumier wrote: This disabling mac learning && unicast flood for the tap interface for vmstart, we don't add mac directly to fdb. We set it latter if it's a migration or a fresh start. for nic hotplug, we directly add mac to fdb Signed-off-by: Alexandre Derumier --

[pve-devel] applied: [PATCH docs] asciidoc: fix capitalization of GmbH

2022-11-09 Thread Thomas Lamprecht
Am 09/11/2022 um 12:44 schrieb Lukas Wagner: > Signed-off-by: Lukas Wagner > --- > asciidoc/dblatex-custom.sty| 2 +- > pve-admin-guide-docinfo.xml.in | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > applied, thanks! fyi, pmg-docs would also profit from such a patch, in proxm

Re: [pve-devel] [PATCH qemu-server v3 08/13] PVE/API2/Qemu: add permission checks for mapped pci devices

2022-11-09 Thread Fabian Grünbichler
On November 9, 2022 1:51 pm, Dominik Csapak wrote: > > On 11/9/22 13:14, Fabian Grünbichler wrote: >> On September 20, 2022 2:50 pm, Dominik Csapak wrote: >>> Signed-off-by: Dominik Csapak >>> --- >>> PVE/API2/Qemu.pm | 54 ++-- >>> 1 file changed, 5

Re: [pve-devel] [PATCH access-control v3 1/1] PVE/AccessControl: add Hardware.* privileges and /hardware/ paths

2022-11-09 Thread Dominik Csapak
On 11/9/22 14:06, Fabian Grünbichler wrote: On November 9, 2022 1:39 pm, Dominik Csapak wrote: On 11/9/22 13:05, Fabian Grünbichler wrote: On September 20, 2022 2:50 pm, Dominik Csapak wrote: so that we can assign privileges on hardware level this will generate a new role (PVEHardwareAdmin)

Re: [pve-devel] [PATCH cluster/qemu-server/container/wt/manager v8] add tags to ui

2022-11-09 Thread Aaron Lauterer
I did test it for a bit, and it seems to work a lot better than the last iteration :) From a high level user perspective, I would like to see the following: - a list of configured tags that I am allowed to set in the drop down (the user-tag-privileges list) - better error messages that tell

Re: [pve-devel] [PATCH access-control v3 1/1] PVE/AccessControl: add Hardware.* privileges and /hardware/ paths

2022-11-09 Thread Fabian Grünbichler
On November 9, 2022 1:39 pm, Dominik Csapak wrote: > On 11/9/22 13:05, Fabian Grünbichler wrote: >> On September 20, 2022 2:50 pm, Dominik Csapak wrote: >>> so that we can assign privileges on hardware level >>> >>> this will generate a new role (PVEHardwareAdmin) >>> >>> Signed-off-by: Dominik Csa

Re: [pve-devel] [PATCH access-control v3 1/1] PVE/AccessControl: add Hardware.* privileges and /hardware/ paths

2022-11-09 Thread Thomas Lamprecht
Am 09/11/2022 um 13:05 schrieb Fabian Grünbichler: > On September 20, 2022 2:50 pm, Dominik Csapak wrote: >> so that we can assign privileges on hardware level >> >> this will generate a new role (PVEHardwareAdmin) >> >> Signed-off-by: Dominik Csapak >> --- >> src/PVE/AccessControl.pm | 13 +

Re: [pve-devel] [PATCH qemu-server v3 08/13] PVE/API2/Qemu: add permission checks for mapped pci devices

2022-11-09 Thread Dominik Csapak
On 11/9/22 13:14, Fabian Grünbichler wrote: On September 20, 2022 2:50 pm, Dominik Csapak wrote: Signed-off-by: Dominik Csapak --- PVE/API2/Qemu.pm | 54 ++-- 1 file changed, 52 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/AP

Re: [pve-devel] [PATCH access-control v3 1/1] PVE/AccessControl: add Hardware.* privileges and /hardware/ paths

2022-11-09 Thread Dominik Csapak
On 11/9/22 13:05, Fabian Grünbichler wrote: On September 20, 2022 2:50 pm, Dominik Csapak wrote: so that we can assign privileges on hardware level this will generate a new role (PVEHardwareAdmin) Signed-off-by: Dominik Csapak --- src/PVE/AccessControl.pm | 13 + src/PVE/RPCEn

Re: [pve-devel] [PATCH qemu-server v3 08/13] PVE/API2/Qemu: add permission checks for mapped pci devices

2022-11-09 Thread Fabian Grünbichler
On September 20, 2022 2:50 pm, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > PVE/API2/Qemu.pm | 54 ++-- > 1 file changed, 52 insertions(+), 2 deletions(-) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index 7afd7a4..d6d393f 10

Re: [pve-devel] [PATCH access-control v3 1/1] PVE/AccessControl: add Hardware.* privileges and /hardware/ paths

2022-11-09 Thread Fabian Grünbichler
On September 20, 2022 2:50 pm, Dominik Csapak wrote: > so that we can assign privileges on hardware level > > this will generate a new role (PVEHardwareAdmin) > > Signed-off-by: Dominik Csapak > --- > src/PVE/AccessControl.pm | 13 + > src/PVE/RPCEnvironment.pm | 3 ++- > 2 files

[pve-devel] [PATCH docs 06/10] add missing comma in if sentences

2022-11-09 Thread Matthias Heiserer
Signed-off-by: Matthias Heiserer --- pve-installation.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pve-installation.adoc b/pve-installation.adoc index c86b620..e101ed3 100644 --- a/pve-installation.adoc +++ b/pve-installation.adoc @@ -161,10 +161,10 @@ the instal

[pve-devel] [PATCH docs 09/10] it's -> its because it isn't 'it is'

2022-11-09 Thread Matthias Heiserer
Signed-off-by: Matthias Heiserer --- sysadmin.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysadmin.adoc b/sysadmin.adoc index 8ac39e1..88c3810 100644 --- a/sysadmin.adoc +++ b/sysadmin.adoc @@ -11,7 +11,7 @@ The following sections will focus on common virtualization

[pve-devel] [PATCH docs 01/10] consistently use 'web interface' (two words)

2022-11-09 Thread Matthias Heiserer
Signed-off-by: Matthias Heiserer --- certificate-management.adoc | 2 +- hyper-converged-infrastructure.adoc | 2 +- pve-storage-pbs.adoc| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/certificate-management.adoc b/certificate-management.adoc index 4

[pve-devel] [PATCH docs 08/10] add missing letter

2022-11-09 Thread Matthias Heiserer
Signed-off-by: Matthias Heiserer --- pve-installation.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-installation.adoc b/pve-installation.adoc index 6eb84a8..15b6c6d 100644 --- a/pve-installation.adoc +++ b/pve-installation.adoc @@ -278,7 +278,7 @@ ifndef::wiki[] In

[pve-devel] [PATCH docs 04/10] add note that secure boot needs to be disabled for host installation

2022-11-09 Thread Matthias Heiserer
Signed-off-by: Matthias Heiserer --- pve-installation.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-installation.adoc b/pve-installation.adoc index 74a356c..8de6ac9 100644 --- a/pve-installation.adoc +++ b/pve-installation.adoc @@ -60,7 +60,7 @@ Please insert the xr

[pve-devel] [PATCH docs 10/10] update link to debian handbook. current one is 404

2022-11-09 Thread Matthias Heiserer
Signed-off-by: Matthias Heiserer --- sysadmin.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysadmin.adoc b/sysadmin.adoc index 88c3810..d3de40a 100644 --- a/sysadmin.adoc +++ b/sysadmin.adoc @@ -17,7 +17,7 @@ https://zfsonlinux.org[ZFS] and several extra hardware driv

[pve-devel] [PATCH docs 05/10] move installation options to advanced folder

2022-11-09 Thread Matthias Heiserer
@Thomas The screenshot still shows the PVE6 menu. Do you want to update that yourself, or should I send you the up-to-date screeshot? Signed-off-by: Matthias Heiserer --- pve-installation.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pve-installation.adoc b/pve-

[pve-devel] [PATCH docs 07/10] rephrase when root password is set to make it clear that when logging it, it is already set

2022-11-09 Thread Matthias Heiserer
Signed-off-by: Matthias Heiserer --- pve-installation.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-installation.adoc b/pve-installation.adoc index e101ed3..6eb84a8 100644 --- a/pve-installation.adoc +++ b/pve-installation.adoc @@ -169,7 +169,7 @@ is still not worki

[pve-devel] [PATCH docs 03/10] consistently capitalize Ceph

2022-11-09 Thread Matthias Heiserer
Signed-off-by: Matthias Heiserer --- hyper-converged-infrastructure.adoc | 4 ++-- pve-storage-rbd.adoc| 4 ++-- pveceph.adoc| 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hyper-converged-infrastructure.adoc b/hyper-converged-in

[pve-devel] [PATCH docs 00/10] docs (mostly) spelling update

2022-11-09 Thread Matthias Heiserer
These are mostly about the first chapters, I'll try to look through the later ones aswell. Many small patches, feel free to squash them, but I figured it's easier that way when the inevitable discussions about proper spelling arise :) Matthias Heiserer (10): consistently use 'web interface' (

[pve-devel] [PATCH docs 02/10] remove misplaced comma

2022-11-09 Thread Matthias Heiserer
Signed-off-by: Matthias Heiserer --- hyper-converged-infrastructure.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hyper-converged-infrastructure.adoc b/hyper-converged-infrastructure.adoc index 3b15093..ee9f185 100644 --- a/hyper-converged-infrastructure.adoc +++ b/hyp

[pve-devel] [PATCH docs] firewall: fix typo: ident -> identical

2022-11-09 Thread Lukas Wagner
"the following two are ident" --> "the following two are identical" Signed-off-by: Lukas Wagner --- pve-firewall.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-firewall.adoc b/pve-firewall.adoc index f59c302..b759b91 100644 --- a/pve-firewall.adoc +++ b/pve-firewall

[pve-devel] [PATCH docs] asciidoc: fix capitalization of GmbH

2022-11-09 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- asciidoc/dblatex-custom.sty| 2 +- pve-admin-guide-docinfo.xml.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/asciidoc/dblatex-custom.sty b/asciidoc/dblatex-custom.sty index ba4a508..6b2578c 100644 --- a/asciidoc/dblatex-custom.sty ++

Re: [pve-devel] [PATCH common v3 2/3] add PVE/HardwareMap

2022-11-09 Thread Thomas Lamprecht
high level comment: should this go into pve-guest-common instead? Am 20/09/2022 um 14:50 schrieb Dominik Csapak: > this adds functionality for the hardwaremap config (as json) > the format of the config is like this: > > { > usb => { > name => { > nodename1 => { /* mapping obj

Re: [pve-devel] [PATCH common v3 1/3] SysFSTools: make mdev cleanup independent of pciid

2022-11-09 Thread Thomas Lamprecht
Am 20/09/2022 um 14:50 schrieb Dominik Csapak: > mediated devices also appear under /sys/bus/mdev/devices with their > uuid, independent of the pci device, so we can use that instead > > Signed-off-by: Dominik Csapak > --- > src/PVE/SysFSTools.pm | 6 ++ > 1 file changed, 2 insertions(+), 4

Re: [pve-devel] [PATCH qemu-server v3 04/13] PCI: reuse parsed info from print_hostpci_devices

2022-11-09 Thread Thomas Lamprecht
Am 20/09/2022 um 14:50 schrieb Dominik Csapak: > instead of parsing the config again when trying to reserver/prepare the > pci devices. also split the preparing into non-mdev devices and mdev > devices, this will come in handy later. I'd rather factor out the parsing parts, see below. > diff --

[pve-devel] applied: [PATCH qemu-server v3 02/13] PCI: make mediated device path independent of pci id

2022-11-09 Thread Thomas Lamprecht
Am 20/09/2022 um 14:50 schrieb Dominik Csapak: > mdevs must have a host-unique uuid, and they appear in > /sys/bus/mdev/devices/, so there is no need to reference the pciid > with it > > Signed-off-by: Dominik Csapak > --- > PVE/QemuServer/PCI.pm | 3 +-- > 1 file changed, 1 insertion(+), 2 dele

[pve-devel] applied: [PATCH qemu-server v3 01/13] cleanup pci devices in more situations

2022-11-09 Thread Thomas Lamprecht
Am 20/09/2022 um 14:50 schrieb Dominik Csapak: > if the preparing of pci devices or the start of the vm fails, we need > to cleanup the pci devices (reservations *and* mdevs), or else > it might happen that there are leftovers which must be manually removed. > > to include also mdevs now, refactor