[pve-devel] [PATCH qemu-server] cdrom handling: default to "none" if no physical drive is available

2022-12-16 Thread Stefan Sterz
when a vm is configured to use the physical cd rom drive but there is no such drive a cryptic "uninitialized value" error is thrown. this is due to the `$path` not being defined in `sub print_drive_commandline_full` in this case. warn that no cd rom drive is available and default back to using "non

Re: [pve-devel] [PATCH qemu-server 09/10] tests: add virtio-mem tests

2022-12-16 Thread Fiona Ebner
Am 09.12.22 um 20:27 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > test/cfg2cmd/memory-virtio-hugepages-1G.conf | 11 ++ > .../memory-virtio-hugepages-1G.conf.cmd | 35 +++ > test/cfg2cmd/memory-virtio-max.conf | 10 ++ > test/cfg

Re: [pve-devel] [PATCH qemu-server 08/10] memory: add virtio-mem support

2022-12-16 Thread Fiona Ebner
Am 09.12.22 um 20:27 schrieb Alexandre Derumier: > a 4GB static memory is needed for DMA+boot memory, as this memory > is almost always un-unpluggeable. > > 1 virtio-mem pci device is setup for each numa node on pci.4 bridge > > virtio-mem use a fixed blocksize with 32000 blocks > Blocksize is co

Re: [pve-devel] [PATCH qemu-server 10/10] memory: fix hotplug with virtiomem && maxmem

2022-12-16 Thread Fiona Ebner
Am 09.12.22 um 20:27 schrieb Alexandre Derumier: > diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm > index 70ab65a..84a9126 100644 > --- a/PVE/QemuServer/Memory.pm > +++ b/PVE/QemuServer/Memory.pm > @@ -9,6 +9,7 @@ use PVE::Exception qw(raise raise_param_exc); > use PVE::QemuServe

Re: [pve-devel] [PATCH qemu-server 06/10] memory: use 64 slots && static dimm size with max is defined

2022-12-16 Thread Fiona Ebner
Am 09.12.22 um 20:27 schrieb Alexandre Derumier: > default kernel vhost config only support 64 slots by default, > for performance since 2015. > > Original memory hotplug code was done before, using qemu > max supported 255 slots. > > To reach max mem (4TB), we used incremental dimm size. > > In

[pve-devel] [PATCH qemu-server v3 4/5] make the timeout value editable when the VM is locked

2022-12-16 Thread Daniel Tschlatscher
In some cases the VM could no longer start when the timeout value was set and afterwards, for example, hibernated. In this case the VM is soft locked in the GUI, because the API would not allow changing the timeout value anymore. (The only way out here would be to change the value manually in the c

[pve-devel] [PATCH manager v3 5/5] VM start Timeout "Options" parameter in the GUI

2022-12-16 Thread Daniel Tschlatscher
This makes it possible to set the newly introduced config parameter for timeout via the 'startoptions' property string. For now this only implements setting the timeout value when starting a VM, though this should be rather easily exentensible to include other future start options parameters. Sign

[pve-devel] [PATCH qemu-server v3 2/5] expose VM start timeout config setting in API

2022-12-16 Thread Daniel Tschlatscher
This patch makes it possible to now set the starting timeout value for a VM via the config parameter 'startoptions'. Now, if the timeout parameter is set, it will override the heuristic calculation of the VM start timeout. The maximum value for the timeout parameter is 86400 seconds, which is one

Re: [pve-devel] [PATCH qemu-server 05/10] memory: get_max_mem: use config memory max

2022-12-16 Thread Fiona Ebner
Am 09.12.22 um 20:27 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer/Memory.pm | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm > index 90e355b..b847742 100644 > --- a/PVE

Re: [pve-devel] [PATCH qemu-server 03/10] config: memory: add 'max' option

2022-12-16 Thread Fiona Ebner
Am 09.12.22 um 20:27 schrieb Alexandre Derumier: > max can be multiple of 64GB only. > Some quick rationale as to why would be nice to have. > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer.pm | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/PVE/Qem

Re: [pve-devel] [PATCH qemu-server 02/10] add memory parser

2022-12-16 Thread Fiona Ebner
Am 09.12.22 um 20:27 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/API2/Qemu.pm | 12 - > PVE/QemuConfig.pm | 4 +-- > PVE/QemuMigrate.pm| 6 +++-- > PVE/QemuServer.pm | 56 ++- > PVE/Qemu

[pve-devel] [PATCH common v3 1/5] VM start timeout config parameter in backend

2022-12-16 Thread Daniel Tschlatscher
This allows setting the 'startoptions' property string in the config. For now this only implements the 'timeout' parameter but should be rather easily extensible and allow related VM start config options to be also configurable here. Signed-off-by: Daniel Tschlatscher --- Changes from v2: * Rewo

[pve-devel] [PATCH qemu-server v3 3/5] await and kill lingering KVM thread when VM start reaches timeout

2022-12-16 Thread Daniel Tschlatscher
In some cases the VM API start method would return before the detached KVM process would have exited. This is especially problematic with HA, because the HA manager would think the VM started successfully, later see that it exited and start it again in an endless loop. Moreover, another case exist

[pve-devel] [PATCH common/qemu-server/manager v3] fix #3502: VM start timeout config parameter

2022-12-16 Thread Daniel Tschlatscher
This patch series adds a an option to specify a timeout value in the config for starting VMs. The minimum is 0 seconds, which disables the timeout completely. The maximum is 86400 seconds, equivalent to 1 day. The timeout value can also be passed via the CLI, which always overrides the setting. If

Re: [pve-devel] [PATCH qemu-server 04/10] memory: add get_static_mem

2022-12-16 Thread Fiona Ebner
Am 09.12.22 um 20:27 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- Ideally, this would be two patches: One for introducing the helper One for handling the new 'max' property (the patches that handle 'max' could also be squashed together with the one introducing the propert

Re: [pve-devel] [PATCH qemu-server 00/10] rework memory hotplug + virtiomem

2022-12-16 Thread Fiona Ebner
Am 09.12.22 um 20:27 schrieb Alexandre Derumier: > This patch series rework the current memory hotplug + virtiomem. > > memory option now have extra options: > > memory: [[current=]] [,max=] [,virtio=<1|0>] > ex: memory: current=1024,max=131072,virtio=1 > > > patches 1-2: add a memory parser >

Re: [pve-devel] [PATCH qemu-server 01/10] test: add memory tests

2022-12-16 Thread Fiona Ebner
Am 09.12.22 um 20:27 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > test/cfg2cmd/memory-hotplug-hugepages.conf| 12 ++ > .../cfg2cmd/memory-hotplug-hugepages.conf.cmd | 62 +++ > test/cfg2cmd/memory-hotplug.conf | 11 ++ > test/cfg2cmd/memory-hotpl

[pve-devel] applied-series: [PATCH qemu 1/2] update submodule and patches to 7.2.0

2022-12-16 Thread Wolfgang Bumiller
applied both patches, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager] fix #4393: ui: storage backup view: make pbs-specific columns sortable

2022-12-16 Thread Stefan Hanreich
The sort order is analogous to how it behaves in the datastore content overview in pbs. This means sorting in ascending order behaves as follows: Verify State * failed * none * ok Encryption * no * yes For the encryption state there is theoretically a distinction between signed and encrypted, b

Re: [pve-devel] [PATCH manager] report: filter comments in VM/CT configs

2022-12-16 Thread Fiona Ebner
Am 15.12.22 um 17:57 schrieb Mira Limbeck: > diff --git a/PVE/Report.pm b/PVE/Report.pm > index 90b7cb1c..7ebe98f7 100644 > --- a/PVE/Report.pm > +++ b/PVE/Report.pm > @@ -5,16 +5,34 @@ use warnings; > > use PVE::Tools; > > +my sub file2text { > +my ($file, $filter) = @_; > +my $text =

Re: [pve-devel] [RFC qemu-server] migration: nbd export: switch away from deprecated QMP command

2022-12-16 Thread Fiona Ebner
Am 16.12.22 um 12:52 schrieb Thomas Lamprecht: > On 02/12/2022 13:54, Fiona Ebner wrote: >> The 'nbd-server-add' QMP command has been deprecated since QEMU 5.2 in >> favor of a more general 'block-export-add'. >> >> When using 'nbd-server-add', QEMU internally converts the parameters >> and calls b

Re: [pve-devel] [RFC qemu-server] migration: nbd export: switch away from deprecated QMP command

2022-12-16 Thread Thomas Lamprecht
On 02/12/2022 13:54, Fiona Ebner wrote: > The 'nbd-server-add' QMP command has been deprecated since QEMU 5.2 in > favor of a more general 'block-export-add'. > > When using 'nbd-server-add', QEMU internally converts the parameters > and calls blk_exp_add() which is also used by 'block-export-add'

Re: [pve-devel] [PATCH manager] report: filter comments in VM/CT configs

2022-12-16 Thread Mira Limbeck
On 12/16/22 11:31, Thomas Lamprecht wrote: On 15/12/2022 17:57, Mira Limbeck wrote: Since some users keep their passwords in the VM/CT configs as comments and those are most of the time unnecessary when looking through the report, filter those. I'd rather have this optional, opt-out is fine, wh

Re: [pve-devel] [PATCH manager] report: filter comments in VM/CT configs

2022-12-16 Thread Thomas Lamprecht
On 15/12/2022 17:57, Mira Limbeck wrote: > Since some users keep their passwords in the VM/CT configs as comments > and those are most of the time unnecessary when looking through the > report, filter those. I'd rather have this optional, opt-out is fine, where the CLI gets a switch and the web in

Re: [pve-devel] [PATCH storage] config: add overrides for default directory locations

2022-12-16 Thread Wolfgang Bumiller
This is going to need multiple sets of eyes as I don't trust that we don't have some rogue direct `$scfg->{path}` usage ruining this for some case ;-) As for the code, see inline comments: On Thu, Dec 15, 2022 at 12:21:46PM +0100, Leo Nunner wrote: > Allowing overrides for the default directory l

Re: [pve-devel] [PATCH manager] report: filter comments in VM/CT configs

2022-12-16 Thread Stefan Sterz
On 12/15/22 17:57, Mira Limbeck wrote: > Since some users keep their passwords in the VM/CT configs as comments > and those are most of the time unnecessary when looking through the > report, filter those. > > In addition to the comments, also filter the `cipassword` option > since it contains the