Re: [pve-devel] [PATCH v2 firewall 1/1] api: Add optional parameters `since` and `until` for timestamp filter

2023-01-18 Thread Wolfgang Bumiller
On Wed, Jan 18, 2023 at 04:10:28PM +0100, Christian Ebner wrote: > > On 18.01.2023 11:33 CET Wolfgang Bumiller wrote: > > > > > > On Wed, Jan 11, 2023 at 02:32:19PM +0100, Christian Ebner wrote: > > > The optional unix epoch timestamps parameters `since` and `until` are > > > introduced > > >

Re: [pve-devel] [PATCH v2 firewall 1/1] api: Add optional parameters `since` and `until` for timestamp filter

2023-01-18 Thread Christian Ebner
> On 18.01.2023 11:33 CET Wolfgang Bumiller wrote: > > > On Wed, Jan 11, 2023 at 02:32:19PM +0100, Christian Ebner wrote: > > The optional unix epoch timestamps parameters `since` and `until` are > > introduced > > in order to filter firewall logs files. If one of these flags is set, also > >

[pve-devel] applied-series: [PATCH widget-toolkit/pve-manager] move node selection into combogrid

2023-01-18 Thread Thomas Lamprecht
Am 18/01/2023 um 14:12 schrieb Dominik Csapak: > proxmox-widget-toolkit: > > Dominik Csapak (2): > ComboGrid: use the grids view for the error message > ComboGrid: make height for the error configurable > > src/form/ComboGrid.js | 14 +- > 1 file changed, 9 insertions(+), 5 delet

[pve-devel] [PATCH manager 2/5] ui: BackupView: add scrolling overflow handler for the toolbar

2023-01-18 Thread Dominik Csapak
since we already have many elements here, and in our minimal resolution of 1280x720 we don't see all elements any more. reported in the forum: https://forum.proxmox.com/threads/web-forms-extend-beyond-web-page-window-in-some-cases.120714 Signed-off-by: Dominik Csapak --- www/manager6/dc/Backup.

[pve-devel] [RFC PATCH manager 5/5] ui: ScheduleSimulator: add UTC checkbox

2023-01-18 Thread Dominik Csapak
that displays the simulated times in UTC instead of the local timezone Only takes effect on the next click of 'Simulate' Signed-off-by: Dominik Csapak --- wanted to make it clearer that the time is the Local timezone by default, not sure if it does that... www/manager6/window/ScheduleSimulator.

[pve-devel] [PATCH manager 1/5] ui: reduce default size of Backup detail window

2023-01-18 Thread Dominik Csapak
on our minimal display size (1280x720), using height 700 is too large when considering that the browser + os also need some vertical space. For good measure, use a maximum of 600 pixels. Since the window is resizable anyway, users with more space should not have a problem here. reported in the fo

[pve-devel] [PATCH manager 3/5] ui: ScheduleSimulator: split date and time into two columns

2023-01-18 Thread Dominik Csapak
and align the time right. This makes it easier to compare times Signed-off-by: Dominik Csapak --- www/manager6/window/ScheduleSimulator.js | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/www/manager6/window/ScheduleSimulator.js b/www/manager6/window/Sch

[pve-devel] [RFC PATCH manager 4/5] ui: ScheduleSimulator: add rownumberer column

2023-01-18 Thread Dominik Csapak
so it's clear what the first time is, for that we have to disable sorting, since the rownumberer will not sort with it Signed-off-by: Dominik Csapak --- not sure if it's worth losing the sorting... www/manager6/window/ScheduleSimulator.js | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [pve-devel] [PATCH manager 1/2] GUI: efi disk: use correct version with aarch64

2023-01-18 Thread Thomas Lamprecht
for subject: s/GUI/ui/ to better match the predominantly used one. Am 17/01/2023 um 13:17 schrieb Matthias Heiserer: > Sets the EFI version to 2m when arch=aarch64. > > When the VM has arch=aarch64, creating an EFI disk failed with > "Can't use an undefined value as an ARRAY reference at > /usr/

Re: [pve-devel] [PATCH manager 2/2] GUI: efi disk: cleanup - var to const

2023-01-18 Thread Thomas Lamprecht
Am 17/01/2023 um 13:17 schrieb Matthias Heiserer: > Signed-off-by: Matthias Heiserer > --- > www/manager6/qemu/HDEfi.js | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/www/manager6/qemu/HDEfi.js b/www/manager6/qemu/HDEfi.js > index ef3092a6..f6b7fc26 100644

[pve-devel] [PATCH docs v5 4/5] added vIOMMU documentation

2023-01-18 Thread Markus Frank
Signed-off-by: Markus Frank --- qm-pci-passthrough.adoc | 25 + 1 file changed, 25 insertions(+) diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc index df6cf21..0db9b06 100644 --- a/qm-pci-passthrough.adoc +++ b/qm-pci-passthrough.adoc @@ -400,6 +400,31 @@ E

[pve-devel] [PATCH manager v5 5/5] ui: MachineEdit with viommu checkbox

2023-01-18 Thread Markus Frank
Added a checkbox to enable viommu, if q35 is selected. Otherwise (i440fx & !kvm) the checkbox is disabled, if not ticked on before. If ticked on before, the user is able to uncheck the checkbox. If kvm is deactivated or i440fx is selected, a hint tells that q35 and kvm are required for vIOMMU. Th

[pve-devel] [PATCH qemu-server v5 2/5] feature #3784: Parameter for guest vIOMMU & machine as property-string

2023-01-18 Thread Markus Frank
vIOMMU enables the option to passthrough pci devices to L2 VMs in L1 VMs via Nested Virtualisation. QEMU-Parameters: https://www.qemu.org/docs/master/system/qemu-manpage.html https://wiki.qemu.org/Features/VT-d -machine ...,kernel-irqchip=split: "split" because of intremap see below. -device in

pve-devel@lists.proxmox.com

2023-01-18 Thread Markus Frank
needed for new machine parameter parse_property_string checks for the regex, therefore the test-cases with somemachine & someothermachine always fail. So I changed somemachine & someothermachine to q35 & pc with sed sed -i 's/somemachine/q35/g' sed -i 's/someothermachine/pc/g' Signed-off-by: Ma

[pve-devel] [PATCH qemu-server/manager/docs v5 0/5] vIOMMU-Feature

2023-01-18 Thread Markus Frank
qemu-server: v5: * set $kvm to 1 if is_native, so that api kvm check works. v4: * added kvm/q35 checks in API * reused pve-qemu-machine v3: * replaced old machine type with property-string with viommu-parameter v2: * moved viommu-parameter inside of machine_fmt and added it the new parameter ma

[pve-devel] [PATCH qemu-server v5 3/5] added test-cases for new machine-syntax & viommu

2023-01-18 Thread Markus Frank
added two test-cases to test the new machine parameter with viommu Signed-off-by: Markus Frank --- test/cfg2cmd/q35-viommu-alt.conf | 1 + test/cfg2cmd/q35-viommu-alt.conf.cmd | 23 +++ test/cfg2cmd/q35-viommu.conf | 1 + test/cfg2cmd/q35-viommu.conf.cmd | 2

[pve-devel] [PATCH manager] fix 4481: fetch changelogs for any Proxmox repository

2023-01-18 Thread Leo Nunner
This patch fixes the issue that when the user supplied any non-standard repositories, the changelogs often wouldn't load. For example, providing both pve-no-subscription and pbs-no-subscription broke the changelog API, since the URL built for pbs-no-subscription was invalid. Signed-off-by: Leo Nun

Re: [pve-devel] [PATCH manager] ui: storage backup view: Update remove button on protection change

2023-01-18 Thread Thomas Lamprecht
Looks ok (but did not tested it yet), few small nits inline Am 18/01/2023 um 14:01 schrieb Christoph Heiss: > Currently this works in the backup view for containers/VMs, but not in > the storage backup view. Implement that for the latter part too. > > Uses the callback functionality of the load()

[pve-devel] [PATCH qemu-server] close #2792: allow online migration with replicated snapshots

2023-01-18 Thread Fiona Ebner
Since commit 9b6efe43 ("migrate: add live-migration of replicated disks") live-migration with replicated volumes is possible. When handling the replication, it is checked that all local volumes previously detected as replicatable are actually replicated. So the check if migration with snapshots is

[pve-devel] [PATCH manager 2/6] ui: storage: move node scan selector inside combobox

2023-01-18 Thread Dominik Csapak
by converting the relevant selection boxes to combogrids. This is done to reduce confusion for how/why to select a node, and doing it this way it is moved closer to the selection of the actual value we want. It still restricts the nodes when selecting a specific one. Show it only when there is mo

[pve-devel] [PATCH manager 6/6] ui: storage/LVMInputPanel: modernize & cleanup code

2023-01-18 Thread Dominik Csapak
using cbin, gettin rid of initComponent this is a bit more complicated than the other refactorings in storage recently, since we have a few fields with non trivial dependecies between the selected mode (existing vgs/base storage) and isCreate Because of that, using a cbind for the xtype here inst

[pve-devel] [PATCH manager 4/6] ui: storage/IScsiInputPanel: modernize, cleanup & improve panel

2023-01-18 Thread Dominik Csapak
using cbind + pmxDisplayEditField, getting rid of initComponent Disables the target selector until a portal is entered. For this, we currently cannot use the pmxDisplayEditField, since that disabled/enables the fields automatically based on 'editable'. Also setting buffer for the portal entry cha

[pve-devel] [PATCH widget-toolkit 1/2] ComboGrid: use the grids view for the error message

2023-01-18 Thread Dominik Csapak
for most of the combogrids, this does not make a difference, but we want to have a node selection in some of their toolbars. There having the error over the whole grid makes it impossible to select a different node (which might be necessary to get rid of the error), so we show the error on the view

[pve-devel] [PATCH widget-toolkit 2/2] ComboGrid: make height for the error configurable

2023-01-18 Thread Dominik Csapak
by introducing a errorHeight config property. This is necessary when the ComboGrid has e.g. a toolbar and we show the error in the grid body only, 100 pixels is not enough then. To solve that without hardcoding different heights, let the subclass/caller configure that also set this when the store

[pve-devel] [PATCH widget-toolkit/pve-manager] move node selection into combogrid

2023-01-18 Thread Dominik Csapak
instead of having it as a seperate input on storage creation. This aims to reduce confusion about what it exactly is and how it interacts with the rest of the input fields. With this series, it sits in a toolbar of the relevant dropdown, which were converted to combogrids. The selection box is onl

[pve-devel] [PATCH manager 3/6] ui: storage/LvmThinInputPanel: modernize & cleanup code

2023-01-18 Thread Dominik Csapak
using cbind + pmxDisplayEditField, getting rid of the initComponent Signed-off-by: Dominik Csapak --- www/manager6/storage/LvmThinEdit.js | 83 - 1 file changed, 35 insertions(+), 48 deletions(-) diff --git a/www/manager6/storage/LvmThinEdit.js b/www/manager6/storag

[pve-devel] [PATCH manager 5/6] ui: storage/ZFSPoolInputPanel: modernize & cleanup code

2023-01-18 Thread Dominik Csapak
using cbind + pmxDisplayEditField, getting rid of initComponent Signed-off-by: Dominik Csapak --- www/manager6/storage/ZFSPoolEdit.js | 77 + 1 file changed, 35 insertions(+), 42 deletions(-) diff --git a/www/manager6/storage/ZFSPoolEdit.js b/www/manager6/storage/ZF

[pve-devel] [PATCH manager 1/6] ui: StorageScanNodeSelector: use null as empty value

2023-01-18 Thread Dominik Csapak
otherwise it can happen that there as additional change event from null to '', even though the value did not change Signed-off-by: Dominik Csapak --- www/manager6/form/StorageScanNodeSelector.js | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/www/manager6/form/Storage

[pve-devel] [PATCH manager] ui: storage backup view: Update remove button on protection change

2023-01-18 Thread Christoph Heiss
Currently this works in the backup view for containers/VMs, but not in the storage backup view. Implement that for the latter part too. Uses the callback functionality of the load() method of the store to properly update the UI as soon as loading is finished. While at it, clean up the same thing i

[pve-devel] [PATCH qemu-server 1/2] swtpm: enable logging

2023-01-18 Thread Fiona Ebner
AFAICT, previously, errors from swtpm would not show up in any logs, because they were just printed to the stderr of the daemonized invocation here. The 'truncate' option is not used, so that the log is not immediately lost when a new instance is started. This increases the chance that the relevan

[pve-devel] [PATCH qemu-server 2/2] swtpm: use start time as prefix for logging

2023-01-18 Thread Fiona Ebner
to be able to distinguish different invocations. Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 97d60e2d..e6aa62eb 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -3252

[pve-devel] [PATCH-SERIES swtpm/qemu-server] Improve swtpm logging

2023-01-18 Thread Fiona Ebner
There was a recent failure when migrating a production VM > kvm: tpm-emulator: Setting the stateblob (type 1) failed with a TPM error 0x3 > a parameter is bad > kvm: error while loading state for instance 0x0 of device 'tpm-emulator' > kvm: load of migration failed: Input/output error and it's not

[pve-devel] [PATCH swtpm 1/1] control channel: add error logs upon receiving short input

2023-01-18 Thread Fiona Ebner
There was a recent failure when migrating a production VM > kvm: tpm-emulator: Setting the stateblob (type 1) failed with a TPM error 0x3 > a parameter is bad > kvm: error while loading state for instance 0x0 of device 'tpm-emulator' > kvm: load of migration failed: Input/output error and it's not

Re: [pve-devel] [PATCH v2 firewall 1/1] api: Add optional parameters `since` and `until` for timestamp filter

2023-01-18 Thread Wolfgang Bumiller
On Wed, Jan 11, 2023 at 02:32:19PM +0100, Christian Ebner wrote: > The optional unix epoch timestamps parameters `since` and `until` are > introduced > in order to filter firewall logs files. If one of these flags is set, also > rotated logfiles are included. This is handled in the `dump_fw_logfil

[pve-devel] applied: [PATCH v2 common 1/1] tools: Add callback based filtering for logfile dump

2023-01-18 Thread Wolfgang Bumiller
applied this one, some nits in the other one ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] api: apt: versions: add proxmox-mail-forward to package list

2023-01-18 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH qemu-server v3] fix #4378: standardized error for ovmf files

2023-01-18 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC manager] vzdump: exclude zfs control dirs by default

2023-01-18 Thread Fabian Grünbichler
On January 17, 2023 3:07 pm, Stoiko Ivanov wrote: > Thanks for tackling this and providing the patch > > LGTM code-wise and I think the potential for regression should be pretty > small (plus users who want this can always adapt the vzdump invocation). > > small nit on the commit-message: > > On