[pve-devel] applied: [PATCH manager v2] ui: storage backup view: Update remove button on protection change

2023-01-19 Thread Thomas Lamprecht
Am 19/01/2023 um 10:56 schrieb Christoph Heiss: > Currently this works in the backup view for containers/VMs, but not in > the storage backup view. Implement that for the latter part too. > > Uses the callback functionality of the load() method of the store to > properly update the UI as soon as t

Re: [pve-devel] [RFC PATCH manager 5/5] ui: ScheduleSimulator: add UTC checkbox

2023-01-19 Thread Thomas Lamprecht
Am 18/01/2023 um 15:35 schrieb Dominik Csapak: > that displays the simulated times in UTC instead of the local timezone > Only takes effect on the next click of 'Simulate' > > Signed-off-by: Dominik Csapak > --- > wanted to make it clearer that the time is the Local timezone by default, > not sur

[pve-devel] applied: [PATCH manager 2/5] ui: BackupView: add scrolling overflow handler for the toolbar

2023-01-19 Thread Thomas Lamprecht
Am 18/01/2023 um 15:35 schrieb Dominik Csapak: > since we already have many elements here, and in our minimal resolution > of 1280x720 we don't see all elements any more. > > reported in the forum: > https://forum.proxmox.com/threads/web-forms-extend-beyond-web-page-window-in-some-cases.120714 Sa

[pve-devel] applied: [PATCH manager 3/5] ui: ScheduleSimulator: split date and time into two columns

2023-01-19 Thread Thomas Lamprecht
Am 18/01/2023 um 15:35 schrieb Dominik Csapak: > and align the time right. This makes it easier to compare times > > Signed-off-by: Dominik Csapak > --- > www/manager6/window/ScheduleSimulator.js | 20 > 1 file changed, 16 insertions(+), 4 deletions(-) > > applied, thanks!

[pve-devel] applied: [PATCH manager 1/5] ui: reduce default size of Backup detail window

2023-01-19 Thread Thomas Lamprecht
Am 18/01/2023 um 15:35 schrieb Dominik Csapak: > on our minimal display size (1280x720), using height 700 is too large > when considering that the browser + os also need some vertical space. > > For good measure, use a maximum of 600 pixels. Since the window is > resizable anyway, users with more

[pve-devel] [RFC container] fix: shutdown: if lxc-stop fails, wait for socket closing with timeout

2023-01-19 Thread Friedrich Weber
When trying to shutdown a hung container with `forceStop=0` (e.g. via the Web UI), the shutdown task may run indefinitely while holding a lock on the container config. The reason is that the shutdown subroutine waits for the LXC command socket to close, even if the `lxc-stop` command has failed due

[pve-devel] [PATCH proxmox-offline-mirror 1/2] fix #4445: mirror: subscription: add proxy support

2023-01-19 Thread Lukas Wagner
This commit adds support for HTTP proxies, configurable via the ALL_PROXY environment variable. For example: $ ALL_PROXY="localhost:3128" proxmox-offline-mirror mirror <...> Note: `ureq` seems to use HTTP CONNECT for *all* connections, including HTTP on port 80. Proxies need to be configured to

[pve-devel] [PATCH proxmox-offline-mirror 2/2] docs: document `ALL_PROXY` environment variable

2023-01-19 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- docs/command-syntax.rst | 3 +++ docs/offline-mirror.rst | 24 2 files changed, 27 insertions(+) diff --git a/docs/command-syntax.rst b/docs/command-syntax.rst index bd91d46..272e6bd 100644 --- a/docs/command-syntax.rst +++ b/docs/command

[pve-devel] [PATCH v3 firewall 1/1] api: Add optional parameters `since` and `until` for timestamp filter

2023-01-19 Thread Christian Ebner
The optional unix epoch timestamps parameters `since` and `until` are introduced in order to filter firewall logs files. If one of these flags is set, also rotated logfiles are included. This is handled in the `dump_fw_logfile` helper function. Filtering is now performed based on a callback functio

[pve-devel] [PATCH v3 firewall 0/1] Optional `since` and `until` firewall log filtering

2023-01-19 Thread Christian Ebner
This patch introduces 2 optional api parameters `since` and `until` to firewall log endpoints, in order to make them filterable. Filtering of the firewall logs is performed by a callback function. --- Changes since RFC version: - common: Use callback function filter instead of `since` `until` pa

[pve-devel] [PATCH manager v2] ui: storage backup view: Update remove button on protection change

2023-01-19 Thread Christoph Heiss
Currently this works in the backup view for containers/VMs, but not in the storage backup view. Implement that for the latter part too. Uses the callback functionality of the load() method of the store to properly update the UI as soon as the loading has finished. While at it, refactor the same th