Re: [pve-devel] [PATCH manager 1/2] GUI: efi disk: use correct version with aarch64

2023-01-20 Thread Matthias Heiserer
On 20.01.2023 14:17, Thomas Lamprecht wrote: Am 20/01/2023 um 13:56 schrieb Matthias Heiserer: On 18.01.2023 15:07, Thomas Lamprecht wrote: for subject: s/GUI/ui/ to better match the predominantly used one. Am 17/01/2023 um 13:17 schrieb Matthias Heiserer: Sets the EFI version to 2m when arch

Re: [pve-devel] [PATCH manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes with Yes/No text

2023-01-20 Thread Thomas Lamprecht
Am 20/01/2023 um 12:17 schrieb Lukas Wagner: > Consider this an RFC to maybe spark up a discussion about this. > > In our UI, we've been a bit inconsistent with the use of checkboxes/text > for `enabled` properties in table views. Looking through the UI, I've > found that the following UI element

Re: [pve-devel] [PATCH manager 2/2] GUI: efi disk: cleanup - var to const

2023-01-20 Thread Thomas Lamprecht
Am 20/01/2023 um 12:16 schrieb Matthias Heiserer: >> >> I'm not that huge fan of applying JavaScript's const broadly to non-scalar  >> values, >> as it's only a shallow constant and immutable; so no effect on array/object  >> member. > > I quite like const, especially with `const me = this`, becau

Re: [pve-devel] [PATCH manager] fix #3037: include the split_list to shell_qoute

2023-01-20 Thread Wolfgang Bumiller
On Fri, Jan 20, 2023 at 01:38:23PM +0100, Moayad Almalat wrote: > By including and using 'split_list' from PVE::Tools we can avoid the null > (\000) bytes in the shell_quote() function, in which the 'split_list' takes > a single argument, to return the array format. > Thanks wolfgang. > > Signed-o

Re: [pve-devel] [PATCH manager 1/2] GUI: efi disk: use correct version with aarch64

2023-01-20 Thread Thomas Lamprecht
Am 20/01/2023 um 13:56 schrieb Matthias Heiserer: > On 18.01.2023 15:07, Thomas Lamprecht wrote: >> for subject: s/GUI/ui/ to better match the predominantly used one. >> >> Am 17/01/2023 um 13:17 schrieb Matthias Heiserer: >>> Sets the EFI version to 2m when arch=aarch64. >>> >>> When the VM has ar

Re: [pve-devel] [PATCH manager 1/2] GUI: efi disk: use correct version with aarch64

2023-01-20 Thread Matthias Heiserer
On 18.01.2023 15:07, Thomas Lamprecht wrote: for subject: s/GUI/ui/ to better match the predominantly used one. Am 17/01/2023 um 13:17 schrieb Matthias Heiserer: Sets the EFI version to 2m when arch=aarch64. When the VM has arch=aarch64, creating an EFI disk failed with "Can't use an undefined

[pve-devel] [PATCH manager] fix #3037: include the split_list to shell_qoute

2023-01-20 Thread Moayad Almalat
By including and using 'split_list' from PVE::Tools we can avoid the null (\000) bytes in the shell_quote() function, in which the 'split_list' takes a single argument, to return the array format. Thanks wolfgang. Signed-off-by: Moayad Almalat --- PVE/CLI/pvesh.pm | 3 ++- 1 file changed, 2 inse

[pve-devel] [PATCH manager 1/2] ui: backup: replication: replace non-clickable checkbox with Yes/No text

2023-01-20 Thread Lukas Wagner
>From a usability view, having a checkbox that is not clickable is pretty misleading, especially if the visual style is exactly the same as in other places in the UI where the checkbox is functional. Signed-off-by: Lukas Wagner --- www/manager6/dc/Backup.js| 7 ++- www/manager6/grid/

[pve-devel] [PATCH widget-toolkit 2/2] repo view: replace non-clickable checkbox with Yes/No text

2023-01-20 Thread Lukas Wagner
>From a usability view, having a checkbox that is not clickable is pretty misleading, especially if the visual style is exactly the same as in other places in the UI where the checkbox is functional. Signed-off-by: Lukas Wagner --- src/node/APTRepositories.js | 7 +++ 1 file changed, 3 inser

[pve-devel] [PATCH manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes with Yes/No text

2023-01-20 Thread Lukas Wagner
Consider this an RFC to maybe spark up a discussion about this. In our UI, we've been a bit inconsistent with the use of checkboxes/text for `enabled` properties in table views. Looking through the UI, I've found that the following UI elements use a checkbox UI control to indicate wheter somethin

Re: [pve-devel] [PATCH manager 2/2] GUI: efi disk: cleanup - var to const

2023-01-20 Thread Matthias Heiserer
On 18.01.2023 15:03, Thomas Lamprecht wrote: Am 17/01/2023 um 13:17 schrieb Matthias Heiserer: Signed-off-by: Matthias Heiserer --- www/manager6/qemu/HDEfi.js | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/www/manager6/qemu/HDEfi.js b/www/manager6/qemu/HDEfi

[pve-devel] [PATCH qemu-server] Fixed spelling error

2023-01-20 Thread Noel Ullreich
fixed a small spelling and grammar error I stumbled over Signed-off-by: Noel Ullreich --- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index c87602d..587bb22 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -840,7

[pve-devel] [PATCH guest-common 2/2] replication: find common base: improve error when no common base snapshot exists

2023-01-20 Thread Fiona Ebner
Suggest an alternative solution by removing the problematic volumes from the replication target rather than the whole job. This is helpful if there are multiple replicated volumes to avoid the need to fully re-sync all volumes in many cases. Signed-off-by: Fiona Ebner --- src/PVE/Replication.pm

[pve-devel] [PATCH guest-common 1/2] replication: prepare: include volumes without snapshots in the result

2023-01-20 Thread Fiona Ebner
Note that PVE::Storage::volume_snapshot_info() will fail when a volume does not exist, so no non-existing volume will end up in the result (prepare() is only called with volumes that should exist). This makes it possible to detect a volume without snapshots in the result of prepare(), and as a con

Re: [pve-devel] [RFC PATCH manager 4/5] ui: ScheduleSimulator: add rownumberer column

2023-01-20 Thread Thomas Lamprecht
Am 18/01/2023 um 15:35 schrieb Dominik Csapak: > so it's clear what the first time is, for that we have to disable > sorting, since the rownumberer will not sort with it > > Signed-off-by: Dominik Csapak > --- > not sure if it's worth losing the sorting... IMO it isn't, if we would need to calcu

[pve-devel] applied: [PATCH manager] ui: fix search for 'Guests without Backup' window

2023-01-20 Thread Thomas Lamprecht
Am 20/01/2023 um 09:47 schrieb Lukas Wagner: > In JS, a `for (const a in <...>)` loop iterates over indices, not > over values. To iterate over values, `for (const a of <..>)` has > to be used. Furthermore, filtering by ID did not work properly, since > the property is called `vmid`, not `id`. see

[pve-devel] [PATCH manager] ui: fix search for 'Guests without Backup' window

2023-01-20 Thread Lukas Wagner
In JS, a `for (const a in <...>)` loop iterates over indices, not over values. To iterate over values, `for (const a of <..>)` has to be used. Furthermore, filtering by ID did not work properly, since the property is called `vmid`, not `id`. Signed-off-by: Lukas Wagner --- www/manager6/dc/Backup