On 1/23/23 16:58, Stefan Hanreich wrote:
This patch series introduces the pre/post/failed-snapshot hooks that run before/
after a snapshot is taken, or after failing to take a snapshot.
I used the new example script from pve-docs as template for my test hookscripts.
What I tested:
* Normal
This commit adds hooks to the snapshotting process, which can be used to
run additional setup scripts to prepare the VM for snapshotting.
Examples for use cases include:
- forcing processes to flush their writes
- blocking processes from writing
- altering the configuration of the VM to make
This patch series introduces the pre/post/failed-snapshot hooks that run before/
after a snapshot is taken, or after failing to take a snapshot.
I used the new example script from pve-docs as template for my test hookscripts.
What I tested:
* Normal snapshotting, without VM state, without
Added a section for each new snapshot hook to the example hookscript,
as well as a short comment explaining when the respective section gets
executed. Additionally added documentation for the different possible
values of the envvar PVE_SNAPSHOT_PHASE.
Signed-off-by: Stefan Hanreich
---
If one is not familiar with the underlying configuration option,
one might think that one can enable Wake-On-Lan for a node with this
option. It was not really clear (at least without RTFM ;) ) that a
MAC address is supposed to be entered here. The added text should
hopefully make this a bit more
The function to set the error mask expects the message as a string,
not the error object.
Signed-off-by: Fiona Ebner
---
www/manager6/dc/Cluster.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/dc/Cluster.js b/www/manager6/dc/Cluster.js
index
>From a usability view, having a checkbox that is not clickable is pretty
misleading, especially if the visual style is exactly the same as in
other places in the UI where the checkbox is functional.
Signed-off-by: Lukas Wagner
---
src/Utils.js| 6 ++
In our UI, we've been a bit inconsistent with the use of checkboxes/text
for `enabled` properties in table views. Looking through the UI, I've
found that the following UI elements use a checkbox UI control to
indicate wheter something is enabled or not:
* backup job overview
* APT repository
>From a usability view, having a checkbox that is not clickable is pretty
misleading, especially if the visual style is exactly the same as in
other places in the UI where the checkbox is functional.
Signed-off-by: Lukas Wagner
---
www/manager6/dc/Backup.js| 11 ++-
which also makes it distinguishable from the other
"qemu_savevm_state_iterate error" message.
Signed-off-by: Fiona Ebner
---
...17-PVE-add-savevm-async-for-background-state-snapshots.patch | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 1/23/23 11:57, Thomas Lamprecht wrote:
Ok, tbh. I have some faint memory that I saw some comment about this in the
distant past; IIRC it was mostly due to the the "writeable" firewall and the
"read-only" other usages using both the exact same display.
My bad, there actually was a report
Am 23/01/2023 um 11:46 schrieb Lukas Wagner:
> On 1/20/23 15:09, Thomas Lamprecht wrote:
>>> While looking sleek, the problem with this is that from a user's
>>> perspective, a checkbox generally implies that it is operable by
>>> clicking on it (which we allow in other places, to make the matter
On 1/20/23 15:09, Thomas Lamprecht wrote:
While looking sleek, the problem with this is that from a user's
perspective, a checkbox generally implies that it is operable by
clicking on it (which we allow in other places, to make the matter even
more confusing).
If it's editable it gets a
Am 20/01/2023 um 12:14 schrieb Noel Ullreich:
> fixed a small spelling and grammar error I stumbled over
>
> Signed-off-by: Noel Ullreich
> ---
> PVE/API2/Qemu.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
___
In the web UI, this was fixed years ago by pve-manager commit c11c4a40
("fix #1631: change units to binary prefix").
Quickly checked with the 'query-memory-size-summary' QMP command that
this is actually the case.
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 4 ++--
1 file changed, 2
Based to the suggestion of Wolfgang, in regard to `split_list()`,
I converted the `split_list()` to `split(/\0/, $param->{$key});`
this will split the `$param->{$key}` null characters and push each
element to the `$args` array along with the key value.
changes since v1:
* get rid of the
by simply doing a ping with the expected port as a fallback when the
rpcinfo command fails.
The timeout was chosen to be 2 seconds, because that's what the
existing callers of tcp_ping() in the iSCSI and GlusterFS plugins use.
Alternatively, the existing check could be replaced, but that would
17 matches
Mail list logo
