Re: [pve-devel] ceph 16.2.11 released!

2023-01-27 Thread Thomas Lamprecht
Am 26/01/2023 um 16:13 schrieb DERUMIER, Alexandre: > It could be great to update the proxmox repo. > > (It have an important fix on pglogs bug that I have triggered multiple > times) FYI, 16.2.11-pve1 is now available on our pacific test repository: https://pve.proxmox.com/wiki/Package_Reposito

Re: [pve-devel] [PATCH v2 qemu-server 6/9] memory: use 64 slots && static dimm size when max is defined

2023-01-27 Thread DERUMIER, Alexandre
> > Question about the existing code: The loops below can count up to > $dimm_id 255, but in the commit message you say that there are at > most > 255 slots (so the highest ID is 254?). But yeah, it only becomes > relevant when going all the way to approximately 4 TiB. yes, the max slot is 255 (id

Re: [pve-devel] [PATCH v2 qemu-server 5/9] memory: get_max_mem: use config memory max

2023-01-27 Thread DERUMIER, Alexandre
Le mardi 24 janvier 2023 à 14:05 +0100, Fiona Ebner a écrit : > > +my $check_memory_param = sub { > > +    my ($conf, $param) = @_; > > + > > +    my $mem = parse_memory($param->{memory}); > > +    my $host_max_mem = get_host_max_mem($conf); > > + > > +    if ($mem->{max}) { > > +   die "memory

Re: [pve-devel] [PATCH v2 qemu-server 4/9] config: memory: add 'max' option

2023-01-27 Thread DERUMIER, Alexandre
> > > +    # skip non hotpluggable value > > +    if (safe_num_ne($newmem->{max}, $oldmem->{max})) { > > +   die "skip\n"; > > +    } > > Please move this to the call sites. The "die "skip""-logic should not > cross function boundaries. > > Just a note: This is exactly how it's done on nic

Re: [pve-devel] Script for bug #2874

2023-01-27 Thread Fiona Ebner
Am 27.01.23 um 14:49 schrieb Fiona Ebner: The attached script allows monitoring the first sector of the bootdisk for running VMs (all or a selection of IDs) for people affected by bug #2874 [0]. The hope is to pinpoint when the sector gets corrupted to be able to correlate the timing with operati

[pve-devel] Script for bug #2874

2023-01-27 Thread Fiona Ebner
The attached script allows monitoring the first sector of the bootdisk for running VMs (all or a selection of IDs) for people affected by bug #2874 [0]. The hope is to pinpoint when the sector gets corrupted to be able to correlate the timing with operations that might cause it. The script also dum

Re: [pve-devel] [PATCH firewall 4/4] config: combine group/ipset and their comments

2023-01-27 Thread Wolfgang Bumiller
On Thu, Jan 26, 2023 at 03:30:19PM +0100, Leo Nunner wrote: > This patch restructures the parsed config structure a bit to be more > consistent across objects. > > group_comments and ipset_comments were removed from the config structure > and are now stored directly within the group/ipset objects

Re: [pve-devel] [PATCH v3 widget-toolkit 1/2] repo view: replace non-clickable checkbox with icons

2023-01-27 Thread Lukas Wagner
Thank you for your input! On 1/27/23 12:09, Dominik Csapak wrote: i know i'm a bit late to the party, but couldn't we simply show nothing when a repo is not enabled? it's greyed-out anyway (though i'm not opposed to using the 'minus' icon here either) I have considered this option as well.

Re: [pve-devel] [PATCH v3 widget-toolkit 1/2] repo view: replace non-clickable checkbox with icons

2023-01-27 Thread Dominik Csapak
On 1/26/23 11:47, Lukas Wagner wrote: From a usability view, having a checkbox that is not clickable is pretty misleading, especially if the visual style is exactly the same as in other places in the UI where the checkbox is functional. Signed-off-by: Lukas Wagner --- src/Utils.js

Re: [pve-devel] applied-series: [PATCH proxmox-offline-mirror 1/2] fix #4445: mirror: subscription: add proxy support

2023-01-27 Thread Lukas Wagner
Thanks for reviewing my patch! On 1/27/23 11:25, Fabian Grünbichler wrote: I wonder how much work it would be to change that upstream? IIRC we also contributed HTTPS_PROXY support to ureq, and this is not the only place where we use it and want proper proxy support.. I'll check once I find th

Re: [pve-devel] [PATCH firewall 1/4] api: factor out renaming parameters to more descriptive names

2023-01-27 Thread Wolfgang Bumiller
On Thu, Jan 26, 2023 at 03:30:16PM +0100, Leo Nunner wrote: > Signed-off-by: Leo Nunner > --- > src/PVE/API2/Firewall/Aliases.pm | 20 ++-- > src/PVE/API2/Firewall/Groups.pm | 53 > src/PVE/API2/Firewall/IPSet.pm | 39 --- > 3 files

Re: [pve-devel] [PATCH manager] fix 4481: fetch changelogs for any Proxmox repository

2023-01-27 Thread Fabian Grünbichler
On January 18, 2023 2:54 pm, Leo Nunner wrote: > This patch fixes the issue that when the user supplied any non-standard > repositories, the changelogs often wouldn't load. For example, providing > both pve-no-subscription and pbs-no-subscription broke the changelog > API, since the URL built for p

[pve-devel] applied-series: [PATCH proxmox-offline-mirror 1/2] fix #4445: mirror: subscription: add proxy support

2023-01-27 Thread Fabian Grünbichler
On January 19, 2023 11:40 am, Lukas Wagner wrote: > This commit adds support for HTTP proxies, configurable via the > ALL_PROXY environment variable. > > For example: > $ ALL_PROXY="localhost:3128" proxmox-offline-mirror mirror <...> > > Note: `ureq` seems to use HTTP CONNECT for *all* connecti

[pve-devel] [PATCH widget-toolkit/manager] fix focus/tbar selection issues in ComboGrid

2023-01-27 Thread Dominik Csapak
these two patches fix two issues regarding the combobox and the ComboBoxSetStoreNode. The widget-toolkit patch is necessary to avoid glitches after the second patch, but independently fixes also the behaviour described in that commit message. proxmox-widget-toolkit: Dominik Csapak (1): ComboGri

[pve-devel] [PATCH manager 1/1] ui: ComboBoxSetStoreNode: don't hide the picker when clicking the toolbar

2023-01-27 Thread Dominik Csapak
When clicking the toolbar of the ComboGrid, the combobox loses focus, and instantly hides the picker. To prevent that, we keep track of the mousedown event on the toolbar (which happily comes before the focusLeave event), and prevent the focusLeave propagation in that case. Then on mouseup, we fo

[pve-devel] [PATCH widget-toolkit 1/1] ComboGrid: avoid needing two clicks after reselecting an item

2023-01-27 Thread Dominik Csapak
'picker.hide()' hides the picker, but does not do everything to properly keep track of the picker state in the combobox class. This lead to a bug when we reselected an entry, we had to click the picker again twice to open it again. Use the 'collapse' method of the combobox instead, which does the

[pve-devel] applied: [PATCH v3 firewall 1/1] api: Add optional parameters `since` and `until` for timestamp filter

2023-01-27 Thread Wolfgang Bumiller
applied, but with a little fixup, see below On Thu, Jan 19, 2023 at 11:25:04AM +0100, Christian Ebner wrote: > The optional unix epoch timestamps parameters `since` and `until` are > introduced > in order to filter firewall logs files. If one of these flags is set, also > rotated logfiles are inc

[pve-devel] applied: [PATCH qemu] add patch to fix issue with VirtIO disk using detect-zeroes=unmap

2023-01-27 Thread Thomas Lamprecht
Am 27/01/2023 um 09:13 schrieb Fiona Ebner: > Affects Proxmox VE, when the discard disk setting is used for a > VirtIO disk. > > Upstream bug report: > https://gitlab.com/qemu-project/qemu/-/issues/1404 > > Signed-off-by: Fiona Ebner > --- > ...-zeroes-with-BDRV_REQ_REGISTERED_BUF.patch | 36 ++

[pve-devel] applied: [PATCH qemu-server] close #2792: allow online migration with replicated snapshots

2023-01-27 Thread Fabian Grünbichler
On January 18, 2023 2:52 pm, Fiona Ebner wrote: > Since commit 9b6efe43 ("migrate: add live-migration of replicated > disks") live-migration with replicated volumes is possible. When > handling the replication, it is checked that all local volumes > previously detected as replicatable are actually

Re: [pve-devel] ceph 16.2.11 released!

2023-01-27 Thread Thomas Lamprecht
Am 26/01/2023 um 16:13 schrieb DERUMIER, Alexandre: > Hi, > > ceph 16.2.11 has been finally released after 6 months. > > (Their CI cluster was broken since 3 months, rhev + glusterfs ^_^) yeah I also followed the 16.2.x release story relatively closesly.. x) > > It could be great to update t

[pve-devel] [PATCH qemu] add patch to fix issue with VirtIO disk using detect-zeroes=unmap

2023-01-27 Thread Fiona Ebner
Affects Proxmox VE, when the discard disk setting is used for a VirtIO disk. Upstream bug report: https://gitlab.com/qemu-project/qemu/-/issues/1404 Signed-off-by: Fiona Ebner --- ...-zeroes-with-BDRV_REQ_REGISTERED_BUF.patch | 36 +++ debian/patches/series