[pve-devel] [PATCH manager v2 5/6] ui: add window for changing tree related options

2023-02-02 Thread Dominik Csapak
such as the sorting/grouping of guests. saves them in the browser local storage under 'pve-tree-sorting' adds a button for it next to the the view selector Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 + www/manager6/Workspace.js | 26 +++-

[pve-devel] [PATCH manager v2 2/6] ui: remove unused booleanfield

2023-02-02 Thread Dominik Csapak
it's not used anymore, does not belong into pve-manager (rather in proxmox-widget-toolkit), does not have a proper alias. it's simple enough to recreate should we ever need it again Signed-off-by: Dominik Csapak --- www/manager6/Makefile| 1 - www/manager6/form/Boolean.js | 10

[pve-devel] [PATCH manager v2 4/6] ui: refactor refreshing the the resource store/tree

2023-02-02 Thread Dominik Csapak
we'll need it elsewhere too, and it was rather hidden in the updateTagSettings call. Signed-off-by: Dominik Csapak --- www/manager6/UIOptions.js | 13 - www/manager6/dc/OptionView.js | 1 + 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/www/manager6/UIOptions.js

[pve-devel] [PATCH manager v2 1/6] ui: remove 'Storage View'

2023-02-02 Thread Dominik Csapak
it is basically the 'Server View' but with less content, and has often times lead to confusion when uses accidentally selected it. Signed-off-by: Dominik Csapak --- www/manager6/form/ViewSelector.js | 7 --- 1 file changed, 7 deletions(-) diff --git a/www/manager6/form/ViewSelector.js

[pve-devel] [PATCH manager v2 3/6] ui: refactor ui option related methods into UIOptions

2023-02-02 Thread Dominik Csapak
a new singleton like Utils/Parser, intended for holding stuff for ui options, such as the tag settings/overrides no behavioural change intended Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 + www/manager6/UIOptions.js | 92

[pve-devel] [PATCH manager v2 6/6] fix #1408: ui: ResourceTree: sort the tree according to tree-sorting options

2023-02-02 Thread Dominik Csapak
Considers the newly added options from browser local storage. We have to save the last sorting mechanism there, so we can detect if it changes and trigger the movement/text changes (otherwise the tree nodes won't be updated/moved) Signed-off-by: Dominik Csapak --- www/manager6/UIOptions.js

[pve-devel] [PATCH manager v2 0/6] fix #1408: ui: make tree sorting configurable

2023-02-02 Thread Dominik Csapak
this series allows configuring the sorting of the resource tree options are the sort-field, if guest types are grouped and if templates are grouped seperately. it's configurable via browser local storage the first 2 patches are not really related but popped up during development changes from

Re: [pve-devel] [PATCH storage manager docs] Allow mounting of CIFS subdirectories

2023-02-02 Thread Leo Nunner
On 2022-12-01 12:32, Leo Nunner wrote: > CIFS supports mounting subdirectories inside a share, so it makes sense > to also have the 'subdir' parameter for the CIFS backend. I'm also > looking into allowing overrides for all the fixed directories, but > even then, I think it makes sense to support

Re: [pve-devel] [PATCH manager 2/3] ui: add TreeSortingEdit window

2023-02-02 Thread Dominik Csapak
On 2/2/23 11:56, Thomas Lamprecht wrote: looks like going in the right direction and feasible, some comments inline high level: subject is using module name 1:1, as mentioned a few times please avoid that, for ~ 99.9% cases it's not useful, for sure not for d/changelog but not really for other

[pve-devel] [PATCH manager] gui: expose content-dirs property in storage edit/create

2023-02-02 Thread Leo Nunner
Add a separate tab for the storage edit/create panels to set the recently introduced "content-dirs" property which overrides the default directory locations. Analogous to the API implementation, the tab was added for Directory, CIFS and NFS storages. Signed-off-by: Leo Nunner --- RFC: something

[pve-devel] [PATCH v3 qemu-server 11/13] memory: add virtio-mem support

2023-02-02 Thread Alexandre Derumier
a 4GiB static memory is needed for DMA+boot memory, as this memory is almost always un-unpluggeable. 1 virtio-mem pci device is setup for each numa node on pci.4 bridge virtio-mem use a fixed blocksize with 32000 blocks Blocksize is computed from the maxmemory-4096/32000 with a minimum of 2MiB

[pve-devel] [PATCH v3 qemu-server 13/13] tests: add virtio-mem tests

2023-02-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- test/cfg2cmd/memory-virtio-hugepages-1G.conf | 12 +++ .../memory-virtio-hugepages-1G.conf.cmd | 35 +++ test/cfg2cmd/memory-virtio-max.conf | 11 ++ test/cfg2cmd/memory-virtio-max.conf.cmd | 35

[pve-devel] [PATCH v3 qemu-server 10/13] test: add memory-max tests

2023-02-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- test/cfg2cmd/memory-max-128G.conf | 11 test/cfg2cmd/memory-max-128G.conf.cmd | 86 +++ test/cfg2cmd/memory-max-512G.conf | 11 test/cfg2cmd/memory-max-512G.conf.cmd | 58 ++ 4 files changed, 166

[pve-devel] [PATCH v3 qemu-server 09/13] memory: use 64 slots && static dimm size when max is defined

2023-02-02 Thread Alexandre Derumier
default kernel vhost config only support 64 slots by default, for performance since 2015. Original memory hotplug code was done before, using qemu max supported 255 slots. To reach max mem (4TB), we used incremental dimm size. Instead of dynamic memory size, use 1 static dimm size, compute from

[pve-devel] [PATCH v3 qemu-server 04/13] add memory parser

2023-02-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Qemu.pm | 14 +-- PVE/QemuConfig.pm | 4 +- PVE/QemuMigrate.pm| 6 ++- PVE/QemuServer.pm | 27 +++--- PVE/QemuServer/Helpers.pm | 3 +- PVE/QemuServer/Memory.pm | 78

[pve-devel] [PATCH v3 qemu-server 07/13] memory: get_max_mem: use config memory max

2023-02-02 Thread Alexandre Derumier
verify than defined vm memorymax is not bigger than host cpu supported memory Add add early check in update vm api Signed-off-by: Alexandre Derumier --- PVE/API2/Qemu.pm | 46 +--- PVE/QemuServer/Memory.pm | 19 - 2 files changed, 47

[pve-devel] [PATCH v3 qemu-server 08/13] memory: don't use foreach_reversedimm for unplug

2023-02-02 Thread Alexandre Derumier
simple use dimm_list() returned by qemu Signed-off-by: Alexandre Derumier --- PVE/QemuServer/Memory.pm | 73 1 file changed, 22 insertions(+), 51 deletions(-) diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm index b5f1076..bcf5f95 100644

[pve-devel] [PATCH v3 qemu-server 03/13] qemu_memory_hotplug: remove unused $opt arg

2023-02-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm| 4 ++-- PVE/QemuServer/Memory.pm | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index e4d1a70..a0e16dc 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -5046,7

[pve-devel] [PATCH v3 qemu-server 02/13] tests: add memory tests

2023-02-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- test/cfg2cmd/memory-hotplug-hugepages.conf| 12 ++ .../cfg2cmd/memory-hotplug-hugepages.conf.cmd | 62 +++ test/cfg2cmd/memory-hotplug.conf | 11 ++ test/cfg2cmd/memory-hotplug.conf.cmd | 174 ++

[pve-devel] [PATCH v3 qemu-server 12/13] memory: virtio-mem : implement redispatch retry.

2023-02-02 Thread Alexandre Derumier
If some memory can be removed on a specific node, we try to rebalance again on other nodes Signed-off-by: Alexandre Derumier --- PVE/QemuServer/Memory.pm | 54 ++-- 1 file changed, 36 insertions(+), 18 deletions(-) diff --git a/PVE/QemuServer/Memory.pm

[pve-devel] [PATCH v3 qemu-server 06/13] config: memory: add 'max' option

2023-02-02 Thread Alexandre Derumier
max can be multiple of 64GiB only, The dimm size is compute from the max memory we can have 64 slots: 64GiB = 64 slots x 1GiB 128GiB = 64 slots x 2GiB .. 4TiB = 64 slots x 64GiB Also, with numa, we need to share slot between (up to 8) sockets. 64 is a multiple of 8, 64GiB = 8 sockets * 8

[pve-devel] [PATCH v3 qemu-server 05/13] memory: add get_static_mem && remove parse_hotplug_features

2023-02-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm| 5 ++-- PVE/QemuServer/Memory.pm | 51 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 17ecd63..9db1d8e 100644 ---

[pve-devel] [PATCH v3 qemu-server 00/13] rework memory hotplug + virtiomem

2023-02-02 Thread Alexandre Derumier
This patch series rework the current memory hotplug + virtiomem. memory option now have extra options: memory: [[current=]] [,max=] [,virtio=<1|0>] ex: memory: current=1024,max=131072,virtio=1 patches 1-4: add a memory parser patches 5-10: add the max option with 64 static dimm hotplug for

[pve-devel] [PATCH v3 qemu-server 01/13] memory: extract some code to their own sub for mocking

2023-02-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/QemuServer/Memory.pm | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm index 3eb1c7c..5a7c1b7 100644 --- a/PVE/QemuServer/Memory.pm +++

Re: [pve-devel] [PATCH manager 2/3] ui: add TreeSortingEdit window

2023-02-02 Thread Thomas Lamprecht
looks like going in the right direction and feasible, some comments inline high level: subject is using module name 1:1, as mentioned a few times please avoid that, for ~ 99.9% cases it's not useful, for sure not for d/changelog but not really for other devs in `git log` (sorting trees can mean

Re: [pve-devel] [PATCH manager 1/3] ui: Utils: refactor refreshing the the resource store/tree

2023-02-02 Thread Thomas Lamprecht
Am 01/02/2023 um 16:49 schrieb Dominik Csapak: > we'll need it elsewhere too, and it was rather hidden in the > updateTagSettings call. > > Signed-off-by: Dominik Csapak > --- > www/manager6/Utils.js | 3 +++ > www/manager6/dc/OptionView.js | 1 + > 2 files changed, 4 insertions(+) > >

[pve-devel] [PATCH novnc 0/3] upgrade to v1.4.0

2023-02-02 Thread Markus Frank
For this patch-series please update the mirror and the submodule. Markus Frank (3): replaced check for VERSION file with check for package.json upgrade novnc and patches to 1.4.0 bump version to 1.4.0-1 Makefile | 2 +- debian/changelog

[pve-devel] [PATCH novnc 2/3] upgrade novnc and patches to 1.4.0

2023-02-02 Thread Markus Frank
rebase patches for 1.4.0 Signed-off-by: Markus Frank --- .../0001-add-PVE-specific-JS-code.patch | 39 +- ...002-add-custom-fbresize-event-on-rfb.patch | 15 ++-- ...nge-scaling-when-toggling-fullscreen.patch | 9 ++- debian/patches/0004-add-pve-style.patch | 15 ++--

[pve-devel] [PATCH novnc 1/3] replaced check for VERSION file with check for package.json

2023-02-02 Thread Markus Frank
Signed-off-by: Markus Frank --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 4f64bbe..9591e35 100644 --- a/Makefile +++ b/Makefile @@ -34,7 +34,7 @@ ${DSC}: ${BUILDDIR} .PHONY: submodule submodule: - test -f "${SRCDIR}/VERSION"

[pve-devel] [PATCH novnc 3/3] bump version to 1.4.0-1

2023-02-02 Thread Markus Frank
Signed-off-by: Markus Frank --- debian/changelog | 8 1 file changed, 8 insertions(+) diff --git a/debian/changelog b/debian/changelog index 04939cd..e8cb27c 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,11 @@ +novnc-pve (1.4.0-1) bullseye; urgency=medium + + *