[pve-devel] minor typo zfs -> zpool

2023-02-10 Thread Roland via pve-devel
--- Begin Message --- good evening, in https://github.com/proxmox/pve-installer/blob/master/proxinstall there is syscmd("zpool set bootfs=$zfspoolname/ROOT/$zfsrootvolname $zfspoolname") == 0 || die "zfs set bootfs failed\n"; that should have been: die "zpool set boofs failed\n"; regards rol

[pve-devel] [PATCH qemu-server 4/4] fix #4525: clone disk: disallow mirror if it might cause problems with io_uring

2023-02-10 Thread Fiona Ebner
The target of the drive-mirror operation is opened with (essentially) the same flags as the source in QEMU, in particular whether io_uring should be used is inherited. But io_uring currently causes problems in combination with certain storage types, sometimes even leading to crashes (LVM with Linu

[pve-devel] [PATCH qemu-server 3/4] drive commandline: factor out determining direct cache usage into helper

2023-02-10 Thread Fiona Ebner
In preparation to re-use it for a check for live disk cloning. Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 10d29a06..d4b1a984 100644 --- a/PVE/QemuServer.

[pve-devel] [PATCH qemu-server 2/4] drive commandline: factor out checks if io_uring is allowed by default

2023-02-10 Thread Fiona Ebner
while getting rid of the double negation. In preparation to re-use the check for live disk cloning. Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 6

[pve-devel] [PATCH qemu-server 1/4] hotplug: disk: mark aio as non-hotpluggable

2023-02-10 Thread Fiona Ebner
Previously, changing aio would be applied to the configuration, but the drive would still be using the old setting. Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index a0e16dcd..6130fe8

[pve-devel] [PATCH qemu 2/2] d/rules: add note explaining why using noopt doesn't currenlty work

2023-02-10 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- debian/rules | 3 +++ 1 file changed, 3 insertions(+) diff --git a/debian/rules b/debian/rules index 7fa9911..e69ba47 100755 --- a/debian/rules +++ b/debian/rules @@ -29,6 +29,9 @@ BUILDDIR=build CFLAGS = -Wall +# FIXME: There is a second -02 added because of

[pve-devel] [PATCH qemu 1/2] d/rules: add missing export for CFLAGS

2023-02-10 Thread Fiona Ebner
Otherwise, they don't affect the build of QEMU at all. Signed-off-by: Fiona Ebner --- debian/rules | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/rules b/debian/rules index 6d5f882..7fa9911 100755 --- a/debian/rules +++ b/debian/rules @@ -35,6 +35,8 @@ else CFLAGS += -O2 e