Re: [pve-devel] [RFC OPTIONAL pve-cluster 1/1] add arcsize to rrd

2023-03-15 Thread DERUMIER, Alexandre
Hi, > > > +++ b/debian/pve-cluster.postinst > > > @@ -0,0 +1,6 @@ > > > +#!/bin/bash > > > + > > > +RRD_DB="/var/lib/rrdcached/db/pve2-node/`hostname`" > > > +if [ -f $RRD_DB ] && [ `rrdtool info $RRD_DB | grep -q arcsize` > > > ]; then > > > +    rrdtool tune $RRD_DB 'DS:arcsize:GAUGE:120:0

[pve-devel] applied: [PATCH manager v5 0/3] Ceph OSD: add detail infos

2023-03-15 Thread Thomas Lamprecht
Am 12/12/2022 um 13:14 schrieb Aaron Lauterer: > This patch series adds 2 new API endpoints for OSDs to fetch more > detailed information about a single OSD. One for overall information and > one for a single volume (block, db, wal). > > More in the actual patches. > > Series got [0]: > Reviewed-

[pve-devel] applied-series: [PATCH-SERIES manager] improve bulk action permissions

2023-03-15 Thread Thomas Lamprecht
Am 01/03/2023 um 15:22 schrieb Fiona Ebner: > In the UI, fix the checks to use the same permission as the backend, > i.e. VM.PowerMgmt rather than Sys.PowerMgmt. > > In the backend, also allow the bulk action when the user has the > appropriate permission for each guest in the passed-in list. > >

[pve-devel] applied: [PATCH manager] ui: don't show tags/lock column in pool member grid

2023-03-15 Thread Thomas Lamprecht
Am 15/03/2023 um 16:30 schrieb Dominik Csapak: > we use a different api call where we currently don't have the tags or > lock, so don't add the columns there > > Signed-off-by: Dominik Csapak > --- > we could also add these in the api call, or use the resource grid as > source for the grid (not n

[pve-devel] [PATCH proxmox-widget-toolkit 1/4] toolkit/utils: set SameSite attr of auth cookie to 'strict'

2023-03-15 Thread Max Carrara
Overrides 'Ext.util.Cookies', optionally allowing the SameSite attribute of cookies to be defined. Using this override, the SameSite attribute of the auth cookie is now set to 'strict', prohibiting the cookie from being sent along in cross-site sub-requests or when the user navigates to a different

[pve-devel] [PATCH proxmox-widget-toolkit 2/4] toolkit/utils: fix whitespace

2023-03-15 Thread Max Carrara
Signed-off-by: Max Carrara --- NOTE: This patch only fixes some whitespace and can therefore be dropped if not necessary. src/Toolkit.js | 480 - src/Utils.js | 2 +- 2 files changed, 241 insertions(+), 241 deletions(-) diff --git a/src/Tool

[pve-devel] [PATCH http-server 3/4] formatter/bootstrap: set SameSite attr of auth cookie to 'strict'

2023-03-15 Thread Max Carrara
This prohibits the cookie from being sent along in cross-site sub-requests or when the user navigates to a different site. Signed-off-by: Max Carrara --- src/PVE/APIServer/Formatter.pm | 2 +- src/PVE/APIServer/Formatter/Bootstrap.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletion

[pve-devel] [PATCH widget-toolkit/http-server/apiclient 0/4] Set SameSite=Strict on Auth Cookies

2023-03-15 Thread Max Carrara
This series sets the `SameSite` attribute of authentication cookies to `Strict` as per RFC 6265[1]. This prevents browsers from nagging; for example, FireFox 102.8.0esr would complain in the following manner: > Cookie “PVEAuthCookie” does not have a proper “SameSite” attribute > value. Soon, cook

[pve-devel] [PATCH apiclient 4/4] lwp: set SameSite attr of auth cookie to 'strict'

2023-03-15 Thread Max Carrara
This prohibits the cookie from being sent along in cross-site sub-requests or when the user navigates to a different site. Signed-off-by: Max Carrara --- PVE/APIClient/LWP.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/APIClient/LWP.pm b/PVE/APIClient/LWP.pm index ed7

[pve-devel] [PATCH docs] html conf: add support for a dark mode in the documentation

2023-03-15 Thread Stefan Sterz
this commit adds support for a dark theme that behaves similarly to that one used by the api viewer. Signed-off-by: Stefan Sterz --- asciidoc/pve-html.conf | 4 1 file changed, 4 insertions(+) diff --git a/asciidoc/pve-html.conf b/asciidoc/pve-html.conf index 8a089d3..99b767d 100644 --- a/

[pve-devel] [PATCH widget-toolkit 1/1] dark-theme: add a dark theme for the asciidoc-based documentation

2023-03-15 Thread Stefan Sterz
this commit adds a css file to the proxmox-widget-toolkit-dev package that makes it possible for pve and pmg docs to use a dark theme Signed-off-by: Stefan Sterz --- debian/proxmox-widget-toolkit-dev.install| 1 + src/proxmox-dark/Makefile| 12 +- src/proxmox-dark/scss

[pve-devel] [PATCH widget-toolkit 0/1] Proxmox Dark Theme - AsciiDoc

2023-03-15 Thread Stefan Sterz
this series add a dark theme for the asciidoc-based documentation for pve and pmg. first it adds a new css dependency to the proxmox-widget-toolkit-dev package. then the following two commits, one for pve and for pmg each, uses that css file to add a dark theme to the respective documentation. it b

[pve-devel] [PATCH manager] ui: don't show tags/lock column in pool member grid

2023-03-15 Thread Dominik Csapak
we use a different api call where we currently don't have the tags or lock, so don't add the columns there Signed-off-by: Dominik Csapak --- we could also add these in the api call, or use the resource grid as source for the grid (not needing an api call at all), but for now this seems to be the

[pve-devel] [PATCH guest-common] fix #4572: config: also update volume IDs in pending section

2023-03-15 Thread Fiona Ebner
The method is intended to be used in cases where the volumes actually got renamed (e.g. migration). Thus, updating the volume IDs should of course also be done for pending changes to avoid changes referring to now non-existent volumes or even the wrong existing volume. Signed-off-by: Fiona Ebner

Re: [pve-devel] [PATCH qemu-server 1/2] fix #4068: implement support for fw_cfg

2023-03-15 Thread Wolfgang Bumiller
On Wed, Mar 01, 2023 at 10:12:26AM +0100, Leo Nunner wrote: > Implements support for passing values to the fw_cfg argument for QEMU. > If the value looks like a file, the backend checks for the correct > permissions/path and if everything is right, includes it as a file > instead of as a string. >

[pve-devel] [PATCH guest-common] vzdump: config: improve description of ionice setting

2023-03-15 Thread Fiona Ebner
The CFQ scheduler was removed with Linux 5.0 and ionice is now used by the newer BFQ scheduler. Mention what the special value 8 does. Also mention that for snapshot and suspend mode backups of VMs, the setting only affects the compressor, because the kvm process is not a child process of vzdump th

[pve-devel] [PATCH docs] backup: update information about performance settings

2023-03-15 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- vzdump.adoc | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/vzdump.adoc b/vzdump.adoc index ce46529..26bbe2b 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@ -214,11 +214,12 @@ the behaviour for catching up. By enabling the `Repeat miss

[pve-devel] [PATCH manager] close #4513: ui: backup job: add performance tab

2023-03-15 Thread Fiona Ebner
pigz is not exposed, because it only works after manually installing the pigz package. ionice is not exposed, because it only works in combination with the BFQ scheduler and even then not in all cases (only affects the compressor when doing snapshot/suspend mode backup of a VM). These can still b

Re: [pve-devel] [PATCH installer] fix #4430: add UTC timezone as option to installer

2023-03-15 Thread Thomas Lamprecht
Am 15/03/2023 um 13:26 schrieb Christoph Heiss: > The 'Etc/UTC' timezone does not have a definite 2-letter country code > assigned. 'xx' was choosen on the basis that this hopefully will never > be assigned to any real country in the future, but a small collision > check won't hurt either. > > Thi

[pve-devel] [PATCH v4 manager] ui: ceph: improve discoverability of warning details

2023-03-15 Thread Aaron Lauterer
by * replacing the info button with expandable rows that contain the details of the warning * adding two action buttons to copy the summary and details * making the text selectable The row expander works like the one in the mail gateway tracking center -> doubleclick only opens it. The height o

Re: [pve-devel] [RFC OPTIONAL pve-cluster 1/1] add arcsize to rrd

2023-03-15 Thread DERUMIER, Alexandre
Hi, AFAIR, we have discussed about this last year (for my need to add new counters for DRS, like pressure io/ram/disk counters), and we have talked about 1 metric = 1rrd. (but I'm not sure about read/write performance). No solution was chosen. Le mercredi 15 mars 2023 à 12:10 +0100, Dominik Cs

[pve-devel] [PATCH installer] fix #4430: add UTC timezone as option to installer

2023-03-15 Thread Christoph Heiss
The 'Etc/UTC' timezone does not have a definite 2-letter country code assigned. 'xx' was choosen on the basis that this hopefully will never be assigned to any real country in the future, but a small collision check won't hurt either. This also means it does not have an entry in either the ISO-cod

Re: [pve-devel] [PATCH access-control 1/2] ldap: Allow quoted values for DN attribute values

2023-03-15 Thread Thomas Lamprecht
Am 15/03/2023 um 12:41 schrieb Dominik Csapak: > if my example and all that could have been configured but > would now be invalid are not valid ldap syntax anyway, i think > we can get more strict and "break" someones config > (as you said, shouldn't have worked anyway) > or how do you see that @th

Re: [pve-devel] [PATCH access-control 1/2] ldap: Allow quoted values for DN attribute values

2023-03-15 Thread Christoph Heiss
Comment inline. On Wed, Mar 15, 2023 at 12:41:39PM +0100, Dominik Csapak wrote: > On 3/15/23 12:17, Christoph Heiss wrote: > > Thanks for the review! > > > > [..] > > > > > > > > diff --git a/src/PVE/Auth/LDAP.pm b/src/PVE/Auth/LDAP.pm > > > > index 4792586..4d771e7 100755 > > > > --- a/src/PVE/Au

Re: [pve-devel] [RFC OPTIONAL pve-cluster 1/1] add arcsize to rrd

2023-03-15 Thread Matthias Heiserer
On 15.03.2023 12:10, Dominik Csapak wrote: hi not sure we would want to do it this way, since this will only work for the node where the new pve-cluster is installed, the other nodes will not be able to update their local database with the info from the new nodes AFAIR, the way we dealt with rrd

Re: [pve-devel] [PATCH access-control 1/2] ldap: Allow quoted values for DN attribute values

2023-03-15 Thread Dominik Csapak
On 3/15/23 12:17, Christoph Heiss wrote: Thanks for the review! On Wed, Mar 15, 2023 at 10:54:38AM +0100, Dominik Csapak wrote: hi, so high level comment: i'd write most of what you wrote in the cover letter here in the commit message, makes it much more convenient to find it only via git ;)

Re: [pve-devel] [PATCH access-control 1/2] ldap: Allow quoted values for DN attribute values

2023-03-15 Thread Christoph Heiss
Thanks for the review! On Wed, Mar 15, 2023 at 10:54:38AM +0100, Dominik Csapak wrote: > hi, > > so high level comment: > i'd write most of what you wrote in the cover letter here in the commit > message, > makes it much more convenient to find it only via git ;) Good point, I'll do that if/when

Re: [pve-devel] [RFC widget-toolkit] ui: add InfoMultiWidget, to be used for RAM

2023-03-15 Thread Dominik Csapak
sorry forgot one high level thing while having it split up is nice in the gui, the user has no real way of knowing what it actually represents. i'd suggest adding a tooltip to the bar and/or modifying the text in a way such that it's clear that this is the arc usage On 1/25/23 12:29, Matthias H

Re: [pve-devel] [RFC widget-toolkit] ui: add InfoMultiWidget, to be used for RAM

2023-03-15 Thread Dominik Csapak
in general i'm not really happy with the manual insertion of a div here, wouldn't it also be possible to extend the progressbar and change the rendertemplate? that way we could have a way nicer interface than "get the dom element if it exists, and manually set the css classes" further comments i

Re: [pve-devel] [RFC OPTIONAL pve-cluster 1/1] add arcsize to rrd

2023-03-15 Thread Dominik Csapak
hi not sure we would want to do it this way, since this will only work for the node where the new pve-cluster is installed, the other nodes will not be able to update their local database with the info from the new nodes AFAIR, the way we dealt with rrd updates in the past is that we introduced a

Re: [pve-devel] [PATCH access-control 1/2] ldap: Allow quoted values for DN attribute values

2023-03-15 Thread Dominik Csapak
hi, so high level comment: i'd write most of what you wrote in the cover letter here in the commit message, makes it much more convenient to find it only via git ;) also i'm missing a bit the rationale for how the regex was chosen, besides that it works in some conditions further comment inline

[pve-devel] applied: [PATCH proxmox-login-manager] login: fix login for saved ipv6 addresses

2023-03-15 Thread Thomas Lamprecht
Am 01/12/2022 um 10:27 schrieb Dominik Csapak: > Since we only string concatenated the host + port, ipv6 addresses were > invalid because their missing [] around the ip. To fix that, use > 'Uri's 'toString' method but strip the 'https://' prefix when creating > an Uri object again > > This now als