[pve-devel] [PATCH docs v2] conf: add support for a dark mode in the documentation

2023-03-16 Thread Stefan Sterz
this commit adds support for a dark theme that behaves similarly to that one used by the api viewer. Signed-off-by: Stefan Sterz --- asciidoc/pve-docs.css | 168 + asciidoc/pve-html.conf | 4 + 2 files changed, 172 insertions(+) create mode 100644

Re: [pve-devel] [PATCH container] lxc start: warn in case of conflicting lxc.idmap entries

2023-03-16 Thread Wolfgang Bumiller
On Thu, Mar 16, 2023 at 04:07:34PM +0100, Friedrich Weber wrote: > Thanks for the review! > > On 16/03/2023 14:59, Wolfgang Bumiller wrote: > > Both seem a bit excessive to me. > > > > Let's look at the data: > > We have a set of ranges consisting of a type, 2 starts and a count. > > The types

[pve-devel] [PATCH v2 follow up manager 3/5] api: ceph: add endpoint to fetch config keys

2023-03-16 Thread Aaron Lauterer
This new endpoint allows to get the values of config keys that are either set in the config db or the ceph.conf file. Values that are set in the ceph.conf file have priority over values set in the conifg db via 'ceph config set'. Expects the --config-keys parameter as a semicolon separated list

Re: [pve-devel] [PATCH container] lxc start: warn in case of conflicting lxc.idmap entries

2023-03-16 Thread Friedrich Weber
Thanks for the review! On 16/03/2023 14:59, Wolfgang Bumiller wrote: Both seem a bit excessive to me. Let's look at the data: We have a set of ranges consisting of a type, 2 starts and a count. The types are uids and gids, so we can view those as 2 separate instances of sets of [ct_start,

[pve-devel] applied: [PATCH v4 manager 3/3] lxc: Add `Disconnect` option for network interfaces

2023-03-16 Thread Wolfgang Bumiller
applied gui patch, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container] lxc start: warn in case of conflicting lxc.idmap entries

2023-03-16 Thread Wolfgang Bumiller
On Thu, Feb 23, 2023 at 06:03:02PM +0100, Friedrich Weber wrote: > Users can customize the mapping between host and container uids/gids > by providing `lxc.idmap` entries in the container config. The syntax > is described in lxc.container.conf(5). One source of errors are > conflicting entries for

[pve-devel] [PATCH v2 manager 2/5] ui: ceph config: use new ceph/cfg/ API endpoints

2023-03-16 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- changes since v1: * added this patch www/manager6/ceph/Config.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/ceph/Config.js b/www/manager6/ceph/Config.js index 7f07f15f..d4da20a8 100644 --- a/www/manager6/ceph/Config.js

[pve-devel] [PATCH v2 manager 1/5] api: ceph: add ceph/cfg path, deprecate ceph/config and ceph/configdb

2023-03-16 Thread Aaron Lauterer
Consolidating the different config paths lets us add more as needed without polluting our API with too many 'configxxx' endpoints. The config and configdb paths are renamed under the ceph/cfg path: * config -> raw (returns the ceph.conf file as is) * configdb -> db (returns the ceph config db

[pve-devel] [PATCH v2 manager 5/5] ui: ceph pool edit: rework with controller and formulas

2023-03-16 Thread Aaron Lauterer
instead of relying purely on listeners that then manually change other components, we can use binds, formulas and a basic controller. This makes it quite a bit easier to let multiple components react to changes. A cbind is used for the size component to set the initial start value. Other

[pve-devel] [PATCH v2 manager 0/5] rework ceph cfg api & fix 2515 use size defaults

2023-03-16 Thread Aaron Lauterer
The main goal of this series is to improve the handling of configured default size & min_size values when creating a new Ceph Pool in the GUI. But since that means a new necessary API endpoint, we also rework the Ceph API to make it cleaner. A new API endpoint is used: 'cfg' and the current

[pve-devel] [PATCH v2 manager 4/5] fix #2515: ui: ceph pool create: use configured defaults for size and min_size

2023-03-16 Thread Aaron Lauterer
Instead of hard coded defaults for the size and min_size parameter, check if we have defaults configured in the ceph.conf or config db and use those. There are clusters where different defaults are needed. For example if the cluster spans two rooms and needs to survive the loss of one. A

[pve-devel] [PATCH v2 manager 3/5] api: ceph: add endpoint to fetch config keys

2023-03-16 Thread Aaron Lauterer
This new endpoint allows to get the values of config keys that are either set in the config db or the ceph.conf file. Values that are set in the ceph.conf file have priority over values set in the conifg db via 'ceph config set'. Expects the --config-keys parameter as a semicolon separated list

[pve-devel] [PATCH pve-docs v3] update the PCI(e) docs

2023-03-16 Thread Noel Ullreich
A little update to the PCI(e) docs with the plan of reworking the PCI wiki as well. Along with some minor grammar fixes added: * how to check if kernelmodules are being loaded * how to check which drivers to blacklist * how to add softdeps for module loading * where to find kernel params

[pve-devel] [PATCH pve-docs v2] update the PCI(e) docs

2023-03-16 Thread Noel Ullreich
A little update to the PCI(e) docs with the plan of reworking the PCI wiki as well. Along some minor grammar fixes added: * how to check if kernelmodules are being loaded * how to check which drivers to blacklist * how to add softdeps for module loading * where to find kernel params

[pve-devel] applied: [PATCH v4 container/manager 0/3] fix #3413: Add `Disconnect` option for LXC networks

2023-03-16 Thread Thomas Lamprecht
Am 22/02/2023 um 13:49 schrieb Christoph Heiss: > Add a `Disconnect` option for network interfaces on LXC containers, much > like it already exists for VMs. This has been requested in #3413 [0] and > seems useful, especially considering we already support the same thing > for VMs. > > One thing

[pve-devel] applied: [PATCH v2 installer] fix #4430: add UTC timezone as option to installer

2023-03-16 Thread Thomas Lamprecht
Am 16/03/2023 um 11:01 schrieb Christoph Heiss: > Adds 'Etc/UTC' as option to the timezone selection, regardless of what > country is selected. > > The 'Etc/' prefix needs to be stripped for the installation, as this > value is written to /etc/timezone. PVE/PMG/PBS already use 'UTC' without > the

[pve-devel] applied: [PATCH guest-common] fix #4572: config: also update volume IDs in pending section

2023-03-16 Thread Thomas Lamprecht
Am 15/03/2023 um 15:44 schrieb Fiona Ebner: > The method is intended to be used in cases where the volumes actually > got renamed (e.g. migration). Thus, updating the volume IDs should of > course also be done for pending changes to avoid changes referring to > now non-existent volumes or even the

[pve-devel] [PATCH v2 installer] fix #4430: add UTC timezone as option to installer

2023-03-16 Thread Christoph Heiss
Adds 'Etc/UTC' as option to the timezone selection, regardless of what country is selected. The 'Etc/' prefix needs to be stripped for the installation, as this value is written to /etc/timezone. PVE/PMG/PBS already use 'UTC' without the prefix, so avoid regressing them. Signed-off-by: Christoph

[pve-devel] applied: [PATCH manager] ui: resource tree: correctly reinsert item when name changes

2023-03-16 Thread Thomas Lamprecht
Am 16/03/2023 um 10:03 schrieb Dominik Csapak: > if the user has the tree sorted by name, we have to move the items > on a name change, otherwise they'll stay on the old position > > Signed-off-by: Dominik Csapak > --- > www/manager6/tree/ResourceTree.js | 3 ++- > 1 file changed, 2

Re: [pve-devel] [PATCH installer] fix #4430: add UTC timezone as option to installer

2023-03-16 Thread Christoph Heiss
Thanks for the review! On Wed, Mar 15, 2023 at 02:23:09PM +0100, Thomas Lamprecht wrote: > [..] > > What I don't like as much that one has to set the country to the timezone, > which is confusing UX and will be subtle to most. > > Better ways might be: > > - add an explicit "Use UTC" checkbox

[pve-devel] [PATCH manager] ui: resource tree: correctly reinsert item when name changes

2023-03-16 Thread Dominik Csapak
if the user has the tree sorted by name, we have to move the items on a name change, otherwise they'll stay on the old position Signed-off-by: Dominik Csapak --- www/manager6/tree/ResourceTree.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[pve-devel] applied: [PATCH qemu-server] pci: workaround nvidia driver issue on mdev cleanup

2023-03-16 Thread Wolfgang Bumiller
applied, though I'm not too happy about it... The moment those driver versions that don't cleanup by themselves are "rare" enough I'd like to just drop the cleanup code from our side! On Fri, Feb 24, 2023 at 02:04:31PM +0100, Dominik Csapak wrote: > in some nvidia grid drivers (e.g. 14.4 and

[pve-devel] applied: [PATCH qemu-server] fix #4553: nvidia vgpu: reuse smbios uuid for '-uuid' parameter

2023-03-16 Thread Wolfgang Bumiller
applied, thanks On Mon, Feb 27, 2023 at 04:34:27PM +0100, Dominik Csapak wrote: > instead of using the mdev uuid. The nvidia driver does not actually care > that it's the same as the mdev, and in qemu the uuid parameter > overwrites the smbios1 uuid internally, so we should have been reusing >

Re: [pve-devel] [RFC OPTIONAL pve-cluster 1/1] add arcsize to rrd

2023-03-16 Thread DERUMIER, Alexandre
Hi, > > > +++ b/debian/pve-cluster.postinst > > > @@ -0,0 +1,6 @@ > > > +#!/bin/bash > > > + > > > +RRD_DB="/var/lib/rrdcached/db/pve2-node/`hostname`" > > > +if [ -f $RRD_DB ] && [ `rrdtool info $RRD_DB | grep -q arcsize` > > > ]; then > > > +    rrdtool tune $RRD_DB