Re: [pve-devel] applied: [PATCH v5 qemu-server 02/12] memory: don't use foreach_reversedimm for unplug

2023-03-17 Thread DERUMIER, Alexandre
Hi Fiona, I don't have checked yet, but does I need to rebase the other virtio- mem patches ? Le vendredi 17 mars 2023 à 14:39 +0100, Fiona Ebner a écrit : > Am 24.02.23 um 13:09 schrieb Alexandre Derumier: > > simple use dimm_list() returned by qemu > > > > Signed-off-by: Alexandre Derumier >

[pve-devel] applied: Re: [PATCH qemu] cherry-pick TCG-related stable fixes for 7.2

2023-03-17 Thread Thomas Lamprecht
On 17/03/2023 13:47, Fiona Ebner wrote: > When turning off the "KVM hardware virtualization" checkbox in Proxmox > VE, the TCG accelerator is used, so these fixes are relevant then. > > The first patch is included to allow cherry-picking the others without > changes. > > Reported-by: Thomas Lampr

[pve-devel] applied: Re: [PATCH docs v2] conf: add support for a dark mode in the documentation

2023-03-17 Thread Thomas Lamprecht
On 16/03/2023 18:02, Stefan Sterz wrote: > this commit adds support for a dark theme that behaves similarly to > that one used by the api viewer. > > Signed-off-by: Stefan Sterz > --- > asciidoc/pve-docs.css | 168 + > asciidoc/pve-html.conf | 4 + > 2

[pve-devel] applied: [PATCH v5 qemu-server 02/12] memory: don't use foreach_reversedimm for unplug

2023-03-17 Thread Fiona Ebner
Am 24.02.23 um 13:09 schrieb Alexandre Derumier: > simple use dimm_list() returned by qemu > > Signed-off-by: Alexandre Derumier Thanks! Applied with this follow-up: > memory: hotplug: sort by numerical ID rather than slot when unplugging > > While, usually, the slot should match t

[pve-devel] applied: [PATCH v5 qemu-server 01/12] memory: rename qemu_dimm_list to qemu_memdevices_list

2023-03-17 Thread Fiona Ebner
Am 24.02.23 um 13:09 schrieb Alexandre Derumier: > current qemu_dimm_list can return any kind of memory devices. > > make it more generic, with an optionnal type device > > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer/Memory.pm | 8 > 1 file changed, 4 insertions(+), 4 dele

Re: [pve-devel] [RFC OPTIONAL pve-cluster 1/1] add arcsize to rrd

2023-03-17 Thread Matthias Heiserer
On 15.03.2023 12:51, Matthias Heiserer wrote: On 15.03.2023 12:10, Dominik Csapak wrote: hi not sure we would want to do it this way, since this will only work for the node where the new pve-cluster is installed, the other nodes will not be able to update their local database with the info from

[pve-devel] [PATCH qemu] cherry-pick TCG-related stable fixes for 7.2

2023-03-17 Thread Fiona Ebner
When turning off the "KVM hardware virtualization" checkbox in Proxmox VE, the TCG accelerator is used, so these fixes are relevant then. The first patch is included to allow cherry-picking the others without changes. Reported-by: Thomas Lamprecht Signed-off-by: Fiona Ebner --- ...Introduce-an

[pve-devel] applied: Re: [PATCH qemu] add patch fixing ACPI CPU hotplug issue with TCG

2023-03-17 Thread Thomas Lamprecht
On 17/03/2023 11:39, Fiona Ebner wrote: > Required for the debian/edk2-vars-generator.py script in the > pve-edk2-firmware repository when building the edk2-stable202302 > release. Without this patch, the QEMU process spawned by the script > would hang indefinietly. spotted above s/indefinietly/in

[pve-devel] applied: [PATCH v3 widget-toolkit 1/2] repo view: replace non-clickable checkbox with icons

2023-03-17 Thread Thomas Lamprecht
On 26/01/2023 11:47, Lukas Wagner wrote: > From a usability view, having a checkbox that is not clickable is pretty > misleading, especially if the visual style is exactly the same as in > other places in the UI where the checkbox is functional. > > Signed-off-by: Lukas Wagner > --- > src/Utils.

[pve-devel] applied: [PATCH v3 manager 2/2] ui: backup: replication: replace non-clickable checkbox with icons

2023-03-17 Thread Thomas Lamprecht
On 26/01/2023 11:47, Lukas Wagner wrote: > From a usability view, having a checkbox that is not clickable is pretty > misleading, especially if the visual style is exactly the same as in > other places in the UI where the checkbox is functional. > > Signed-off-by: Lukas Wagner > --- > www/manage

[pve-devel] [PATCH qemu] add patch fixing ACPI CPU hotplug issue with TCG

2023-03-17 Thread Fiona Ebner
Required for the debian/edk2-vars-generator.py script in the pve-edk2-firmware repository when building the edk2-stable202302 release. Without this patch, the QEMU process spawned by the script would hang indefinietly. Signed-off-by: Fiona Ebner --- I'll be thinking twice about not picking up TC

Re: [pve-devel] [PATCH container] lxc start: warn in case of conflicting lxc.idmap entries

2023-03-17 Thread Friedrich Weber
On 16/03/2023 17:09, Wolfgang Bumiller wrote: > Since it's about helping out users, even better would be to collect all > the errors together and than die() with a message containing all of > them. > And then the order doesn't matter again ;-) Agree. :) So I'll prepare a v2 that * is based on the