[pve-devel] applied: [PATCH docs 1/1] user management: ldap: specify space and number sign escaping

2023-03-23 Thread Thomas Lamprecht
Am 23/03/2023 um 14:14 schrieb Dominik Csapak: > number sign at the beginning (was missing completely) > space only needs escaping at the start and end > > Signed-off-by: Dominik Csapak > --- > pveum.adoc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied, thanks!

[pve-devel] applied-series: [PATCH widget-toolkit 0/5] Proxmox Dark Theme Fixups - Round 4

2023-03-23 Thread Thomas Lamprecht
Am 23/03/2023 um 16:26 schrieb Stefan Sterz: > this round of fixups improves the contrast ratios on several icons and > the mask message. it also fixes the background of boundlists which > appeared to brightly in certain contexts and fixes #4610. #4610 is > fixed by adding a white padding to the to

[pve-devel] [PATCH widget-toolkit 5/5] fix #4610: add a small white padding to the totp qr code

2023-03-23 Thread Stefan Sterz
some qr code readers need a white "quiet zone" around the main qr code. otherwise, they won't be able to scan it at all which made it impossible to scan the totp qr code on certain devices. Signed-off-by: Stefan Sterz --- src/window/AddTotp.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[pve-devel] [PATCH widget-toolkit 0/5] Proxmox Dark Theme Fixups - Round 4

2023-03-23 Thread Stefan Sterz
this round of fixups improves the contrast ratios on several icons and the mask message. it also fixes the background of boundlists which appeared to brightly in certain contexts and fixes #4610. #4610 is fixed by adding a white padding to the totp qr code so most (hopefully, all) qr code scanners

[pve-devel] [PATCH widget-toolkit 1/5] dark-mode: improve contrast on split buttons

2023-03-23 Thread Stefan Sterz
this improves the contrast of the little triangle in split buttons, making it stand out more especially when focused. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs/form/_button.scss | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/proxmox-dark/sc

[pve-devel] [PATCH widget-toolkit 2/5] dark-mode: color the custom grid and tree icons

2023-03-23 Thread Stefan Sterz
this wasn't noticed before because usually vms would either be running or stopped/offline/unknown etc. and there the colors are set separately. however, in e.g., the backup view's missing backups window these weren't colored properly. so this commit sets a default color. Signed-off-by: Stefan Ster

[pve-devel] [PATCH widget-toolkit 4/5] dark-mode: improve contrast ratios on the mask message

2023-03-23 Thread Stefan Sterz
this removes the transparent background of the masks message box. this should help improve the contrast between the background and text. also sets an appropriate border color to make it stand out more. Signed-off-by: Stefan Sterz --- interestingly, sassc removes the alpha value from something lik

[pve-devel] [PATCH widget-toolkit 3/5] dark-mode: set boundlist background

2023-03-23 Thread Stefan Sterz
this is only visible when no boundlist items are present, which only occurs when loading elements for the boundlist (e.g., when adding a nfs storage) Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs/form/_combobox.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/src/proxmox-da

[pve-devel] applied: [PATCH access-control 1/1] fix #4609: allow valid DN in ldap/ad realm config

2023-03-23 Thread Thomas Lamprecht
Am 23/03/2023 um 14:14 schrieb Dominik Csapak: > we previously added support for ',' in the dns attribute by allowing a > quoted format. the regex was sadly too restrictive: > > in a quoted attribute we'd only allow \w (alphanumeric + _) and the > restricted characters. this patch now changes that

[pve-devel] [PATCH pve-widget-toolkit 2/2] increased language dropdown menu width

2023-03-23 Thread Noel Ullreich
With the new translations and layout, the width of the dropdown menu needs to be increased so that the languages are all on the same line. This width might need to increased in the future if translations were to create a linebreak. Signed-off-by: Noel Ullreich --- src/window/LanguageEdit.js | 1

[pve-devel] [PATCH pve-widget-toolkit 1/2] Translated language dropdown menu in web interface

2023-03-23 Thread Noel Ullreich
Translated the languages in the web interface dropdown menu. Languages used to be in English, now they are in their native language and writing system along with their translation in the currently selected language. Signed-off-by: Noel Ullreich --- src/Utils.js | 50 +

[pve-devel] [PATCH pve-widget-toolkit 0/2] fix 4524: Language names should be translated

2023-03-23 Thread Noel Ullreich
Translated the language names from English to their respective language as well as added a translation of the language into the language currently selected. Once the patch is accepted, I would write the German translation in the i18n repo. The bugzilla report also includes a French translation. Ca

[pve-devel] [PATCH widget-toolkit 3/3] fix #4442: Extend LogView for firewall datetime filtering

2023-03-23 Thread Christian Ebner
Extends the current panels date filtering capability to date-time based filtering, and adds a config option to switch between livemode and filter mode, analogous to the JournalView panel. The `submitFormat` config is introduced to adapt the formatting of params values for their corresponding api c

[pve-devel] [PATCH pmg-gui 4/4] DateTimeField: fix typo in xtype

2023-03-23 Thread Christian Ebner
Signed-off-by: Christian Ebner --- js/MailTracker.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/MailTracker.js b/js/MailTracker.js index 52641a4..ce1a487 100644 --- a/js/MailTracker.js +++ b/js/MailTracker.js @@ -106,7 +106,7 @@ Ext.define('PMG.MailTrackerFilter',

[pve-devel] [PATCH widget-toolkit 2/3] DateTimeField: Extend and refactor to make field value bindable

2023-03-23 Thread Christian Ebner
Extends the date time field so that bindings are updated on value changes. Also adds a config to disable child components and avoid modification of current values by cloning the referenced object for min/max value calculation. Signed-off-by: Christian Ebner --- src/form/DateTimeField.js | 105 ++

[pve-devel] [PATCH 0/5] fix #4442: Firewall log filtering

2023-03-23 Thread Christian Ebner
This patch series extends the log view panel for date-time filtering and introduces the configs needed to allow the user to switch between the livemode and the filter mode, analogous to the journal view panel. The existing date time field was extended to publish state changes for value bindings to

[pve-devel] [PATCH manager 5/5] fix #4442: Add date-time filtering for firewall logs

2023-03-23 Thread Christian Ebner
Extend the current firewall log view to add date time based filtering. The user can switch between live view, which shows logs from the unrotated log file, or to filter mode, where date time based filtering, including rotated logs can be performed. Signed-off-by: Christian Ebner --- www/manager6

[pve-devel] [PATCH widget-toolkit 1/3] DateTimeField: fix typo in xtype

2023-03-23 Thread Christian Ebner
Signed-off-by: Christian Ebner --- src/form/DateTimeField.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/form/DateTimeField.js b/src/form/DateTimeField.js index a061e15..87bb1ef 100644 --- a/src/form/DateTimeField.js +++ b/src/form/DateTimeField.js @@ -1,6 +1,6 @@ Ext

Re: [pve-devel] [PATCH access-control 1/1] fix #4609: allow valid DN in ldap/ad realm config

2023-03-23 Thread Friedrich Weber
Tested-by: Friedrich Weber Tested the following: * PVE 7.3: setup LDAP realms realm #1 with `base_dn ou=Foo- und Bar,dc=example,dc=com` realm #2 with `base_dn ou=Users,dc=example,dc=com` both work, i.e., sync is possible and users can log in * Update to 7.4: realm #1: users cannot login

Re: [pve-devel] [PATCH access-control 1/1] fix #4609: allow valid DN in ldap/ad realm config

2023-03-23 Thread Thomas Lamprecht
Am 23/03/2023 um 14:14 schrieb Dominik Csapak: > we previously added support for ',' in the dns attribute by allowing a > quoted format. the regex was sadly too restrictive: > > in a quoted attribute we'd only allow \w (alphanumeric + _) and the > restricted characters. this patch now changes that

[pve-devel] [PATCH manager] ui: backupedit: reduce height

2023-03-23 Thread Aaron Lauterer
with the advanced panel enabled, the overall height of the window is too high. By reducing the size of the guest selection grid we can reduce the overall height to be at max ~600px. Signed-off-by: Aaron Lauterer --- www/manager6/dc/Backup.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[pve-devel] [PATCH docs 1/1] user management: ldap: specify space and number sign escaping

2023-03-23 Thread Dominik Csapak
number sign at the beginning (was missing completely) space only needs escaping at the start and end Signed-off-by: Dominik Csapak --- pveum.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pveum.adoc b/pveum.adoc index 147f317..6a0ad17 100644 --- a/pveum.adoc +++ b/pve

[pve-devel] [PATCH access-control 1/1] fix #4609: allow valid DN in ldap/ad realm config

2023-03-23 Thread Dominik Csapak
we previously added support for ',' in the dns attribute by allowing a quoted format. the regex was sadly too restrictive: in a quoted attribute we'd only allow \w (alphanumeric + _) and the restricted characters. this patch now changes that to everything except " (nearer to the original regex whi

[pve-devel] [PATCH access-control/docs] fix #4609: fix ldap regex

2023-03-23 Thread Dominik Csapak
to better cover existing configurations and the spec pve-access-control: Dominik Csapak (1): fix #4609: allow valid DN in ldap/ad realm config src/PVE/Auth/LDAP.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) pve-docs: Dominik Csapak (1): user management: ldap: specify space an

[pve-devel] [PATCH edk2-firmware] fix #4606: cherry-pick fix for PlatformConfig setting editing

2023-03-23 Thread Fiona Ebner
For example, the default screen resolution is such a setting. Signed-off-by: Fiona Ebner --- .../0001-OvmfPkg-fix-PlatformConfig.patch | 66 +++ debian/patches/series | 1 + 2 files changed, 67 insertions(+) create mode 100644 debian/patches/0001-Ovm

[pve-devel] [PATCH v3 manager 1/2] ui: qga: Add option to turn off QGA fs-freeze/-thaw on backup

2023-03-23 Thread Christoph Heiss
Adds a default-on checkbox to the QEMU Guest Agent feature selector controlling the 'fs-freeze-on-backup' option. If unchecked, an additional warning is displayed that backups can potentially corrupt with this setting off. Signed-off-by: Christoph Heiss --- The qemu-server part has already been a

[pve-devel] [PATCH v3 docs 2/2] Revert "qm: freeze-fs-on-backup: remove reference to GUI"

2023-03-23 Thread Christoph Heiss
This reverts commit 0025e843194130ec5223d5789fa01f916d189783. The option is now also exposed in the GUI. Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * New patch qm.adoc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index 0726b29..15ac2fc 10

[pve-devel] applied: [PATCH pve-installer] fix typo in error message

2023-03-23 Thread Thomas Lamprecht
Am 23/03/2023 um 09:56 schrieb Christian Ebner: > Signed-off-by: Christian Ebner > --- > proxinstall | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.pr

[pve-devel] applied: [RFC edk2-firmware] d/rules: re-enable PVSCSI support

2023-03-23 Thread Thomas Lamprecht
Am 23/03/2023 um 11:10 schrieb Fiona Ebner: > It is not maintained anymore and got disabled by default in upstream > commit 57783adfb5 ("OvmfPkg: Change default to disable MptScsi and > PvScsi"). Re-enable it to preserve backwards compatibility in Proxmox > VE. > > Signed-off-by: Fiona Ebner > --

[pve-devel] [RFC edk2-firmware] d/rules: re-enable PVSCSI support

2023-03-23 Thread Fiona Ebner
It is not maintained anymore and got disabled by default in upstream commit 57783adfb5 ("OvmfPkg: Change default to disable MptScsi and PvScsi"). Re-enable it to preserve backwards compatibility in Proxmox VE. Signed-off-by: Fiona Ebner --- Or should we just keep it disabled, because it's unsupp

[pve-devel] Proxmox VE 7.4 released!

2023-03-23 Thread Martin Maurer
Hi all, we're very excited to announce the release of Proxmox Virtual Environment 7.4. It's based on Debian 11.6 "Bullseye" but using a newer Linux kernel 5.15 or 6.2, QEMU 7.2, LXC 5.0.2, and ZFS 2.1.9. Proxmox Virtual Environment 7.4 comes with a new dark theme "Proxmox Dark". Here is a se

[pve-devel] [PATCH pve-installer] fix typo in error message

2023-03-23 Thread Christian Ebner
Signed-off-by: Christian Ebner --- proxinstall | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxinstall b/proxinstall index e85dd3e..c275be2 100755 --- a/proxinstall +++ b/proxinstall @@ -3716,7 +3716,7 @@ create_main_window (); my $initial_error = 0; if (!defined ($hds