Re: [pve-devel] [PATCH v3 manager 1/2] ui: qga: Add option to turn off QGA fs-freeze/-thaw on backup

2023-05-03 Thread Christoph Heiss
Ping - the API part has been merged before release 7.4 and was thus part of it. This is just the missing puzzle piece so that users can toggle it via the GUI :^) On Thu, Mar 23, 2023 at 12:02:47PM +0100, Christoph Heiss wrote: > Adds a default-on checkbox to the QEMU Guest Agent feature selector >

[pve-devel] [PATCH qemu-server] vm start: set minimum timeout of 300s if using PCI passthrough

2023-05-03 Thread Friedrich Weber
The default VM startup timeout is max(30, VM memory in GiB) seconds. Multiple reports in the forum [0] [1] and the bug tracker [2] suggest this is too short when using PCI passthrough with a large amount of VM memory, since QEMU needs to map the whole memory during startup (see comment #2 in [2]).

Re: [pve-devel] [PATCH manager v4 3/6] added Config for Shared Filesystem Directories

2023-05-03 Thread Dominik Csapak
just a short comment since this series overlaps a bit with my cluster resource mapping series (i plan on sending a v4 soon). i'd prefer to have the configuration endpoints for mapping bundled in a subdirectory so instead of /nodes//dirs/ i'd put it in /nodes//mapping/dirs/ (or /nodes//map/dirs )

[pve-devel] [PATCH manager 3/3] ui: GuestStatusView: add 'privileged' and 'ostype' fields

2023-05-03 Thread Christoph Heiss
The privileged status is displayed by adding a new row to the status panel, while the distribution logo and name are displayed on the right side of the title bar of the status panel. The latter fits neatly there, is rather unintrusive and yet still visible at first sight. This also solves the prob

[pve-devel] [PATCH manager 0/3] fix #2435: lxc: show distro and privileged status in summary

2023-05-03 Thread Christoph Heiss
This implements #2435 [0]. Show the unprivileged status in the summary panel, the distro logo and name in the title of the summary panel. [0] https://bugzilla.proxmox.com/show_bug.cgi?id=2435 pve-manager: Christoph Heiss (3): ui: clean up remnants of in-tree font-awesome files ui: add 'font-

[pve-devel] [PATCH manager 1/3] ui: clean up remnants of in-tree font-awesome files

2023-05-03 Thread Christoph Heiss
Commit e97c2601 ("change to debian font-awesome") removed the usage of the in-tree font-awesome files, replacing them with the Debian package. Thus clear out these leftovers out, as they are completely usused. Signed-off-by: Christoph Heiss --- Formatted the patch with `--irreversible-delete` for

[pve-devel] [PATCH manager 2/3] ui: add 'font-logos' stylesheet and font files

2023-05-03 Thread Christoph Heiss
>From [0]. As they are licensed under the "Unlicence" license, including them here and re-distributing them should bear no problems [1]. [0] https://github.com/Lukas-W/font-logos [1] https://choosealicense.com/licenses/unlicense/ Signed-off-by: Christoph Heiss --- Formatted the patch with `--no-

[pve-devel] [PATCH docs v8 5/5] added noVNC clipboard documentation

2023-05-03 Thread Markus Frank
Signed-off-by: Markus Frank --- qm.adoc | 18 ++ 1 file changed, 18 insertions(+) diff --git a/qm.adoc b/qm.adoc index f28043f..8214bdd 100644 --- a/qm.adoc +++ b/qm.adoc @@ -717,6 +717,24 @@ Selecting `serialX` as display 'type' disables the VGA output, and redirects the Web C

[pve-devel] [PATCH qemu-server v8 2/5] test cases for clipboard spice & std

2023-05-03 Thread Markus Frank
added one test case for a spice display and one for std Signed-off-by: Markus Frank --- test/cfg2cmd/VNC-clipboard-spice.conf | 1 + test/cfg2cmd/VNC-clipboard-spice.conf.cmd | 27 +++ test/cfg2cmd/VNC-clipboard-std.conf | 1 + test/cfg2cmd/VNC-clipboard-std.conf.

[pve-devel] [PATCH manager v8 4/5] added clipboard checkbox to VM Options

2023-05-03 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/qemu/DisplayEdit.js | 8 +++ www/manager6/qemu/Options.js | 37 2 files changed, 45 insertions(+) diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js index 9bb1763e..ca5baa25 10064

[pve-devel] [PATCH qemu-server/novnc/manager/docs v8 0/5] Feature VNC-Clipboard

2023-05-03 Thread Markus Frank
changes v8: * removed unnecessary conditions * removed spicedevices variable and changed back to devices * created is_spice variable changes v6: * added check if vga->type is set to prevent error when using default display * renamed clipboard to vnc_clipboard changes v5: * removed return of regex

[pve-devel] [PATCH qemu-server v8 1/5] enable clipboard parameter in vga_fmt

2023-05-03 Thread Markus Frank
added option to use the qemu vdagent implementation to enable the noVNC clipboard. When enabled with SPICE the spice-vdagent gets replaced with the qemu implementation. This patch does not solve #1406, but does allow copy and paste with a running X-session, when spice-vdagent is installed on the g

[pve-devel] [PATCH novnc v8 3/5] added show clipboard button patch to series

2023-05-03 Thread Markus Frank
Signed-off-by: Markus Frank --- .../patches/0019-show-clipboard-button.patch | 30 +++ debian/patches/series | 1 + 2 files changed, 31 insertions(+) create mode 100644 debian/patches/0019-show-clipboard-button.patch diff --git a/debian/patches/0019-sho

Re: [pve-devel] [PATCH qemu-server 1/2] migration: avoid migrating disk images multiple times

2023-05-03 Thread Fabian Grünbichler
On May 2, 2023 3:17 pm, Aaron Lauterer wrote: > Scan the VM config and store the volid and full path for each storage. > Do the same when we scan each storage. Then we can have these > scenarios: > * multiple storage configurations might point to the same storage > The result is, that when scannin

Re: [pve-devel] [PATCH container 2/2] migration: avoid migrating volume images multiple times

2023-05-03 Thread Fabian Grünbichler
On May 2, 2023 3:17 pm, Aaron Lauterer wrote: > Scan the VM config and store the volid and full path for each storage. > Do the same when we scan each storage. Then we can have these > scenarios: > * multiple storage configurations might point to the same storage > The result is, that when scannin

[pve-devel] [PATCH manager 1/2] ui: cloudinit: match backend privilege checks

2023-05-03 Thread Fabian Grünbichler
the cloudinit options except for ipconfig are all modifiable with just "VM.Config.Cloudinit". Signed-off-by: Fabian Grünbichler --- www/manager6/qemu/CloudInit.js | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/www/manager6/qemu/CloudInit.js b/www/manager6/qemu/CloudI

[pve-devel] [PATCH manager/qemu-server 0/3] Cloudinit priv adaptations

2023-05-03 Thread Fabian Grünbichler
these patches adapt the Cloudinit privileges in the backend and GUI so that just giving out "VM.Config.Cloudinit" (and, if forceful regeneration outside of guest starts is desired, "VM.Config.CDROM") is enough to allow an unprivileged user to manage cloudinit for a given guest. pve-managar Fabian

[pve-devel] [RFC qemu-server 1/1] allow setting ipconfigX with VM.Config.Cloudinit

2023-05-03 Thread Fabian Grünbichler
these config keys only affect the cloudinit drive contents (and state of the guest inside the VM), they are not used anywhere on the hypervisor side, so they should not require VM.Config.Network (which allows a lot more, such as changing vNIC VLAN tags or the bridges they are connected to). Signed

[pve-devel] [RFC manager 2/2] ui: cloudinit: also allow ipconfig with VM.Config.Cloudinit

2023-05-03 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Notes: only if the qemu-server patch gets applied, and then it can be folded into the previous commit www/manager6/qemu/CloudInit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/CloudInit.js b/www/manager6/q

Re: [pve-devel] [PATCH common/access-control/wt/manager v3] add realm sync jobs

2023-05-03 Thread Dominik Csapak
any comment to the rest of the series (access-control 2/2 and manager)? it still applies ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH qemu-server v7 1/5] enable clipboard parameter in vga_fmt

2023-05-03 Thread Dominik Csapak
hi, a few comments inline, hopefully we're soon at the finish line ;) On 4/21/23 12:00, Markus Frank wrote: added option to use the qemu vdagent implementation to enable the noVNC clipboard. When enabled with SPICE the spice-vdagent gets replaced with the qemu implementation. This patch does n