Re: [pve-devel] [PATCH qemu-server 1/2] migration: avoid migrating disk images multiple times

2023-05-09 Thread Fiona Ebner
Am 09.05.23 um 14:55 schrieb Aaron Lauterer: > > * Don't scan all storages and only look at disk images that are > referenced in the config. With this, we should have removed most > situations where aliases would happen, and a migration is less likely to > fail, because a storage is not online. I

Re: [pve-devel] [PATCH qemu-server 1/2] migration: avoid migrating disk images multiple times

2023-05-09 Thread Aaron Lauterer
On 5/9/23 09:34, Fiona Ebner wrote: Am 02.05.23 um 15:17 schrieb Aaron Lauterer: Scan the VM config and store the volid and full path for each storage. Do the same when we scan each storage. Then we can have these scenarios: * multiple storage configurations might point to the same storage T

Re: [pve-devel] [PATCH manager v4 3/6] added Config for Shared Filesystem Directories

2023-05-09 Thread Dominik Csapak
to summarize what thomas and i discussed off-list: 1. i'll try to integrate arrays into the section config in pve(pbs has rudimentary support, but no "automatic" api integration) including a sensible api create/update/delete schema: - plan is to have the inner properties exposed but req

[pve-devel] [PATCH qemu-server] fix #4549: capture and bubble up qemu errors correctly

2023-05-09 Thread Christoph Heiss
See [0]. The issue is that currently, all messages from qemu get directly sent to stdout by run_command(). In turn, this output was missing from mail notifications. Fix this by unifying it with the migration logging, properly capturing the output and including it in the error message, which then g

Re: [pve-devel] [RFC manager] ui: DirEdit: add hint when to enable shared

2023-05-09 Thread Lukas Wagner
Hi! On 5/9/23 09:56, Aaron Lauterer wrote: To hopefully reduce confusion what the 'shared' checkbox does. Signed-off-by: Aaron Lauterer --- I saw it one time too many where users were a bit confused as to what this checkbox is for. Since we have a hard time to find a better label, maybe we wa

[pve-devel] [RFC manager] ui: DirEdit: add hint when to enable shared

2023-05-09 Thread Aaron Lauterer
To hopefully reduce confusion what the 'shared' checkbox does. Signed-off-by: Aaron Lauterer --- I saw it one time too many where users were a bit confused as to what this checkbox is for. Since we have a hard time to find a better label, maybe we want to put a small hint below it? The phrasing

Re: [pve-devel] [PATCH qemu-server 1/2] migration: avoid migrating disk images multiple times

2023-05-09 Thread Fiona Ebner
Am 02.05.23 um 15:17 schrieb Aaron Lauterer: > Scan the VM config and store the volid and full path for each storage. > Do the same when we scan each storage. Then we can have these > scenarios: > * multiple storage configurations might point to the same storage > The result is, that when scanning