[pve-devel] [PATCH v3 cluster 3/4] pvecm: updatecerts: silence warning that potentially has no context

2023-06-30 Thread Fiona Ebner
If timeout is reached, run_fork_with_timeout will warn "got timeout". When processing triggers for pve-manager (because of ExecStartPre of pveproxy.service invoking pvecm updatecerts) that warning can appear in the apt output without any context (output of the forked sub doesn't appear there). So m

[pve-devel] [PATCH v3 cluster 1/4] setup: split generation of local (i.e. non-pmxcfs) files out into helper

2023-06-30 Thread Fiona Ebner
In preparation to wait for quorum in the updatecerts command. The generation of files that do not depend on quorum should still be done beforehand. Signed-off-by: Fiona Ebner --- No changes in v3. New in v2. src/PVE/CLI/pvecm.pm | 1 + src/PVE/Cluster/Setup.pm | 10 ++ 2 files cha

[pve-devel] [PATCH v3 cluster 2/4] pvecm: updatecerts: wait for quorum

2023-06-30 Thread Fiona Ebner
Mostly useful for the updatecerts call triggered via the ExecStartPre hook for pveproxy.service. When starting a node that's part of a cluster, there is a time window between the start of pve-cluster.service and when quorum is reached (from the node's perspective). pveproxy.service is ordered afte

[pve-devel] [PATCH v3 cluster 4/4] fix typo

2023-06-30 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- No changes in v3. No changes in v2. src/PVE/Cluster.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm index ff777ba..c310a67 100644 --- a/src/PVE/Cluster.pm +++ b/src/PVE/Cluster.pm @@ -93,7 +93,7 @@ sub

Re: [pve-devel] [PATCH v2 cluster 2/4] pvecm: updatecerts: allow specifying time to wait for quorum via CLI argument

2023-06-30 Thread Fiona Ebner
Am 30.06.23 um 13:49 schrieb Fiona Ebner: > Useful for the updatecerts call triggered via the ExecStartPre hook > for pveproxy.service. > > When starting a node that's part of a cluster, there is a time window > between the start of pve-cluster.service and when quorum is reached > (from the node's

[pve-devel] [PATCH v2 cluster 1/4] setup: split generation of local (i.e. non-pmxcfs) files out into helper

2023-06-30 Thread Fiona Ebner
In preparation to wait for quorum in the updatecerts command. The generation of files that do not depend on quorum should still be done beforehand. Signed-off-by: Fiona Ebner --- New in v2. src/PVE/CLI/pvecm.pm | 1 + src/PVE/Cluster/Setup.pm | 10 ++ 2 files changed, 7 insertions

[pve-devel] [PATCH v2 cluster 2/4] pvecm: updatecerts: allow specifying time to wait for quorum via CLI argument

2023-06-30 Thread Fiona Ebner
Useful for the updatecerts call triggered via the ExecStartPre hook for pveproxy.service. When starting a node that's part of a cluster, there is a time window between the start of pve-cluster.service and when quorum is reached (from the node's perspective). pveproxy.service is ordered after pve-c

[pve-devel] [PATCH v2 cluster 3/4] pvecm: updatecerts: silence warning that potentially has no context

2023-06-30 Thread Fiona Ebner
If timeout is reached, run_fork_with_timeout will warn "got timeout". When processing triggers for pve-manager (because of ExecStartPre of pveproxy.service invoking pvecm updatecerts) that warning can appear in the apt output without any context (output of the forked sub doesn't appear there). So m

[pve-devel] [PATCH v2 cluster 4/4] fix typo

2023-06-30 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- No changes in v2. src/PVE/Cluster.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm index ff777ba..c310a67 100644 --- a/src/PVE/Cluster.pm +++ b/src/PVE/Cluster.pm @@ -93,7 +93,7 @@ sub prepare_observed_