Re: [pve-devel] [PATCH stable-7+master manager] ui: vm selector: handle empty string gracefully

2023-07-06 Thread Thomas Lamprecht
Am 06/07/2023 um 15:51 schrieb Fiona Ebner: > which is passed by the backup job window when using selection mode > 'all', would be converted to [""] and wrongly add an entry with VMID > 0 because the item "" could not be found in the store. > > Reported in the community forum: > https://forum.prox

[pve-devel] applied: [PATCH qemu-server] fix #4822: vzdump: fix pbs encryption for no-disk guests

2023-07-06 Thread Thomas Lamprecht
Am 03/07/2023 um 09:03 schrieb Fabian Grünbichler: > these are backed up directly with proxmox-backup-client, and the invocation > was > lacking the key parameters. > > Signed-off-by: Fabian Grünbichler > --- > Should possibly be cherry-picked for stable-7 (no changes required) > > PVE/VZDump/

[pve-devel] applied: [PATCH manager v2] fix #4364: pveceph: add confirmation dialogue for ceph installation

2023-07-06 Thread Thomas Lamprecht
Am 05/07/2023 um 20:02 schrieb Max Carrara: > Displays a confirmation dialogue if the user didn't explicitly > provide a valid ceph version via the `--version` flag and if > stdout is connected to a tty. > > Signed-off-by: Max Carrara > --- > > v2 of this little patch incorporates the given feed

[pve-devel] [PATCH stable-7+master manager] ui: vm selector: handle empty string gracefully

2023-07-06 Thread Fiona Ebner
which is passed by the backup job window when using selection mode 'all', would be converted to [""] and wrongly add an entry with VMID 0 because the item "" could not be found in the store. Reported in the community forum: https://forum.proxmox.com/threads/130164/ Fixes: 7a5ca76a ("fix #4239: ui

[pve-devel] [PATCH installer] tui: fix incorrect scrolling of form view contents

2023-07-06 Thread Christoph Heiss
See the inline comment for what & why. Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/views/mod.rs | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/proxmox-tui-installer/src/views/mod.rs b/proxmox-tui-installer/src/views/mod.rs index b1a1a13..

Re: [pve-devel] [PATCH pve_installer] tui-installer: don't aborted install if min requirements not met

2023-07-06 Thread Christoph Heiss
Good catch, that's indeed a place were the GUI- and TUI-installer diverge in behavior. Small comment inline about code structuring. As subject it's completely sufficient to use "tui: [..]", also; bit of a typo'd subject in general? :^) On Thu, Jul 06, 2023 at 01:52:12PM +0200, Noel Ullreich wrot

[pve-devel] [PATCH pve_installer] tui-installer: don't aborted install if min requirements not met

2023-07-06 Thread Noel Ullreich
If the minimum requirements are not met, the TUI installer will create a popup notifying you that the install might not work and then exits the installer. While the GUI also creates such a popup, it will not exit the installer. This patch adapts the behavior of the GUI: the TUI creates a popup warn

[pve-devel] [PATCH manager v6 5/5] ui: added options to add virtio-fs to qemu config

2023-07-06 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 1 + www/manager6/qemu/HardwareView.js | 19 + www/manager6/qemu/VirtiofsEdit.js | 120 ++ 4 files changed, 141 insertions(+) create mode 100644 www/m

[pve-devel] [PATCH manager v6 1/5] api: add resource map api endpoints for directories

2023-07-06 Thread Markus Frank
Signed-off-by: Markus Frank --- PVE/API2/Cluster/Mapping.pm | 7 + PVE/API2/Cluster/Mapping/DIR.pm | 299 ++ PVE/API2/Cluster/Mapping/Makefile | 3 +- 3 files changed, 308 insertions(+), 1 deletion(-) create mode 100644 PVE/API2/Cluster/Mapping/DIR.pm dif

[pve-devel] [PATCH manager v6 4/5] ui: form: add DIRMapSelector

2023-07-06 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/form/DIRMapSelector.js | 63 + 2 files changed, 64 insertions(+) create mode 100644 www/manager6/form/DIRMapSelector.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile

[pve-devel] [PATCH qemu-server v6 1/3] feature #1027: virtio-fs support

2023-07-06 Thread Markus Frank
adds support for sharing directorys with a guest vm virtio-fs needs virtiofsd to be started. In order to start virtiofsd as a process (despite being a daemon it is does not run in the background), a double-fork is used. virtiofsd should close itself together with qemu. There are the parameters

[pve-devel] [PATCH manager v6 3/5] ui: ResourceMapTree for DIR

2023-07-06 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/dc/Config.js | 10 +++ www/manager6/dc/DIRMapView.js | 50 +++ 3 files changed, 61 insertions(+) create mode 100644 www/manager6/dc/DIRMapView.js diff --git a/www/manager6/

[pve-devel] [PATCH qemu-server v6 3/3] check_local_resources: virtiofs

2023-07-06 Thread Markus Frank
Signed-off-by: Markus Frank --- PVE/QemuServer.pm | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 3a8b4c5..8914154 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2703,6 +2703,7 @@ sub check_local_resources {

[pve-devel] [PATCH guest-common v6 1/1] add DIR mapping config

2023-07-06 Thread Markus Frank
adds a config file for directories by using a 'map' array propertystring for each node mapping. next to node & path, there are xattr, acl & submounts parameters for virtiofsd in the map array. example config: ``` some-dir-id map node=node1,path=/mnt/share/,xattr=1,acl=1,submounts=1

[pve-devel] [PATCH manager v6 2/5] ui: add edit window for dir mappings

2023-07-06 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/window/DIRMapEdit.js | 186 ++ 2 files changed, 187 insertions(+) create mode 100644 www/manager6/window/DIRMapEdit.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile i

[pve-devel] [PATCH docs v6 1/1] added shared filesystem doc for virtio-fs

2023-07-06 Thread Markus Frank
Signed-off-by: Markus Frank --- qm.adoc | 60 +++-- 1 file changed, 58 insertions(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index e35dbf0..00a0668 100644 --- a/qm.adoc +++ b/qm.adoc @@ -997,6 +997,61 @@ recommended to always use a limit

[pve-devel] [PATCH cluster v6 1/1] add mapping/dir.cfg for resource mapping

2023-07-06 Thread Markus Frank
Add it to both, the perl side (PVE/Cluster.pm) and pmxcfs side (status.c). Signed-off-by: Markus Frank --- src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm index ff777ba..39f2d99 100644 --- a/src/PVE/Clus

[pve-devel] [PATCH qemu-server v6 2/3] Permission check for virtiofs directory access

2023-07-06 Thread Markus Frank
Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 18 ++ 1 file changed, 18 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index d0c199b..2048e4a 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -585,6 +585,19 @@ my $check_vm_create_serial_perm = sub {

[pve-devel] [PATCH cluster/guest-common/qemu-server/manager v6 0/11] virtiofs

2023-07-06 Thread Markus Frank
cluster: Markus Frank (1): add mapping/dir.cfg for resource mapping src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2 files changed, 2 insertions(+) guest-common: Markus Frank (1): add DIR mapping config src/Makefile | 1 + src/PVE/Mapping/DIR.pm | 175