[pve-devel] [PATCH docs 1/2] pveum: add missing roles and privileges

2023-07-10 Thread Max Carrara
Signed-off-by: Max Carrara --- pveum.adoc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/pveum.adoc b/pveum.adoc index 3f6c997..6a806ef 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -772,7 +772,10 @@ of predefined roles, which satisfy most requirements. * `PVEAuditor`: has read only ac

[pve-devel] [PATCH docs 2/2] pveum: sort roles and privileges alphabetically

2023-07-10 Thread Max Carrara
Signed-off-by: Max Carrara --- NOTE: Thought it would make these two little sections a little more readable if their list items were sorted alphabetically; if that's not desired, then this commit can be dropped. pveum.adoc | 48 1 file changed, 2

[pve-devel] [PATCH pve_docs 1/1] raise min ram requirements to 2 GiB and specify min disk space

2023-07-10 Thread Noel Ullreich
Raise the minimum ram required for a PVE instance. Also specify the minimum and recommended disk space for a PVE instance in GiB. Signed-off-by: Noel Ullreich --- pve-system-requirements.adoc | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pve-system-requirements

[pve-devel] [PATCH pve-installer; pve-docs; pmg-docs; proxmox-backup/docs 0/4] Update min RAM and min disk size for pve

2023-07-10 Thread Noel Ullreich
Note that this patch series needs the patch `tui: don't abort install if min ram requirement is not met` (https://lists.proxmox.com/pipermail/pve-devel/2023-July/058057.html) to apply. This patch series does two things: 1) It raises the minimum usable RAM the installer checks for from 1 GiB to 2

[pve-devel] [PATCH pve-installer 1/1] raise the minimum ram requirements to 2 GiB

2023-07-10 Thread Noel Ullreich
Check that the system has at least 2 GiB of usable RAM. The docs for the pmg and pbs (and with this patch series pve as well) already specify 2 GiB as the minimum RAM needed. Signed-off-by: Noel Ullreich --- proxinstall | 4 ++-- proxmox-tui-installer/src/main.rs | 4 ++--

[pve-devel] [PATCH pmg_docs 1/1] Consistency of GB and GiB pmg

2023-07-10 Thread Noel Ullreich
Since the actual system-checks are done in GiB and to stay consistent with the other docs, change all GB units to GiB Signed-off-by: Noel Ullreich --- pmg-planning-deployment.adoc | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pmg-planning-deployment.adoc b/pmg-plann

[pve-devel] [PATCH proxmox-backup/docs 1/1] Consistency of GB and GiB pbs

2023-07-10 Thread Noel Ullreich
Since the actual system-checks are done in GiB and to stay consistent with the other docs, change all GB units to GiB Signed-off-by: Noel Ullreich --- docs/system-requirements.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/system-requirements.rst b/docs/system-r

[pve-devel] [PATCH installer 2/2] tui: add "Deselect all" button to zfs/btrfs raid disk select

2023-07-10 Thread Christoph Heiss
Another puzzle piece in the quest to align the TUI installer more to its GUI counterpart. Like the GUI installer, it will only be shown if >3 disks are detected on the system. Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/views/bootdisk.rs | 46 - proxmox-tui-

[pve-devel] [PATCH installer 1/2] tui: fix clippy warnings

2023-07-10 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/options.rs| 6 +- proxmox-tui-installer/src/setup.rs | 8 ++-- proxmox-tui-installer/src/views/bootdisk.rs | 4 ++-- 3 files changed, 5 insertions(+), 13 deletions(-) diff --git a/proxmox-tui-installer/src/opti

[pve-devel] [PATCH installer 0/2] tui: add "Deselect all" disks button for zfs/btrfs raid

2023-07-10 Thread Christoph Heiss
Pretty much as it says on the tin. pve-installer: Christoph Heiss (2): tui: fix clippy warnings tui: add "Deselect all" button to zfs/btrfs raid disk select proxmox-tui-installer/src/options.rs| 6 +-- proxmox-tui-installer/src/setup.rs | 8 +--- proxmox-tui-installer/src

Re: [pve-devel] [PATCH pve_installer v3] tui: don't abort install if min ram requirement is not met

2023-07-10 Thread Christoph Heiss
LGTM. On Mon, Jul 10, 2023 at 11:22:27AM +0200, Noel Ullreich wrote: > If the minimum requirements are not met, the TUI installer will create a > popup notifying you that the install might not work and then exits the > installer. > While the GUI also creates such a popup, it will not exit the inst

[pve-devel] [PATCH pve_installer v3] tui: don't abort install if min ram requirement is not met

2023-07-10 Thread Noel Ullreich
If the minimum requirements are not met, the TUI installer will create a popup notifying you that the install might not work and then exits the installer. While the GUI also creates such a popup, it will not exit the installer. This patch adapts the behavior of the GUI: the TUI creates a popup warn

Re: [pve-devel] [PATCH pve_installer v2] tui: don't abort install if min ram requirement is not met

2023-07-10 Thread Christoph Heiss
On Mon, Jul 10, 2023 at 11:00:58AM +0200, Noel Ullreich wrote: > > On 10-07-2023 09:27, Christoph Heiss wrote: > > On Fri, Jul 07, 2023 at 01:53:46PM +0200, Noel Ullreich wrote: > > > [..] > > > @@ -256,6 +256,7 @@ fn installer_setup(in_test_mode: bool) -> > > > Result<(LocaleInfo, RuntimeInfo), S

Re: [pve-devel] [PATCH pve_installer v2] tui: don't abort install if min ram requirement is not met

2023-07-10 Thread Noel Ullreich
On 10-07-2023 09:27, Christoph Heiss wrote: On Fri, Jul 07, 2023 at 01:53:46PM +0200, Noel Ullreich wrote: [..] diff --git a/proxmox-tui-installer/src/main.rs b/proxmox-tui-installer/src/main.rs index 64f21fa..99a4a11 100644 --- a/proxmox-tui-installer/src/main.rs +++ b/proxmox-tui-installer/

[pve-devel] [PATCH v2 qemu-server 1/4] qmeventd: improve getting VMID from PID in presence of legacy cgroup entries

2023-07-10 Thread Fiona Ebner
On a hybrid cgroup system, the /proc//cgroup file looks like > 13:pids:/qemu.slice/110.scope > 12:perf_event:/ > 11:devices:/qemu.slice > 10:misc:/ > 9:hugetlb:/ > 8:freezer:/ > 7:cpu,cpuacct:/qemu.slice/110.scope > 6:memory:/qemu.slice/110.scope > 5:rdma:/ > 4:cpuset:/ > 3:blkio:/qemu.slice > 2:n

[pve-devel] [PATCH v2 qemu-server 3/4] qmeventd: VMID from PID: don't fail immediately when encountering unexpected entry

2023-07-10 Thread Fiona Ebner
While such entries shuoldn't exist in practice without manually messing around, it's not hard to imagine, and there's still a good chance the actual VMID can still be found. It's still unexpected to encounter such entries so keep the log line. Signed-off-by: Fiona Ebner --- New in v2. qmevent

[pve-devel] [PATCH v2 qemu-server 2/4] qmeventd: further improve getting VMID from PID

2023-07-10 Thread Fiona Ebner
by also expecting the ".scope" part and trying the next entry if it is not present instead of immediately failing. It's still unexpected to encounter such entries, so keep the log line. Signed-off-by: Fiona Ebner --- Changes in v2: * Keep setting vmid to zero in the error case! * Still

[pve-devel] [PATCH v2 qemu-server 4/4] qmeventd: VMID from PID: avoid goto

2023-07-10 Thread Fiona Ebner
If strtol() returns an errno, make sure not to print the error message twice after the refactoring. Signed-off-by: Fiona Ebner --- New in v2. qmeventd/qmeventd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/qmeventd/qmeventd.c b/qmeventd/qmeventd.c index 76a894cb..

Re: [pve-devel] [PATCH qemu-server 1/2] qmeventd: improve getting vmid from PID in presence of legacy cgroup entries

2023-07-10 Thread Fiona Ebner
Am 10.07.23 um 09:58 schrieb Fiona Ebner: > On a hybrid cgroup system, the /proc//cgroup file usually looks > like: > >> 13:pids:/qemu.slice/110.scope >> 12:perf_event:/ >> 11:devices:/qemu.slice >> 10:misc:/ >> 9:hugetlb:/ >> 8:freezer:/ >> 7:cpu,cpuacct:/qemu.slice/110.scope >> 6:memory:/qemu.sl

[pve-devel] [PATCH qemu-server 1/2] qmeventd: improve getting vmid from PID in presence of legacy cgroup entries

2023-07-10 Thread Fiona Ebner
On a hybrid cgroup system, the /proc//cgroup file usually looks like: > 13:pids:/qemu.slice/110.scope > 12:perf_event:/ > 11:devices:/qemu.slice > 10:misc:/ > 9:hugetlb:/ > 8:freezer:/ > 7:cpu,cpuacct:/qemu.slice/110.scope > 6:memory:/qemu.slice/110.scope > 5:rdma:/ > 4:cpuset:/ > 3:blkio:/qemu.sl

[pve-devel] [PATCH qemu-server 2/2] qmeventd: further improve getting vmid from PID

2023-07-10 Thread Fiona Ebner
by also expecting the ".scope" part and trying the next entry if it is not present instead of immediately failing. Signed-off-by: Fiona Ebner --- qmeventd/qmeventd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qmeventd/qmeventd.c b/qmeventd/qmeventd.c index 503bce69

Re: [pve-devel] [PATCH pve_installer v2] tui: don't abort install if min ram requirement is not met

2023-07-10 Thread Christoph Heiss
On Fri, Jul 07, 2023 at 01:53:46PM +0200, Noel Ullreich wrote: > [..] > > diff --git a/proxmox-tui-installer/src/main.rs > b/proxmox-tui-installer/src/main.rs > index 64f21fa..99a4a11 100644 > --- a/proxmox-tui-installer/src/main.rs > +++ b/proxmox-tui-installer/src/main.rs > @@ -209,6 +209,8 @@ f