Lukas Wagner writes:
> Signed-off-by: Lukas Wagner
> ---
> Cargo.toml | 1 +
> proxmox-notify/Cargo.toml | 9 +
> proxmox-notify/src/config.rs| 51 +
> proxmox-notify/src/endpoints/mod.rs | 0
> proxmox-notify/src/lib.rs | 311 +++
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 100 ++
1 file changed, 100 insertions(+)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index e358573c..32a873a7 100644
--- a/PVE/API2/Cluster/Notifications.pm
++
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 315 ++
1 file changed, 315 insertions(+)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index b1971911..aea571f0 100644
--- a/PVE/API2/Cluster/Notifications.pm
++
This commit adds a way to filter notifications based on severity. The
filter module also has the necessary foundation work for more complex
filters, e.g. matching on properties or for creating arbitarily complex
filter structures using nested sub-filters.
Signed-off-by: Lukas Wagner
---
proxmox-
... instead of using sendmail directly.
If the new 'notification-target' parameter is set,
we send the notification to this endpoint or group.
If 'mailto' is set, we add a temporary endpoint and a
temporary group containg both targets.
This commit also refactors the old 'sendmail' sub heavily:
Signed-off-by: Lukas Wagner
---
proxmox-notify/debian/changelog | 5 ++
proxmox-notify/debian/control | 108
proxmox-notify/debian/copyright | 16 +
proxmox-notify/debian/debcargo.toml | 7 ++
4 files changed, 136 insertions(+)
create mode 1006
Signed-off-by: Lukas Wagner
---
www/manager6/dc/BackupJobDetail.js | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/www/manager6/dc/BackupJobDetail.js
b/www/manager6/dc/BackupJobDetail.js
index c4683a47..8b9bb749 100644
--- a/www/manager6/dc/BackupJobDeta
Signed-off-by: Lukas Wagner
---
test/Makefile | 8
test/{mail_test.pl => vzdump_notification_test.pl} | 0
2 files changed, 4 insertions(+), 4 deletions(-)
rename test/{mail_test.pl => vzdump_notification_test.pl} (100%)
diff --git a/test/Makefile b
Otherwise, a filter with the same name as an already existing
endpoint or group can overwrite it.
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/filter.rs | 7 +
proxmox-notify/src/api/gotify.rs | 10 +--
proxmox-notify/src/api/group.rs| 24 ++-
proxmox-notif
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/filter.rs | 1 +
proxmox-notify/src/api/gotify.rs | 1 +
proxmox-notify/src/api/mod.rs | 113 ++---
proxmox-notify/src/api/sendmail.rs | 1 +
4 files changed, 106 insertions(+), 10 deletions(-)
diff --g
Signed-off-by: Lukas Wagner
---
src/Makefile| 1 +
src/Schema.js | 5 +
src/panel/NotificationGroupEditPanel.js | 177
src/window/EndpointEditBase.js | 6 +-
4 files changed, 188 insertions(+), 1 deletio
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 40 +++
1 file changed, 40 insertions(+)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index 32a873a7..fa2c1d9d 100644
--- a/PVE/API2/Cluster/Notifications.pm
+++
Signed-off-by: Lukas Wagner
---
pve-rs/src/notify.rs | 88
1 file changed, 88 insertions(+)
diff --git a/pve-rs/src/notify.rs b/pve-rs/src/notify.rs
index cac233a..9490ea8 100644
--- a/pve-rs/src/notify.rs
+++ b/pve-rs/src/notify.rs
@@ -5,6 +5,9 @@ mo
Signed-off-by: Lukas Wagner
---
Notes:
I'm not sure if I like this solution, but adding notification targets to
the resources API endpoint would not have make sense.
Maybe we could create a new API endpoint that returns all possible ACL
paths and then use a normal store for the pe
Check notification targets configured in datacenter.cfg and jobs.cfg,
failing if the group/endpoint to be removed is still in use there.
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 44 ++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff -
The function returns all other entities referenced by a filter/target.
This is useful for permission checks, where the user must have the
appropriate permissions for all entities.
Signed-off-by: Lukas Wagner
---
pve-rs/src/notify.rs | 9 +
1 file changed, 9 insertions(+)
diff --git a/pv
Signed-off-by: Lukas Wagner
---
pve-rs/src/notify.rs | 83
1 file changed, 83 insertions(+)
diff --git a/pve-rs/src/notify.rs b/pve-rs/src/notify.rs
index aa2c312..a6143fc 100644
--- a/pve-rs/src/notify.rs
+++ b/pve-rs/src/notify.rs
@@ -12,6 +12,9 @@
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 263 ++
1 file changed, 263 insertions(+)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index 8f0b6429..e358573c 100644
--- a/PVE/API2/Cluster/Notifications.pm
++
Signed-off-by: Lukas Wagner
---
src/PVE/Cluster.pm | 2 ++
src/pmxcfs/status.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index c310a67..e3705b6 100644
--- a/src/PVE/Cluster.pm
+++ b/src/PVE/Cluster.pm
@@ -55,6 +55,8 @@ my $observed = {
'f
Signed-off-by: Lukas Wagner
---
pve-rs/src/notify.rs | 11 +++
1 file changed, 11 insertions(+)
diff --git a/pve-rs/src/notify.rs b/pve-rs/src/notify.rs
index 04e902c..0c00b03 100644
--- a/pve-rs/src/notify.rs
+++ b/pve-rs/src/notify.rs
@@ -60,6 +60,11 @@ impl Context for PVEContext {
Signed-off-by: Lukas Wagner
---
src/Makefile | 4 +
src/Schema.js| 8 ++
src/data/model/NotificationConfig.js | 8 ++
src/panel/NotificationConfigView.js | 192 +++
src/panel/SendmailEditPanel.js | 140 ++
This commit adds template rendering to the `proxmox-notify` crate, based
on the `handlebars` crate.
Title and body of a notification are rendered using any `properties`
passed along with the notification. There are also a few helpers,
allowing to render tables from `serde_json::Value`.
'Value' re
Signed-off-by: Lukas Wagner
---
notifications.adoc | 159 +++
pve-admin-guide.adoc | 2 +
pve-gui.adoc | 2 +
vzdump.adoc | 5 ++
4 files changed, 168 insertions(+)
create mode 100644 notifications.adoc
diff --git a/notifications.
This commit adds a possibility to choose between different options
for notifications for backup jobs:
- Notify via email, in the same manner as before
- Notify via an endpoint/group
If 'notify via mail' is selected, a text field where an email address
can be entered is displayed:
Noti
Signed-off-by: Lukas Wagner
---
src/Makefile | 3 +-
src/data/model/NotificationConfig.js | 9 ++
src/panel/NotificationConfigView.js | 119 +++
src/window/NotificationFilterEdit.js | 115 ++
4 files changed, 245 inserti
Signed-off-by: Lukas Wagner
---
src/Makefile| 1 +
src/form/NotificationFilterSelector.js | 58 +
src/panel/GotifyEditPanel.js| 9
src/panel/NotificationConfigView.js | 4 ++
src/panel/NotificationGroupEditPanel.js | 9
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 271 ++
1 file changed, 271 insertions(+)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index aea571f0..8f0b6429 100644
--- a/PVE/API2/Cluster/Notifications.pm
++
... instead of using sendmail directly.
If the new 'notify.target-fencing' parameter from datacenter config
is set, we use it as a target for notifications. If it is not set,
we send the notification to the default target (mail-to-root).
There is also a new 'notify.fencing' paramter which control
Signed-off-by: Lukas Wagner
---
src/Makefile | 1 +
src/Schema.js| 5
src/panel/GotifyEditPanel.js | 52
3 files changed, 58 insertions(+)
create mode 100644 src/panel/GotifyEditPanel.js
diff --git a/src/Makefile b/src/
The package contains the PVE::Notify. It is a very thin wrapper
around the Proxmox::RS::Notify module, feeding the configuration
from the new 'notifications.cfg' and 'priv/notifications.cfg' files
into it.
Signed-off-by: Lukas Wagner
---
debian/control| 9 ++
debian/libpve
... instead of using sendmail directly
If the new 'target-package-updates' is set, we send a
notification to this target. If not, we continue to send
a mail to root@pam (if the mail address is configured)
Signed-off-by: Lukas Wagner
---
PVE/API2/APT.pm | 99 ++---
# Overview
The purpose of this patch series is to overhaul the existing mail
notification infrastructure in Proxmox VE.
The series replaces calls to 'sendmail' with calls to a
new, configurable notification module. The module was designed to
support multiple notification endpoints, 'sendmail' usin
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster.pm | 7 +++
PVE/API2/Cluster/Makefile | 1 +
PVE/API2/Cluster/Notifications.pm | 71 +++
3 files changed, 79 insertions(+)
create mode 100644 PVE/API2/Cluster/Notifications.pm
diff --git a/PVE/A
In essence the same change as for backup jobs.
Signed-off-by: Lukas Wagner
---
www/manager6/window/Backup.js | 35 ++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index 4b21c746..17a37
If the new 'target-replication' option in datacenter.cfg is set
to a notification target, we send notifications that way.
If it is not set, we continue send a notification to the
default target (mail to root@pam).
There is also a new 'replication' option. It controls whether
to send a notification
These options allow setting the notification target for package update
notifications, node fencing notifications and replication notifications.
Also, fencing and replication has now new options that allow disabling
notifications altogether.
Signed-off-by: Lukas Wagner
---
src/PVE/DataCenterConf
Signed-off-by: Lukas Wagner
---
www/manager6/dc/Config.js | 16
1 file changed, 16 insertions(+)
diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
index aa025c8d..9ba7b301 100644
--- a/www/manager6/dc/Config.js
+++ b/www/manager6/dc/Config.js
@@ -329,6 +329,22 @
- Add new option 'notification-target'
Allows to select to which endpoint/group notifications shall be sent
- Add new option 'notification-policy'
Replacement for the now deprecated 'mailnotification' option. Mostly
just a rename for consistency, but also adds the 'never' option.
- Mark 'mail
Signed-off-by: Lukas Wagner
---
Notes:
Did not add version number since I do not know which it will be yet.
debian/control | 2 ++
1 file changed, 2 insertions(+)
diff --git a/debian/control b/debian/control
index 3206b514..b807dbfe 100644
--- a/debian/control
+++ b/debian/control
@@ -14,6
This introduces a new configuration parameter `mailto-user`.
A user's email address will be looked up in the product-specific
user database.
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/sendmail.rs | 32 ---
proxmox-notify/src/context.rs| 4 ++-
proxm
Signed-off-by: Lukas Wagner
---
pve-rs/src/notify.rs | 33 -
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/pve-rs/src/notify.rs b/pve-rs/src/notify.rs
index ea34bfe..04e902c 100644
--- a/pve-rs/src/notify.rs
+++ b/pve-rs/src/notify.rs
@@ -34,6 +34,1
Signed-off-by: Lukas Wagner
---
pve-rs/Cargo.toml| 1 +
pve-rs/Makefile | 1 +
pve-rs/src/lib.rs| 1 +
pve-rs/src/notify.rs | 71
4 files changed, 74 insertions(+)
create mode 100644 pve-rs/src/notify.rs
diff --git a/pve-rs/Cargo.toml
Signed-off-by: Lukas Wagner
---
www/manager6/Makefile | 1 +
www/manager6/dc/Config.js | 12 ++
www/manager6/dc/NotificationEvents.js | 238 ++
3 files changed, 251 insertions(+)
create mode 100644 www/manager6/dc/NotificationEvents.js
diff
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/gotify.rs | 284 +++
proxmox-notify/src/api/mod.rs| 6 +
2 files changed, 290 insertions(+)
create mode 100644 proxmox-notify/src/api/gotify.rs
diff --git a/proxmox-notify/src/api/gotify.rs b/proxmox-notify
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/lib.rs | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/proxmox-notify/src/lib.rs b/proxmox-notify/src/lib.rs
index 3c2b6d55..d2f15496 100644
--- a/proxmox-notify/src/lib.rs
+++ b/proxmox-notify/src/lib.r
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 254 ++
1 file changed, 254 insertions(+)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index 1efebbc1..b1971911 100644
--- a/PVE/API2/Cluster/Notifications.pm
++
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/context.rs| 2 ++
proxmox-notify/src/endpoints/sendmail.rs | 18 +-
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/proxmox-notify/src/context.rs b/proxmox-notify/src/context.rs
index 25be949a..8b55a2d
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/mod.rs | 7 +
proxmox-notify/src/api/sendmail.rs | 254 +
2 files changed, 261 insertions(+)
create mode 100644 proxmox-notify/src/api/sendmail.rs
diff --git a/proxmox-notify/src/api/mod.rs b/proxmox-notif
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/mod.rs | 94 +++
proxmox-notify/src/lib.rs | 1 +
2 files changed, 95 insertions(+)
create mode 100644 proxmox-notify/src/api/mod.rs
diff --git a/proxmox-notify/src/api/mod.rs b/proxmox-notify/src/api/mo
ACL paths for notification targets can become quite long, e.g.:
/mappings/notifications/
Signed-off-by: Lukas Wagner
---
www/manager6/form/PermPathSelector.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/form/PermPathSelector.js
b/www/manager6/form/PermPathSelector.js
index
They need to have the same name as the target.
Took the opportunity to move the .PHONY right next to the target recipe,
so that mistakes like these are hopefully easier caught.
Signed-off-by: Lukas Wagner
---
test/Makefile | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --
This parameter allows to send mails to the email address configured
for users from the product's user database.
`proxmox-notify` now has a `Context` that must be set via
`proxmox_notify::context::set_context` before the crate is used.
Signed-off-by: Lukas Wagner
---
pve-rs/Cargo.toml| 1 +
The new notification backend is implemented in Rust where we use SHA256
for config digests.
Signed-off-by: Lukas Wagner
---
src/PVE/JSONSchema.pm | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index 7589bba..49e0d7a 100644
When notifying via a group, all endpoints contained in that group
will send out the notification.
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/config.rs | 9 ++
proxmox-notify/src/group.rs | 40 +
proxmox-notify/src/lib.rs| 170 ---
3 files c
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/filter.rs | 231 +
proxmox-notify/src/api/gotify.rs | 12 ++
proxmox-notify/src/api/group.rs| 7 +
proxmox-notify/src/api/mod.rs | 1 +
proxmox-notify/src/api/sendmail.rs | 10 ++
5 files changed
Signed-off-by: Lukas Wagner
---
pve-rs/src/notify.rs | 83
1 file changed, 83 insertions(+)
diff --git a/pve-rs/src/notify.rs b/pve-rs/src/notify.rs
index 9490ea8..aa2c312 100644
--- a/pve-rs/src/notify.rs
+++ b/pve-rs/src/notify.rs
@@ -5,6 +5,10 @@ m
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/common.rs | 11 +++
proxmox-notify/src/api/mod.rs| 125 +++
2 files changed, 136 insertions(+)
diff --git a/proxmox-notify/src/api/common.rs b/proxmox-notify/src/api/common.rs
index 518caa8f..48761fbb 100644
Signed-off-by: Lukas Wagner
---
pve-rs/src/notify.rs | 70
1 file changed, 70 insertions(+)
diff --git a/pve-rs/src/notify.rs b/pve-rs/src/notify.rs
index 74a872b..cac233a 100644
--- a/pve-rs/src/notify.rs
+++ b/pve-rs/src/notify.rs
@@ -5,6 +5,7 @@ mo
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/group.rs | 264
proxmox-notify/src/api/mod.rs | 1 +
2 files changed, 265 insertions(+)
create mode 100644 proxmox-notify/src/api/group.rs
diff --git a/proxmox-notify/src/api/group.rs b/proxmox-notify/sr
Signed-off-by: Lukas Wagner
---
pve-rs/src/notify.rs | 34 --
1 file changed, 32 insertions(+), 2 deletions(-)
diff --git a/pve-rs/src/notify.rs b/pve-rs/src/notify.rs
index 9677d8b..74a872b 100644
--- a/pve-rs/src/notify.rs
+++ b/pve-rs/src/notify.rs
@@ -2,10 +2,
The proxy configuration will be read from datacenter.cfg via
a new method of the `Context` trait.
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/context.rs | 1 +
proxmox-notify/src/endpoints/gotify.rs | 22 --
2 files changed, 17 insertions(+), 6 deletions(-)
Signed-off-by: Lukas Wagner
---
Cargo.toml | 1 +
proxmox-notify/Cargo.toml | 9 +
proxmox-notify/src/config.rs| 51 +
proxmox-notify/src/endpoints/mod.rs | 0
proxmox-notify/src/lib.rs | 311
proxmox-not
Signed-off-by: Lukas Wagner
---
proxmox-notify/examples/render.rs | 63 +++
1 file changed, 63 insertions(+)
create mode 100644 proxmox-notify/examples/render.rs
diff --git a/proxmox-notify/examples/render.rs
b/proxmox-notify/examples/render.rs
new file mode 100644
Since `proxmox-notify` is intended to be used by multiple products,
there needs to be a way to inject product-specific behavior.
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/context.rs | 13 +
proxmox-notify/src/lib.rs | 1 +
2 files changed, 14 insertions(+)
create mode
Add an endpoint for Gotify [1], showing the how easy it is to add new
endpoint implementations.
[1] https://gotify.net/
Signed-off-by: Lukas Wagner
---
proxmox-notify/Cargo.toml | 6 +-
proxmox-notify/src/config.rs | 23 +
proxmox-notify/src/endpoints/gotify.rs | 1
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/common.rs | 44
proxmox-notify/src/api/mod.rs| 2 ++
2 files changed, 46 insertions(+)
create mode 100644 proxmox-notify/src/api/common.rs
diff --git a/proxmox-notify/src/api/common.rs b/proxmox-notify/
This plugin uses the 'sendmail' command to send an email
to one or more recipients.
Signed-off-by: Lukas Wagner
---
proxmox-notify/Cargo.toml| 9 ++-
proxmox-notify/src/config.rs | 12
proxmox-notify/src/endpoints/mod.rs | 2 +
proxmox-notify/src/endpoints
Signed-off-by: Lukas Wagner
---
Notes:
Changes v1 -> v2:
- Renamed crate from 'proxmox-notification' to 'proxmox-notify'
Cargo.toml| 1 +
proxmox-notify/Cargo.toml | 10 ++
proxmox-notify/src/lib.rs | 0
3 files changed, 11 insertions(+)
create mode 100644
Am 10/07/2023 um 17:10 schrieb Max Carrara:
> Signed-off-by: Max Carrara
> ---
> pveum.adoc | 7 +++
> 1 file changed, 7 insertions(+)
>
>
The grouping is a bit odd for a few points, like SDN.Use and Mapping.Use are
roughly about the same thing, but one is at guest level the other at node l
Currently, remote migration behaves a bit differently, because an
explicitly passed-in format that is not supported by the target
storage is not overwritten with the storage's default format.
This meant remote live migration with qcow2 to e.g. LVM-thin would not
work, because the code here wrongly
Previously, qemu_img_format() was called with the target storage's
$scfg and the source storage's volume name.
This mismatch should only be relevant for certain special kinds of
storage plugins:
- no path, but does support an additional QEMU image format besides
'raw', in short NPAF.
- no path,
While the comment sated
># order of precedence, filtered by whether storage supports it:
># 1. explicit requested format
># 2. format of current volume
># 3. default format of storage
the code did not fall back to the default format in the case of remote
migration, because the form
Am 15/06/2023 um 14:11 schrieb Dominik Csapak:
> Looks good from my side now, maybe someone else wants to chime in
> regarding the splitting of the setting in the gui (but IMHO that's good)
>
I'm torn about that, as IMO it would be a slightly better fit there,
but if we'd move it we'd also need t
Am 14/07/2023 um 11:18 schrieb Philipp Hufnagl:
> There is an error in this example. The .conf has to be moved in the
> quemu-server folder of the new node for the migration to work.
>
> Signed-off-by: Philipp Hufnagl
> ---
> pmxcfs.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Am 14/07/2023 um 11:29 schrieb Christoph Heiss:
> .. in the same fashion as the GUI installer.
> See also proxinstall:create_intro_view() for reference.
>
> Signed-off-by: Christoph Heiss
> ---
> proxmox-tui-installer/src/main.rs | 10 ++
> proxmox-tui-installer/src/setup.rs | 17 ++
Am 15/06/2023 um 14:03 schrieb Noel Ullreich:
> When adding or editing a storage device in Datacenter->Storage in the
> web interface, the subdirectory depth can be set in the advanced menu.
>
> Signed-off-by: Noel Ullreich
> ---
> www/manager6/storage/Base.js | 11 +++
> 1 file changed,
Am 17/07/2023 um 10:38 schrieb Fiona Ebner:
> Commit 114e5f2c ("pve7to8: sync over from stable-7 branch")
> accidentally got rid of the correct value 0 here and also the new TODO
> message to improve the situation. But the TODO is actually easy,
> because there already is the $upgraded variable. Ju
Am 17/07/2023 um 14:34 schrieb Dominik Csapak:
> by converting the textfield into a textarea and validate the value
> line wise (if there is more than one line)
>
> also create a 'MultiFileButton' (mostly copied from extjs) that allows
> to select multiple files at once
>
> Signed-off-by: Dominik
Am 14/07/2023 um 15:34 schrieb Friedrich Weber:
> The 7->8 upgrade guide [1] mentions that cgroup v1 will be deprecated
> starting from PVE 9.0, so also mention this in the docs.
>
> [1] https://pve.proxmox.com/wiki/Upgrade_from_7_to_8#cgroup_V1_Deprecation
>
> Signed-off-by: Friedrich Weber
> -
by converting the textfield into a textarea and validate the value
line wise (if there is more than one line)
also create a 'MultiFileButton' (mostly copied from extjs) that allows
to select multiple files at once
Signed-off-by: Dominik Csapak
---
changes from v2:
* added comments to indicate wh
Am 17/07/2023 um 11:03 schrieb Dominik Csapak:
> On 7/13/23 12:09, Christoph Heiss wrote:
>> also: s/let/const/
>>
>
> hmm... we don't really have a style recommendation which to prefer.
> maybe we should improve our style guideline to have some more hints when to
> use const
> and when to use le
applied series, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Am 14.07.23 um 20:30 schrieb Thomas Lamprecht:
>
> If it gains us something we can drop this patch a bit in the future
> Proxmox VE 9 major release, but we should ensure that VMs that where
> started before PVE 8 cannot be directly live-migrated to the release
> that includes that change; so we sh
On 7/13/23 12:09, Christoph Heiss wrote:
On Mon, Jul 03, 2023 at 04:51:16PM +0200, Dominik Csapak wrote:
by converting the textfield into a textarea and validate the value
line wise (if there is more than one line)
also create a 'MultiFileButton' (mostly copied from extjs) that allows
to selec
applied & bumped, thanks
On Tue, Jul 11, 2023 at 11:41:15AM +0200, Leo Nunner wrote:
> We tried to resolve aliases in some places where the cluster
> configuration didn't get set. It's probably better to handle these cases
> directly in the function at hand, instead of at every place where this
>
Commit 114e5f2c ("pve7to8: sync over from stable-7 branch")
accidentally got rid of the correct value 0 here and also the new TODO
message to improve the situation. But the TODO is actually easy,
because there already is the $upgraded variable. Just rely on that
instead of hard-coding and forgettin
w.r.t the subject line: s/added/add/, should not be past-tense
As mentioned in the cover letter reply, a sentence explaining what the
mount tag is and about the virtio/WinFsp drivers situation would also be
useful.
On Thu, Jul 06, 2023 at 12:54:13PM +0200, Markus Frank wrote:
>
> Signed-off-by:
Tested the whole series, using Debian 12 and Windows 11 as guest
machines. Works fine with both.
Two small things overall that I noticed, although only really pertaining
to documentation:
* It should be explained in the docs and via a tooltip in the GUI
what the "mount tag" is / does. Thi
Relevant when modifying or removing an existing network device.
Signed-off-by: Fiona Ebner
---
src/PVE/LXC.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index a531ea5..1e9af0f 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1316,7 +
Relevant when modifying or removing an existing network device.
Signed-off-by: Fiona Ebner
---
PVE/API2/Qemu.pm | 13 +
1 file changed, 13 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 59307133..fd718f93 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@
90 matches
Mail list logo
