Le mercredi 13 septembre 2023 à 13:21 +, DERUMIER, Alexandre a
écrit :
> yes, use should be able to define his own ip too. (maybe directly in
> a
> ipam gui on the sdn subnet , or maybe on the vm nic gui (but
> registering ip in ipam), I'm really not sure ...)
Hi, I have done some tests
Am 20/09/2023 um 13:39 schrieb Christoph Heiss:
> Even if the installer is run in release mode, the test-mode flag should
> be honored on whether to start a test-installation or not.
>
> The test mode is always forced on in debug builds, so the cfg()
> conditionals can be dropped.
>
>
Am 20/09/2023 um 15:42 schrieb Maximiliano Sandoval:
> Thomas Lamprecht writes:
>
>> @maximiliano: how does ceph react if oe sets this currently?
>> I.e., does it silently accepts unknown config keys, or does it break
>> something?
>
> Running
>
> ceph config set global osd_pg_bits 42
>
>
Thomas Lamprecht writes:
> @maximiliano: how does ceph react if one sets this currently?
> I.e., does it silently accepts unknown config keys, or does it break
> something?
Running
ceph config set global osd_pg_bits 42
results in
Error EINVAL: unrecognized config option
Rest of the series looks fine to me (and tested ok), but here i have some
comments/nits inline:
On 9/8/23 13:06, Markus Frank wrote:
Signed-off-by: Markus Frank
---
www/manager6/qemu/DisplayEdit.js | 8 +
www/manager6/qemu/Options.js | 52
2 files
Am 20/09/2023 um 11:59 schrieb Dominik Csapak:
> personally i would be cautious to include such deep links to vendor sites in
> our
> documentation, because they can be outdated fast and it becomes a catch-up
> game
>
> No strong feelings though if the others are fine with it.
I normally
Am 20/09/2023 um 14:10 schrieb Dominik Csapak:
> sadly removing these parameters would be a breaking change
>
@maximiliano: how does ceph react if one sets this currently?
I.e., does it silently accepts unknown config keys, or does it break
something?
Because if it's the latter we can assume
On 9/20/23 14:09, Fabian Grünbichler wrote:
On September 20, 2023 1:50 pm, Dominik Csapak wrote:
On 9/20/23 13:46, Fabian Grünbichler wrote:
On September 20, 2023 1:07 pm, Dominik Csapak wrote:
LGTM and works as advertised.
it breaks downloading container templates that are compressed with
sadly removing these parameters would be a breaking change
i'd rather mark it deprecatedand non-functional in the description
and remove the functionality
then on the next major release, we can announce the breaking change and
remove the parameter
On 9/7/23 11:49, Maximiliano Sandoval wrote:
On September 20, 2023 1:50 pm, Dominik Csapak wrote:
> On 9/20/23 13:46, Fabian Grünbichler wrote:
>> On September 20, 2023 1:07 pm, Dominik Csapak wrote:
>>> LGTM and works as advertised.
>>
>> it breaks downloading container templates that are compressed with one
>> of the "known" compression
On 9/20/23 13:50, Dominik Csapak wrote:
On 9/20/23 13:46, Fabian Grünbichler wrote:
On September 20, 2023 1:07 pm, Dominik Csapak wrote:
LGTM and works as advertised.
it breaks downloading container templates that are compressed with one
of the "known" compression algorithms (such as gz).
On 9/20/23 13:46, Fabian Grünbichler wrote:
On September 20, 2023 1:07 pm, Dominik Csapak wrote:
LGTM and works as advertised.
it breaks downloading container templates that are compressed with one
of the "known" compression algorithms (such as gz).
probably the detect-compression parameter
On September 20, 2023 1:07 pm, Dominik Csapak wrote:
> LGTM and works as advertised.
it breaks downloading container templates that are compressed with one
of the "known" compression algorithms (such as gz).
probably the detect-compression parameter and handling needs to go back
in (that was the
Even if the installer is run in release mode, the test-mode flag should
be honored on whether to start a test-installation or not.
The test mode is always forced on in debug builds, so the cfg()
conditionals can be dropped.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/main.rs |
sry just saw that this was already applied (some version of it)
and the discussion had included about oldtimeout always being 0 here, but
my point still stands for the applied code in case $oldtimeout is not 0
___
pve-devel mailing list
comment inline:
On 9/12/23 11:16, Fiona Ebner wrote:
10 minutes is not long enough when disks are large and/or network
storages are used when preallocation is not disabled. The default is
metadata preallocation for qcow2, so there are still reports of the
issue [0][1]. If allocation really does
LGTM and works as advertised.
Needs pve-storage >= 8.0.3 (for compression parameter)
consider both patches:
Reviewed-by: Dominik Csapak
Tested-by: Dominik Csapak
___
pve-devel mailing list
pve-devel@lists.proxmox.com
personally i would be cautious to include such deep links to vendor sites in our
documentation, because they can be outdated fast and it becomes a catch-up
game
No strong feelings though if the others are fine with it.
Besides that, consider this
Reviewed-by: Dominik Csapak
I think this can be part of the auto-installer itself, instead of
introducing another shell script somewhere. While yes, "do one thing and
do it well", its a rather small part and not unreasonable to move it
directly into the auto-installer.
Or have a separate Rust-written executable for this,
19 matches
Mail list logo
