Re: [pve-devel] applied: [PATCH v2 docs] sysadmin: add section 'Firmware Updates' and references

2023-09-21 Thread Thomas Lamprecht
Am 21/09/2023 um 15:17 schrieb Thomas Lamprecht: > Oh, and this made me think that it would be nice to have a test for > checking all linked URLs, i.e., make a request and see if that > immediately return HTTP OK 200 code, otherwise output the url as > possibly broken or in need of update. This cou

[pve-devel] applied: [PATCH installer] sys: block: fix inverted check when detecting block size

2023-09-21 Thread Thomas Lamprecht
Am 21/09/2023 um 13:22 schrieb Christoph Heiss: > We do actually want the block size if it is integer - currently, it is > always set to `undef` (and then `null` in the serialized JSON). > > Fixes: 15b2cd7 ("sys: block: fix possible use of `undef`-value when detecting > disk sizes") > Signed-off-

[pve-devel] applied: [PATCH v2 docs] sysadmin: add section 'Firmware Updates' and references

2023-09-21 Thread Thomas Lamprecht
Am 28/07/2023 um 15:21 schrieb Alexander Zeidler: > Firmware updates are important, their existence should not be checked > only when there are already noticeable problems. > > Signed-off-by: Alexander Zeidler > --- > Changes since v1: > * apply Aaron's comment (section Vendor-specific) > > >

[pve-devel] [PATCH manager v8 2/2] fix #4849: ui: download to storage: automatically dectect and configure compression

2023-09-21 Thread Philipp Hufnagl
extends the download iso prompt with a "compression algorithm" drop down under advanced. User can configure there if a decompression algorithm should be used from the storage backend. The compression algorithm will be automatically guessed when calling query_url_metadata Signed-off-by: Philipp Huf

[pve-devel] [PATCH manager v8 0/2] fix #4849: allow download of compressed ISOs

2023-09-21 Thread Philipp Hufnagl
Many web pages offer the download of the disk images compressed. This patch allows the download of archives (like .gz), automatically detects the format and decompresses it Changes since v7: * added detect-compression API parameter again Changes since v6: * remove detect-compression API param

[pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-09-21 Thread Philipp Hufnagl
extends the query_url_metadata callback with the functionallity to detect used compressions. If a compression is used it tells the ui which one Signed-off-by: Philipp Hufnagl --- PVE/API2/Nodes.pm | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/PVE/API2

[pve-devel] [PATCH qemu-sever v13 1/6] enable VNC clipboard parameter in vga_fmt

2023-09-21 Thread Markus Frank
add option to use the qemu vdagent implementation to enable the VNC clipboard. When enabled with SPICE the spice-vdagent gets replaced with the QEMU implementation. This patch does not solve #1406, but does allow copy and paste with a running X-session, when spice-vdagent is installed on the guest

[pve-devel] [PATCH docs v13 6/6] add VNC clipboard documentation

2023-09-21 Thread Markus Frank
Signed-off-by: Markus Frank --- qm.adoc | 18 ++ 1 file changed, 18 insertions(+) diff --git a/qm.adoc b/qm.adoc index b3c3034..43c1da4 100644 --- a/qm.adoc +++ b/qm.adoc @@ -776,6 +776,24 @@ Selecting `serialX` as display 'type' disables the VGA output, and redirects the Web C

[pve-devel] [PATCH qemu-sever v13 2/6] add clipboard variable to return at status/current

2023-09-21 Thread Markus Frank
By that noVNC is able to check if clipboard is active. Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 8 1 file changed, 8 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 8a2fdef..49d0420 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -2697,6 +2697,13

[pve-devel] [PATCH manager v13 5/6] add clipboard checkbox to VM Options

2023-09-21 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/qemu/DisplayEdit.js | 8 +++ www/manager6/qemu/Options.js | 89 2 files changed, 97 insertions(+) diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js index 9bb1763e..d7cd51a9 100644 --

[pve-devel] [PATCH qemu-sever v13 3/6] test cases for clipboard spice & std

2023-09-21 Thread Markus Frank
add one test case for a spice display and one for std Signed-off-by: Markus Frank --- test/cfg2cmd/VNC-clipboard-spice.conf | 1 + test/cfg2cmd/VNC-clipboard-spice.conf.cmd | 27 +++ test/cfg2cmd/VNC-clipboard-std.conf | 1 + test/cfg2cmd/VNC-clipboard-std.conf.cm

[pve-devel] [PATCH novnc v13 4/6] add "show clipboard button" patch to series

2023-09-21 Thread Markus Frank
Signed-off-by: Markus Frank --- .../patches/0019-show-clipboard-button.patch | 30 +++ debian/patches/series | 1 + 2 files changed, 31 insertions(+) create mode 100644 debian/patches/0019-show-clipboard-button.patch diff --git a/debian/patches/0019-sho

[pve-devel] [PATCH qemu-sever/novnc/manager/docs v13 0/6] Feature VNC-Clipboard

2023-09-21 Thread Markus Frank
overall changes v11: * renamed vnc-clipboard to clipboard and changed it to a string overall changes v9: * renamed vnc_clipboard to vnc-clipboard qemu-sever: changes v10: * separated "vnc-clipboard return at status/current" to its own patch * added missing trailing comma * changed capitalizatio

Re: [pve-devel] [RFC installer 2/6] add proxmox-auto-installer

2023-09-21 Thread Christoph Heiss
On Thu, Sep 21, 2023 at 01:30:33PM +0200, Thomas Lamprecht wrote: > > Am 21/09/2023 um 13:16 schrieb Christoph Heiss: [..] > > Sending simple JSON-formatted logs to an HTTP endpoint or even using > > the rsyslog protocol come to mind and would be a good solution for > > this, I think. > >

Re: [pve-devel] [RFC installer 2/6] add proxmox-auto-installer

2023-09-21 Thread Thomas Lamprecht
Am 21/09/2023 um 13:16 schrieb Christoph Heiss: > > Some general notes: > > - The overall approach seems fine too me. Did some cursory testing too, > worked fine - although I did not really test out the > filtering/matching much. > > - Probably just due to it being still a bit early, but all

[pve-devel] [PATCH installer] sys: block: fix inverted check when detecting block size

2023-09-21 Thread Christoph Heiss
We do actually want the block size if it is integer - currently, it is always set to `undef` (and then `null` in the serialized JSON). Fixes: 15b2cd7 ("sys: block: fix possible use of `undef`-value when detecting disk sizes") Signed-off-by: Christoph Heiss --- Proxmox/Sys/Block.pm | 2 +- 1 fil

Re: [pve-devel] [RFC installer 2/6] add proxmox-auto-installer

2023-09-21 Thread Christoph Heiss
Some general notes: - The overall approach seems fine too me. Did some cursory testing too, worked fine - although I did not really test out the filtering/matching much. - Probably just due to it being still a bit early, but all these `.unwrap()/.expect()` should be replaced with proper e