Am 25/10/2023 um 10:28 schrieb Christoph Heiss:
> On Tue, Oct 24, 2023 at 08:59:36AM -0300, Gilberto Ferreira via pve-devel
> wrote:
>> Date: Tue, 24 Oct 2023 08:59:36 -0300
>> From: Gilberto Ferreira
>> To: Proxmox VE development discussion
>> Subject: Re: [pve-devel] [PATCH installer v2 1/6] f
Am 25/10/2023 um 10:56 schrieb Christoph Heiss:
> Removes the `static mut` for holding a `SetupInfo` instance.
>
> This is done by either passing the needed info as parameter, or in some
> cases, the needed information is already available through other means.
>
> Not only does it get rid of some
Am 25/10/2023 um 11:08 schrieb Dominik Csapak:
> with the new webgl renderer, chrome/chromium has buggy software support for
> emulating this (see [0]), so we have to detect that manually and prevent
> loading the addon. This fixes the issue that on chrome without hw
> support, it would not always
Am 25/10/2023 um 15:34 schrieb Fabian Grünbichler:
> like we do for the main APT auth file(s) in proxmox-subscription.
>
> Signed-off-by: Fabian Grünbichler
> ---
> PVE/API2/Subscription.pm | 16 ++--
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
>
applied, thanks!
___
>
>>Is it required for this series?
for this series, no.
It's only focus on migrating to remote with different cpu without too
much downtime.
>> Unused disks can just be migrated
>>offline via storage_migrate(), or?
currently unused disk can't be migrate through the http tunnel for
remote-mi
by switching dependencies and deleting doubled code to avoid ambiguities
within the same scope.
Signed-off-by: Aaron Lauterer
---
proxmox-tui-installer/src/main.rs | 13 +-
proxmox-tui-installer/src/options.rs| 403 +---
proxmox-tui-installer/src/setup.rs
Copy code that is common to its own crate.
Signed-off-by: Aaron Lauterer
---
proxmox-installer-common/Cargo.toml | 2 +
proxmox-installer-common/src/disk_checks.rs | 237
proxmox-installer-common/src/lib.rs | 4 +
proxmox-installer-common/src/options.rs | 387
Signed-off-by: Aaron Lauterer
---
proxmox-installer-common/src/disk_checks.rs | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/proxmox-installer-common/src/disk_checks.rs
b/proxmox-installer-common/src/disk_checks.rs
index 15b5928..bcf2e21 100644
--- a/proxmox-insta
Signed-off-by: Aaron Lauterer
---
proxmox-tui-installer/src/main.rs | 40 +--
1 file changed, 1 insertion(+), 39 deletions(-)
diff --git a/proxmox-tui-installer/src/main.rs
b/proxmox-tui-installer/src/main.rs
index 875a33a..3216868 100644
--- a/proxmox-tui-installer/
since work on the auto installer is happenning in parallel, now would be
a good point to move commonly used code into its own crate. Otherwise
the auto-installer will always have to play catch up with the ongoing
development of the tui installer.
I tried to split up the commits as much as possible
Signed-off-by: Aaron Lauterer
---
proxmox-installer-common/src/setup.rs | 1 +
1 file changed, 1 insertion(+)
diff --git a/proxmox-installer-common/src/setup.rs
b/proxmox-installer-common/src/setup.rs
index 34b00cb..3ef05ae 100644
--- a/proxmox-installer-common/src/setup.rs
+++ b/proxmox-instal
It will be used for code shared among the different crates in the
installer. For now between the TUI installer and the upcoming auto
installer.
Signed-off-by: Aaron Lauterer
---
Cargo.toml | 1 +
proxmox-installer-common/Cargo.toml | 10 ++
proxmox-installer-com
Was probably missed because it used to be in a binary crate where doc
tests aren't run automatically.
Signed-off-by: Aaron Lauterer
---
proxmox-installer-common/src/utils.rs | 1 +
1 file changed, 1 insertion(+)
diff --git a/proxmox-installer-common/src/utils.rs
b/proxmox-installer-common/src/
all it did moved to the common crate
Signed-off-by: Aaron Lauterer
---
proxmox-tui-installer/src/utils.rs | 268 -
1 file changed, 268 deletions(-)
delete mode 100644 proxmox-tui-installer/src/utils.rs
diff --git a/proxmox-tui-installer/src/utils.rs
b/proxmox-tui-i
moved over from the TUI installer
Signed-off-by: Aaron Lauterer
---
proxmox-installer-common/src/setup.rs | 37 +++
1 file changed, 37 insertions(+)
diff --git a/proxmox-installer-common/src/setup.rs
b/proxmox-installer-common/src/setup.rs
index a55f059..34b00cb 100644
Signed-off-by: Aaron Lauterer
---
proxmox-tui-installer/src/setup.rs | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/proxmox-tui-installer/src/setup.rs
b/proxmox-tui-installer/src/setup.rs
index 211a96b..efcabed 100644
--- a/proxmox-tui-installer/src/setup.rs
+++
Signed-off-by: Aaron Lauterer
---
proxmox-tui-installer/Cargo.toml | 1 +
1 file changed, 1 insertion(+)
diff --git a/proxmox-tui-installer/Cargo.toml b/proxmox-tui-installer/Cargo.toml
index 8a6eba8..fc653f0 100644
--- a/proxmox-tui-installer/Cargo.toml
+++ b/proxmox-tui-installer/Cargo.toml
@@
Signed-off-by: Aaron Lauterer
---
proxmox-installer-common/src/setup.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-installer-common/src/setup.rs
b/proxmox-installer-common/src/setup.rs
index a4947f1..a55f059 100644
--- a/proxmox-installer-common/src/setup.rs
+++
One nit inline, but that could be fixed up when applying too probably?
Also, and that was previously also the case, if the first (or any) portal is not
reachable, we get a big warning about iscsiadm --login not being able to login
every 10 seconds in pvestatd. It's nothing your patch changes, but
like we do for the main APT auth file(s) in proxmox-subscription.
Signed-off-by: Fabian Grünbichler
---
PVE/API2/Subscription.pm | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/PVE/API2/Subscription.pm b/PVE/API2/Subscription.pm
index 7c1e300ba..836e7a86f 10
The ToS endpoint ignored data that is needed to detect if EAB needs to
be used. Instead of adding a new endpoint that does the same request,
the tos endpoint is deprecated and replaced by the meta endpoint,
that returns all information returned by the directory.
Signed-off-by: Folke Gleumes
---
implementation acording to rfc855 section 7.3.4
Signed-off-by: Folke Gleumes
---
Changes v1 -> v2:
Switched from including the eab credentials in the info hash,
to passing them in their own variable. This still unfortunately still
breaks the api, but doesn't potentially expose secrets and is
cl
Signed-off-by: Folke Gleumes
---
Changes v1 -> v2:
* renamed api methods so they use '-' instead of '_'
* use 'requires' in api to declare dependency instead of manual check
PVE/API2/ACMEAccount.pm | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/PVE
Besides the switch from tos to meta endpoint, this fixes a visual bug,
where the 'Accept TOS' button would show up, even if no ToS was needed.
Signed-off-by: Folke Gleumes
---
No changes in v2
www/manager6/node/ACME.js | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --
Since external account binding is advertised the same way as the ToS,
it can be detected when creating an account and asked for if needed.
Signed-off-by: Folke Gleumes
---
Changes v1 -> v2:
* If a custom directory is used, ask if EAB should be used, even when not
required by the CA.
PVE/CLI/
Changes since v1:
* fixed nit's
* expanded meta endpoint by all return values defined in the rfc
* expanded new_account signature by field for eab credentials
* allow for eab even if not required
This patch series adds functionality to use acme directiories
that require the use of external acc
Signed-off-by: Hannes Duerr
---
PVE/QemuServer.pm | 12
PVE/QemuServer/Drive.pm | 26 ++
2 files changed, 38 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 2cd8948..69be3af 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@
On September 26, 2023 9:39 am, Alexandre Derumier wrote:
> - add|del_bridge_fdb: remove unused firewall param
> - sdn: move add|del_bridge_fdb to plugin to be overridable
> - sdn: evpn : add disable-bridge-learning option
>
> pve-network :
>
> Alexandre Derumier (3):
> zones: add|del_bridge_fdb
On September 13, 2023 1:38 pm, Alexandre Derumier wrote:
> Hi,
> This patch serie add support for the isis routing protocol for underlay
> network,
> instead bgp.
>
> This was a request of a proxmox user, the implementation has been tested
> https://forum.proxmox.com/threads/integrating-proxmox-s
Am 17/10/2023 um 14:10 schrieb Fiona Ebner:
> Patch changes:
>
> For backup, opening the backup dump block driver needed to be adapted,
> because of coroutine context changes.
>
> Block graph locking was disabled, because of deadlocks.
>
> Snapshot code has a huge performance regression which re
in the general tab in the advanced section.
For that to work, we introduce a new option for the TagEditContainer
named 'editOnly', which controls now the cancel/finish buttons,
automatically enter edit mode and disable enter/escape keypresses.
We also prevent now the loading of tags while in edit
Signed-off-by: Maximiliano Sandoval R
---
ha-manager.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ha-manager.adoc b/ha-manager.adoc
index 6bbd267..7f1ba3d 100644
--- a/ha-manager.adoc
+++ b/ha-manager.adoc
@@ -854,7 +854,7 @@ Maintenance Mode
Enabl
with the new webgl renderer, chrome/chromium has buggy software support for
emulating this (see [0]), so we have to detect that manually and prevent
loading the addon. This fixes the issue that on chrome without hw
support, it would not always render every character.
Firefox does not have support
This aligns it with the other constructors for options struct by
introducing a `::defaults_from()` function.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/main.rs| 15 +++---
proxmox-tui-installer/src/options.rs | 75 +---
proxmox-tui-installer/src/setu
Enables the advanced and LVM dialog to determine what options (max
root/data size and Btrfs RAIDs) by itself, without needing to resort to
the global `setup_info()` function.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/views/bootdisk.rs | 74 ++---
1 file changed
Removes the `static mut` for holding a `SetupInfo` instance.
This is done by either passing the needed info as parameter, or in some
cases, the needed information is already available through other means.
Not only does it get rid of some ugly, unsafe code, it is needed anyway
as a prerequisite by
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/main.rs | 21 ++---
1 file changed, 2 insertions(+), 19 deletions(-)
diff --git a/proxmox-tui-installer/src/main.rs
b/proxmox-tui-installer/src/main.rs
index a342a08..81fe3ca 100644
--- a/proxmox-tui-installer/src/main
Am 24.10.23 um 14:20 schrieb DERUMIER, Alexandre:
>>> So I think the best way for now is to restart the target vm.
>>>
>>> Sure! Going with that is a much cleaner approach then.
>
> I'll try to send a v5 today with you're last comments.
>
> I don't manage yet the unused disks, I need to test with
On Tue, Oct 24, 2023 at 08:59:36AM -0300, Gilberto Ferreira via pve-devel wrote:
> Date: Tue, 24 Oct 2023 08:59:36 -0300
> From: Gilberto Ferreira
> To: Proxmox VE development discussion
> Subject: Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add
> new ZFS `arc_max` setup optio
Thanks for the review!
I will refactor all the points mentioned and send a v2 soon.
On Tue, Oct 24, 2023 at 05:05:15PM +0200, Thomas Lamprecht wrote:
>
> Am 24/10/2023 um 13:55 schrieb Christoph Heiss:
> > Signed-off-by: Christoph Heiss
> > ---
> > Changes v1 -> v2:
> > * No changes
> >
> >
40 matches
Mail list logo
