these can happen for example if the system
- is set up to boot using systemd-boot
- but grub updates trigger a call to "grub-install"
- and systemd-boot is not installed
in this case, "proxmox-boot-tool reinit" will fail because of the lack of
"systemd-boot", and the upgrade triggering the
Since create_vm already calls update_pct_config, which in turn calls
vmconfig_apply_pending we do not need to explicitly create the IPAM
entries when creating a container from scratch.
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/LXC.pm | 1 -
1 file changed, 1 deletion(-)
diff --git
When editing a NIC there was a possibility of duplicate IPAM entries being
generated. This should be fixed with this patch series.
Additionally when creating vNICs for a container there were multiple warnings
in the log due to the LXC module trying to use the QemuServer module for
parsing net
Signed-off-by: Stefan Hanreich
---
src/PVE/LXC.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index c239715..847b8c8 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -2771,9 +2771,9 @@ sub create_ifaces_ipams_ips {
for my
Currently a new IPAM entry is created everytime a NIC config changes.
When editing properties other than MAC or Bridge this could lead to
duplicated entries in the IPAM. Only reserve a new IP when the bridge
or MAC changes or the NIC is completely new.
Signed-off-by: Stefan Hanreich
---
Currently when updating the network configuration of a container, SDN
would always create a new entry in the IPAM. Only create a new entry
when the bridge or MAC changes or the NIC is completely new.
Signed-off-by: Stefan Hanreich
---
src/PVE/LXC/Config.pm | 6 --
1 file changed, 4
Currently when updating the network configuration of a container, SDN
would always create a new entry in the IPAM. Only create a new entry
when the bridge or MAC changes or the NIC is completely new.
Signed-off-by: Stefan Hanreich
---
src/PVE/LXC/Config.pm | 6 --
1 file changed, 4
Signed-off-by: Stefan Hanreich
---
src/PVE/LXC.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index c239715..071faca 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -2771,7 +2771,7 @@ sub create_ifaces_ipams_ips {
for my $opt
Currently a new IPAM entry is created everytime a NIC config changes.
When editing properties other than MAC or Bridge this could lead to
duplicated entries in the IPAM. Only reserve a new IP when the bridge
or MAC changes or the NIC is completely new.
Signed-off-by: Stefan Hanreich
---
When editing a NIC there was a possibility of duplicate IPAM entries being
generated. This should be fixed with this patch series.
Additionally when creating vNICs for a container there were multiple warnings
in the log due to the LXC module trying to use the QemuServer module for
parsing net
Am 20/11/2023 um 18:20 schrieb DERUMIER, Alexandre:
> It's needed for transparent reload (usr/lib/frr/frr-reload.py).
>
> so you can be 100% sure It'll break if it's not installed ^_^
Ah, we already got a check in EVPN's reload_controller:
my $bin_path = "/usr/lib/frr/frr-reload.py";
Message initial
De: Thomas Lamprecht
À: PVE development discussion , Alexandre
Derumier
Objet: pve-network : downgrading frr dependency to suggested
Date: 20/11/2023 17:55:40
>>Hi,
>>I'd downgrade frr-pythontools to a suggestion, as Debian has install-
>>recommends
>>on by
Hi,
I'd downgrade frr-pythontools to a suggestion, as Debian has install-recommends
on by default, so an upgrade would pull FRR always in, if we add a dependency
for our SDN package to e.g. pve-manager, and FRR daemon is quite noisy IIRC.
Would that be fine for you? A short documentation how to
Am 20/11/2023 um 17:28 schrieb Stefan Hanreich:
> The initial URL structure was less than optimal due to Ipam as well as
> Ipams being endpoints in the API, which are too similar and might be
> confusing to users.
>
> Move the listing of PVE IPAM to /ipams/pve/status
> Move the create / update /
Am 18/11/2023 um 15:13 schrieb Alexandre Derumier:
> Apply on top of stefan patch v4 series
>
> changes:
> - fix tests from last stefan patches changes
> - dnsmasq: update lease cache through bus (for ipv4 only)
> - dnsmasq: use static range to avoid to distribute dynamic ips
> - dnsmasq: fix
Am 17/11/2023 um 12:39 schrieb Stefan Hanreich:
> pve-network:
>
> Alexandre Derumier (3):
> sdn: fix tests
> sdn: fix subnets && netbox ipam tests
> add add_dhcp_mapping
>
> Stefan Hanreich (12):
> sdn: preparations for DHCP plugin
> subnet: add dhcp options
> sdn: zone: add dhcp
Am 17.11.23 um 13:17 schrieb Hannes Duerr:
> diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm
> index de62d43..4e1646d 100644
> --- a/PVE/QemuServer/Drive.pm
> +++ b/PVE/QemuServer/Drive.pm
> @@ -161,6 +161,26 @@ my %iothread_fmt = ( iothread => {
> optional => 1,
> });
>
>
The IPAM-related API endpoints were moved, reflect those changes in
the UI as well.
Signed-off-by: Stefan Hanreich
---
www/manager6/sdn/IpamEdit.js | 4 +++-
www/manager6/tree/DhcpTree.js | 15 +++
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git
Moving the API method for the IPAM index to /ipams/pve/status which seems
better suited as it returns the current state of the PVE IPAM. This could be
then extended further to return the current status of other IPAM plugins,
although it is probably preferrable to use the respective API / UI of the
The initial URL structure was less than optimal due to Ipam as well as
Ipams being endpoints in the API, which are too similar and might be
confusing to users.
Move the listing of PVE IPAM to /ipams/pve/status
Move the create / update / delete endpoints to /vnets/{vnetid}/ips
Signed-off-by:
On 11/20/23 13:28, DERUMIER, Alexandre wrote:
> Hi,
>
> > > I'll look again into this, maybe POST / PUT / DELETE
> > > `/ipams/pve/mapping` or `/ipams/pve/ip` would be a good
> > > alternative
> > > here? We need to move away from MAC addresses as a unique
> > > identifier
> > > anyway (since
Am 20/11/2023 um 16:48 schrieb Aaron Lauterer:
> Signed-off-by: Aaron Lauterer
> ---
> pvecm.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied series, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
Am 17.11.23 um 13:17 schrieb Hannes Duerr:
> diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm
> index e24ba12..dce1398 100644
> --- a/PVE/QemuServer/Drive.pm
> +++ b/PVE/QemuServer/Drive.pm
(...)
> +my $fh = IO::File->new("+<$path") || return;
There's no "use IO::File;" yet in
Am 17.11.23 um 13:17 schrieb Hannes Duerr:
> +
> + # for compatibility only, we prefer scsi-hd (#2408, #2355, #2380)
> + if ($path =~ m/^iscsi\:\/\// &&
> +!min_version($machine_version, 4, 1)) {
min_version is not defined in the Drive.pm module, you need to import it
from
Signed-off-by: Christian Ebner
---
it.po | 556 --
1 file changed, 187 insertions(+), 369 deletions(-)
diff --git a/it.po b/it.po
index ca149df..6ae242d 100644
--- a/it.po
+++ b/it.po
@@ -96,9 +96,8 @@ msgid "API Data"
msgstr ""
#:
Signed-off-by: Aaron Lauterer
---
pveceph.adoc | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/pveceph.adoc b/pveceph.adoc
index 56d745a..0720941 100644
--- a/pveceph.adoc
+++ b/pveceph.adoc
@@ -241,22 +241,26 @@ The configuration step includes the
Signed-off-by: Aaron Lauterer
---
pveceph.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pveceph.adoc b/pveceph.adoc
index 361e7c7..56d745a 100644
--- a/pveceph.adoc
+++ b/pveceph.adoc
@@ -134,7 +134,7 @@ That means that you should avoid maxing out your available
Signed-off-by: Aaron Lauterer
---
pvecm.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pvecm.adoc b/pvecm.adoc
index d595ac5..1f78585 100644
--- a/pvecm.adoc
+++ b/pvecm.adoc
@@ -1090,7 +1090,7 @@ The status output of the QDevice, as seen above, will
usually contain
and make it into a proper field
it's intended to be used like a single field and exactly as before
Signed-off-by: Dominik Csapak
---
no changes
www/manager6/Makefile| 1 +
www/manager6/form/IsoSelector.js | 107 +++
www/manager6/qemu/CDEdit.js |
This is useful for adding the virtio-win iso for new installs, and thus
we change the default disk type to scsi and network type to virtio.
we add special logic to the OSTypeInputPanel when 'insideWizard' is
true to add an additional checkbox + iso selector
Signed-off-by: Dominik Csapak
---
Am 14/11/2023 um 10:22 schrieb Markus Frank:
> add option to use the qemu vdagent implementation to enable the VNC
> clipboard. When enabled with SPICE the spice-vdagent gets replaced with the
> QEMU
> implementation.
>
> This patch does not solve #1406, but does allow copy and paste with
> a
Am 20/11/2023 um 15:53 schrieb Fiona Ebner:
> The 'not' prefix is already stripped in the set() method of the view
> model's 'rootMode' and not present anymore when updating the store.
> The information about whether the mode is inverted or not is present
> in the 'invert' data member.
>
>
yes, this fixes setting/loading the inverted modes
it seems i have sent a hunk too much with my followup
thanks for fixing!
Reviewed-by: Dominik Csapak
Tested-by: Dominik Csapak
On 11/20/23 15:53, Fiona Ebner wrote:
The 'not' prefix is already stripped in the set() method of the view
The 'not' prefix is already stripped in the set() method of the view
model's 'rootMode' and not present anymore when updating the store.
The information about whether the mode is inverted or not is present
in the 'invert' data member.
Signed-off-by: Fiona Ebner
---
for this, we invent the 'storageStateId' parameter that is undeifned by
default, but if set, the storage selector saves it's value on every
change there and on initial load (when no value is set from outside)
loads it from there and uses that as its value.
for now only use it for the selection of
generally looks ok, but i couldn't edit a manual dhcp
mapping with the error:
vmid: type check ('integer') failed - got ''
did not look too deep so i'm not sure where the empty vmid value
is coming from
also i like alexandres idea to put it into the main tree in the zone
panel as new panel
Am 20/11/2023 um 13:57 schrieb Alexandre Derumier:
> Signed-off-by: Alexandre Derumier
> ---
> debian/patches/series | 1 +
> ...-compare-between-remote-ips-and-old_.patch | 33 +++
> 2 files changed, 34 insertions(+)
> create mode 100644
>
Am 20/11/2023 um 13:52 schrieb Mira Limbeck:
> The original patch removed the first branch of `if` condition, leaving the
> `else` in which matched the `if` above.
> The correct condition for this `else` is any bond mode that is not `lacp`
> (4).
>
> Signed-off-by: Mira Limbeck
> ---
>
applied, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
hi, a few issues here:
high level:
adding/modifying/deleting dhcp ranges does not trigger form 'isDirty'
check properly, leading to me unable to add dhcp ranges
to an existing subnet without also changing something else on
the first tab (there are probably some 'checkChange' triggers missing?)
Signed-off-by: Alexandre Derumier
---
debian/patches/series | 1 +
...-compare-between-remote-ips-and-old_.patch | 33 +++
2 files changed, 34 insertions(+)
create mode 100644
Hi,
This patch is fixing a regression in ifupdown2 with evpn vxlan,
where on reload, ifupdown2 is now trying to delete mac entries from bridges fdb,
then it's breaking vm access on reload.
Could be great to have it for pve 8.1, because it's really impact production
Alexandre Derumier (1):
Fix
The original patch removed the first branch of `if` condition, leaving the
`else` in which matched the `if` above.
The correct condition for this `else` is any bond mode that is not `lacp`
(4).
Signed-off-by: Mira Limbeck
---
...bond-remove-bond-min-links-0-warning.patch | 19
On 11/20/23 13:34, Stefan Hanreich wrote:
> Not sure about this, since the endpoint returns the state of the PVE
> IPAM and never returns the state of Netbox IPAM, for instance. Since if
> you want to inspect that state you would use the Netbox API / Web UI.
> For that reason it would make
On 11/20/23 13:28, DERUMIER, Alexandre wrote:
> Hi,
>
>>> I'll look again into this, maybe POST / PUT / DELETE
>>> `/ipams/pve/mapping` or `/ipams/pve/ip` would be a good alternative
>>> here? We need to move away from MAC addresses as a unique identifier
>>> anyway (since with dual-stack there
Hi,
>>I'll look again into this, maybe POST / PUT / DELETE
>>`/ipams/pve/mapping` or `/ipams/pve/ip` would be a good alternative
>>here? We need to move away from MAC addresses as a unique identifier
>>anyway (since with dual-stack there can be multiple IP addresses for
>>the same MAC address) so
Wrong mailing list, please ignore
On 20/11/2023 12:54, Filip Schauer wrote:
Include symlinks when restoring files from a backup as a zip file.
proxmox:
Filip Schauer (1):
fix #4995: compression: Include symlinks in zip file restore
proxmox-compression/src/zip.rs | 46
Signed-off-by: Filip Schauer
---
pbs-client/src/pxar/extract.rs | 18 ++
1 file changed, 18 insertions(+)
diff --git a/pbs-client/src/pxar/extract.rs b/pbs-client/src/pxar/extract.rs
index f78e06c2..6f23c144 100644
--- a/pbs-client/src/pxar/extract.rs
+++
Include symlinks when restoring files from a backup as a zip file.
proxmox:
Filip Schauer (1):
fix #4995: compression: Include symlinks in zip file restore
proxmox-compression/src/zip.rs | 46 ++
1 file changed, 35 insertions(+), 11 deletions(-)
Signed-off-by: Filip Schauer
---
proxmox-compression/src/zip.rs | 46 ++
1 file changed, 35 insertions(+), 11 deletions(-)
diff --git a/proxmox-compression/src/zip.rs b/proxmox-compression/src/zip.rs
index d2d3fd8..89b079b 100644
---
applied series, bumped access control and manager's dep on it
On Mon, Nov 20, 2023 at 08:22:38AM +0100, Fabian Grünbichler wrote:
> this series extends the poolname to allow (for now) two '/' inside the
> name to nest pools like this:
>
> parent/child/grandchild
>
> since '/' is a bad character
On 11/18/23 17:27, Thomas Lamprecht wrote:
> what's the deal with Ipam vs. Ipams?
>
> I did not looked to closely into it but it seems like the existing Ipams,
> plural,
> is for managing ipam plugins and Ipam, singular, here is for getting the
> current
> state? That should really be better
On 11/20/23 10:11, Dominik Csapak wrote:
A 'match-type' rule would simplify this by simply allowing one to list
all notification types on wants to match, eg.
matcher: test3
match-type vzdump,replication
For this 'specialized' match-rule we could easily add a list of known
values in a
Am 20/11/2023 um 10:16 schrieb Fiona Ebner:
> The issue prevented FreeBSD 14 VMs with SATA disk from booting.
>
> The commit it fixes e2a5d9b3d9c3 ("hw/ide/ahci: simplify and document
> PxCI handling") is part of stable 8.1.2.
>
> The patch was already applied to the block branch upstream:
>
Tested with an OPNsense VM: With pve-qemu-kvm 8.1.2-2, it did not boot
from SATA ("Root mount waiting for: CAM"). virtio worked though.
With the patched pve-qemu-kvm package I got from Fiona, the VM booted
from SATA again. virtio still works too.
Tested-by: Friedrich Weber
On 20/11/2023 10:16,
The issue prevented FreeBSD 14 VMs with SATA disk from booting.
The commit it fixes e2a5d9b3d9c3 ("hw/ide/ahci: simplify and document
PxCI handling") is part of stable 8.1.2.
The patch was already applied to the block branch upstream:
Am 20/11/2023 um 09:02 schrieb Dominik Csapak:
> it seems in new versions of chrome , this triggers too early on a fresh
> start (when autostarting a pve tab), resulting in the
> 'viewWidth'/'viewHeight' being zero pixels. This means we set the width
> of the left and the height of the bottom
Am 20/11/2023 um 10:03 schrieb Lukas Wagner:
> On 11/17/23 09:41, Dominik Csapak wrote:
>> one additional comment to the ux:
>>
>> the match field could use a bit of improvement:
>>
>> the docs describe the current fields, but for users that
>> don't deep dive into the docs first it may be
On 11/20/23 10:03, Lukas Wagner wrote:
On 11/17/23 09:41, Dominik Csapak wrote:
one additional comment to the ux:
the match field could use a bit of improvement:
the docs describe the current fields, but for users that
don't deep dive into the docs first it may be confusing having
a simple
On 11/17/23 09:41, Dominik Csapak wrote:
one additional comment to the ux:
the match field could use a bit of improvement:
the docs describe the current fields, but for users that
don't deep dive into the docs first it may be confusing having
a simple text input field for that
at least
Am 17/11/2023 um 14:55 schrieb Stefan Lendl:
> * Try to homogenize style and format
> * Title case naming conventions for configuration options
> * Simplify examples
> * Re-phrase descriptions
>
> Changes to v1 -> v2:
>
> * Split changes per chapter.
> * Use multi-line heading format like in the
On 11/20/23 09:26, Thomas Lamprecht wrote:
Am 20/11/2023 um 09:07 schrieb Dominik Csapak:
On 11/20/23 09:02, Dominik Csapak wrote:
it seems in new versions of chrome , this triggers too early on a fresh
start (when autostarting a pve tab), resulting in the
'viewWidth'/'viewHeight' being zero
Am 20/11/2023 um 09:07 schrieb Dominik Csapak:
> On 11/20/23 09:02, Dominik Csapak wrote:
>> it seems in new versions of chrome , this triggers too early on a fresh
>> start (when autostarting a pve tab), resulting in the
>> 'viewWidth'/'viewHeight' being zero pixels. This means we set the width
On 11/20/23 09:02, Dominik Csapak wrote:
it seems in new versions of chrome , this triggers too early on a fresh
start (when autostarting a pve tab), resulting in the
'viewWidth'/'viewHeight' being zero pixels. This means we set the width
of the left and the height of the bottom panel to zero
it seems in new versions of chrome , this triggers too early on a fresh
start (when autostarting a pve tab), resulting in the
'viewWidth'/'viewHeight' being zero pixels. This means we set the width
of the left and the height of the bottom panel to zero pixels, making
them functionally invisible.
65 matches
Mail list logo
