Re: [pve-devel] [PATCH manager] ui: ceph installer: Run ceph/init if joining a cluster

2023-12-19 Thread Aaron Lauterer
The commit message doesn't explain the actual issue that it is trying to solve. AFAICT we do not need the ceph.conf symlinked right away for normal PVE operations. If it is not present in /etc/ceph/ceph.conf, the RBD and CephFS connections will use the dedicated parameters to connect and

Re: [pve-devel] [PATCH pve-storage v4 2/2] fix #1611: implement import of base-images for LVM-thin Storage

2023-12-19 Thread Lukas Wagner
On 12/19/23 15:03, Hannes Duerr wrote: for base images we call the volume_import of the parent plugin and pass it as vm-image instead of base-image, then convert it back as base-image Signed-off-by: Hannes Duerr --- src/PVE/Storage/LvmThinPlugin.pm | 50

[pve-devel] [PATCH pve-storage v4 2/2] fix #1611: implement import of base-images for LVM-thin Storage

2023-12-19 Thread Hannes Duerr
for base images we call the volume_import of the parent plugin and pass it as vm-image instead of base-image, then convert it back as base-image Signed-off-by: Hannes Duerr --- src/PVE/Storage/LvmThinPlugin.pm | 50 1 file changed, 50 insertions(+) diff --git

[pve-devel] [PATCH qemu-server/storage v4 0/2] fix #1611: implement import of base-images for LVM-thin Storage

2023-12-19 Thread Hannes Duerr
if a base-image is to be migrated to a lvm-thin storage, a new vm-image is allocated on the target side, then the data is written and afterwards the image is converted to a base-image Changes in V2: * restructure and remove duplicaiton * fix deactivation of volumes after migration Changes in

[pve-devel] [PATCH qemu-server v4 1/2] migration: secure and use source volume names for deactivation

2023-12-19 Thread Hannes Duerr
During migration, the volume names may change if the name is already in use at the target location. We therefore want to save the original names so that we can deactivate the original volumes afterwards. Signed-off-by: Hannes Duerr --- PVE/QemuMigrate.pm | 5 +++-- 1 file changed, 3

[pve-devel] [PATCH v2 qemu-server] fix #4501: TCP migration: start vm: move port reservation and usage closer together

2023-12-19 Thread Fiona Ebner
Currently, volume activation, PCI reservation and resetting systemd scope happen in between, so the 5 second expiretime used for port reservation is not always enough. It's possible to defer telling QEMU where it should listen for migration and do so after it has been started via QMP. Therefore,

Re: [pve-devel] [PATCH pve-manager v2] postinst: filter rbds in lvm

2023-12-19 Thread Stefan Hanreich
Although already shortly discussed off-list, here the summary of the discussion. v3 coming soon. On 12/19/23 12:54, Fabian Grünbichler wrote: > this part is now a lot stricter then before (e.g., if the user has > added multipath devices or something else to the filter for whatever > reason, the

Re: [pve-devel] [PATCH pve-manager v2] postinst: filter rbds in lvm

2023-12-19 Thread Friedrich Weber
Tested-by: Friedrich Weber Tried a couple of upgrades from PVE 7 to PVE 8 (including pve-manager with this patch). When upgrading, dpkg asks (in most cases) whether to keep local /etc/lvm/lvm.conf or install package maintainer version, so I tried both answers. Results were as I'd expect. I'm

Re: [pve-devel] [PATCH pve-manager v2] postinst: filter rbds in lvm

2023-12-19 Thread Fabian Grünbichler
On December 15, 2023 2:51 pm, Stefan Hanreich wrote: > Since LVM 2.03.15 RBD devices are also scanned by default [1]. This > can lead to guest volumes being recognized and displayed on the host > when using KRBD for RBD-backed disks. In order to prevent this we add > an additional filter to the

Re: [pve-devel] [PATCH qemu-server v3 1/2] migration: secure and use source volume names for deactivation

2023-12-19 Thread Fabian Grünbichler
On December 19, 2023 11:43 am, Hannes Duerr wrote: > During migration, the volume names may change if the name is already in > use at the target location. We therefore want to save the original names > before the migration so that we can deactivate the original volumes > afterwards. we already do

[pve-devel] [PATCH qemu-server v3 1/2] migration: secure and use source volume names for deactivation

2023-12-19 Thread Hannes Duerr
During migration, the volume names may change if the name is already in use at the target location. We therefore want to save the original names before the migration so that we can deactivate the original volumes afterwards. Signed-off-by: Hannes Duerr --- PVE/QemuMigrate.pm | 8 ++-- 1

[pve-devel] [PATCH pve-storage v3 2/2] fix #1611: implement import of base-images for LVM-thin Storage

2023-12-19 Thread Hannes Duerr
for base images we call the volume_import of the parent plugin and pass it as vm-image instead of base-image, then convert it back as base-image Signed-off-by: Hannes Duerr --- src/PVE/Storage/LvmThinPlugin.pm | 51 1 file changed, 51 insertions(+) diff --git

[pve-devel] [PATCH qemu-server/storage v3 0/2] fix #1611: implement import of base-images for LVM-thin Storage

2023-12-19 Thread Hannes Duerr
Changes in V2: * restructure and remove duplication * fix deactivation of volumes after migration Changes in V3: * fix nits * remove unnecessary oldname override * deactivate not only offline volumes, but all of them qemu-server: Hannes Duerr (1): migration: secure and use source volume

Re: [pve-devel] [PATCH v6 qemu-server] Prevent starting a 32-bit VM using a 64-bit OVMF BIOS

2023-12-19 Thread Filip Schauer
Patch series v7 is available: https://lists.proxmox.com/pipermail/pve-devel/2023-December/061147.html On 14/12/2023 12:09, Filip Schauer wrote: Instead of starting a VM with a 32-bit CPU type and a 64-bit OVMF image, throw an error before starting the VM telling the user that OVMF is not

[pve-devel] [PATCH qemu-server 4/4] cpu config: Unify the default value for 'kvm'

2023-12-19 Thread Filip Schauer
Make the default value for 'kvm' consistent and take into account whether the VM will run on the same CPU architecture as the host. This is a breaking change for VMs with a different CPU architecture running on an x86_64 host, since in this case the default CPU type for CPU hotplug switches from

[pve-devel] [PATCH qemu-server 1/4] cpu config: Add helper to get the default CPU type

2023-12-19 Thread Filip Schauer
Signed-off-by: Filip Schauer --- PVE/QemuServer/CPUConfig.pm | 9 +++-- PVE/QemuServer/Helpers.pm | 10 ++ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm index ca2946b..c25c2c8 100644 ---

[pve-devel] [PATCH v7 qemu-server 2/4] Prevent starting a 32-bit VM using a 64-bit OVMF BIOS

2023-12-19 Thread Filip Schauer
Instead of starting a VM with a 32-bit CPU type and a 64-bit OVMF image, throw an error before starting the VM telling the user that OVMF is not supported on 32-bit CPU types. To obtain a list of 32-bit CPU types, refer to the builtin_x86_defs in target/i386/cpu.c of QEMU. Exclude any entries

[pve-devel] [PATCH-SERIES v7 qemu-server, common] Prevent starting a 32-bit VM using a 64-bit OVMF BIOS

2023-12-19 Thread Filip Schauer
This patch series prevents starting a 32-bit VM using a 64-bit OVMF BIOS and makes the default value for 'kvm' during CPU hotplug consistent with the rest of the code. This is a breaking change for VMs with a different CPU architecture running on an x86_64 host. Changes since v6: * Skip the CPU

[pve-devel] [PATCH common 1/1] tools: Add is_native sub to compare the CPU architecture

2023-12-19 Thread Filip Schauer
Add an is_native($arch) subroutine to compare a CPU architecture to the host CPU architecture. This is brought in from PVE::QemuServer. Signed-off-by: Filip Schauer --- src/PVE/Tools.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index

[pve-devel] [PATCH qemu-server 3/4] Move is_native from PVE::QemuServer to PVE::Tools

2023-12-19 Thread Filip Schauer
Signed-off-by: Filip Schauer --- PVE/QemuServer.pm | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index a7b237e..1a1080d 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -45,7 +45,7 @@ use PVE::RPCEnvironment; use

[pve-devel] [PATCH ifupdown2] fix #5009: avoid waiting for stdout eof of /etc/network/ scripts

2023-12-19 Thread Friedrich Weber
Previously, PVE (7 and 8) hosts would hang at boot if both ntpsec and ntpsec-ntpdate are installed. The root cause for the hang is an unfortunate interaction between ntpsec, ntpsec-ntpdate and the PVE ifupdown2 package. The hang happens because ntpsec-ntpdate installs a hook

[pve-devel] [PATCH pve-network 3/7] dnsmasq service: run service in vrf

2023-12-19 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/services/01-dnsmasq-vrf.conf | 4 src/services/Makefile| 1 + 2 files changed, 5 insertions(+) create mode 100644 src/services/01-dnsmasq-vrf.conf diff --git a/src/services/01-dnsmasq-vrf.conf b/src/services/01-dnsmasq-vrf.conf new

[pve-devel] [PATCH pve-network 6/7] zones: qinq: add dhcp support

2023-12-19 Thread Alexandre Derumier
add gateway ip to vnet and force /32 for ipv4 to avoid arp problem, and disable forwarding by security Signed-off-by: Alexandre Derumier --- src/PVE/Network/SDN/Zones/QinQPlugin.pm | 32 + .../zones/qinq/dhcp/expected_sdn_interfaces | 34 +++

[pve-devel] [PATCH pve-network 2/7] dhcp: enable-ra on layer3 zones only

2023-12-19 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 4 ++-- src/PVE/Network/SDN/Zones/EvpnPlugin.pm | 2 +- src/PVE/Network/SDN/Zones/Plugin.pm | 2 +- src/PVE/Network/SDN/Zones/SimplePlugin.pm | 9 + 4 files changed, 13 insertions(+), 4 deletions(-)

[pve-devel] [PATCH pve-network 4/7] zones: evpn: add dhcp support

2023-12-19 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/PVE/Network/SDN/Zones/EvpnPlugin.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/Network/SDN/Zones/EvpnPlugin.pm b/src/PVE/Network/SDN/Zones/EvpnPlugin.pm index 3c3278a..26a22c7 100644 --- a/src/PVE/Network/SDN/Zones/EvpnPlugin.pm +++

[pve-devel] [PATCH pve-network 7/7] zones: vxlan: add dhcp support

2023-12-19 Thread Alexandre Derumier
add gateway ip to vnet and force /32 for ipv4 to avoid arp problem, and disable forwarding by security Signed-off-by: Alexandre Derumier --- src/PVE/Network/SDN/Zones/VxlanPlugin.pm | 32 +++ .../zones/vxlan/dhcp/expected_sdn_interfaces | 19 +++

[pve-devel] [PATCH pve-network 1/7] dhcp: add vrf support

2023-12-19 Thread Alexandre Derumier
launch dnsmasq in a vrf context with "ip vrf exec dnsmasq.." use "default" vrf if plugin don't return a specific vrf Signed-off-by: Alexandre Derumier --- src/PVE/Network/SDN/Dhcp.pm | 3 ++- src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 3 ++- src/PVE/Network/SDN/Zones.pm

[pve-devel] [PATCH pve-network 5/7] zones: vlan: add dhcp support

2023-12-19 Thread Alexandre Derumier
add gateway ip to vnet and force /32 for ipv4 to avoid arp problem, and disable forwarding by security Signed-off-by: Alexandre Derumier --- src/PVE/Network/SDN/Zones/VlanPlugin.pm | 33 +++ .../zones/vlan/dhcp/expected_sdn_interfaces | 27 +++

[pve-devel] [PATCH pve-network 0/7] add dhcp support for all zones

2023-12-19 Thread Alexandre Derumier
This patch serie add dhcp support for all zones types. also: - Exec dnsmasq in a specific vrf if needed (currently only evpn) - Enable-ra only on layer3 subnets TO FIX: - Dnsmasq is currently buggy with ipv6 && vrf (no crash but it's not listening), and need to be patched with: